[linux-sunxi] Re: [PATCH 07/12] arm64: dts: allwinner: orange-pi-3: Enable ethernet

2019-04-09 Thread Linus Walleij
On Tue, Apr 9, 2019 at 1:22 AM Ondřej Jirman wrote: > > > +enable-active-high; > > > +gpio = < 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */ > > > > Is enable-active-high still needed? It's redundant with the > > GPIO_ACTIVE_HIGH flag. > > Looking at the code, use/non-use of

[linux-sunxi] Re: [PATCH 07/12] arm64: dts: allwinner: orange-pi-3: Enable ethernet

2019-04-09 Thread Maxime Ripard
On Tue, Apr 09, 2019 at 01:22:32AM +0200, Ondřej Jirman wrote: > On Mon, Apr 08, 2019 at 09:40:42AM +0200, Maxime Ripard wrote: > > On Sat, Apr 06, 2019 at 01:45:09AM +0200, meg...@megous.com wrote: > > > From: Ondrej Jirman > > > > > > Orange Pi 3 has two regulators that power the Realtek

[linux-sunxi] Re: [PATCH 07/12] arm64: dts: allwinner: orange-pi-3: Enable ethernet

2019-04-08 Thread 'Ondřej Jirman' via linux-sunxi
On Mon, Apr 08, 2019 at 09:40:42AM +0200, Maxime Ripard wrote: > On Sat, Apr 06, 2019 at 01:45:09AM +0200, meg...@megous.com wrote: > > From: Ondrej Jirman > > > > Orange Pi 3 has two regulators that power the Realtek RTL8211E. > > According to the phy datasheet, both regulators need to be

[linux-sunxi] Re: [PATCH 07/12] arm64: dts: allwinner: orange-pi-3: Enable ethernet

2019-04-08 Thread 'Ondřej Jirman' via linux-sunxi
On Mon, Apr 08, 2019 at 11:41:38AM +0530, Jagan Teki wrote: > On Sat, Apr 6, 2019 at 5:15 AM wrote: > > > > From: Ondrej Jirman > > > > Orange Pi 3 has two regulators that power the Realtek RTL8211E. > > According to the phy datasheet, both regulators need to be enabled > > at the same time, but

[linux-sunxi] Re: [PATCH 07/12] arm64: dts: allwinner: orange-pi-3: Enable ethernet

2019-04-08 Thread Maxime Ripard
On Sat, Apr 06, 2019 at 01:45:09AM +0200, meg...@megous.com wrote: > From: Ondrej Jirman > > Orange Pi 3 has two regulators that power the Realtek RTL8211E. > According to the phy datasheet, both regulators need to be enabled > at the same time, but we can only specify a single phy-supply in >

[linux-sunxi] Re: [PATCH 07/12] arm64: dts: allwinner: orange-pi-3: Enable ethernet

2019-04-08 Thread Jagan Teki
On Sat, Apr 6, 2019 at 5:15 AM wrote: > > From: Ondrej Jirman > > Orange Pi 3 has two regulators that power the Realtek RTL8211E. > According to the phy datasheet, both regulators need to be enabled > at the same time, but we can only specify a single phy-supply in > the DT. > > This can be