[linux-sunxi] Re: [PATCH 2/2] sunxi: dts: H616: Drop reserved-memory node
On Tue, 30 Mar 2021 18:58:23 +0530
Jagan Teki wrote:
Hi Jagan,
> On Tue, Mar 30, 2021 at 6:31 PM Andre Przywara wrote:
> >
> > Trusted Firmware now adds the /reserved-memory subnode to the DT at
> > runtime[1], putting in the right values.
> >
> > Drop our hard-coded version, as this might clash with the actual values
> > (which have also changed), and rely on TF-A to add the node.
> >
> > [1] https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/7770
> >
> > Signed-off-by: Andre Przywara
> > ---
> > arch/arm/dts/sun50i-h616.dtsi | 12
> > 1 file changed, 12 deletions(-)
> >
> > diff --git a/arch/arm/dts/sun50i-h616.dtsi b/arch/arm/dts/sun50i-h616.dtsi
> > index 953e8fac20f..dd4d2f3 100644
> > --- a/arch/arm/dts/sun50i-h616.dtsi
> > +++ b/arch/arm/dts/sun50i-h616.dtsi
> > @@ -51,18 +51,6 @@
> > };
> > };
> >
> > - reserved-memory {
> > - #address-cells = <2>;
> > - #size-cells = <2>;
> > - ranges;
> > -
> > - /* 512KiB reserved for ARM Trusted Firmware (BL31) */
> > - secmon_reserved: secmon@4000 {
> > - reg = <0x0 0x4000 0x0 0x8>;
> > - no-map;
> > - };
> > - };
> > -
>
> As said always. it's better to not touch Linux dts files. If the same
> fix same available in Linux add SHA1 on the commit message otherwise
> keep /delete-node on -u-boot.dtsi. This how we are maintaining sofar
> at least on sunxi.
this DT is not in Linux yet.
As this is a new SoC, we have to start at some point, and getting TF-A,
Linux and U-Boot patches merged at the same time is virtually
impossible. Ideally we have some bootloader support first, so that
people can test the kernel patches, for instance.
So this DT is a tentative one, just here to make U-Boot happy. It is
expected to change, and will be synced once it's merged into Linux.
As mentioned, the TF-A patches were changed after the U-Boot patches
were merged, so this node was needed back then, but is obsolete now.
Cheers,
Andre
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
To view this discussion on the web, visit
https://groups.google.com/d/msgid/linux-sunxi/20210330151328.661324b7%40slackpad.fritz.box.
[linux-sunxi] Re: [PATCH 2/2] sunxi: dts: H616: Drop reserved-memory node
On Tue, Mar 30, 2021 at 7:21 PM Samuel Holland wrote:
>
> On 3/30/21 8:28 AM, Jagan Teki wrote:
> > On Tue, Mar 30, 2021 at 6:31 PM Andre Przywara
> > wrote:
> >>
> >> Trusted Firmware now adds the /reserved-memory subnode to the DT at
> >> runtime[1], putting in the right values.
> >>
> >> Drop our hard-coded version, as this might clash with the actual values
> >> (which have also changed), and rely on TF-A to add the node.
> >>
> >> [1] https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/7770
> >>
> >> Signed-off-by: Andre Przywara
>
> Reviewed-by: Samuel Holland
>
> >> ---
> >> arch/arm/dts/sun50i-h616.dtsi | 12
> >> 1 file changed, 12 deletions(-)
> >>
> >> diff --git a/arch/arm/dts/sun50i-h616.dtsi b/arch/arm/dts/sun50i-h616.dtsi
> >> index 953e8fac20f..dd4d2f3 100644
> >> --- a/arch/arm/dts/sun50i-h616.dtsi
> >> +++ b/arch/arm/dts/sun50i-h616.dtsi
> >> @@ -51,18 +51,6 @@
> >> };
> >> };
> >>
> >> - reserved-memory {
> >> - #address-cells = <2>;
> >> - #size-cells = <2>;
> >> - ranges;
> >> -
> >> - /* 512KiB reserved for ARM Trusted Firmware (BL31) */
> >> - secmon_reserved: secmon@4000 {
> >> - reg = <0x0 0x4000 0x0 0x8>;
> >> - no-map;
> >> - };
> >> - };
> >> -
> >
> > As said always. it's better to not touch Linux dts files. If the same
> > fix same available in Linux add SHA1 on the commit message otherwise
> > keep /delete-node on -u-boot.dtsi. This how we are maintaining sofar
> > at least on sunxi.
>
> This file has not yet been added to the Linux tree, so that rule does not
> apply
> in this case.
Reviewed-by: Jagan Teki
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
To view this discussion on the web, visit
https://groups.google.com/d/msgid/linux-sunxi/CAMty3ZDLJHgaj0CHbo6rpb3%2B1-Qz%2Bz1fPiBzkBub9ZDC4mdoJw%40mail.gmail.com.
[linux-sunxi] Re: [PATCH 2/2] sunxi: dts: H616: Drop reserved-memory node
On 3/30/21 8:28 AM, Jagan Teki wrote:
> On Tue, Mar 30, 2021 at 6:31 PM Andre Przywara wrote:
>>
>> Trusted Firmware now adds the /reserved-memory subnode to the DT at
>> runtime[1], putting in the right values.
>>
>> Drop our hard-coded version, as this might clash with the actual values
>> (which have also changed), and rely on TF-A to add the node.
>>
>> [1] https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/7770
>>
>> Signed-off-by: Andre Przywara
Reviewed-by: Samuel Holland
>> ---
>> arch/arm/dts/sun50i-h616.dtsi | 12
>> 1 file changed, 12 deletions(-)
>>
>> diff --git a/arch/arm/dts/sun50i-h616.dtsi b/arch/arm/dts/sun50i-h616.dtsi
>> index 953e8fac20f..dd4d2f3 100644
>> --- a/arch/arm/dts/sun50i-h616.dtsi
>> +++ b/arch/arm/dts/sun50i-h616.dtsi
>> @@ -51,18 +51,6 @@
>> };
>> };
>>
>> - reserved-memory {
>> - #address-cells = <2>;
>> - #size-cells = <2>;
>> - ranges;
>> -
>> - /* 512KiB reserved for ARM Trusted Firmware (BL31) */
>> - secmon_reserved: secmon@4000 {
>> - reg = <0x0 0x4000 0x0 0x8>;
>> - no-map;
>> - };
>> - };
>> -
>
> As said always. it's better to not touch Linux dts files. If the same
> fix same available in Linux add SHA1 on the commit message otherwise
> keep /delete-node on -u-boot.dtsi. This how we are maintaining sofar
> at least on sunxi.
This file has not yet been added to the Linux tree, so that rule does not apply
in this case.
Cheers,
Samuel
> Jagan.
>
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
To view this discussion on the web, visit
https://groups.google.com/d/msgid/linux-sunxi/912b7c69-fdac-8e2d-9d52-b28141beb299%40sholland.org.
[linux-sunxi] Re: [PATCH 2/2] sunxi: dts: H616: Drop reserved-memory node
On Tue, Mar 30, 2021 at 6:31 PM Andre Przywara wrote:
>
> Trusted Firmware now adds the /reserved-memory subnode to the DT at
> runtime[1], putting in the right values.
>
> Drop our hard-coded version, as this might clash with the actual values
> (which have also changed), and rely on TF-A to add the node.
>
> [1] https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/7770
>
> Signed-off-by: Andre Przywara
> ---
> arch/arm/dts/sun50i-h616.dtsi | 12
> 1 file changed, 12 deletions(-)
>
> diff --git a/arch/arm/dts/sun50i-h616.dtsi b/arch/arm/dts/sun50i-h616.dtsi
> index 953e8fac20f..dd4d2f3 100644
> --- a/arch/arm/dts/sun50i-h616.dtsi
> +++ b/arch/arm/dts/sun50i-h616.dtsi
> @@ -51,18 +51,6 @@
> };
> };
>
> - reserved-memory {
> - #address-cells = <2>;
> - #size-cells = <2>;
> - ranges;
> -
> - /* 512KiB reserved for ARM Trusted Firmware (BL31) */
> - secmon_reserved: secmon@4000 {
> - reg = <0x0 0x4000 0x0 0x8>;
> - no-map;
> - };
> - };
> -
As said always. it's better to not touch Linux dts files. If the same
fix same available in Linux add SHA1 on the commit message otherwise
keep /delete-node on -u-boot.dtsi. This how we are maintaining sofar
at least on sunxi.
Jagan.
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
To view this discussion on the web, visit
https://groups.google.com/d/msgid/linux-sunxi/CAMty3ZDpETzmE%3D1CRo2d3yT4FN0nSi7p%2Bpvf8cLjBSwfu7Kpkg%40mail.gmail.com.
