Re: [linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-06-06 Thread Mark Brown
On Sun, Jun 05, 2016 at 01:27:11PM +0200, Michal Suchanek wrote: > On 2 June 2016 at 16:26, Mark Brown wrote: > > On Thu, Jun 02, 2016 at 02:14:26PM +0200, Michal Suchanek wrote: > >> And the code added in that patch will never run unless you > >> 1) use long spi transfers > >> 2) compile in/loa

Re: [linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-06-05 Thread Michal Suchanek
On 2 June 2016 at 16:26, Mark Brown wrote: > On Thu, Jun 02, 2016 at 02:14:26PM +0200, Michal Suchanek wrote: >> On 2 June 2016 at 06:42, Priit Laes wrote: >> > On Wed, 2016-06-01 at 20:00 +0200, Maxime Ripard wrote: > >> > Actually it non-DMA case works fine if you don't need SPI transfers >> >

Re: [linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-06-02 Thread Mark Brown
On Thu, Jun 02, 2016 at 02:14:26PM +0200, Michal Suchanek wrote: > On 2 June 2016 at 06:42, Priit Laes wrote: > > On Wed, 2016-06-01 at 20:00 +0200, Maxime Ripard wrote: > > Actually it non-DMA case works fine if you don't need SPI transfers > > larger than SUN4I_FIFO_DEPTH - 1, which is 63 bytes

Re: [linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-06-02 Thread Michal Suchanek
On 2 June 2016 at 06:42, Priit Laes wrote: > On Wed, 2016-06-01 at 20:00 +0200, Maxime Ripard wrote: >> Hi, >> >> On Mon, May 30, 2016 at 04:50:16PM +0100, Mark Brown wrote: >> > >> > On Mon, May 30, 2016 at 05:28:10PM +0200, Michal Suchanek wrote: >> > > >> > > On 30 May 2016 at 17:03, Mark Brown

Re: [linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-06-02 Thread Mark Brown
On Thu, Jun 02, 2016 at 07:42:26AM +0300, Priit Laes wrote: > This was addressed by this patch, but was never applied: > http://permalink.gmane.org/gmane.linux.kernel.spi.devel/18950 I've never seen that patch before, if it was CCed to me there's a good chance it'd have been deleted unread becaus

[linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-06-02 Thread Maxime Ripard
On Tue, May 31, 2016 at 04:19:28PM +0200, Michal Suchanek wrote: > On 31 May 2016 at 15:27, Mark Brown wrote: > > On Tue, May 31, 2016 at 12:44:54PM +0200, Michal Suchanek wrote: > >> On 30 May 2016 at 17:50, Mark Brown wrote: > >> > On Mon, May 30, 2016 at 05:28:10PM +0200, Michal Suchanek wrote

Re: [linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-06-01 Thread Priit Laes
On Wed, 2016-06-01 at 20:00 +0200, Maxime Ripard wrote: > Hi, > > On Mon, May 30, 2016 at 04:50:16PM +0100, Mark Brown wrote: > > > > On Mon, May 30, 2016 at 05:28:10PM +0200, Michal Suchanek wrote: > > > > > > On 30 May 2016 at 17:03, Mark Brown wrote: > > > > > > > > > > > I really don't th

[linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-06-01 Thread Maxime Ripard
Hi, On Mon, May 30, 2016 at 04:50:16PM +0100, Mark Brown wrote: > On Mon, May 30, 2016 at 05:28:10PM +0200, Michal Suchanek wrote: > > On 30 May 2016 at 17:03, Mark Brown wrote: > > > > I really don't think it's worth caring too much about cases where the > > > DMA driver hasn't been compiled in

[linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-05-31 Thread Michal Suchanek
On 31 May 2016 at 15:27, Mark Brown wrote: > On Tue, May 31, 2016 at 12:44:54PM +0200, Michal Suchanek wrote: >> On 30 May 2016 at 17:50, Mark Brown wrote: >> > On Mon, May 30, 2016 at 05:28:10PM +0200, Michal Suchanek wrote: > >> >> It's what the driver did to start with and it was requested to

[linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-05-31 Thread Mark Brown
On Tue, May 31, 2016 at 12:44:54PM +0200, Michal Suchanek wrote: > On 30 May 2016 at 17:50, Mark Brown wrote: > > On Mon, May 30, 2016 at 05:28:10PM +0200, Michal Suchanek wrote: > >> It's what the driver did to start with and it was requested to fall > >> back to non-DMA in the case DMA is not a

[linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-05-31 Thread Michal Suchanek
On 30 May 2016 at 17:50, Mark Brown wrote: > On Mon, May 30, 2016 at 05:28:10PM +0200, Michal Suchanek wrote: >> On 30 May 2016 at 17:03, Mark Brown wrote: > >> > I really don't think it's worth caring too much about cases where the >> > DMA driver hasn't been compiled in, it's not like SPI is th

[linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-05-30 Thread Mark Brown
On Mon, May 30, 2016 at 05:28:10PM +0200, Michal Suchanek wrote: > On 30 May 2016 at 17:03, Mark Brown wrote: > > I really don't think it's worth caring too much about cases where the > > DMA driver hasn't been compiled in, it's not like SPI is the only thing > It's what the driver did to start

[linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-05-30 Thread Michal Suchanek
Hello, On 30 May 2016 at 17:03, Mark Brown wrote: > On Mon, May 30, 2016 at 02:11:51PM +0200, Geert Uytterhoeven wrote: >> On Mon, May 30, 2016 at 1:26 PM, Mark Brown wrote: >> > On Thu, May 26, 2016 at 07:25:25PM -, Michal Suchanek wrote: >> >> - fallback to previous behaviour when DMA ini

[linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-05-30 Thread Mark Brown
On Mon, May 30, 2016 at 02:11:51PM +0200, Geert Uytterhoeven wrote: > On Mon, May 30, 2016 at 1:26 PM, Mark Brown wrote: > > On Thu, May 26, 2016 at 07:25:25PM -, Michal Suchanek wrote: > >> - fallback to previous behaviour when DMA initialization fails > >> > >>+ this has the problem tha

[linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-05-30 Thread Geert Uytterhoeven
Hi Mark, On Mon, May 30, 2016 at 1:26 PM, Mark Brown wrote: > On Thu, May 26, 2016 at 07:25:25PM -, Michal Suchanek wrote: >> - fallback to previous behaviour when DMA initialization fails >> >>+ this has the problem that when the driver happens to load before the dma >> driver it w

[linux-sunxi] Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

2016-05-30 Thread Mark Brown
On Thu, May 26, 2016 at 07:25:25PM -, Michal Suchanek wrote: > - fallback to previous behaviour when DMA initialization fails > >+ this has the problem that when the driver happens to load before the dma > driver it will not use dma - can be addressed with a module parameter No, yo