[linux-sunxi] Re: [PATCH 6/6] sunxi: add PineCube board
On Mon, Oct 26, 2020 at 7:51 PM Icenowy Zheng wrote: > > PineCube is an IP camera development kit released by Pine64. > > It comes with the following compoents: > > - A mainboard with Sochip S3 SoC, a 16MByte SPI Flash, AXP209 PMIC, > a power-only microUSB connector, a USB Type-A connector, a 10/100Mbps > Ethernet port and FPC connectors for camera and daughter board. > - An OV5640-based camera module which is connected to the parallel CSI > bus of the mainboard. > - A daughterboard with several buttons, a SD slot, some IR LEDs, a > microphone and a speaker connector. > > As the device tree is synchronized in a previous commit, just add > MAINTAINER item and a defconfig. > > Signed-off-by: Icenowy Zheng > --- > board/sunxi/MAINTAINERS| 5 + > configs/pinecube_defconfig | 17 + > 2 files changed, 22 insertions(+) > create mode 100644 configs/pinecube_defconfig > > diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS > index 1180b86db3..5c53b2c878 100644 > --- a/board/sunxi/MAINTAINERS > +++ b/board/sunxi/MAINTAINERS > @@ -440,6 +440,11 @@ M: Vasily Khoruzhick > S: Maintained > F: configs/pinebook_defconfig > > +PINECUBE BOARD: > +M: Icenowy Zheng > +S: Maintained > +F: configs/pinecube_defconfig > + > PINE64 BOARDS > M: Andre Przywara > S: Maintained > diff --git a/configs/pinecube_defconfig b/configs/pinecube_defconfig > new file mode 100644 > index 00..107562ee49 > --- /dev/null > +++ b/configs/pinecube_defconfig > @@ -0,0 +1,17 @@ > +CONFIG_ARM=y > +CONFIG_ARCH_SUNXI=y > +CONFIG_SPL=y > +CONFIG_MACH_SUN8I_V3S=y > +CONFIG_SUNXI_DRAM_DDR3_1333=y > +CONFIG_DRAM_CLK=504 > +CONFIG_DRAM_ODT_EN=y > +CONFIG_I2C0_ENABLE=y > +CONFIG_DEFAULT_DEVICE_TREE="sun8i-s3-pinecube" > +CONFIG_SPL_I2C_SUPPORT=y > +# CONFIG_NETDEVICES is not set > +CONFIG_AXP209_POWER=y > +CONFIG_AXP_DCDC2_VOLT=1250 > +CONFIG_AXP_DCDC3_VOLT=3300 > +CONFIG_AXP_ALDO3_VOLT_SLOPE_08=y > +CONFIG_AXP_ALDO3_INRUSH_QUIRK=y All these AXP enablements start from AXP209_POWER to the respective dc and load values are selected from drivers/power/Kconfig itself. Please check it. Jagan. -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/CAMty3ZDCOdOMNc4-S6z94UE397xV-Bu-z71BTKP-Uww1wrKznA%40mail.gmail.com.
Re: [linux-sunxi] Re: [PATCH 6/6] sunxi: add PineCube board
于 2020年10月27日 GMT+08:00 上午2:32:30, Maxime Ripard 写到: >On Mon, Oct 26, 2020 at 10:21:00PM +0800, Icenowy Zheng wrote: >> PineCube is an IP camera development kit released by Pine64. >> >> It comes with the following compoents: >> >> - A mainboard with Sochip S3 SoC, a 16MByte SPI Flash, AXP209 PMIC, >> a power-only microUSB connector, a USB Type-A connector, a 10/100Mbps >> Ethernet port and FPC connectors for camera and daughter board. >> - An OV5640-based camera module which is connected to the parallel >CSI >> bus of the mainboard. >> - A daughterboard with several buttons, a SD slot, some IR LEDs, a >> microphone and a speaker connector. >> >> As the device tree is synchronized in a previous commit, just add >> MAINTAINER item and a defconfig. >> >> Signed-off-by: Icenowy Zheng >> --- >> board/sunxi/MAINTAINERS| 5 + >> configs/pinecube_defconfig | 17 + >> 2 files changed, 22 insertions(+) >> create mode 100644 configs/pinecube_defconfig >> >> diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS >> index 1180b86db3..5c53b2c878 100644 >> --- a/board/sunxi/MAINTAINERS >> +++ b/board/sunxi/MAINTAINERS >> @@ -440,6 +440,11 @@ M: Vasily Khoruzhick >> S: Maintained >> F: configs/pinebook_defconfig >> >> +PINECUBE BOARD: >> +M: Icenowy Zheng >> +S: Maintained >> +F: configs/pinecube_defconfig >> + >> PINE64 BOARDS >> M: Andre Przywara >> S: Maintained >> diff --git a/configs/pinecube_defconfig b/configs/pinecube_defconfig >> new file mode 100644 >> index 00..107562ee49 >> --- /dev/null >> +++ b/configs/pinecube_defconfig >> @@ -0,0 +1,17 @@ >> +CONFIG_ARM=y >> +CONFIG_ARCH_SUNXI=y >> +CONFIG_SPL=y >> +CONFIG_MACH_SUN8I_V3S=y >> +CONFIG_SUNXI_DRAM_DDR3_1333=y >> +CONFIG_DRAM_CLK=504 >> +CONFIG_DRAM_ODT_EN=y >> +CONFIG_I2C0_ENABLE=y >> +CONFIG_DEFAULT_DEVICE_TREE="sun8i-s3-pinecube" >> +CONFIG_SPL_I2C_SUPPORT=y >> +# CONFIG_NETDEVICES is not set >> +CONFIG_AXP209_POWER=y >> +CONFIG_AXP_DCDC2_VOLT=1250 >> +CONFIG_AXP_DCDC3_VOLT=3300 >> +CONFIG_AXP_ALDO3_VOLT_SLOPE_08=y >> +CONFIG_AXP_ALDO3_INRUSH_QUIRK=y > >It would be worth mentioning in the commit log why you need those >options. For the ALDO3 options, they might be not necessary in U-Boot stage, because it's finally only used in Linux stage. I don't know whether these are still needed when we declared the hack in DT for Linux. > >With that fixed, the whole series is >Acked-by: Maxime Ripard > >Thanks! >Maxime -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/877B7B36-CE6D-481A-AEAB-011E6C735F76%40aosc.io.
[linux-sunxi] Re: [PATCH 6/6] sunxi: add PineCube board
On Mon, Oct 26, 2020 at 10:21:00PM +0800, Icenowy Zheng wrote: > PineCube is an IP camera development kit released by Pine64. > > It comes with the following compoents: > > - A mainboard with Sochip S3 SoC, a 16MByte SPI Flash, AXP209 PMIC, > a power-only microUSB connector, a USB Type-A connector, a 10/100Mbps > Ethernet port and FPC connectors for camera and daughter board. > - An OV5640-based camera module which is connected to the parallel CSI > bus of the mainboard. > - A daughterboard with several buttons, a SD slot, some IR LEDs, a > microphone and a speaker connector. > > As the device tree is synchronized in a previous commit, just add > MAINTAINER item and a defconfig. > > Signed-off-by: Icenowy Zheng > --- > board/sunxi/MAINTAINERS| 5 + > configs/pinecube_defconfig | 17 + > 2 files changed, 22 insertions(+) > create mode 100644 configs/pinecube_defconfig > > diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS > index 1180b86db3..5c53b2c878 100644 > --- a/board/sunxi/MAINTAINERS > +++ b/board/sunxi/MAINTAINERS > @@ -440,6 +440,11 @@ M: Vasily Khoruzhick > S: Maintained > F: configs/pinebook_defconfig > > +PINECUBE BOARD: > +M: Icenowy Zheng > +S: Maintained > +F: configs/pinecube_defconfig > + > PINE64 BOARDS > M: Andre Przywara > S: Maintained > diff --git a/configs/pinecube_defconfig b/configs/pinecube_defconfig > new file mode 100644 > index 00..107562ee49 > --- /dev/null > +++ b/configs/pinecube_defconfig > @@ -0,0 +1,17 @@ > +CONFIG_ARM=y > +CONFIG_ARCH_SUNXI=y > +CONFIG_SPL=y > +CONFIG_MACH_SUN8I_V3S=y > +CONFIG_SUNXI_DRAM_DDR3_1333=y > +CONFIG_DRAM_CLK=504 > +CONFIG_DRAM_ODT_EN=y > +CONFIG_I2C0_ENABLE=y > +CONFIG_DEFAULT_DEVICE_TREE="sun8i-s3-pinecube" > +CONFIG_SPL_I2C_SUPPORT=y > +# CONFIG_NETDEVICES is not set > +CONFIG_AXP209_POWER=y > +CONFIG_AXP_DCDC2_VOLT=1250 > +CONFIG_AXP_DCDC3_VOLT=3300 > +CONFIG_AXP_ALDO3_VOLT_SLOPE_08=y > +CONFIG_AXP_ALDO3_INRUSH_QUIRK=y It would be worth mentioning in the commit log why you need those options. With that fixed, the whole series is Acked-by: Maxime Ripard Thanks! Maxime -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20201026183230.mafpgldbgua2cdzo%40gilmour.lan. signature.asc Description: PGP signature
