[linux-sunxi] Re: [PATCH v2] ARM: sunxi: Add driver for sunxi usb phy

2014-02-10 Thread Maxime Ripard
Hi, On Sat, Feb 08, 2014 at 12:27:42AM +0100, Hans de Goede wrote: > Hi, > > On 02/07/2014 11:36 PM, Maxime Ripard wrote: > >Hi Hans, > > > >It looks very nice, I just have a few comments below though. > > > >On Fri, Feb 07, 2014 at 05:33:21PM +0100, Hans de Goede wrote: > >>The Allwinner A1x / A

[linux-sunxi] Re: [PATCH v2] ARM: sunxi: Add driver for sunxi usb phy

2014-02-07 Thread Hans de Goede
Hi, On 02/07/2014 11:36 PM, Maxime Ripard wrote: Hi Hans, It looks very nice, I just have a few comments below though. On Fri, Feb 07, 2014 at 05:33:21PM +0100, Hans de Goede wrote: The Allwinner A1x / A2x SoCs have 2 or 3 usb phys which are all accessed through a single set of registers. Bes

[linux-sunxi] Re: [PATCH v2] ARM: sunxi: Add driver for sunxi usb phy

2014-02-07 Thread Maxime Ripard
Hi Hans, It looks very nice, I just have a few comments below though. On Fri, Feb 07, 2014 at 05:33:21PM +0100, Hans de Goede wrote: > The Allwinner A1x / A2x SoCs have 2 or 3 usb phys which are all accessed > through a single set of registers. Besides this there are also some other > phy related