[linux-sunxi] Re: [PATCH v3 3/5] spi: sunxi: Add Allwinner A31 SPI controller driver

2014-02-04 Thread Mark Brown
On Tue, Feb 04, 2014 at 10:09:26AM +0100, Maxime Ripard wrote: > On Tue, Feb 04, 2014 at 12:21:10AM +, Mark Brown wrote: > > It isn't awesome, no. Ideally the runtime PM code would do this but > > then you couldn't ifdef the operations which as far as I can tell is the > > main thing people w

[linux-sunxi] Re: [PATCH v3 3/5] spi: sunxi: Add Allwinner A31 SPI controller driver

2014-02-04 Thread Maxime Ripard
Hi Mark, On Tue, Feb 04, 2014 at 12:21:10AM +, Mark Brown wrote: > On Fri, Jan 31, 2014 at 11:47:04PM +0100, Maxime Ripard wrote: > > On Fri, Jan 31, 2014 at 12:48:09PM +, Mark Brown wrote: > > > On Fri, Jan 31, 2014 at 11:55:50AM +0100, Maxime Ripard wrote: > > > > > + pm_runtime_e

[linux-sunxi] Re: [PATCH v3 3/5] spi: sunxi: Add Allwinner A31 SPI controller driver

2014-02-03 Thread Mark Brown
On Fri, Jan 31, 2014 at 11:47:04PM +0100, Maxime Ripard wrote: > On Fri, Jan 31, 2014 at 12:48:09PM +, Mark Brown wrote: > > On Fri, Jan 31, 2014 at 11:55:50AM +0100, Maxime Ripard wrote: > > > + pm_runtime_enable(&pdev->dev); > > > + if (!pm_runtime_enabled(&pdev->dev)) { > > > + ret

[linux-sunxi] Re: [PATCH v3 3/5] spi: sunxi: Add Allwinner A31 SPI controller driver

2014-01-31 Thread Maxime Ripard
On Fri, Jan 31, 2014 at 12:48:09PM +, Mark Brown wrote: > On Fri, Jan 31, 2014 at 11:55:50AM +0100, Maxime Ripard wrote: > > > + master = devm_spi_alloc_master(&pdev->dev, sizeof(struct sun6i_spi)); > > + if (!master) { > > + dev_err(&pdev->dev, "Unable to allocate SPI Master\n")

[linux-sunxi] Re: [PATCH v3 3/5] spi: sunxi: Add Allwinner A31 SPI controller driver

2014-01-31 Thread Mark Brown
On Fri, Jan 31, 2014 at 11:55:50AM +0100, Maxime Ripard wrote: > + master = devm_spi_alloc_master(&pdev->dev, sizeof(struct sun6i_spi)); > + if (!master) { > + dev_err(&pdev->dev, "Unable to allocate SPI Master\n"); > + return -ENOMEM; > + } This now depends on