[linux-sunxi] Re: [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support

2014-05-14 Thread Boris BREZILLON
Hello Mike, On 14/05/2014 02:51, Mike Turquette wrote: Quoting Boris BREZILLON (2014-05-09 04:11:49) +struct clk_ops ar100_ops = { + .recalc_rate = ar100_recalc_rate, + .determine_rate = ar100_determine_rate, + .set_parent = ar100_set_parent, + .get_parent =

[linux-sunxi] Re: [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support

2014-05-14 Thread Mike Turquette
Quoting Boris BREZILLON (2014-05-14 00:30:59) Hello Mike, On 14/05/2014 02:51, Mike Turquette wrote: Quoting Boris BREZILLON (2014-05-09 04:11:49) +struct clk_ops ar100_ops = { + .recalc_rate = ar100_recalc_rate, + .determine_rate = ar100_determine_rate, +

[linux-sunxi] Re: [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support

2014-05-13 Thread Emilio López
Hi Boris, First of all, thanks for working on this :) While reading the code below I noticed a complete lack of comments. I think it would be good to have at least some to aid readability, considering these clocks are poorly documented on AW's material. El 09/05/14 08:11, Boris BREZILLON