On Thu, Jan 2, 2020 at 4:33 PM Maxime Ripard <mrip...@kernel.org> wrote: > > On Tue, Dec 31, 2019 at 06:35:25PM +0530, Jagan Teki wrote: > > The MIPI DSI PHY controller on Allwinner R40 is similar > > on the one on A31. > > > > Add R40 compatible and append A31 compatible as fallback. > > > > Signed-off-by: Jagan Teki <ja...@amarulasolutions.com> > > --- > > Changes for v3: > > - update the binding in new yaml format > > > > .../devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml > > b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml > > index 8841938050b2..0c283fe79402 100644 > > --- > > a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml > > +++ > > b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml > > @@ -18,6 +18,7 @@ properties: > > oneOf: > > - const: allwinner,sun6i-a31-mipi-dphy > > - items: > > + - const: allwinner,sun8i-r40-mipi-dphy > > - const: allwinner,sun50i-a64-mipi-dphy > > - const: allwinner,sun6i-a31-mipi-dphy > > This isn't doing what you say it does. > > Here you're stating that there's two valid values, one that is a > single element allwinner,sun6i-a31-mipi-dphy, and another which is a > list of three elements allwinner,sun8i-r40-mipi-dphy, > allwinner,sun50i-a64-mipi-dphy and allwinner,sun6i-a31-mipi-dphy, in > that order.
I got it Maxime, thanks for pointing this. > > Did you run make dtbs_check and dt_bindings_check? I sure I didn't, thanks for the clue. Will do this on another patch as well. Jagan. -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/CAMty3ZAwaqE31%3DrCiub3bRZBOa68ck5Ld%3DA7kVsQjssps9TCxg%40mail.gmail.com.
