[linux-sunxi] Re: [PATCH 2/3] mmc: sunxi: Filter out unsupported modes declared in the device tree

2019-02-04 Thread Maxime Ripard
On Mon, Feb 04, 2019 at 06:16:24PM +0800, Chen-Yu Tsai wrote: > On Mon, Feb 4, 2019 at 5:34 PM Maxime Ripard > wrote: > > > > On Sun, Feb 03, 2019 at 11:56:27PM +0800, Chen-Yu Tsai wrote: > > > The MMC device tree bindings include properties used to signal various > > > signalling speed modes.

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 10:40:12AM +0100, Daniel Vetter wrote: > On Mon, Feb 04, 2019 at 09:23:59AM +0100, Thierry Reding wrote: > > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > > On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding > > > wrote: > > > > > > > > On Sun, Feb

[linux-sunxi] Re: [PATCH 2/3] mmc: sunxi: Filter out unsupported modes declared in the device tree

2019-02-04 Thread Chen-Yu Tsai
On Mon, Feb 4, 2019 at 5:34 PM Maxime Ripard wrote: > > On Sun, Feb 03, 2019 at 11:56:27PM +0800, Chen-Yu Tsai wrote: > > The MMC device tree bindings include properties used to signal various > > signalling speed modes. Until now the sunxi driver was accepting them > > without any further

Re: [linux-sunxi] Re: [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected

2019-02-04 Thread Vasily Khoruzhick
On Mon, Feb 4, 2019 at 8:29 AM Icenowy Zheng wrote: > >> IIRC, from the previous discussion, HDMI had a tolerancy requirement > >> in the standard. Do you know if there's such a thing for eDP? That > >> would solve the issue for all the eDP displays at once. > > > >I don't have access to eDP

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Daniel Vetter
On Mon, Feb 04, 2019 at 12:22:18PM +0100, Thierry Reding wrote: > On Mon, Feb 04, 2019 at 10:40:12AM +0100, Daniel Vetter wrote: > > On Mon, Feb 04, 2019 at 09:23:59AM +0100, Thierry Reding wrote: > > > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > > > On Sun, Feb 3, 2019

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Vasily Khoruzhick
On Mon, Feb 4, 2019 at 12:24 AM Thierry Reding wrote: > > > > Pinebook used several 768p panels that have slightly different timings > > and recent batch uses 1080p panel. > > > > What panel descriptor should I use as fallback? > > You don't use panel descriptors as fallback. The simple-panel

[linux-sunxi] Re: [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected

2019-02-04 Thread Icenowy Zheng
于 2019年2月5日 GMT+08:00 上午12:26:43, Vasily Khoruzhick 写到: >On Mon, Feb 4, 2019 at 6:20 AM Maxime Ripard > wrote: >> >> Hi, >> >> On Sun, Feb 03, 2019 at 10:54:55AM -0800, Vasily Khoruzhick wrote: >> > Clock rate check that was added in commit bb43d40d7c83 ("drm/sun4i: >rgb: >> > Validate the

[linux-sunxi] Re: [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected

2019-02-04 Thread Maxime Ripard
Hi, On Sun, Feb 03, 2019 at 10:54:55AM -0800, Vasily Khoruzhick wrote: > Clock rate check that was added in commit bb43d40d7c83 ("drm/sun4i: rgb: > Validate the clock rate") prevents some panel and bridges from working with > sun4i driver. > > Unfortunately, dotclock frequency for some modes are

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Rob Herring
On Mon, Feb 4, 2019 at 2:26 PM Vasily Khoruzhick wrote: > > On Mon, Feb 4, 2019 at 12:23 PM Rob Herring wrote: > > > > simple-panel would probably work if you stuck in some mostly compatible > > > string and provided a ddc-i2c-bus property in the device tree node. The > > > generic-ish fallback

[linux-sunxi] Re: [PATCH 0/9] Analogix ANX6345 RGB-(e)DP bridge support

2019-02-04 Thread Vasily Khoruzhick
On Mon, Feb 4, 2019 at 4:22 AM Torsten Duwe wrote: > > On Thu, Oct 18, 2018 at 03:33:18PM +0800, Icenowy Zheng wrote: > > This patchset brings the support for Analogix ANX6345 RGB-(e)DP bridge, > > which is used by some Allwinner A64 laptops, such as Pinebook and Olimex > > TERES-I. > > > > So

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Rob Herring
On Mon, Feb 4, 2019 at 10:56 AM Thierry Reding wrote: > > On Mon, Feb 04, 2019 at 10:27:09AM -0600, Rob Herring wrote: > > On Mon, Feb 4, 2019 at 2:24 AM Thierry Reding > > wrote: > > > > > > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > > > On Sun, Feb 3, 2019 at 11:43

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Vasily Khoruzhick
On Mon, Feb 4, 2019 at 12:23 PM Rob Herring wrote: > > simple-panel would probably work if you stuck in some mostly compatible > > string and provided a ddc-i2c-bus property in the device tree node. The > > generic-ish fallback case could be implemented by providing a fallback > > compatible

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 08:11:05AM -0800, Vasily Khoruzhick wrote: > On Mon, Feb 4, 2019 at 12:24 AM Thierry Reding > wrote: > > > > > > Pinebook used several 768p panels that have slightly different timings > > > and recent batch uses 1080p panel. > > > > > > What panel descriptor should I use

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 10:27:09AM -0600, Rob Herring wrote: > On Mon, Feb 4, 2019 at 2:24 AM Thierry Reding > wrote: > > > > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > > On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding > > > wrote: > > > > > > > > On Sun, Feb 03,

Re: [linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Vasily Khoruzhick
On Mon, Feb 4, 2019 at 8:39 AM Rob Herring wrote: > > On Mon, Feb 4, 2019 at 10:11 AM Vasily Khoruzhick wrote: > > > > On Mon, Feb 4, 2019 at 12:24 AM Thierry Reding > > wrote: > > > > > > > > Pinebook used several 768p panels that have slightly different timings > > > > and recent batch uses

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Rob Herring
On Mon, Feb 4, 2019 at 2:24 AM Thierry Reding wrote: > > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding > > wrote: > > > > > > On Sun, Feb 03, 2019 at 10:54:57AM -0800, Vasily Khoruzhick wrote: > > > > eDP panels usually

[linux-sunxi] Re: [PATCH RESEND v2 06/12] drm/sun4i: rgb: Add 1% tolerance to dclk frequency check when bridge is connected

2019-02-04 Thread Vasily Khoruzhick
On Mon, Feb 4, 2019 at 6:20 AM Maxime Ripard wrote: > > Hi, > > On Sun, Feb 03, 2019 at 10:54:55AM -0800, Vasily Khoruzhick wrote: > > Clock rate check that was added in commit bb43d40d7c83 ("drm/sun4i: rgb: > > Validate the clock rate") prevents some panel and bridges from working with > > sun4i

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Rob Herring
On Mon, Feb 4, 2019 at 10:11 AM Vasily Khoruzhick wrote: > > On Mon, Feb 4, 2019 at 12:24 AM Thierry Reding > wrote: > > > > > > Pinebook used several 768p panels that have slightly different timings > > > and recent batch uses 1080p panel. > > > > > > What panel descriptor should I use as

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Vasily Khoruzhick
On Mon, Feb 4, 2019 at 8:56 AM Thierry Reding wrote: > > I think it is perfectly fine to have a generic-ish fallback as long as > > it is just that, a fallback. If the panel has quirks, then you'd > > better make sure the firmware is stuffing in the right compatibles or > > that you can update

[linux-sunxi] Re: [PATCH 2/3] mmc: sunxi: Filter out unsupported modes declared in the device tree

2019-02-04 Thread Maxime Ripard
On Sun, Feb 03, 2019 at 11:56:27PM +0800, Chen-Yu Tsai wrote: > The MMC device tree bindings include properties used to signal various > signalling speed modes. Until now the sunxi driver was accepting them > without any further filtering, while the sunxi device trees were not > actually using

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Vasily Khoruzhick
On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding wrote: > > On Sun, Feb 03, 2019 at 10:54:57AM -0800, Vasily Khoruzhick wrote: > > eDP panels usually have EDID EEPROM, so there's no need to define panel > > width/height or any modes/timings in dts. But this panel still may have > > regulator and/or

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Daniel Vetter
On Mon, Feb 04, 2019 at 09:23:59AM +0100, Thierry Reding wrote: > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding > > wrote: > > > > > > On Sun, Feb 03, 2019 at 10:54:57AM -0800, Vasily Khoruzhick wrote: > > > > eDP panels

[linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding > wrote: > > > > On Sun, Feb 03, 2019 at 10:54:57AM -0800, Vasily Khoruzhick wrote: > > > eDP panels usually have EDID EEPROM, so there's no need to define panel > > > width/height

[linux-sunxi] Re: [PATCH 1/3] mmc: sunxi: Disable HS-DDR mode for H5 eMMC controller by default

2019-02-04 Thread Maxime Ripard
On Sun, Feb 03, 2019 at 11:56:26PM +0800, Chen-Yu Tsai wrote: > Some H5 boards seem to not have proper trace lengths for eMMC to be able > to use the default setting for the delay chains under HS-DDR mode. These > include the Bananapi M2+ H5 and NanoPi NEO Core2. However the Libre > Computer