Re: [linux-sunxi] [PATCH v5 12/15] ASoC: sun4i-i2s: Add multi-lane functionality

2019-08-14 Thread Jernej Škrabec
Hi! Dne sreda, 14. avgust 2019 ob 08:08:51 CEST je codekip...@gmail.com napisal(a): > From: Marcus Cooper > > The i2s block supports multi-lane i2s output however this functionality > is only possible in earlier SoCs where the pins are exposed and for > the i2s block used for HDMI audio on the

Re: [linux-sunxi] [PATCH v5 15/15] ASoC: sun4i-i2s: Adjust regmap settings

2019-08-14 Thread Jernej Škrabec
Hi! Dne sreda, 14. avgust 2019 ob 08:08:54 CEST je codekip...@gmail.com napisal(a): > From: Marcus Cooper > > Bypass the regmap cache when flushing the i2s FIFOs and modify the tables > to reflect this. > > Signed-off-by: Marcus Cooper > --- > sound/soc/sunxi/sun4i-i2s.c | 31

[linux-sunxi] Re: [PATCH v5 11/15] ASoC: sun4i-i2s: Add support for H6 I2S

2019-08-14 Thread Jernej Škrabec
Hi! Dne sreda, 14. avgust 2019 ob 08:08:50 CEST je codekip...@gmail.com napisal(a): > From: Jernej Skrabec > > H6 I2S is very similar to that in H3, except it supports up to 16 > channels. > > Signed-off-by: Jernej Skrabec Your Signed-off-by is missing here and on all other patches made

[linux-sunxi] [PATCH v5 03/15] ASoC: sun4i-i2s: Correct divider calculations

2019-08-14 Thread codekipper
From: Marcus Cooper The clock division circuitry is different on the H3 and later SoCs. The division of bclk is now based on pll2. Signed-off-by: Marcus Cooper --- sound/soc/sunxi/sun4i-i2s.c | 73 + 1 file changed, 49 insertions(+), 24 deletions(-) diff

[linux-sunxi] [PATCH v5 11/15] ASoC: sun4i-i2s: Add support for H6 I2S

2019-08-14 Thread codekipper
From: Jernej Skrabec H6 I2S is very similar to that in H3, except it supports up to 16 channels. Signed-off-by: Jernej Skrabec --- sound/soc/sunxi/sun4i-i2s.c | 148 1 file changed, 148 insertions(+) diff --git a/sound/soc/sunxi/sun4i-i2s.c

[linux-sunxi] [PATCH v5 07/15] ASoC: sun4i-i2s: Add functions for RX and TX channel selects

2019-08-14 Thread codekipper
From: Marcus Cooper Newer SoCs like the H6 have the channel select bits in a different positions than what is on the H3. As we will eventually add multi- channel support then create function calls as opposed to regmap fields to add support for different devices. Signed-off-by: Marcus Cooper

[linux-sunxi] [PATCH v5 05/15] ASoC: sun4i-i2s: Add functions for RX and TX channel offsets

2019-08-14 Thread codekipper
From: Marcus Cooper Newer SoCs like the H6 have the channel offset bits in a different position to what is on the H3. As we will eventually add multi- channel support then create function calls as opposed to regmap fields to add support for different devices. Signed-off-by: Marcus Cooper ---

[linux-sunxi] [PATCH v5 10/15] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible

2019-08-14 Thread codekipper
From: Jernej Skrabec H6 I2S is very similar to H3, except that it supports up to 16 channels and thus few registers have fields on different position. Signed-off-by: Jernej Skrabec --- .../devicetree/bindings/sound/allwinner,sun4i-a10-i2s.yaml | 2 ++ 1 file changed, 2 insertions(+)

[linux-sunxi] [PATCH v5 00/15] ASoC: sun4i-i2s: Updates to the driver

2019-08-14 Thread codekipper
From: Marcus Cooper Hi All, here is a patch series to add some improvements to the sun4i-i2s driver found whilst getting slave clocking and hdmi audio working on the newer SoCs. As the LibreELEC project is progressing extremely well then there has been some activity getting H6 SoC support with

[linux-sunxi] [PATCH v5 12/15] ASoC: sun4i-i2s: Add multi-lane functionality

2019-08-14 Thread codekipper
From: Marcus Cooper The i2s block supports multi-lane i2s output however this functionality is only possible in earlier SoCs where the pins are exposed and for the i2s block used for HDMI audio on the later SoCs. To enable this functionality, an optional property has been added to the bindings.

[linux-sunxi] [PATCH v5 14/15] ASoc: sun4i-i2s: Add 20, 24 and 32 bit support

2019-08-14 Thread codekipper
From: Marcus Cooper Extend the functionality of the driver to include support of 20 and 24 bits per sample for the earlier SoCs. Newer SoCs can also handle 32bit samples. Signed-off-by: Marcus Cooper --- sound/soc/sunxi/sun4i-i2s.c | 21 +++-- 1 file changed, 19

[linux-sunxi] [PATCH v5 04/15] ASoC: sun4i-i2s: Support more formats on newer SoCs

2019-08-14 Thread codekipper
From: Marcus Cooper There is a need to support more formats on the newer SoCs(H3 and later). Extend the formats supported to include DSP_A and DSP_B modes. Signed-off-by: Marcus Cooper --- sound/soc/sunxi/sun4i-i2s.c | 87 +++-- 1 file changed, 63

[linux-sunxi] [PATCH v5 02/15] ASoC: sun4i-i2s: Add set_tdm_slot functionality

2019-08-14 Thread codekipper
From: Marcus Cooper Codecs without a control connection such as i2s based HDMI audio and the Pine64 DAC require a different amount of bit clocks per frame than what is calculated by the sample width. Use the tdm slot bindings to provide this mechanism. Signed-off-by: Marcus Cooper ---

[linux-sunxi] [PATCH v5 01/15] ASoC: sun4i-i2s: Add regmap field to sign extend sample

2019-08-14 Thread codekipper
From: Marcus Cooper On the newer SoCs such as the H3 and A64 this is set by default to transfer a 0 after each sample in each slot. However the A10 and A20 SoCs that this driver was developed on had a default setting where it padded the audio gain with zeros. This isn't a problem whilst we have

[linux-sunxi] [PATCH v5 09/15] clk: sunxi-ng: h6: Allow I2S to change parent rate

2019-08-14 Thread codekipper
From: Jernej Skrabec I2S doesn't work if parent rate couldn't be change. Difference between wanted and actual rate is too big. Fix this by adding CLK_SET_RATE_PARENT flag to I2S clocks. Signed-off-by: Jernej Skrabec --- drivers/clk/sunxi-ng/ccu-sun50i-h6.c | 8 1 file changed, 4

[linux-sunxi] [PATCH v5 15/15] ASoC: sun4i-i2s: Adjust regmap settings

2019-08-14 Thread codekipper
From: Marcus Cooper Bypass the regmap cache when flushing the i2s FIFOs and modify the tables to reflect this. Signed-off-by: Marcus Cooper --- sound/soc/sunxi/sun4i-i2s.c | 31 ++- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git

[linux-sunxi] [PATCH v5 06/15] ASoC: sun4i-i2s: Add functions for RX and TX channel enables

2019-08-14 Thread codekipper
From: Marcus Cooper Newer SoCs like the H6 have the channel enable bits in a different position to what is on the H3. As we will eventually add multi- channel support then create function calls as opposed to regmap fields to add support for different devices. Signed-off-by: Marcus Cooper ---

[linux-sunxi] [PATCH v5 13/15] ASoC: sun4i-i2s: Add multichannel functionality

2019-08-14 Thread codekipper
From: Marcus Cooper The i2s block can be used to pass PCM data over multiple channels and is sometimes used for the audio side of an HDMI connection. Signed-off-by: Marcus Cooper --- sound/soc/sunxi/sun4i-i2s.c | 93 + 1 file changed, 63 insertions(+), 30

[linux-sunxi] [PATCH v5 08/15] ASoC: sun4i-i2s: Add functions for channel mapping

2019-08-14 Thread codekipper
From: Marcus Cooper As we will eventually add multi-channel audio support to the i2s then create function calls as opposed to regmap fields to add support for different devices. Signed-off-by: Marcus Cooper --- sound/soc/sunxi/sun4i-i2s.c | 71 + 1 file

Re: [linux-sunxi] Re: [PATCH v5 15/15] ASoC: sun4i-i2s: Adjust regmap settings

2019-08-14 Thread Jernej Škrabec
Dne sreda, 14. avgust 2019 ob 09:20:07 CEST je Maxime Ripard napisal(a): > On Wed, Aug 14, 2019 at 08:08:54AM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > Bypass the regmap cache when flushing the i2s FIFOs and modify the tables > > to reflect this. > > > > Signed-off-by:

[linux-sunxi] Re: [PATCH v5 12/15] ASoC: sun4i-i2s: Add multi-lane functionality

2019-08-14 Thread Code Kipper
On Wed, 14 Aug 2019 at 13:08, Maxime Ripard wrote: > > On Wed, Aug 14, 2019 at 08:08:51AM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > The i2s block supports multi-lane i2s output however this functionality > > is only possible in earlier SoCs where the pins are exposed and

[linux-sunxi] Re: [PATCH v5 04/15] ASoC: sun4i-i2s: Support more formats on newer SoCs

2019-08-14 Thread Code Kipper
On Wed, 14 Aug 2019 at 13:08, Maxime Ripard wrote: > > On Wed, Aug 14, 2019 at 08:08:43AM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > There is a need to support more formats on the newer SoCs(H3 and later). > > Extend the formats supported to include DSP_A and DSP_B modes.

[linux-sunxi] Re: [PATCH v5 01/15] ASoC: sun4i-i2s: Add regmap field to sign extend sample

2019-08-14 Thread Code Kipper
On Wed, 14 Aug 2019 at 13:08, Maxime Ripard wrote: > > Hi, > > On Wed, Aug 14, 2019 at 08:08:40AM +0200, codekip...@gmail.com wrote: > > From: Marcus Cooper > > > > On the newer SoCs such as the H3 and A64 this is set by default > > to transfer a 0 after each sample in each slot. However the A10

[linux-sunxi] Re: [PATCH v5 15/15] ASoC: sun4i-i2s: Adjust regmap settings

2019-08-14 Thread Chen-Yu Tsai
On Wed, Aug 14, 2019 at 2:09 PM wrote: > > From: Marcus Cooper > > Bypass the regmap cache when flushing the i2s FIFOs and modify the tables > to reflect this. > > Signed-off-by: Marcus Cooper > --- > sound/soc/sunxi/sun4i-i2s.c | 31 ++- > 1 file changed, 10

[linux-sunxi] Re: [PATCH] arm: dts: sync dts for Allwinner H6

2019-08-14 Thread Clément Péron
Hi On Sun, 11 Aug 2019 at 22:42, Clément Péron wrote: > > Sync Kernel DTS for Allwinner H6 boards. > > commit Linux 5.3-rc4 > > Signed-off-by: Clément Péron > --- > arch/arm/dts/sun50i-h6-beelink-gs1.dts | 76 ++ > arch/arm/dts/sun50i-h6-pine-h64.dts| 12 >

[linux-sunxi] Re: [PATCH v5 02/15] ASoC: sun4i-i2s: Add set_tdm_slot functionality

2019-08-14 Thread Mark Brown
On Wed, Aug 14, 2019 at 08:08:41AM +0200, codekip...@gmail.com wrote: > From: Marcus Cooper > > Codecs without a control connection such as i2s based HDMI audio and > the Pine64 DAC require a different amount of bit clocks per frame than This isn't a universal property of CODECs without a

[linux-sunxi] Re: [PATCH v5 03/15] ASoC: sun4i-i2s: Correct divider calculations

2019-08-14 Thread Mark Brown
On Wed, Aug 14, 2019 at 08:08:42AM +0200, codekip...@gmail.com wrote: > + if (i2s->variant->has_fmt_set_lrck_period) > + bclk_div = sun4i_i2s_get_bclk_div(i2s, clk_rate / rate, > + word_size, > +

Re: [linux-sunxi] [PATCH v5 14/15] ASoc: sun4i-i2s: Add 20, 24 and 32 bit support

2019-08-14 Thread Code Kipper
On Wed, 14 Aug 2019 at 10:28, Jernej Škrabec wrote: > > Hi! > > Dne sreda, 14. avgust 2019 ob 08:08:53 CEST je codekip...@gmail.com > napisal(a): > > From: Marcus Cooper > > > > Extend the functionality of the driver to include support of 20 and > > 24 bits per sample for the earlier SoCs. > > >

Re: [linux-sunxi] [PATCH v5 15/15] ASoC: sun4i-i2s: Adjust regmap settings

2019-08-14 Thread Code Kipper
On Wed, 14 Aug 2019 at 10:38, Jernej Škrabec wrote: > > Hi! > > Dne sreda, 14. avgust 2019 ob 08:08:54 CEST je codekip...@gmail.com > napisal(a): > > From: Marcus Cooper > > > > Bypass the regmap cache when flushing the i2s FIFOs and modify the tables > > to reflect this. > > > > Signed-off-by:

[linux-sunxi] Re: [PATCH v5 03/15] ASoC: sun4i-i2s: Correct divider calculations

2019-08-14 Thread Maxime Ripard
Hi, (I just noticed this, but can you update my mail address, it's not @free-electrons for quite a while, you probably want to change your scripts to use mrip...@kernel.org) On Wed, Aug 14, 2019 at 08:08:42AM +0200, codekip...@gmail.com wrote: > From: Marcus Cooper > > The clock division

[linux-sunxi] Re: [PATCH v5 15/15] ASoC: sun4i-i2s: Adjust regmap settings

2019-08-14 Thread Maxime Ripard
On Wed, Aug 14, 2019 at 08:08:54AM +0200, codekip...@gmail.com wrote: > From: Marcus Cooper > > Bypass the regmap cache when flushing the i2s FIFOs and modify the tables > to reflect this. > > Signed-off-by: Marcus Cooper This patch looks like it's fixing something while the commit log doesn't

[linux-sunxi] Re: [PATCH v5 04/15] ASoC: sun4i-i2s: Support more formats on newer SoCs

2019-08-14 Thread Maxime Ripard
On Wed, Aug 14, 2019 at 08:08:43AM +0200, codekip...@gmail.com wrote: > From: Marcus Cooper > > There is a need to support more formats on the newer SoCs(H3 and later). > Extend the formats supported to include DSP_A and DSP_B modes. > > Signed-off-by: Marcus Cooper > --- >

[linux-sunxi] Re: [PATCH v5 01/15] ASoC: sun4i-i2s: Add regmap field to sign extend sample

2019-08-14 Thread Maxime Ripard
Hi, On Wed, Aug 14, 2019 at 08:08:40AM +0200, codekip...@gmail.com wrote: > From: Marcus Cooper > > On the newer SoCs such as the H3 and A64 this is set by default > to transfer a 0 after each sample in each slot. However the A10 > and A20 SoCs that this driver was developed on had a default >

[linux-sunxi] Re: [PATCH v5 02/15] ASoC: sun4i-i2s: Add set_tdm_slot functionality

2019-08-14 Thread Maxime Ripard
Hi, On Wed, Aug 14, 2019 at 08:08:41AM +0200, codekip...@gmail.com wrote: > From: Marcus Cooper > > Codecs without a control connection such as i2s based HDMI audio and > the Pine64 DAC require a different amount of bit clocks per frame than > what is calculated by the sample width. Use the tdm

[linux-sunxi] Re: [PATCH v5 12/15] ASoC: sun4i-i2s: Add multi-lane functionality

2019-08-14 Thread Maxime Ripard
On Wed, Aug 14, 2019 at 08:08:51AM +0200, codekip...@gmail.com wrote: > From: Marcus Cooper > > The i2s block supports multi-lane i2s output however this functionality > is only possible in earlier SoCs where the pins are exposed and for > the i2s block used for HDMI audio on the later SoCs. > >

[linux-sunxi] Re: [PATCH v5 11/15] ASoC: sun4i-i2s: Add support for H6 I2S

2019-08-14 Thread Code Kipper
On Wed, 14 Aug 2019 at 09:57, Jernej Škrabec wrote: > > Hi! > > Dne sreda, 14. avgust 2019 ob 08:08:50 CEST je codekip...@gmail.com > napisal(a): > > From: Jernej Skrabec > > > > H6 I2S is very similar to that in H3, except it supports up to 16 > > channels. > > > > Signed-off-by: Jernej Skrabec

[linux-sunxi] Re: [PATCH] ARM64: dts: allwinner: Add devicetree for pine H64 modelA evaluation board

2019-08-14 Thread Corentin Labbe
On Mon, Aug 12, 2019 at 11:40:00AM +0200, Maxime Ripard wrote: > On Thu, Aug 08, 2019 at 10:42:53AM +0200, Corentin Labbe wrote: > > This patch adds the evaluation variant of the model A of the PineH64. > > The model A has the same size of the pine64 and has a PCIE slot. > > > > The only

Re: [linux-sunxi] [PATCH] ARM64: dts: allwinner: Add devicetree for pine H64 modelA evaluation board

2019-08-14 Thread Clément Péron
Hi, On Wed, 14 Aug 2019 at 15:20, Corentin Labbe wrote: > > On Mon, Aug 12, 2019 at 12:56:56PM +0200, Jernej Škrabec wrote: > > Dne četrtek, 08. avgust 2019 ob 10:42:53 CEST je Corentin Labbe napisal(a): > > > This patch adds the evaluation variant of the model A of the PineH64. > > > The model

Re: [linux-sunxi] [PATCH] ARM64: dts: allwinner: Add devicetree for pine H64 modelA evaluation board

2019-08-14 Thread Corentin Labbe
On Thu, Aug 08, 2019 at 04:50:35PM +0200, Clément Péron wrote: > Hi, > > On Thu, 8 Aug 2019 at 10:42, Corentin Labbe wrote: > > > > This patch adds the evaluation variant of the model A of the PineH64. > > The model A has the same size of the pine64 and has a PCIE slot. > > > > The only

Re: [linux-sunxi] [PATCH] ARM64: dts: allwinner: Add devicetree for pine H64 modelA evaluation board

2019-08-14 Thread Corentin Labbe
On Mon, Aug 12, 2019 at 12:56:56PM +0200, Jernej Škrabec wrote: > Dne četrtek, 08. avgust 2019 ob 10:42:53 CEST je Corentin Labbe napisal(a): > > This patch adds the evaluation variant of the model A of the PineH64. > > The model A has the same size of the pine64 and has a PCIE slot. > > > > The