On Tue, Nov 15, 2022 at 07:36:02AM +, Corentin Labbe wrote:
> Add handling of optional regulators for PHY.
> Regulators need to be enabled before PHY scanning, so MDIO bus
> initiate this task.
>
> Signed-off-by: Corentin Labbe
> ---
> drivers/net/mdio/fwnode_mdio.c | 31
> But this way could have some problem, a netdev driver could handle
> already its PHY (like dwmac-sun8i already do) and so both phy-core and
> the netdev will use both.
> It is why phy-supply was renamed in ephy-supply in patch #3.
A MAC driver will put its DT properties in the MAC node. A PHY
> + reg_cnt = of_regulator_bulk_get_all(>dev, nchild,
> );
This allocates memory for consumers?
I don't see it being freed. I think you need to add to
phy_remove. Plus the error patch should also free it.
Andrew
--
You received this message because you are subscribed
On Tue, Nov 15, 2022 at 11:18:50AM +0100, Corentin LABBE wrote:
> Le Tue, Nov 15, 2022 at 10:03:14AM +, Mark Brown a écrit :
> > What's the use case - why would a device not know which supplies
> > it requires? This just looks like an invitation to badly written
> > consumers TBH.
> The
On Tue, Nov 15, 2022 at 07:36:01AM +, Corentin Labbe wrote:
> It work exactly like regulator_bulk_get() but instead of working on a
> provided list of names, it seek all consumers properties matching
> xxx-supply.
What's the use case - why would a device not know which supplies
it requires?
On Tue, Nov 15, 2022 at 10:42:50AM +, Russell King (Oracle) wrote:
> On Tue, Nov 15, 2022 at 10:34:41AM +, Mark Brown wrote:
> > Well, it's not making this maintainer happy :/ If we know what
> > PHY is there why not just look up the set of supplies based on
> > the compatible of the
On Tue, Nov 15, 2022 at 11:16:53AM +, Mark Brown wrote:
> On Tue, Nov 15, 2022 at 10:42:50AM +, Russell King (Oracle) wrote:
> > On Tue, Nov 15, 2022 at 10:34:41AM +, Mark Brown wrote:
>
> > > Well, it's not making this maintainer happy :/ If we know what
> > > PHY is there why not
