[linux-sunxi] Re: [lm-sensors] [PATCH v2 2/5] input: sun4i-ts: Add support for temperature sensor

2013-12-27 Thread Guenter Roeck
of nitpicks and one moe question. Assuming you fix the nitpicks and the question is not a concern, feel free to add Reviewed-by: Guenter Roeck li...@roeck-us.net Guenter --- .../bindings/input/touchscreen/sun4i.txt | 6 + drivers/input/touchscreen/sun4i-ts.c | 129

[linux-sunxi] Re: [PATCH v3] regmap: i2c: fallback to SMBus if the adapter does not support standard I2C

2014-04-18 Thread Guenter Roeck
On 04/18/2014 01:11 PM, Boris BREZILLON wrote: Some I2C adapters are only compatible with the SMBus protocol and do not support standard I2C transfers. Fallback to SMBus transfers if we encounter such kind of adapters. The transfer type is chosen according to the val_bits field in the regmap

[linux-sunxi] Re: [PATCH 1/5] wdt: sunxi: Move restart code to the watchdog driver

2014-04-26 Thread Guenter Roeck
On 04/23/2014 08:04 AM, Maxime Ripard wrote: Most of the watchdog code is duplicated between the machine restart code and the watchdog driver. Add the restart hook to the watchdog driver, to be able to remove it from the machine code eventually. Signed-off-by: Maxime Ripard

[linux-sunxi] Re: [PATCH 2/5] power: reset: Add Allwinner A31 reset code

2014-04-26 Thread Guenter Roeck
On 04/23/2014 08:04 AM, Maxime Ripard wrote: That code used to be in the machine code, but it's more fit here with other restart hooks. That will allow to cleanup the machine directory, while waiting for a proper watchdog driver for the A31. Signed-off-by: Maxime Ripard

[linux-sunxi] Re: [PATCH 0/6] ARM: sunxi: Machine code cleanup

2014-05-05 Thread Guenter Roeck
On Sun, May 04, 2014 at 10:07:58PM -0500, Maxime Ripard wrote: Hi, This serie moves the restart code out of the mach-sunxi directory to either the watchdog driver or to a new driver in drivers/power/reset. Since the reset code was pretty much all the code left in the mach-sunxi directory

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-07 Thread Guenter Roeck
Ripard maxime.rip...@free-electrons.com Acked-by: Arnd Bergmann a...@arndb.de Reviewed-by: Guenter Roeck li...@roeck-us.net -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-05-22 Thread Guenter Roeck
On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote: On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote: On Tue, May 06, 2014 at 09:44:19PM

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Guenter Roeck
On 06/23/2014 03:31 AM, Maxime Ripard wrote: On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote: On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Guenter Roeck
On 06/23/2014 07:42 AM, Arnd Bergmann wrote: On Monday 23 June 2014 07:30:56 Guenter Roeck wrote: On 06/23/2014 03:31 AM, Maxime Ripard wrote: On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote: On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote: On Mon, May 19, 2014

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Guenter Roeck
On 06/23/2014 08:35 AM, Arnd Bergmann wrote: On Monday 23 June 2014 08:16:18 Guenter Roeck wrote: Moved to where? I certainly don't want it in the platform directories, and for arm64 we intentionally don't have a place to put this stuff. I have no idea, but setting the arm reset function

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Guenter Roeck
On 06/23/2014 02:30 PM, Wim Van Sebroeck wrote: Hi All, On Mon, Jun 23, 2014 at 07:30:56AM -0700, Guenter Roeck wrote: The patches _are_ in my watchdog-next branch and get some coverage from both my auto-builders and from Fenguang's build robots, so while they are not in linux-next

[linux-sunxi] Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-08-02 Thread Guenter Roeck
On Sat, Aug 02, 2014 at 10:02:08AM +0200, Wim Van Sebroeck wrote: Maxime, All, 1) For me the discussion was not ended and needs further thinking. (And I just read some good ideas about it). It would have been great for you to mention it then. 2) You never mentioned you needed

[linux-sunxi] Re: [PATCH v4 04/24] hwmon: pwm-fan: use pwm_get_xxx() helpers where appropriate

2015-11-16 Thread Guenter Roeck
On 11/16/2015 08:53 AM, Boris Brezillon wrote: On Mon, 16 Nov 2015 07:59:23 -0800 Guenter Roeck <li...@roeck-us.net> wrote: On 11/16/2015 12:56 AM, Boris Brezillon wrote: Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. Doing that will ease adaptation o

[linux-sunxi] Re: [PATCH v4 13/24] hwmon: pwm-fan: use pwm_get/set_default_xxx() helpers where appropriate

2015-11-16 Thread Guenter Roeck
On 11/16/2015 12:56 AM, Boris Brezillon wrote: pwm_set/get_default_xxx() helpers have been introduced to differentiate the default PWM states (those retrieved through DT, PWM lookup table or statically assigned by the driver) and the current ones. Make use of those helpers where appropriate.

[linux-sunxi] Re: [PATCH v4 05/24] misc: max77693-haptic: use pwm_get_xxx() helpers where appropriate

2015-11-16 Thread Guenter Roeck
On 11/16/2015 05:55 AM, Boris Brezillon wrote: Hi Krzysztof, On Mon, 16 Nov 2015 22:10:40 +0900 Krzysztof Kozlowski wrote: W dniu 16.11.2015 o 17:56, Boris Brezillon pisze: Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. Doing that will

[linux-sunxi] Re: [PATCH v4 04/24] hwmon: pwm-fan: use pwm_get_xxx() helpers where appropriate

2015-11-16 Thread Guenter Roeck
On 11/16/2015 12:56 AM, Boris Brezillon wrote: Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. Doing that will ease adaptation of the PWM framework to support atomic update. Signed-off-by: Boris Brezillon --- Patch generated with

[linux-sunxi] Re: [PATCH v5 08/46] hwmon: pwm-fan: use pwm_get_args() where appropriate

2016-03-30 Thread Guenter Roeck
On Wed, Mar 30, 2016 at 10:03:31PM +0200, Boris Brezillon wrote: > The PWM framework has clarified the concept of reference PWM config > (the platform dependent config retrieved from the DT or the PWM > lookup table) and real PWM state. > > Use pwm_get_args() when the PWM user wants to retrieve

[linux-sunxi] Re: [PATCH v2 16/21] dt-bindings: watchdog: sun4i: Add A100 compatible

2020-12-13 Thread Guenter Roeck
On Fri, Dec 11, 2020 at 01:19:29AM +, Andre Przywara wrote: > From: Yangtao Li > > Add a binding for A100's watchdog controller. > > Signed-off-by: Yangtao Li > Acked-by: Rob Herring > Signed-off-by: Andre Przywara Reviewed-by: Guenter Roeck > --- > .../d

[linux-sunxi] Re: [PATCH v2 17/21] dt-bindings: watchdog: sun4i: Add H616 compatible string

2021-01-23 Thread Guenter Roeck
On Fri, Dec 11, 2020 at 01:19:30AM +, Andre Przywara wrote: > Use enums to group all compatible devices together on the way. > > Signed-off-by: Andre Przywara > Acked-by: Rob Herring Reviewed-by: Guenter Roeck > --- > .../bindings/watchdog/allwinner,sun4i-a

[linux-sunxi] Re: [PATCH v3 17/21] dt-bindings: watchdog: sun4i: Add H616 compatible string

2021-01-23 Thread Guenter Roeck
On Mon, Jan 18, 2021 at 02:08:44AM +, Andre Przywara wrote: > Use enums to group all compatible devices together on the way. > > Signed-off-by: Andre Przywara > Acked-by: Rob Herring > Acked-by: Maxime Ripard Reviewed-by: Guenter Roeck > --- > .../bindings/watchdo

[linux-sunxi] Re: [PATCH v2 23/52] dt-bindings: hwmon: Add IIO HWMON binding

2021-09-04 Thread Guenter Roeck
On Wed, Sep 01, 2021 at 11:18:23AM +0200, Maxime Ripard wrote: > Even though we had the iio-hwmon driver for some time and a number of > boards using it already, we never had a binding for it. Let's add it > based on what the driver expects and the boards are providing. > > Cc