[linux-sunxi] Re: [PATCH v2 3/4] pinctrl: sunxi: Add Allwinner A20 clock output pin functions

2014-01-08 Thread Linus Walleij
module. Signed-off-by: Chen-Yu Tsai w...@csie.org Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux

[linux-sunxi] Re: [PATCH RFC 4/6] net: rfkill: gpio: add device tree support

2014-01-17 Thread Linus Walleij
to figure out a way to label gpios outside of the *gpiod_get* calls. The string passed in *gpiod_get* is a connection ID not a proper name for the GPIO. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from

[linux-sunxi] Re: [PATCH v2] pinctrl: sunxi: Honor GPIO output initial vaules

2014-01-20 Thread Linus Walleij
the pin function to avoid a glitch. Patch applied with Maxime's ACK and tagged for stable. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email

[linux-sunxi] Re: [PATCH 1/4] pinctrl-sunxi: Fix sun5i-a13 port F multiplexing

2014-02-25 Thread Linus Walleij
...@redhat.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Patch applied. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux

[linux-sunxi] Re: [PATCH 2/4] pinctrl-sunxi: Fix hang on gpio irq

2014-02-25 Thread Linus Walleij
Tsai for fixes so dropping this. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options

[linux-sunxi] Re: [PATCH 3/4] pinctrl-sunxi: Fix masking when setting irq type

2014-02-25 Thread Linus Walleij
On Mon, Feb 17, 2014 at 10:19 PM, Hans de Goede hdego...@redhat.com wrote: Signed-off-by: Hans de Goede hdego...@redhat.com Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe

[linux-sunxi] Re: [PATCH 4/4] pinctrl-sunxi: Fix interrupt register offset calculation

2014-02-25 Thread Linus Walleij
On Mon, Feb 17, 2014 at 10:19 PM, Hans de Goede hdego...@redhat.com wrote: This fixing setting the interrupt type for eints = 8. Signed-off-by: Hans de Goede hdego...@redhat.com Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed

[linux-sunxi] Re: [PATCH v3 1/7] pinctrl: sunxi: check clk_prepare_enable return value

2014-04-22 Thread Linus Walleij
On Thu, Apr 10, 2014 at 3:52 PM, Boris BREZILLON boris.brezil...@free-electrons.com wrote: Check the clk_prepare_enable return value to avoid false positive probe. Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Patch applied with Maxime's ACK. Yours, Linus Walleij -- You

[linux-sunxi] Re: [PATCH v3 2/7] pinctrl: sunxi: disable clk when failing to probe pin controller

2014-04-22 Thread Linus Walleij
On Thu, Apr 10, 2014 at 3:52 PM, Boris BREZILLON boris.brezil...@free-electrons.com wrote: Disable the clk when failing to probe the pin controller device. Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Patch applied with Maxime's ACK. Yours, Linus Walleij -- You

[linux-sunxi] Re: [PATCH v3 3/7] pinctrl: sunxi: add PL and PM pin definitions

2014-04-22 Thread Linus Walleij
On Thu, Apr 10, 2014 at 3:52 PM, Boris BREZILLON boris.brezil...@free-electrons.com wrote: Define PL and PM pin macros. Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Patch applied. Yours, Linus Walleij -- You

[linux-sunxi] Re: [PATCH v3 4/7] pinctrl: sunxi: support multiple pin controller

2014-04-22 Thread Linus Walleij
in the sunxi_pinctrl_desc which will be used to specify the gpiochip base pin. Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Patch applied. Yours, Linus Walleij -- You received this message because you are subscribed

[linux-sunxi] Re: [PATCH v3 5/7] pinctrl: sunxi: define A31 R_PIO pin functions

2014-04-22 Thread Linus Walleij
on here and help me figure out what and how to apply the changes to the bindings. The hunk adding the docs was dropped from the patch, please develop new series on top of my pinctrl devel branch as I push it out. Yours, Linus Walleij -- You received this message because you are subscribed

[linux-sunxi] Re: [PATCH v3 6/7] pinctrl: sunxi: add reset control support

2014-04-22 Thread Linus Walleij
-electrons.com Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more

[linux-sunxi] Re: [PATCH v3 7/7] ARM: sunxi: update the default ARCH_NR_GPIO for sunxi arch

2014-04-22 Thread Linus Walleij
Patch applied, and g we need to get rid of these static #gpios defines in the long run. ARM SoC folks: notice this hitting arch/arm/Kconfig, complain if it's problematic. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group

[linux-sunxi] Re: [PATCH 2/7] gpiolib: Support purely name based gpiod lookup in device trees

2014-04-22 Thread Linus Walleij
compatibility and any drivers needing more than one GPIO for any function. Signed-off-by: Chen-Yu Tsai w...@csie.org This looks a bit scary and I cannot claim to realize the entire semantic effect of this patch, but if it's the way to go then OK. Acked-by: Linus Walleij linus.wall...@linaro.org

[linux-sunxi] Re: [PATCH 1/7] gpiolib: gpiolib-of: Implement device tree gpio-names based lookup

2014-04-22 Thread Linus Walleij
on this alternative scheme. However if I shall apply this patch I want ACKs from the DT maintainers with them expressing that they want things to look like this going forward. Otherwise the set is stalled right here. Yours, Linus Walleij -- You received this message because you are subscribed

[linux-sunxi] Re: [PATCH v3 7/7] ARM: sunxi: update the default ARCH_NR_GPIO for sunxi arch

2014-04-23 Thread Linus Walleij
use only GPIO descriptors from day one. Also if new drivers only apply a an entirely new machine even. They should just use descriptors. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop

[linux-sunxi] Re: [PATCH 2/7] gpiolib: Support purely name based gpiod lookup in device trees

2014-04-23 Thread Linus Walleij
realized this a bit later, sorry for being a bit confused :-/ Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr

[linux-sunxi] Re: [PATCH] pinctrl: sunxi Ensure the correct pinctrl drivers are enabled

2014-05-08 Thread Linus Walleij
side ... I only have a mail stating you will send a pull request but not the pull request itself. Can you please resend the pull reques *and* include the fixup patch on that branch? Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi

[linux-sunxi] Re: [PATCH] pinctrl: sunxi: fix pin numbers passed to register offset helpers

2014-05-22 Thread Linus Walleij
subtracts .pin_base from the pin number passed to these functions, so the driver accesses the correct registers. Signed-off-by: Chen-Yu Tsai w...@csie.org Maxime, can I have your ACK on this patch, too? Yours, Linus Walleij -- You received this message because you are subscribed to the Google

[linux-sunxi] Re: [PATCH] pinctrl: sunxi: fix pin numbers passed to register offset helpers

2014-05-27 Thread Linus Walleij
subtracts .pin_base from the pin number passed to these functions, so the driver accesses the correct registers. Signed-off-by: Chen-Yu Tsai w...@csie.org Patch applied with Boris' and Maximes Reviewd/ACK tags. Yours, Linus Walleij -- You received this message because you are subscribed

[linux-sunxi] Re: [PATCH 01/11] pinctrl: sunxi: create irq/pin mapping during init

2014-05-27 Thread Linus Walleij
in -irq_array[] git me stuck. If any of you guys could be so nice to take a stab at this (compare to other commits converting drivers to use gpiolibs irqchip helpers) then I'd be very happy. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi

[linux-sunxi] Re: [PATCH 03/11] pinctrl: sunxi: Move setting of mux to irq type from unmask to set_type

2014-05-27 Thread Linus Walleij
, why cant we just call pinctrl_request_gpio() and pinctrl_free_gpio() here instead? Or maybe pinctrl_gpio_direction_input() and have that set up the muxing in the pinctrl driver side? It looks slightly convoluted. Yours, Linus Walleij -- You received this message because you are subscribed

Re: [linux-sunxi] Re: [PATCH 01/11] pinctrl: sunxi: create irq/pin mapping during init

2014-05-28 Thread Linus Walleij
On Tue, May 27, 2014 at 4:21 PM, Chen-Yu Tsai w...@csie.org wrote: On Tue, May 27, 2014 at 10:11 PM, Linus Walleij I tried to hack the sunxi driver to even use the gpiolib irqchip helpers but exactly this complex map thing in -irq_array[] git me stuck. If any of you guys could be so nice

[linux-sunxi] Re: [PATCH v2 1/5] pinctrl: sunxi: Fix sunxi_irq_cfg_reg not working for irqs = 8

2014-06-09 Thread Linus Walleij
first, then Hans' as you're the maintainer of this driver. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr

[linux-sunxi] Re: [PATCH 04/11] pinctrl: sunxi: Properly handle level triggered gpio interrupts

2014-06-11 Thread Linus Walleij
patch in the series. Anyway, this needs to be rebased and reposted anyway, I just merged some base patches from Maxime for external interrupts that will go in after the merge window, I need some help to figure out what and how to merge here. Yours, Linus Walleij -- You received this message

[linux-sunxi] Re: [PATCH v3 1/4] pinctrl: sunxi: Add IRQCHIP_SKIP_SET_WAKE flag for pinctrl irq chip

2014-07-04 Thread Linus Walleij
...@csie.org Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Patch applied. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop

[linux-sunxi] Re: [PATCH v3 2/4] pinctrl: sunxi: Move setting of mux to irq type from unmask to request_resources

2014-07-04 Thread Linus Walleij
it there. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Patch applied. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving

[linux-sunxi] Re: [PATCH v3 3/4] pinctrl: sunxi: Properly handle level triggered gpio interrupts

2014-07-04 Thread Linus Walleij
(which may involve sleeping waiting for i2c / spi / mmc transfers), before acknowledging the interrupt. Signed-off-by: Hans de Goede hdego...@redhat.com Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux

[linux-sunxi] Re: [PATCH v3 4/4] pinctrl: sunxi: Define enable / disable irq callbacks for level triggered irqs

2014-07-04 Thread Linus Walleij
an enable_irq callback, this will turn into an unmask, at which point the irq will trigger immediately because when it was originally acked the level was still high, so the ack was a nop. Signed-off-by: Hans de Goede hdego...@redhat.com Patch applied with Maxime's ACK. Yours, Linus Walleij

[linux-sunxi] Re: [PATCH] pinctrl: sunxi: Fix multi bank interrupt support in gpio_to_irq

2014-07-04 Thread Linus Walleij
-by: Chen-Yu Tsai w...@csie.org Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr

[linux-sunxi] Re: [PATCH v2 14/20] pinctrl: sunxi: Add A23 PIO controller support

2014-07-07 Thread Linus Walleij
-electrons.com Patch applied, thanks! Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options

[linux-sunxi] Re: [PATCH v2 15/20] pinctrl: sunxi: Add A23 R_PIO controller support

2014-07-07 Thread Linus Walleij
-electrons.com Patch applied. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit

[linux-sunxi] Re: [PATCH 0/2] pinctrl: sunxi: misc improvements for gpio

2014-07-22 Thread Linus Walleij
have names than numbers, then some artificial numbering is applied, whatever is helpful. I'm not directly familiar with the sunxi numbering system though... Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from

[linux-sunxi] Re: [PATCH 1/2] pinctrl: sunxi: use gpiolib API to mark a GPIO used as an IRQ

2014-07-28 Thread Linus Walleij
On Mon, Jul 14, 2014 at 7:24 PM, Chen-Yu Tsai w...@csie.org wrote: When an IRQ is started on a GPIO line, mark this GPIO as IRQ in the gpiolib so we can keep track of the usage centrally. Signed-off-by: Chen-Yu Tsai w...@csie.org Patch applied with Maxime's ACK. Yours, Linus Walleij

[linux-sunxi] Re: [PATCH 2/2] pinctrl: sunxi: number gpio ranges starting from 0

2014-07-28 Thread Linus Walleij
starting from an offset of 0, by subtracting the pin_base number from the pin number. This also makes the system-wide gpio number match the pin number. Tested on sun8i with sysfs exported gpios. Signed-off-by: Chen-Yu Tsai w...@csie.org Patch applied with Maxime's ACK. Yours, Linus Walleij -- You

[linux-sunxi] Re: [PATCH v2 1/4] pinctrl: sunxi: Add PN bank base pin

2014-10-30 Thread Linus Walleij
On Tue, Oct 28, 2014 at 10:41 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: The A80 R-PIO controller has one more bank that what we've seen so far, add the PN pin bank. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Patch applied. Yours, Linus Walleij -- You

[linux-sunxi] Re: [PATCH v2 2/4] pinctrl: sunxi: Add A80 pinctrl muxing options

2014-10-30 Thread Linus Walleij
Ripard maxime.rip...@free-electrons.com Patch applied. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com

[linux-sunxi] Re: [PATCH v2 3/4] ARM: sun9i: Enable the A80 pinctrl driver

2014-10-30 Thread Linus Walleij
Acked-by: Linus Walleij linus.wall...@linaro.org Please funnel this through ARM SoC and the Sunxi tree or wherever these things go... Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop

[linux-sunxi] Re: [PATCH 0/5] sun6i: Add A31s (pinctrl) support

2014-11-28 Thread Linus Walleij
symbols and DTS changes, no cross calls or header files that break compilation etc) and then they can be applied orthogonally. I just put the pinctrl patch in my tree and the rest in the platform tree. Yours, Linus Walleij -- You received this message because you are subscribed to the Google

[linux-sunxi] Re: [PATCH v2 01/13] pinctrl: sun6i: Add some missing functions

2015-01-13 Thread Linus Walleij
this was based on A31s Datasheet v1.40.pdf, but all other A31 related info puts them at the pins where we already have them, so leave this as is Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group

[linux-sunxi] Re: [PATCH v2 02/13] pinctrl: sun6i: Add A31s pinctrl support

2015-01-13 Thread Linus Walleij
-Add myself to the copyright header Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr

[linux-sunxi] Re: [PATCH] pinctrl: sun4i: GPIOs configured as irq must be set to input before reading

2015-03-18 Thread Linus Walleij
there. Signed-off-by: Hans de Goede hdego...@redhat.com Patch applied for fixes with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux

[linux-sunxi] Re: [PATCH 0/6] Introduce Allwinner A33 support

2015-05-12 Thread Linus Walleij
to the patches so I know he's verified them. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options

[linux-sunxi] Re: [PATCH v2 07/10] pinctrl: sunxi: Add H3 PIO controller support

2015-05-19 Thread Linus Walleij
on these patches before merging. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux-sunxi group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https

[linux-sunxi] Re: [PATCH v2 04/10] pinctrl: sunxi: Prepare for building SoC specific drivers as modules

2015-05-19 Thread Linus Walleij
devices use any pin-related things. pinctrl_unregister doesn't look like it cares about whether or not there's users left in the system. Both GPIO and pinctrl has this problem, Johan Hovold has been looking at fixing the GPIO side of things. Patches welcome. Yours, Linus Walleij -- You

[linux-sunxi] Re: [PATCH resend] pinctrl: sunxi: Add allwinner A33 PIO controller support

2015-06-04 Thread Linus Walleij
...@redhat.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Signed-off-by: Hans de Goede hdego...@redhat.com Patch applied. BTW: is your name Hans de Göde and you just gave up trying to get UTF-8 right, or is it really spelled like so? Yours, Linus Walleij -- You received this message

[linux-sunxi] Re: [PATCH v2] pinctrl: sun4i: add spdif to pin description.

2015-08-13 Thread Linus Walleij
On Wed, Aug 12, 2015 at 7:27 PM, codekip...@gmail.com wrote: From: Marcus Cooper codekip...@gmail.com Signed-off-by: Marcus Cooper codekip...@gmail.com Patch applied with Hans' ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups linux

[linux-sunxi] Re: [PATCH v2 1/2] pinctrl: sunxi: Fix irq_of_xlate for the r_pio pinctrl block

2015-10-23 Thread Linus Walleij
t.com> Patch applied with Chen-Yu's and Maxime's ACKs. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googleg

[linux-sunxi] Re: [PATCH v2 2/2] pinctrl: sunxi: Add irq pinmuxing to sun6i "r" pincontroller

2015-10-23 Thread Linus Walleij
Fix compile error introduced by last minute changes before sending out > the patch (note to self: always do a recompile in such a case) Patch applied with Chen-Yu's and Maxime's ACKs. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-su

[linux-sunxi] Re: [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support

2015-10-23 Thread Linus Walleij
s not apply to my "devel" branch on the pinctrl tree. https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel Please rebase it on the devel branch, add Maxime's ACKs and resend so I can apply it. Yours, Linus Walleij -- You received this message because you a

[linux-sunxi] Re: [PATCH 2/4] pinctrl: sunxi: add allwinner A83T PIO controller support

2015-10-02 Thread Linus Walleij
d-off-by: Vishnu Patekar <vishnupatekar0...@gmail.com> Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to

[linux-sunxi] Re: [PATCH v5 2/4] pinctrl: sunxi: Add H3 PIO controller support

2015-12-11 Thread Linus Walleij
Patch applied with Rob's & Maxime's ACKs. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegro

[linux-sunxi] Re: reason for Allwinner SoC specific pinctrl drivers?

2016-01-07 Thread Linus Walleij
and debug, and easy for new developers to get into precisely because so much knowledge is in the kernel and not in DT. A quick tour in /sys/kernel/debug/pinctrl/* should convince anyone that this is actually very helpful to get things right. Yours, Linus Walleij -- You received this message because you a

[linux-sunxi] Re: [PATCH v2 3/5] pinctrl: sunxi: Add H3 R_PIO controller support

2016-02-11 Thread Linus Walleij
ko.eu> Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.

[linux-sunxi] Re: [PATCH v4 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set

2016-02-11 Thread Linus Walleij
Signed-off-by: Krzysztof Adamski <k...@japko.eu> > Acked-by: Chen-Yu Tsai <w...@csie.org> > Acked-by: Maxime Ripard <maxime.rip...@free-electrons.com> OK applied this version that has Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscrib

Re: [linux-sunxi] Re: [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set

2016-02-11 Thread Linus Walleij
On Thu, Feb 11, 2016 at 2:20 PM, Krzysztof Adamski <k...@japko.eu> wrote: > On Thu, Feb 11, 2016 at 02:17:41PM +0100, Linus Walleij wrote: >> >> On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski <k...@japko.eu> wrote: >> >>> sunxi_pmx_set acc

[linux-sunxi] Re: [PATCH v2] pinctrl: sunxi: H3 requires irq_read_needs_mux

2016-02-11 Thread Linus Walleij
On Fri, Feb 5, 2016 at 2:51 PM, Chen-Yu Tsai <w...@csie.org> wrote: > On Fri, Feb 5, 2016 at 9:39 PM, Linus Walleij <linus.wall...@linaro.org> > wrote: >> On Wed, Feb 3, 2016 at 8:57 AM, Krzysztof Adamski <k...@japko.eu> wrote: >> >>> It s

[linux-sunxi] Re: [PATCH 01/14] pinctrl: sunxi: Add A83T R_PIO controller support

2016-02-11 Thread Linus Walleij
On Thu, Feb 11, 2016 at 1:36 PM, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Thu, Feb 11, 2016 at 12:59:47PM +0100, Linus Walleij wrote: >> On Sun, Jan 31, 2016 at 2:20 AM, Vishnu Patekar >> <vishnupatekar0...@gmail.com> wrote: >> >> > Th

[linux-sunxi] Re: [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set

2016-02-11 Thread Linus Walleij
by: Krzysztof Adamski <k...@japko.eu> Waiting for Maxime to review this. I guess this patch can be merged independently of the other patches? Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe fro

[linux-sunxi] Re: [PATCH v2] pinctrl: sunxi: H3 requires irq_read_needs_mux

2016-02-05 Thread Linus Walleij
put for > reads. > > Signed-off-by: Krzysztof Adamski <k...@japko.eu> 1. Waiting for Maxime's ACK on this patch. 2. Is this a regression that need to go in to fixes? Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linu

[linux-sunxi] Re: [PATCH v5] Fix sun7i pin assignment for IRQ's

2016-02-25 Thread Linus Walleij
n v5: > Added a more detailed description. Aha there is a v5. I took out the v4 and applied this instead. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiv

[linux-sunxi] Re: [PATCH v6] Fix sun7i pin assignment for IRQ's

2016-02-25 Thread Linus Walleij
he hardware itself. > > How did you test it? Using the sysfs API, or did you have any hardware > connected to it? I'm taking this patch out of my tree now following Maxime's comments. I'm a bit annoyed that it is iterating too quickly as well, I will wait and see for a while. Yours, Li

[linux-sunxi] Re: [PATCH] pinctrl: sunxi: Add missing H3 R_PIO binding documentation

2016-02-25 Thread Linus Walleij
; this issue. > > Signed-off-by: Krzysztof Adamski <k...@japko.eu> Patch applied with Chen-Yu's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emai

[linux-sunxi] Re: [PATCH v5 3/4] ARM: dts: sun8i-h3: Add R_PIO controller node to the dtsi

2016-02-25 Thread Linus Walleij
On Mon, Feb 22, 2016 at 2:03 PM, Krzysztof Adamski <k...@japko.eu> wrote: > Add the corresponding device node for R_PIO on H3 to the dtsi. Support > for the controller was added in earlier commit. > > Signed-off-by: Krzysztof Adamski <k...@japko.eu> Acked-by: L

[linux-sunxi] Re: [PATCH v4] Fix sun7i pin assignment for IRQ's

2016-02-25 Thread Linus Walleij
On Mon, Feb 22, 2016 at 12:17 AM, Henry Paulissen <draakje...@gmail.com> wrote: > After testing IRQ pins we found some bugs in the pinctrl declaration. > > Signed-off-by: Henry Paulissen <he...@nitronetworks.nl> This v4 patch applied with Chen-Yu's ACK. Yours, Linus Wall

[linux-sunxi] Re: [PATCH 01/14] pinctrl: sunxi: Add A83T R_PIO controller support

2016-02-25 Thread Linus Walleij
On Thu, Feb 25, 2016 at 1:56 AM, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > Hi Linus, > On Tue, Feb 16, 2016 at 12:23:37AM +0100, Linus Walleij wrote: >> On Thu, Feb 11, 2016 at 4:12 PM, Maxime Ripard >> <maxime.rip...@free-electrons.com> wrote: >

Re: [linux-sunxi] Re: [PATCH v2 3/5] pinctrl: sunxi: Add H3 R_PIO controller support

2016-02-15 Thread Linus Walleij
On Mon, Feb 15, 2016 at 9:08 AM, Krzysztof Adamski <k...@japko.eu> wrote: > On Thu, Feb 11, 2016 at 02:21:15PM +0100, Linus Walleij wrote: >> >> On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski <k...@japko.eu> wrote: >> >>> H3 has additional PIO con

[linux-sunxi] Re: [PATCH] pinctrl: sunxi: set pin function as input on export

2016-02-15 Thread Linus Walleij
xi problem. So maybe it is wrong to set pins to either input or output when exporting them, I suspect they should be exported as is. Also: the sysfs ABI is deprecated. I suggest you invest your time in working on the new chardev ABI. Yours, Linus Walleij -- You received this message because you a

[linux-sunxi] Re: [PATCH 01/14] pinctrl: sunxi: Add A83T R_PIO controller support

2016-02-15 Thread Linus Walleij
On Thu, Feb 11, 2016 at 4:12 PM, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Thu, Feb 11, 2016 at 02:47:57PM +0100, Linus Walleij wrote: >> Can you guys supply a MAINTAINERS entry for the sunxi >> stuff? > > We have one, and Chen-Yu is liste

[linux-sunxi] Re: [PATCH] pinctrl: sunxi: set pin function as input on export

2016-02-16 Thread Linus Walleij
dn't be > the only driver to do this. This does also show that indeed the problem is > not sunxi specific, though. Drivers can do pretty much what they want, they are supposed to handle the hardware as well as they can. They might be doing this for a reason or not, better ask the driver writers a

[linux-sunxi] Re: [PATCH 01/14] pinctrl: sunxi: Add A83T R_PIO controller support

2016-02-11 Thread Linus Walleij
t; Maxime, can you look at this patch? Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.

[linux-sunxi] Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support

2016-03-08 Thread Linus Walleij
sun8i_a83t_r_pinctrl_driver = { > + .probe = sun8i_a83t_r_pinctrl_probe, > + .driver = { > + .name = "sun8i-a83t-r-pinctrl", > + .of_match_table = sun8i_a83t_r_pinctrl_match, > + }, > +}; > +module_platform_driver(sun8

[linux-sunxi] Re: [PATCH v4] drivers: pinctrl: add driver for Allwinner A64 SoC

2016-03-11 Thread Linus Walleij
<maxime.rip...@free-electrons.com> Patch applied. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.

[linux-sunxi] Re: [PATCH 3/4] ARM: dt: axp209: Add AXP209 GPIO driver

2016-03-16 Thread Linus Walleij
On Wed, Mar 9, 2016 at 11:50 AM, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > Add the AXP209 GPIO node to our AXP209 DTSI so that boards can use it. > > Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> Acked-by: Linus Walleij <linus.wall...@l

Re: [linux-sunxi] Re: [PATCH 0/4] Add AXP209 GPIO driver

2016-03-16 Thread Linus Walleij
fferent functions, then I think pin control may be a bit too thick overhead. (Not sure where the limit is though.) Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receivin

Re: [linux-sunxi] [PATCH 1/4] gpio: Add AXP209 GPIO driver

2016-03-16 Thread Linus Walleij
be so noisy? The GPIO maintainer likes boasty drivers. I don't understand people who are dmesg minimalists, I want to have positive indications that things work in there, not just bad news about what went wrong. Yours, Linus Walleij -- You received this message because you are subscribed to the G

[linux-sunxi] Re: [PATCH 1/4] gpio: Add AXP209 GPIO driver

2016-03-16 Thread Linus Walleij
> + gpio->chip.owner= THIS_MODULE; > + gpio->chip.get = axp20x_gpio_get; > + gpio->chip.set = axp20x_gpio_set; > + gpio->chip.direction_input = axp20x_gpio_input; > + gpio->chip.directi

[linux-sunxi] Re: [PATCH] pinctrl: sunxi: Fix A33 external interrupts not working

2016-03-19 Thread Linus Walleij
nterrupts not working on the A33 (tested with > an i2c touchscreen controller which uses an external interrupt). > > Signed-off-by: Hans de Goede <hdego...@redhat.com> Patch applied, tagged for stable. Yours, Linus Walleij -- You received this message because you are subscribed to t

[linux-sunxi] Re: [PATCH v4 01/13] pinctrl: sunxi: Add A83T R_PIO controller

2016-03-22 Thread Linus Walleij
On Thu, Mar 17, 2016 at 4:34 PM, Vishnu Patekar <vishnupatekar0...@gmail.com> wrote: > On Thu, Mar 17, 2016 at 10:51 PM, Linus Walleij >> I think I already merged this? > > AFAIK, this one is not yet merged. At least, you did not say it's merged. :) Sorry, confused i

[linux-sunxi] Re: [PATCH v4 01/13] pinctrl: sunxi: Add A83T R_PIO controller

2016-03-22 Thread Linus Walleij
On Tue, Mar 22, 2016 at 2:12 PM, Linus Walleij <linus.wall...@linaro.org> wrote: > On Thu, Mar 17, 2016 at 4:34 PM, Vishnu Patekar > <vishnupatekar0...@gmail.com> wrote: >> On Thu, Mar 17, 2016 at 10:51 PM, Linus Walleij > >>> I think I already merged this? >

[linux-sunxi] Re: [PATCH v4 01/13] pinctrl: sunxi: Add A83T R_PIO controller

2016-03-20 Thread Linus Walleij
> Acked-by: Chen-Yu Tsai <w...@csie.org> > Acked-by: Rob Herring <r...@kernel.org> I think I already merged this? Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this gr

[linux-sunxi] Re: [PATCH 2/2] pinctrl: sunxi: Change mux setting on PI irq pins

2016-03-08 Thread Linus Walleij
Andre Przywara <andre.przyw...@arm.com> > Signed-off-by: Henry Paulissen <he...@nitronetworks.nl> Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from

[linux-sunxi] Re: [PATCH 1/2] pinctrl: sunxi: Remove non existing irq's

2016-03-08 Thread Linus Walleij
/class/gpio/gpio###/edge > > Check /proc/interrupts if a irq was attached and if irq's where > received. > > Signed-off-by: Henry Paulissen <he...@nitronetworks.nl> Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscri

[linux-sunxi] Re: [PATCH v5] Fix sun7i pin assignment for IRQ's

2016-03-06 Thread Linus Walleij
On Thu, Feb 25, 2016 at 4:37 PM, Henry Paulissen <he...@nitronetworks.nl> wrote: > Op donderdag 25 februari 2016 10:36:38 UTC+1 schreef Linus Walleij: >> >> Aha there is a v5. I took out the v4 and applied this >> instead. > > There is also a v6. Sigh this

[linux-sunxi] Re: [PATCH v3 04/10] drivers: pinctrl: add driver for Allwinner A64 SoC

2016-03-06 Thread Linus Walleij
not apply do the pinctrl devel branch, so please rebase it. > .../bindings/pinctrl/allwinner,sunxi-pinctrl.txt | 1 + > arch/arm64/Kconfig.platforms | 1 + Remove this from the patch, it can go in through the ASoC or ARM64 tree, just a symbol dependence is fine t

[linux-sunxi] Re: [PATCH] pinctrl: sun6i: add SPDIF to pin description.

2016-08-11 Thread Linus Walleij
On Sat, Jul 30, 2016 at 4:20 PM, <codekip...@gmail.com> wrote: > From: Marcus Cooper <codekip...@gmail.com> > > Add the SPDIF mux functionality to the pinctrl for the Allwinner A31 > SoC. > > Signed-off-by: Marcus Cooper <codekip...@gmail.com> Patch appli

[linux-sunxi] Re: [PATCH] pinctrl: sunxi: fix nand0 function name for sun8i

2016-07-05 Thread Linus Walleij
d0", for the consistency. > > Signed-off-by: Icenowy Zheng <icen...@aosc.xyz> Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and st

[linux-sunxi] Re: [PATCH v2 1/9] drivers: pinctrl: add driver for Allwinner H5 SoC

2017-01-30 Thread Linus Walleij
.g. three more groups of TS > pins, and one more groups of SIM pins) than H3. > > Signed-off-by: Icenowy Zheng <icen...@aosc.xyz> > --- > Changes in v2: > - Fixed interrupt banks. (There's one more GPIO banks (PF) that can do > interrupt handling on H5) Patch applied w

[linux-sunxi] Re: [PATCH v3 01/10] drivers: pinctrl: add driver for Allwinner H5 SoC

2017-01-30 Thread Linus Walleij
interrupt banks. (There's one more GPIO banks (PF) that can do > interrupt handling on H5) I already applied V2 with Maximes' ACK and all. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from th

Re: [linux-sunxi] [PATCH 1/2] drivers: pinctrl: add driver for Allwinner H5 SoC

2017-01-26 Thread Linus Walleij
ovedly wrong, just use git log and you will see how much of such bugs we fix, even in drivers and DTSes produced by the vendors themselves. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from t

[linux-sunxi] Re: [RFC PATCH 0/9] Add support for Allwinner R40 SoC

2017-02-23 Thread Linus Walleij
ed guess and > try and error. Out of curiosity: does the board support use the mainline drivers as starting point? I.e. does it build on top of the community work done by Maxime & others? Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linu

[linux-sunxi] Re: [PATCH 3/8] pinctrl: sunxi: Add A64 R_PIO controller support

2017-02-13 Thread Linus Walleij
e happy to merge patches 1,2 & 3 to the pinctrl tree but I need a maintainer ACK on these three patches first. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving e

Re: [linux-sunxi] [PATCH 1/2] drivers: pinctrl: add driver for Allwinner H5 SoC

2017-01-19 Thread Linus Walleij
tuation where none of the above scenarios apply. What we/you need to ask: what is most helpful for the Allwinner community? What makes the barrier low for new contributions, and makes it easiest to cooperate? I try to live by this motto from IETF: "rough consensus and running code" Pleas

[linux-sunxi] Re: [PATCH 0/3] pinctrl: sunxi: Support generic pinconf functions

2016-10-20 Thread Linus Walleij
hardware to get > the current config, and b) not using the right arguments for the bias > parameters. Looks OK to me, Maxime are you OK with me applying this, or are we waiting for a new iteration of this patch set? I have started to apply Maxime's generic binding rework, will it clash with

[linux-sunxi] Re: [PATCH v3 2/3] pinctrl: sunxi: Add support for fetching pinconf settings from hardware

2016-11-15 Thread Linus Walleij
f them. Since > we can now read back settings directly from the hardware, it is no > longer required. > > Signed-off-by: Chen-Yu Tsai <w...@csie.org> Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Goo

[linux-sunxi] Re: [PATCH v3 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN,UP} argument

2016-11-15 Thread Linus Walleij
gt; > Since Allwinner hardware uses a weak pull resistor internally, > the argument should be 1. > > Signed-off-by: Chen-Yu Tsai <w...@csie.org> > Acked-by: Maxime Ripard <maxime.rip...@free-electrons.com> Applied this v3 rather than the v2. Yours, Linus Walleij -- You

[linux-sunxi] Re: [PATCH] ARM: dts: sunxi: Explicitly enable pull-ups for MMC pins

2016-11-18 Thread Linus Walleij
(Mostly no bias, push-pull I think.) I highly suspect a whole bunch of SoC drivers are not getting this business right today. Not even in out-of-tree vendor kernels. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" g

[linux-sunxi] Re: [PATCH] pinctrl: sunxi: Free configs in pinctrl_map only if it is a config map

2016-11-15 Thread Linus Walleij
gt; Also slightly expand the comment explaining this. > > Fixes: f233dbca6227 ("pinctrl: sunxi: Rework the pin config building code") > Signed-off-by: Chen-Yu Tsai <w...@csie.org> Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because

[linux-sunxi] Re: [PATCH v2 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN,UP} argument

2016-11-15 Thread Linus Walleij
gt; > Since Allwinner hardware uses a weak pull resistor internally, > the argument should be 1. > > Signed-off-by: Chen-Yu Tsai <w...@csie.org> Patch applied with Maxime's ACK. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups &

  1   2   >