[linux-sunxi] Re: [PATCH v2 01/16] reset: add non CONFIG_RESET_CONTROLLER routines

2014-01-10 Thread Philipp Zabel
Hi, [Added Ivan, Stephen and Barry to Cc:] Am Freitag, den 10.01.2014, 15:00 +0800 schrieb Chen-Yu Tsai: Some drivers are shared between platforms that may or may not have RESET_CONTROLLER selected for them. I expected that drivers compiled for platforms without reset controllers but use the

[linux-sunxi] Re: [PATCH v4 1/5] clk: sunxi: Add support for USB clock-register reset bits

2014-02-07 Thread Philipp Zabel
-by: Hans de Goede hdego...@redhat.com Acked-by: Philipp Zabel p.za...@pengutronix.de --- drivers/clk/sunxi/clk-sunxi.c | 71 +++ 1 file changed, 71 insertions(+) diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index 64bda21

[linux-sunxi] Re: [PATCH] reset: Add of_reset_control_get to reset.h

2014-04-14 Thread Philipp Zabel
Am Sonntag, den 13.04.2014, 14:09 +0200 schrieb Hans de Goede: of_reset_control_get is not declared static in drivers/reset/core.c, which is correct as we want to use it elsewhere too. But it does not have a protype declared anywhere under include/linux. Add a prototype / stub for it to

[linux-sunxi] Re: [PATCH v4 2/7] reset: sunxi: allow MFD subdevices probe

2014-05-14 Thread Philipp Zabel
are registered from an MFD device that define resources from mfd_cell definition. Moreover, we can make of devm functions when we're in the probe context. Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Acked-by: Philipp

[linux-sunxi] Re: [PATCH v4 1/7] reset: sunxi: document sunxi's reset controllers bindings

2014-05-14 Thread Philipp Zabel
Am Mittwoch, den 14.05.2014, 14:38 +0200 schrieb Boris BREZILLON: Add DT bindings documentation for sunxi's reset controllers. Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Acked-by: Philipp Zabel p.za

[linux-sunxi] Re: [PATCH v4 4/6] reset: sunxi: Add Allwinner H3 bus resets

2015-10-28 Thread Philipp Zabel
Hi Jens, Am Dienstag, den 27.10.2015, 17:50 +0100 schrieb Jens Kuske: [...] > --- a/drivers/reset/reset-sunxi.c > +++ b/drivers/reset/reset-sunxi.c > @@ -75,7 +75,9 @@ static struct reset_control_ops sunxi_reset_ops = { > .deassert = sunxi_reset_deassert, > }; > > -static int

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

2015-11-16 Thread Philipp Zabel
Am Montag, den 16.11.2015, 17:49 +0100 schrieb Hans de Goede: > Hi, > > On 16-11-15 17:04, Chen-Yu Tsai wrote: > > On Mon, Nov 16, 2015 at 11:42 PM, Alan Stern > > wrote: > >> On Sun, 15 Nov 2015, Hans de Goede wrote: > >> > >>> From: Reinder de Haan

[linux-sunxi] Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2015-12-11 Thread Philipp Zabel
Hi Hans, thanks for moving this forward. Am Freitag, den 11.12.2015, 16:41 +0100 schrieb Hans de Goede: > Add reset_control_deassert_shared / reset_control_assert_shared > functions which are intended for use by drivers for hw blocks which > (may) share a reset line with another driver / hw

[linux-sunxi] Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2015-12-14 Thread Philipp Zabel
Hi Hans, Am Freitag, den 11.12.2015, 19:21 +0100 schrieb Hans de Goede: [...] > >> @@ -119,13 +134,55 @@ EXPORT_SYMBOL_GPL(reset_control_assert); > >> int reset_control_deassert(struct reset_control *rstc) > >> { > > > > Maybe WARN_ON(rstc->line->refcnt > 1) ? > > I assume you mean

[linux-sunxi] Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2015-12-16 Thread Philipp Zabel
Hi Maxime, Am Mittwoch, den 16.12.2015, 11:29 +0100 schrieb Maxime Ripard: > On Mon, Dec 14, 2015 at 10:50:55AM +0100, Philipp Zabel wrote: > > Am Montag, den 14.12.2015, 10:36 +0100 schrieb Maxime Ripard: > > > Hi, > > > > > > On Fri, Dec 11, 2015 at 0

[linux-sunxi] Re: [PATCH v2 2/3] ehci-platform: Add support for controllers with multiple reset lines

2015-12-14 Thread Philipp Zabel
> The 2 controllers are supposed to be 100% independent but on the H3 > Allwinner has done something (not documented) which requires one to > deassert reset on both before you can talk to either one. ... so thank you for the explanation. Acked-by: Philipp Zabel <p.za...@pengutronix

[linux-sunxi] Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2015-12-14 Thread Philipp Zabel
Am Montag, den 14.12.2015, 10:36 +0100 schrieb Maxime Ripard: > Hi, > > On Fri, Dec 11, 2015 at 04:41:58PM +0100, Hans de Goede wrote: > > diff --git a/include/linux/reset.h b/include/linux/reset.h > > index c4c097d..1cca8ce 100644 > > --- a/include/linux/reset.h > > +++ b/include/linux/reset.h >

Re: [linux-sunxi] Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2016-01-04 Thread Philipp Zabel
Am Samstag, den 19.12.2015, 11:55 +0100 schrieb Hans de Goede: > On 18-12-15 12:08, Maxime Ripard wrote: [...] > > I guess we could also have something like this: > > > >* The driver gets the reference to the reset line using > > reset_control_get or its shared variant. > > > > - If

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

2015-11-18 Thread Philipp Zabel
Am Mittwoch, den 18.11.2015, 21:20 +1100 schrieb Julian Calaby: > Hi All, > > On Wed, Nov 18, 2015 at 9:18 PM, Maxime Ripard > <maxime.rip...@free-electrons.com> wrote: > > On Wed, Nov 18, 2015 at 10:46:52AM +0100, Philipp Zabel wrote: > >> Hi Hans, > >

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

2015-11-18 Thread Philipp Zabel
Hi Julian, Am Mittwoch, den 18.11.2015, 23:32 +1100 schrieb Julian Calaby: [...] > Assuming board designers are sufficiently ... stupid, won't most > drivers eventually need to use the _shared variants? Wouldn't it be > (horrifically more complicated and) better to just build this into the >

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

2015-11-18 Thread Philipp Zabel
Hi Hans, Am Mittwoch, den 18.11.2015, 11:38 +0100 schrieb Hans de Goede: > Hi, > > On 18-11-15 10:46, Philipp Zabel wrote: > > Hi Hans, > > > > Am Montag, den 16.11.2015, 18:13 +0100 schrieb Hans de Goede: > >> On 16-11-15 18:01, Philipp Zabel wrote: &g

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

2015-11-18 Thread Philipp Zabel
Hi Hans, Am Montag, den 16.11.2015, 18:13 +0100 schrieb Hans de Goede: > On 16-11-15 18:01, Philipp Zabel wrote: > > If there are two devices sharing the same reset line that is initially > > held asserted, do the two drivers somehow have to synchronize before > > releasi

[linux-sunxi] Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-20 Thread Philipp Zabel
Am Sonntag, den 19.06.2016, 14:06 +0200 schrieb Boris Brezillon: > +Philipp > > On Sun, 19 Jun 2016 19:37:39 +0800 > Icenowy Zheng wrote: > > > The NAND controller on some sun8i chips needs its reset line to be > > deasserted > > before they can enter working state. This

[linux-sunxi] Re: [PATCH v2 01/26] reset: Move DT cell size check to the core

2016-01-15 Thread Philipp Zabel
Hi Maxime, Am Donnerstag, den 14.01.2016, 16:24 +0100 schrieb Maxime Ripard: > The core currently doesn't check that the DT cell size matches what the > driver declares, which means that every xlate function needs to duplicate > that check. > > Make sure that of_reset_control_get checks for this

[linux-sunxi] Re: [PATCH v2 02/26] reset: Make reset_control_ops const

2016-01-15 Thread Philipp Zabel
Am Donnerstag, den 14.01.2016, 16:24 +0100 schrieb Maxime Ripard: > The ops pointer is holding a pointer to a structure that is usually not > modified. Make it const. > > Signed-off-by: Maxime Ripard > --- > include/linux/reset-controller.h | 2 +- > 1 file

[linux-sunxi] Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata

2018-02-19 Thread Philipp Zabel
t; Cc: he...@sntech.de > Acked-by: Neil Armstrong <narmstr...@baylibre.com> > Signed-off-by: Jernej Skrabec <jernej.skra...@siol.net> For i.MX: Tested-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp -- Yo

[linux-sunxi] Re: [PATCH v8 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-02-27 Thread Philipp Zabel
On Tue, 2018-02-27 at 10:07 +0800, Yong Deng wrote: > Add binding documentation for Allwinner V3s CSI. > > Acked-by: Maxime Ripard > Acked-by: Sakari Ailus > Reviewed-by: Rob Herring > Signed-off-by: Yong Deng

[linux-sunxi] Re: [PATCH v2 08/10] dt-bindings: media: Document bindings for the Sunxi-Cedrus VPU driver

2018-04-19 Thread Philipp Zabel
Hi Paul, On Thu, 2018-04-19 at 17:45 +0200, Paul Kocialkowski wrote: > This adds a device-tree binding document that specifies the properties > used by the Sunxi-Cedurs VPU driver, as well as examples. > > Signed-off-by: Paul Kocialkowski > --- >

[linux-sunxi] Re: [PATCH 2/6] pwm: sun4i: Add a quirk for reset line

2019-07-29 Thread Philipp Zabel
Hi, On Mon, 2019-07-29 at 09:12 +0200, Uwe Kleine-König wrote: > Hello, > > On Mon, Jul 29, 2019 at 02:43:23PM +0800, Chen-Yu Tsai wrote: > > On Mon, Jul 29, 2019 at 2:36 PM Uwe Kleine-König > > wrote: > > > On Fri, Jul 26, 2019 at 08:40:41PM +0200, Jernej Skrabec wrote: > > > > @@ -371,6

[linux-sunxi] Re: [PATCH v3 1/4] crypto: Add Allwinner sun8i-ss cryptographic offloader

2019-10-28 Thread Philipp Zabel
Hi Corentin, On Fri, 2019-10-25 at 20:51 +0200, Corentin Labbe wrote: > The Security System is an hardware cryptographic offloader present > on Allwinner SoCs A80 and A83T. > It is different from the previous sun4i-ss. > > This driver supports AES cipher in CBC and ECB mode. > > Acked-by:

[linux-sunxi] Re: [PATCH v6 2/6] mailbox: sun6i-msgbox: Add a new mailbox driver

2020-01-13 Thread Philipp Zabel
t; + * > + * Therefore, we do *not* assert the reset line if probing fails or > + * when removing the device. > + */ > + ret = reset_control_deassert(reset); > + if (ret) { > + dev_err(dev, "Failed to deassert reset: %d\n", ret); &g

[linux-sunxi] Re: [PATCH v5 3/8] mailbox: sun6i-msgbox: Add a new mailbox driver

2020-01-02 Thread Philipp Zabel
On Sat, 2019-12-14 at 22:24 -0600, Samuel Holland wrote: > Allwinner sun6i, sun8i, sun9i, and sun50i SoCs contain a hardware > message box used for communication between the ARM CPUs and the ARISC > management coprocessor. This mailbox contains 8 unidirectional > 4-message FIFOs. > > Add a driver

[linux-sunxi] Re: [PATCH v7 13/19] phy: sun4i-usb: Allow reset line to be shared

2021-06-15 Thread Philipp Zabel
lude this reset line in the HCIs' resets > property, which requires this line to be shareable. > > Change the call to allocate the reset line to mark it as shared, to > enable the other ports on those SoCs. > > Signed-off-by: Andre Przywara Reviewed-by: Philipp Zabel