Re: [linux-sunxi] [PATCH 3.4] Revert "usb:sunxi:Fix "device not recognized" problem during android boot (3.4)"

2014-02-17 Thread Michal Suchanek
On 17 February 2014 21:52, Jari Helaakoski  wrote:
>
>
>
> 2014-02-17 22:43 GMT+02:00 Michal Suchanek :
>
>> On 16 February 2014 18:33, Jari Helaakoski  wrote:
>> >
>> >
>> >
>> > 2014-02-16 18:25 GMT+02:00 Michal Suchanek :
>> >
>> >> On 10 February 2014 18:25, Jari Helaakoski  wrote:
>> >> >>
>> >> >>
>> >> >> Is there even an android tree that builds with 3.4?
>> >> >>
>> >> > I have been using this: https://github.com/allwinner-dev-team
>> >> >
>> >> > 4months ago I got ICS working with 3.4 kernel and a13_mid board. I
>> >> > don't
>> >> > know current status. Does it even build.
>> >> >
>> >>
>> >> It seems to default to 3.0 kernel.
>> >>
>> >> How do you even build that thing?
>> >
>> > I used BSP.
>> >
>> > (https://github.com/linux-sunxi/sunxi-bsp/blob/master/scripts/mk_android.sh)
>> > It seems to point http://turl.linux-sunxi.org/local_manifest_jb.xml
>> >
>> > I just changed to kernel module to different revision(manually inside
>> > tree).
>> >
>>
>> Reportedly also http://linux-sunxi.org/Building_CyanogenMod_for_ZaTab
>>
>> However, I cannot reproduce the issue on sun4i and I don't have a
>> sun5i device working enough to test android images on it for now.
>
>
> Then I would ack this patch. Thanks. If there is still problem with sun5i it
> needs different solution.

To be clear I don't observe the problem on sun4i Linux with the revert
applied or not.

On sun5i I need the revert for Linux but cannot really test android.

Thanks

Michal

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [linux-sunxi] [PATCH 3.4] Revert "usb:sunxi:Fix "device not recognized" problem during android boot (3.4)"

2014-02-17 Thread Jari Helaakoski
2014-02-17 22:43 GMT+02:00 Michal Suchanek :

> On 16 February 2014 18:33, Jari Helaakoski  wrote:
> >
> >
> >
> > 2014-02-16 18:25 GMT+02:00 Michal Suchanek :
> >
> >> On 10 February 2014 18:25, Jari Helaakoski  wrote:
> >> >>
> >> >>
> >> >> Is there even an android tree that builds with 3.4?
> >> >>
> >> > I have been using this: https://github.com/allwinner-dev-team
> >> >
> >> > 4months ago I got ICS working with 3.4 kernel and a13_mid board. I
> don't
> >> > know current status. Does it even build.
> >> >
> >>
> >> It seems to default to 3.0 kernel.
> >>
> >> How do you even build that thing?
> >
> > I used BSP.
> > (
> https://github.com/linux-sunxi/sunxi-bsp/blob/master/scripts/mk_android.sh
> )
> > It seems to point http://turl.linux-sunxi.org/local_manifest_jb.xml
> >
> > I just changed to kernel module to different revision(manually inside
> tree).
> >
>
> Reportedly also http://linux-sunxi.org/Building_CyanogenMod_for_ZaTab
>
> However, I cannot reproduce the issue on sun4i and I don't have a
> sun5i device working enough to test android images on it for now.
>

Then I would ack this patch. Thanks. If there is still problem with sun5i
it needs different solution.

-Jari

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [linux-sunxi] [PATCH 3.4] Revert "usb:sunxi:Fix "device not recognized" problem during android boot (3.4)"

2014-02-17 Thread Michal Suchanek
On 16 February 2014 18:33, Jari Helaakoski  wrote:
>
>
>
> 2014-02-16 18:25 GMT+02:00 Michal Suchanek :
>
>> On 10 February 2014 18:25, Jari Helaakoski  wrote:
>> >>
>> >>
>> >> Is there even an android tree that builds with 3.4?
>> >>
>> > I have been using this: https://github.com/allwinner-dev-team
>> >
>> > 4months ago I got ICS working with 3.4 kernel and a13_mid board. I don't
>> > know current status. Does it even build.
>> >
>>
>> It seems to default to 3.0 kernel.
>>
>> How do you even build that thing?
>
> I used BSP.
> (https://github.com/linux-sunxi/sunxi-bsp/blob/master/scripts/mk_android.sh)
> It seems to point http://turl.linux-sunxi.org/local_manifest_jb.xml
>
> I just changed to kernel module to different revision(manually inside tree).
>

Reportedly also http://linux-sunxi.org/Building_CyanogenMod_for_ZaTab

However, I cannot reproduce the issue on sun4i and I don't have a
sun5i device working enough to test android images on it for now.

Thanks

Michal

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [linux-sunxi] [PATCH 3.4] Revert "usb:sunxi:Fix "device not recognized" problem during android boot (3.4)"

2014-02-16 Thread Jari Helaakoski
2014-02-16 18:25 GMT+02:00 Michal Suchanek :

> On 10 February 2014 18:25, Jari Helaakoski  wrote:
> >>
> >>
> >> Is there even an android tree that builds with 3.4?
> >>
> > I have been using this: https://github.com/allwinner-dev-team
> >
> > 4months ago I got ICS working with 3.4 kernel and a13_mid board. I don't
> > know current status. Does it even build.
> >
>
> It seems to default to 3.0 kernel.
>
> How do you even build that thing?
>
I used BSP. (
https://github.com/linux-sunxi/sunxi-bsp/blob/master/scripts/mk_android.sh)
It seems to point http://turl.linux-sunxi.org/local_manifest_jb.xml

I just changed to kernel module to different revision(manually inside tree).

-Jari

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [linux-sunxi] [PATCH 3.4] Revert "usb:sunxi:Fix "device not recognized" problem during android boot (3.4)"

2014-02-16 Thread Michal Suchanek
On 10 February 2014 18:25, Jari Helaakoski  wrote:
>>
>>
>> Is there even an android tree that builds with 3.4?
>>
> I have been using this: https://github.com/allwinner-dev-team
>
> 4months ago I got ICS working with 3.4 kernel and a13_mid board. I don't
> know current status. Does it even build.
>

It seems to default to 3.0 kernel.

How do you even build that thing?

There is no manifiest.

Thanks

Michal

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [linux-sunxi] [PATCH 3.4] Revert "usb:sunxi:Fix "device not recognized" problem during android boot (3.4)"

2014-02-10 Thread Jari Helaakoski
>
>
>
> Is there even an android tree that builds with 3.4?
>
> I have been using this: https://github.com/allwinner-dev-team

4months ago I got ICS working with 3.4 kernel and a13_mid board. I don't
know current status. Does it even build.

I built android long ago and I can't tell if it had this patch or not
> but I had no problems with adb. I had problems running anything other
> than the boot animation, however. If there is no working android tree
> for 3.4 kernel there is no point having android stuff in our kernel
> tree.
>
> Thanks
>
> Michal
>

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [linux-sunxi] [PATCH 3.4] Revert "usb:sunxi:Fix "device not recognized" problem during android boot (3.4)"

2014-02-10 Thread Michal Suchanek
On 9 February 2014 22:07, Jari Helaakoski  wrote:
>
>
>
> 2014-02-09 Michal Suchanek :
>
>> ping?
>>
>> On 27 January 2014 21:10, Michal Suchanek  wrote:
>> > From c35e54a6500e3b99fa90544d123df306d11f Mon Sep 17 00:00:00 2001
>> >
>> > This reverts commit 44a6e1bfed98cd636b55a1191426ce2c373e15b2.
>> >
>> > Before this commit USB gadgets work if you boot with cable connected.
>> >
>> > eg. download kernel over FEL, mount NFS root over g_ether.
>> >
>> > After this commit gadgets only come up if cable is unplugged.
>> >
>> > eg. boot, load g_ether (nothing) unplug and replug cable - USB gadget is
>> > seen by the host on the other end of the cable. Only tested the FEL boot
>> > because I have no kernel installed on device.
>
>
> Without 44a6e1bfed98cd636b55a1191426ce2c373e15b2 you have to reconnect cable
> to get adb working. Revert causes regression on android side.
>
> Patch was originally cherry-picked from 3.0 side. If I remember correctly
> every gadget worked ok with 3.0.. Haven't checked this on 3.4 side in long
> time. Things might have been changed, so I think someone has to check this
> with android too.
>

Is there even an android tree that builds with 3.4?

I built android long ago and I can't tell if it had this patch or not
but I had no problems with adb. I had problems running anything other
than the boot animation, however. If there is no working android tree
for 3.4 kernel there is no point having android stuff in our kernel
tree.

Thanks

Michal

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [linux-sunxi] [PATCH 3.4] Revert "usb:sunxi:Fix "device not recognized" problem during android boot (3.4)"

2014-02-09 Thread Jari Helaakoski
2014-02-09 Michal Suchanek :

> ping?
>
> On 27 January 2014 21:10, Michal Suchanek  wrote:
> > From c35e54a6500e3b99fa90544d123df306d11f Mon Sep 17 00:00:00 2001
> >
> > This reverts commit 44a6e1bfed98cd636b55a1191426ce2c373e15b2.
> >
> > Before this commit USB gadgets work if you boot with cable connected.
> >
> > eg. download kernel over FEL, mount NFS root over g_ether.
> >
> > After this commit gadgets only come up if cable is unplugged.
> >
> > eg. boot, load g_ether (nothing) unplug and replug cable - USB gadget is
> > seen by the host on the other end of the cable. Only tested the FEL boot
> > because I have no kernel installed on device.
>

Without 44a6e1bfed98cd636b55a1191426ce2c373e15b2 you have to reconnect
cable to get adb working. Revert causes regression on android side.

Patch was originally cherry-picked from 3.0 side. If I remember correctly
every gadget worked ok with 3.0.. Haven't checked this on 3.4 side in long
time. Things might have been changed, so I think someone has to check this
with android too.

-Jari

>

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [linux-sunxi] [PATCH 3.4] Revert "usb:sunxi:Fix "device not recognized" problem during android boot (3.4)"

2014-02-09 Thread Michal Suchanek
ping?

On 27 January 2014 21:10, Michal Suchanek  wrote:
> From c35e54a6500e3b99fa90544d123df306d11f Mon Sep 17 00:00:00 2001
>
> This reverts commit 44a6e1bfed98cd636b55a1191426ce2c373e15b2.
>
> Before this commit USB gadgets work if you boot with cable connected.
>
> eg. download kernel over FEL, mount NFS root over g_ether.
>
> After this commit gadgets only come up if cable is unplugged.
>
> eg. boot, load g_ether (nothing) unplug and replug cable - USB gadget is
> seen by the host on the other end of the cable. Only tested the FEL boot
> because I have no kernel installed on device.
>
> Signed-off-by: Michal Suchanek 
> ---
>  drivers/usb/sunxi_usb/udc/sw_udc.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/sunxi_usb/udc/sw_udc.c 
> b/drivers/usb/sunxi_usb/udc/sw_udc.c
> index 283ae4c..1e054a5 100644
> --- a/drivers/usb/sunxi_usb/udc/sw_udc.c
> +++ b/drivers/usb/sunxi_usb/udc/sw_udc.c
> @@ -2757,12 +2757,12 @@ static int sw_udc_set_pullup(struct sw_udc *udc, int 
> is_on)
>  {
> DMSG_DBG_UDC("sw_udc_set_pullup\n");
>
> -   is_udc_enable = is_on;
> if(!is_peripheral_active()){
> DMSG_PANIC("ERR: usb device is not active\n");
> return 0;
> }
>
> +   is_udc_enable = is_on;
>
> if(is_on){
> sw_udc_enable(udc);
> --
> 1.7.10.4
>
>
> --
> You received this message because you are subscribed to the Google Groups 
> "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to linux-sunxi+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[linux-sunxi] [PATCH 3.4] Revert "usb:sunxi:Fix "device not recognized" problem during android boot (3.4)"

2014-01-28 Thread Michal Suchanek
>From c35e54a6500e3b99fa90544d123df306d11f Mon Sep 17 00:00:00 2001

This reverts commit 44a6e1bfed98cd636b55a1191426ce2c373e15b2.

Before this commit USB gadgets work if you boot with cable connected.

eg. download kernel over FEL, mount NFS root over g_ether.

After this commit gadgets only come up if cable is unplugged.

eg. boot, load g_ether (nothing) unplug and replug cable - USB gadget is
seen by the host on the other end of the cable. Only tested the FEL boot
because I have no kernel installed on device.

Signed-off-by: Michal Suchanek 
---
 drivers/usb/sunxi_usb/udc/sw_udc.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/sunxi_usb/udc/sw_udc.c 
b/drivers/usb/sunxi_usb/udc/sw_udc.c
index 283ae4c..1e054a5 100644
--- a/drivers/usb/sunxi_usb/udc/sw_udc.c
+++ b/drivers/usb/sunxi_usb/udc/sw_udc.c
@@ -2757,12 +2757,12 @@ static int sw_udc_set_pullup(struct sw_udc *udc, int 
is_on)
 {
DMSG_DBG_UDC("sw_udc_set_pullup\n");
 
-   is_udc_enable = is_on;
if(!is_peripheral_active()){
DMSG_PANIC("ERR: usb device is not active\n");
return 0;
}
 
+   is_udc_enable = is_on;
 
if(is_on){
sw_udc_enable(udc);
-- 
1.7.10.4


-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.