[linux-sunxi] Re: [PATCH] phy: allwinner: Fix GENMASK misuse

2019-11-08 Thread Ondřej Jirman
On Fri, Nov 08, 2019 at 07:29:21PM +0800, Icenowy Zheng wrote: > > > 于 2019年11月8日 GMT+08:00 上午5:45:14, "Ondřej Jirman" 写到: > >Hello Rikard, > > > >On Thu, Nov 07, 2019 at 09:46:45PM +0100, Rikard Falkeborn wrote: > >> Arguments are supposed to be ordered high then low. > >> > >> Signed-off-by:

[linux-sunxi] Re: [PATCH] phy: allwinner: Fix GENMASK misuse

2019-11-08 Thread Icenowy Zheng
于 2019年11月8日 GMT+08:00 上午5:45:14, "Ondřej Jirman" 写到: >Hello Rikard, > >On Thu, Nov 07, 2019 at 09:46:45PM +0100, Rikard Falkeborn wrote: >> Arguments are supposed to be ordered high then low. >> >> Signed-off-by: Rikard Falkeborn >> --- >> Spotted while trying to add compile time checks of

[linux-sunxi] Re: [PATCH] phy: allwinner: Fix GENMASK misuse

2019-11-08 Thread Paul Kocialkowski
Hi, On Thu 07 Nov 19, 23:39, Russell King - ARM Linux admin wrote: > On Thu, Nov 07, 2019 at 09:46:45PM +0100, Rikard Falkeborn wrote: > > Arguments are supposed to be ordered high then low. > > > > Signed-off-by: Rikard Falkeborn > > --- > > Spotted while trying to add compile time checks of

[linux-sunxi] Re: [PATCH] phy: allwinner: Fix GENMASK misuse

2019-11-07 Thread Joe Perches
On Thu, 2019-11-07 at 23:39 +, Russell King - ARM Linux admin wrote: > On Thu, Nov 07, 2019 at 09:46:45PM +0100, Rikard Falkeborn wrote: > > Arguments are supposed to be ordered high then low. > > > > Signed-off-by: Rikard Falkeborn > > --- > > Spotted while trying to add compile time checks

[linux-sunxi] Re: [PATCH] phy: allwinner: Fix GENMASK misuse

2019-11-07 Thread Ondřej Jirman
Hello Rikard, On Thu, Nov 07, 2019 at 09:46:45PM +0100, Rikard Falkeborn wrote: > Arguments are supposed to be ordered high then low. > > Signed-off-by: Rikard Falkeborn > --- > Spotted while trying to add compile time checks of GENMASK arguments. > Patch has only been compile tested. thank