[linux-sunxi] Re: [PATCH 05/21] net-next: stmmac: Add dwmac-sun8i

2017-02-21 Thread Maxime Ripard
On Fri, Feb 17, 2017 at 02:18:02PM +0100, Corentin Labbe wrote: > On Thu, Feb 16, 2017 at 08:05:24PM +0100, Maxime Ripard wrote: > > Hi, > > > > [...] > > > + > > > +struct emac_variant { > > > + u32 default_syscon_value; > > > > Why do you need a default value? Can't you read it from the syscon

[linux-sunxi] Re: [PATCH 05/21] net-next: stmmac: Add dwmac-sun8i

2017-02-17 Thread Corentin Labbe
On Thu, Feb 16, 2017 at 08:05:24PM +0100, Maxime Ripard wrote: > Hi, > [...] > > + > > +struct emac_variant { > > + u32 default_syscon_value; > > Why do you need a default value? Can't you read it from the syscon > directly? > Why not, but you can see the default value as "value for disabled

[linux-sunxi] Re: [PATCH 05/21] net-next: stmmac: Add dwmac-sun8i

2017-02-17 Thread Maxime Ripard
Hi, On Thu, Feb 16, 2017 at 01:48:43PM +0100, Corentin Labbe wrote: > The dwmac-sun8i is a heavy hacked version of stmmac hardware by > allwinner. > In fact the only common part is the descriptor management and the first > register function. > > Signed-off-by: Corentin Labbe > --- > drivers/net