Re: [linux-sunxi] Re: [PATCH v4] ARM: sun8i: h2+: add support for Banana Pi M2 Zero board

2018-02-08 Thread Chen-Yu Tsai 
On Thu, Feb 8, 2018 at 5:28 PM, Jernej Škrabec  wrote:
> Dne četrtek, 08. februar 2018 ob 10:15:35 CET je Icenowy Zheng napisal(a):
>> 在 2018-02-08 17:00，Maxime Ripard 写道：
>>
>> > On Tue, Feb 06, 2018 at 09:16:47PM +0800, Icenowy Zheng wrote:
>> >> Banana Pi M2 Zero board is a H2+-based board by Sinovoip, with a form
>> >> factor and GPIO holes similar to Raspberry Pi Zero.
>> >>
>> >> It features:
>> >> - Allwinner H2+ SoC
>> >> - Single-chip (16-bit) 512MiB DDR3 DRAM
>> >> - Ampak AP6212 Wi-Fi/Bluetooth module
>> >> - MicroSD slot
>> >> - Two MicroUSB Type-B ports (one can only be used to power the board
>> >> and
>> >>
>> >>   the other features OTG functionality)
>> >>
>> >> - Two keys, a reset and a GPIO-connected key.
>> >> - HDMI Type-C (miniHDMI) connector connected to the HDMI part of H2+.
>> >> - CSI connector to connect the camera sensor provided by Sinovoip.
>> >>
>> >> Signed-off-by: Icenowy Zheng 
>> >> ---
>> >> Changes in v4:
>> >> - Use SPDX license identifier.
>> >>
>> >> Changes in v3:
>> >> - Add comments about Vbus problem in  node.
>> >>
>> >> Changes in v2:
>> >> - Use high active SD card detect on the production batch.
>> >>
>> >>  arch/arm/boot/dts/Makefile |   1 +
>> >>  .../boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts| 126
>> >>
>> >> +
>> >>
>> >>  2 files changed, 127 insertions(+)
>> >>  create mode 100644
>> >>
>> >> arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >>
>> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> >> index ade7a38543dc..d5a17e6e8b0f 100644
>> >> --- a/arch/arm/boot/dts/Makefile
>> >> +++ b/arch/arm/boot/dts/Makefile
>> >> @@ -974,6 +974,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
>> >>
>> >>sun8i-a83t-cubietruck-plus.dtb \
>> >>sun8i-a83t-tbs-a711.dtb \
>> >>sun8i-h2-plus-orangepi-r1.dtb \
>> >>
>> >> +  sun8i-h2-plus-bananapi-m2-zero.dtb \
>> >>
>> >>sun8i-h2-plus-orangepi-zero.dtb \
>> >>sun8i-h3-bananapi-m2-plus.dtb \
>> >>sun8i-h3-beelink-x2.dtb \
>> >>
>> >> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> new file mode 100644
>> >> index ..e2ee65a5bf92
>> >> --- /dev/null
>> >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> @@ -0,0 +1,126 @@
>> >> +/*
>> >> + * Copyright (C) 2017 Icenowy Zheng 
>> >> + *
>> >> + * Based on sun8i-h3-bananapi-m2-plus.dts, which is:
>> >> + *   Copyright (C) 2016 Chen-Yu Tsai 
>> >> + *
>> >> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> >
>> > Sorry to be a bit picky about this, but this should be your very first
>> > line, see arch/arm/boot/dts/sun7i-a20-olimex-som204-evb.dts for
>> > example.
>>
>> I think it's also OK here, see
>> arch/arm/boot/dts/sun8i-h3-libretech-all-h3-cc.dts.
>
> Lincesing rules [1] says it should be in first possible line which can contain
> comment.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/
> Documentation/process/license-rules.rst#n57

I confess I only read the license line rule some time after I posted that
patch.

ChenYu

>>
>> > Thanks!
>> > Maxime
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "linux-sunxi" group. To unsubscribe from this group and stop receiving
>> emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [linux-sunxi] Re: [PATCH v4] ARM: sun8i: h2+: add support for Banana Pi M2 Zero board

2018-02-08 Thread Jernej Škrabec 
Dne četrtek, 08. februar 2018 ob 10:15:35 CET je Icenowy Zheng napisal(a):
> 在 2018-02-08 17:00，Maxime Ripard 写道：
> 
> > On Tue, Feb 06, 2018 at 09:16:47PM +0800, Icenowy Zheng wrote:
> >> Banana Pi M2 Zero board is a H2+-based board by Sinovoip, with a form
> >> factor and GPIO holes similar to Raspberry Pi Zero.
> >> 
> >> It features:
> >> - Allwinner H2+ SoC
> >> - Single-chip (16-bit) 512MiB DDR3 DRAM
> >> - Ampak AP6212 Wi-Fi/Bluetooth module
> >> - MicroSD slot
> >> - Two MicroUSB Type-B ports (one can only be used to power the board
> >> and
> >> 
> >>   the other features OTG functionality)
> >> 
> >> - Two keys, a reset and a GPIO-connected key.
> >> - HDMI Type-C (miniHDMI) connector connected to the HDMI part of H2+.
> >> - CSI connector to connect the camera sensor provided by Sinovoip.
> >> 
> >> Signed-off-by: Icenowy Zheng 
> >> ---
> >> Changes in v4:
> >> - Use SPDX license identifier.
> >> 
> >> Changes in v3:
> >> - Add comments about Vbus problem in  node.
> >> 
> >> Changes in v2:
> >> - Use high active SD card detect on the production batch.
> >> 
> >>  arch/arm/boot/dts/Makefile |   1 +
> >>  .../boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts| 126
> >> 
> >> +
> >> 
> >>  2 files changed, 127 insertions(+)
> >>  create mode 100644
> >> 
> >> arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> 
> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> >> index ade7a38543dc..d5a17e6e8b0f 100644
> >> --- a/arch/arm/boot/dts/Makefile
> >> +++ b/arch/arm/boot/dts/Makefile
> >> @@ -974,6 +974,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
> >> 
> >>sun8i-a83t-cubietruck-plus.dtb \
> >>sun8i-a83t-tbs-a711.dtb \
> >>sun8i-h2-plus-orangepi-r1.dtb \
> >> 
> >> +  sun8i-h2-plus-bananapi-m2-zero.dtb \
> >> 
> >>sun8i-h2-plus-orangepi-zero.dtb \
> >>sun8i-h3-bananapi-m2-plus.dtb \
> >>sun8i-h3-beelink-x2.dtb \
> >> 
> >> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> new file mode 100644
> >> index ..e2ee65a5bf92
> >> --- /dev/null
> >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> @@ -0,0 +1,126 @@
> >> +/*
> >> + * Copyright (C) 2017 Icenowy Zheng 
> >> + *
> >> + * Based on sun8i-h3-bananapi-m2-plus.dts, which is:
> >> + *   Copyright (C) 2016 Chen-Yu Tsai 
> >> + *
> >> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > 
> > Sorry to be a bit picky about this, but this should be your very first
> > line, see arch/arm/boot/dts/sun7i-a20-olimex-som204-evb.dts for
> > example.
> 
> I think it's also OK here, see
> arch/arm/boot/dts/sun8i-h3-libretech-all-h3-cc.dts.

Lincesing rules [1] says it should be in first possible line which can contain 
comment.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/
Documentation/process/license-rules.rst#n57

> 
> > Thanks!
> > Maxime
> 
> --
> You received this message because you are subscribed to the Google Groups
> "linux-sunxi" group. To unsubscribe from this group and stop receiving
> emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.




-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[linux-sunxi] Re: [PATCH v4] ARM: sun8i: h2+: add support for Banana Pi M2 Zero board

2018-02-08 Thread Icenowy Zheng 

在 2018-02-08 17:00，Maxime Ripard 写道：

On Tue, Feb 06, 2018 at 09:16:47PM +0800, Icenowy Zheng wrote:

Banana Pi M2 Zero board is a H2+-based board by Sinovoip, with a form
factor and GPIO holes similar to Raspberry Pi Zero.

It features:
- Allwinner H2+ SoC
- Single-chip (16-bit) 512MiB DDR3 DRAM
- Ampak AP6212 Wi-Fi/Bluetooth module
- MicroSD slot
- Two MicroUSB Type-B ports (one can only be used to power the board 
and

  the other features OTG functionality)
- Two keys, a reset and a GPIO-connected key.
- HDMI Type-C (miniHDMI) connector connected to the HDMI part of H2+.
- CSI connector to connect the camera sensor provided by Sinovoip.

Signed-off-by: Icenowy Zheng 
---
Changes in v4:
- Use SPDX license identifier.

Changes in v3:
- Add comments about Vbus problem in  node.

Changes in v2:
- Use high active SD card detect on the production batch.

 arch/arm/boot/dts/Makefile |   1 +
 .../boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts| 126 
+

 2 files changed, 127 insertions(+)
 create mode 100644 
arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts


diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index ade7a38543dc..d5a17e6e8b0f 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -974,6 +974,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
sun8i-a83t-cubietruck-plus.dtb \
sun8i-a83t-tbs-a711.dtb \
sun8i-h2-plus-orangepi-r1.dtb \
+   sun8i-h2-plus-bananapi-m2-zero.dtb \
sun8i-h2-plus-orangepi-zero.dtb \
sun8i-h3-bananapi-m2-plus.dtb \
sun8i-h3-beelink-x2.dtb \
diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts 
b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts

new file mode 100644
index ..e2ee65a5bf92
--- /dev/null
+++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
@@ -0,0 +1,126 @@
+/*
+ * Copyright (C) 2017 Icenowy Zheng 
+ *
+ * Based on sun8i-h3-bananapi-m2-plus.dts, which is:
+ *   Copyright (C) 2016 Chen-Yu Tsai 
+ *
+ * SPDX-License-Identifier: (GPL-2.0+ OR MIT)


Sorry to be a bit picky about this, but this should be your very first
line, see arch/arm/boot/dts/sun7i-a20-olimex-som204-evb.dts for 
example.


I think it's also OK here, see 
arch/arm/boot/dts/sun8i-h3-libretech-all-h3-cc.dts.




Thanks!
Maxime


--
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.