Re: [linux-sunxi] Re: [PATCH 0/7] mmc: sunxi: Enable DM_MMC
On Mon, Jan 14, 2019 at 10:39:37AM +, Priit Laes wrote:
> On Mon, Jan 14, 2019 at 04:00:44PM +0530, Jagan Teki wrote:
> > On Mon 14 Jan, 2019, 3:53 PM Priit Laes >
> > > On Mon, Jan 14, 2019 at 03:40:37PM +0530, Jagan Teki wrote:
> > > > On Mon, Jan 14, 2019 at 3:05 PM Priit Laes wrote:
> > > > >
> > > > > On Fri, Jan 11, 2019 at 11:34:07PM +0530, Jagan Teki wrote:
> > > > > > I thought of waiting this till CLK framework gets Mainline,
> > > > > > but migration deadline for DM_MMC and BLK seems expiring in
> > > > > > next release. So instead of doing so huddle and make some last
> > > > > > minute changes, I have managed to add CLK, Reset code for mmc
> > > > > > driver via driver data.
> > > > >
> > > > > U-Boot 2019.01-rc3-00084-g0ce29380cf (Jan 14 2019 - 11:22:13 +0200)
> > > Allwinner Technology
> > > > >
> > > > > CPU: Allwinner A20 (SUN7I)
> > > > > Model: Olimex A20-OLinuXino-LIME2-eMMC
> > > > > I2C: ready
> > > > > DRAM: 1 GiB
> > > > > MMC: mmc@1c0f000: 0, mmc@1c11000: 1
> > > > > Loading Environment from FAT... Card did not respond to voltage
> > > > > select!
> > > > >
> > > > > eMMC seems to be broken:
> > > > > => mmc list
> > > > > mmc@1c0f000: 0
> > > > > mmc@1c11000: 1
> > > > > => mmc dev 1
> > > > > => mmc dev 0
> > > > > MMC: no card present
> > > > > => mmc part
> > > > > MMC: no card present
> > > > > => mmc info
> > > > > MMC: no card present
> > > >
> > > > Can you try this
> > > > diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
> > > > index 33f1ec5e5a..7fab88c47f 100644
> > > > --- a/drivers/mmc/sunxi_mmc.c
> > > > +++ b/drivers/mmc/sunxi_mmc.c
> > > > @@ -648,7 +648,7 @@ static int sunxi_mmc_probe(struct udevice *dev)
> > > > gate_reg = (void *)ccu_reg + priv->variant->gate_offset;
> > > > setbits_le32(gate_reg, BIT(AHB_GATE_OFFSET_MMC(priv->mmc_no)));
> > > >
> > > > - if ((!IS_ENABLED(CONFIG_MACH_SUN4I)) &&
> > > priv->variant->has_reset) {
> > > > + if ((!IS_ENABLED(CONFIG_MACH_SUN7I)) &&
> > > priv->variant->has_reset) {
> > > > reset_reg = (void *)ccu_reg +
> > > priv->variant->reset_offset;
> > > > setbits_le32(reset_reg, BIT(priv->mmc_no +
> > > > priv->variant->reset_start_bit));
> > >
> > > Still fails:
> > >
> > > MMC: no card present
> > > scanning bus for devices...
> > > Found 0 device(s).
> > >
> > > Device 0: unknown device
> > >
> > > Device 0: unknown device
> > >
> >
> > Can you print the reg values mclk and gate_reg. I have Lime2 which is fine
> > but doesn't have eMMC.
>
> mclk0: 0x0
> gate0: 0x200c141
> mclk2: 0x0
> gate2: 0x200c541
I managed to mess it up:
XXX: mclk0: 0x8050
XXX: gate0: 0x200c141
XXX: mclk2: 0x8050
XXX: gate2: 0x200c541
This is what you want:
diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
index 33f1ec5e5a..ac396d8d89 100644
--- a/drivers/mmc/sunxi_mmc.c
+++ b/drivers/mmc/sunxi_mmc.c
@@ -684,6 +684,9 @@ static int sunxi_mmc_probe(struct udevice *dev)
upriv->mmc = >mmc;
+printf("XXX: mclk%d: 0x%x\n", priv->mmc_no, *priv->mclkreg);
+printf("XXX: gate%d: 0x%x\n", priv->mmc_no, *gate_reg);
+
/* Reset controller */
writel(SUNXI_MMC_GCTRL_RESET, >reg->gctrl);
udelay(1000);
>
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "linux-sunxi" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to linux-sunxi+unsubscr...@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to linux-sunxi+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: [linux-sunxi] Re: [PATCH 0/7] mmc: sunxi: Enable DM_MMC
On Mon, Jan 14, 2019 at 04:00:44PM +0530, Jagan Teki wrote:
> On Mon 14 Jan, 2019, 3:53 PM Priit Laes
> > On Mon, Jan 14, 2019 at 03:40:37PM +0530, Jagan Teki wrote:
> > > On Mon, Jan 14, 2019 at 3:05 PM Priit Laes wrote:
> > > >
> > > > On Fri, Jan 11, 2019 at 11:34:07PM +0530, Jagan Teki wrote:
> > > > > I thought of waiting this till CLK framework gets Mainline,
> > > > > but migration deadline for DM_MMC and BLK seems expiring in
> > > > > next release. So instead of doing so huddle and make some last
> > > > > minute changes, I have managed to add CLK, Reset code for mmc
> > > > > driver via driver data.
> > > >
> > > > U-Boot 2019.01-rc3-00084-g0ce29380cf (Jan 14 2019 - 11:22:13 +0200)
> > Allwinner Technology
> > > >
> > > > CPU: Allwinner A20 (SUN7I)
> > > > Model: Olimex A20-OLinuXino-LIME2-eMMC
> > > > I2C: ready
> > > > DRAM: 1 GiB
> > > > MMC: mmc@1c0f000: 0, mmc@1c11000: 1
> > > > Loading Environment from FAT... Card did not respond to voltage select!
> > > >
> > > > eMMC seems to be broken:
> > > > => mmc list
> > > > mmc@1c0f000: 0
> > > > mmc@1c11000: 1
> > > > => mmc dev 1
> > > > => mmc dev 0
> > > > MMC: no card present
> > > > => mmc part
> > > > MMC: no card present
> > > > => mmc info
> > > > MMC: no card present
> > >
> > > Can you try this
> > > diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
> > > index 33f1ec5e5a..7fab88c47f 100644
> > > --- a/drivers/mmc/sunxi_mmc.c
> > > +++ b/drivers/mmc/sunxi_mmc.c
> > > @@ -648,7 +648,7 @@ static int sunxi_mmc_probe(struct udevice *dev)
> > > gate_reg = (void *)ccu_reg + priv->variant->gate_offset;
> > > setbits_le32(gate_reg, BIT(AHB_GATE_OFFSET_MMC(priv->mmc_no)));
> > >
> > > - if ((!IS_ENABLED(CONFIG_MACH_SUN4I)) &&
> > priv->variant->has_reset) {
> > > + if ((!IS_ENABLED(CONFIG_MACH_SUN7I)) &&
> > priv->variant->has_reset) {
> > > reset_reg = (void *)ccu_reg +
> > priv->variant->reset_offset;
> > > setbits_le32(reset_reg, BIT(priv->mmc_no +
> > > priv->variant->reset_start_bit));
> >
> > Still fails:
> >
> > MMC: no card present
> > scanning bus for devices...
> > Found 0 device(s).
> >
> > Device 0: unknown device
> >
> > Device 0: unknown device
> >
>
> Can you print the reg values mclk and gate_reg. I have Lime2 which is fine
> but doesn't have eMMC.
mclk0: 0x0
gate0: 0x200c141
mclk2: 0x0
gate2: 0x200c541
>
> --
> You received this message because you are subscribed to the Google Groups
> "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to linux-sunxi+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: [linux-sunxi] Re: [PATCH 0/7] mmc: sunxi: Enable DM_MMC
On Mon 14 Jan, 2019, 3:53 PM Priit Laes On Mon, Jan 14, 2019 at 03:40:37PM +0530, Jagan Teki wrote:
> > On Mon, Jan 14, 2019 at 3:05 PM Priit Laes wrote:
> > >
> > > On Fri, Jan 11, 2019 at 11:34:07PM +0530, Jagan Teki wrote:
> > > > I thought of waiting this till CLK framework gets Mainline,
> > > > but migration deadline for DM_MMC and BLK seems expiring in
> > > > next release. So instead of doing so huddle and make some last
> > > > minute changes, I have managed to add CLK, Reset code for mmc
> > > > driver via driver data.
> > >
> > > U-Boot 2019.01-rc3-00084-g0ce29380cf (Jan 14 2019 - 11:22:13 +0200)
> Allwinner Technology
> > >
> > > CPU: Allwinner A20 (SUN7I)
> > > Model: Olimex A20-OLinuXino-LIME2-eMMC
> > > I2C: ready
> > > DRAM: 1 GiB
> > > MMC: mmc@1c0f000: 0, mmc@1c11000: 1
> > > Loading Environment from FAT... Card did not respond to voltage select!
> > >
> > > eMMC seems to be broken:
> > > => mmc list
> > > mmc@1c0f000: 0
> > > mmc@1c11000: 1
> > > => mmc dev 1
> > > => mmc dev 0
> > > MMC: no card present
> > > => mmc part
> > > MMC: no card present
> > > => mmc info
> > > MMC: no card present
> >
> > Can you try this
> > diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
> > index 33f1ec5e5a..7fab88c47f 100644
> > --- a/drivers/mmc/sunxi_mmc.c
> > +++ b/drivers/mmc/sunxi_mmc.c
> > @@ -648,7 +648,7 @@ static int sunxi_mmc_probe(struct udevice *dev)
> > gate_reg = (void *)ccu_reg + priv->variant->gate_offset;
> > setbits_le32(gate_reg, BIT(AHB_GATE_OFFSET_MMC(priv->mmc_no)));
> >
> > - if ((!IS_ENABLED(CONFIG_MACH_SUN4I)) &&
> priv->variant->has_reset) {
> > + if ((!IS_ENABLED(CONFIG_MACH_SUN7I)) &&
> priv->variant->has_reset) {
> > reset_reg = (void *)ccu_reg +
> priv->variant->reset_offset;
> > setbits_le32(reset_reg, BIT(priv->mmc_no +
> > priv->variant->reset_start_bit));
>
> Still fails:
>
> MMC: no card present
> scanning bus for devices...
> Found 0 device(s).
>
> Device 0: unknown device
>
> Device 0: unknown device
>
Can you print the reg values mclk and gate_reg. I have Lime2 which is fine
but doesn't have eMMC.
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: [linux-sunxi] Re: [PATCH 0/7] mmc: sunxi: Enable DM_MMC
On Mon, Jan 14, 2019 at 03:40:37PM +0530, Jagan Teki wrote:
> On Mon, Jan 14, 2019 at 3:05 PM Priit Laes wrote:
> >
> > On Fri, Jan 11, 2019 at 11:34:07PM +0530, Jagan Teki wrote:
> > > I thought of waiting this till CLK framework gets Mainline,
> > > but migration deadline for DM_MMC and BLK seems expiring in
> > > next release. So instead of doing so huddle and make some last
> > > minute changes, I have managed to add CLK, Reset code for mmc
> > > driver via driver data.
> >
> > U-Boot 2019.01-rc3-00084-g0ce29380cf (Jan 14 2019 - 11:22:13 +0200)
> > Allwinner Technology
> >
> > CPU: Allwinner A20 (SUN7I)
> > Model: Olimex A20-OLinuXino-LIME2-eMMC
> > I2C: ready
> > DRAM: 1 GiB
> > MMC: mmc@1c0f000: 0, mmc@1c11000: 1
> > Loading Environment from FAT... Card did not respond to voltage select!
> >
> > eMMC seems to be broken:
> > => mmc list
> > mmc@1c0f000: 0
> > mmc@1c11000: 1
> > => mmc dev 1
> > => mmc dev 0
> > MMC: no card present
> > => mmc part
> > MMC: no card present
> > => mmc info
> > MMC: no card present
>
> Can you try this
> diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
> index 33f1ec5e5a..7fab88c47f 100644
> --- a/drivers/mmc/sunxi_mmc.c
> +++ b/drivers/mmc/sunxi_mmc.c
> @@ -648,7 +648,7 @@ static int sunxi_mmc_probe(struct udevice *dev)
> gate_reg = (void *)ccu_reg + priv->variant->gate_offset;
> setbits_le32(gate_reg, BIT(AHB_GATE_OFFSET_MMC(priv->mmc_no)));
>
> - if ((!IS_ENABLED(CONFIG_MACH_SUN4I)) && priv->variant->has_reset) {
> + if ((!IS_ENABLED(CONFIG_MACH_SUN7I)) && priv->variant->has_reset) {
> reset_reg = (void *)ccu_reg + priv->variant->reset_offset;
> setbits_le32(reset_reg, BIT(priv->mmc_no +
> priv->variant->reset_start_bit));
Still fails:
MMC: no card present
scanning bus for devices...
Found 0 device(s).
Device 0: unknown device
Device 0: unknown device
> >
> > Setting up a 640x480 dvi console (overscan 0x0)
> > In:serial
> > Out: vga
> > Err: vga
> > Allwinner mUSB OTG (Peripheral)
> > SCSI: SATA link 0 timeout.
> > AHCI 0001.0100 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
> > flags: ncq stag pm led clo only pmp pio slum part ccc apst
> >
> > Net: sunxi_set_gate: (CLK#66) unhandled
> > eth0: ethernet@1c5
> >
> >
> > And also CLK#66 message
>
> This is expected, looking EMAC clock from dw driver, will handle in
> next series. to be noted we enable print.
>
> --
> You received this message because you are subscribed to the Google Groups
> "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to linux-sunxi+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
