Re: [linux-sunxi] Re: [PATCH v2] mmc: sunxi: Fix NULL pointer reference on clk_delays
在 2017-08-08 15:10，Chen-Yu Tsai 写道：
On Tue, Aug 8, 2017 at 3:07 PM, wrote:
在 2017-08-08 15:02，Chen-Yu Tsai 写道：
Some SoCs do not support clk delays for MMC in the clock control
unit.
These include the old controllers in A10/A10s/A13/R8, and the new
eMMC
controller in A64. The config structure for these controllers do not
specify clk_delays, but the check for this was replaced in commit
b0600daebf31 ("mmc: sunxi: Support controllers that can use both old
and new timings").
This patch adds back the check for clk_delays, and also adds comments
for both checks in sunxi_mmc_clk_set_phase().
Fixes: b0600daebf31 ("mmc: sunxi: Support controllers that can use
both old and new timings")
Signed-off-by: Chen-Yu Tsai
Should I add a Tested-by here?
If you tested it, then yes. :)
I tested it on A64 MMC2.
So:
Tested-by: Icenowy Zheng
ChenYu
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: [linux-sunxi] Re: [PATCH v2] mmc: sunxi: Fix NULL pointer reference on clk_delays
On Tue, Aug 8, 2017 at 3:07 PM, wrote:
> 在 2017-08-08 15:02，Chen-Yu Tsai 写道：
>>
>> Some SoCs do not support clk delays for MMC in the clock control unit.
>> These include the old controllers in A10/A10s/A13/R8, and the new eMMC
>> controller in A64. The config structure for these controllers do not
>> specify clk_delays, but the check for this was replaced in commit
>> b0600daebf31 ("mmc: sunxi: Support controllers that can use both old
>> and new timings").
>>
>> This patch adds back the check for clk_delays, and also adds comments
>> for both checks in sunxi_mmc_clk_set_phase().
>>
>> Fixes: b0600daebf31 ("mmc: sunxi: Support controllers that can use
>> both old and new timings")
>> Signed-off-by: Chen-Yu Tsai
>
>
> Should I add a Tested-by here?
If you tested it, then yes. :)
ChenYu
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
