Re: [PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-05 Thread Steven Rostedt
On Tue, 5 Dec 2023 20:39:28 +0100 Eric Dumazet wrote: > > So, we do not want to add some tracepoint to do some unknow debug. > > We have a clear goal. debugging is just an incidental capability. > > > > We have powerful mechanisms in the stack already that ordinary (no > privilege requested) a

Re: [PATCH net-next] tcp: add tracepoints for data send/recv/acked

2023-12-05 Thread Eric Dumazet
On Tue, Dec 5, 2023 at 3:11 AM Xuan Zhuo wrote: > > On Mon, 4 Dec 2023 13:28:21 +0100, Eric Dumazet wrote: > > On Mon, Dec 4, 2023 at 12:43 PM Philo Lu wrote: > > > > > > Add 3 tracepoints, namely tcp_data_send/tcp_data_recv/tcp_data_acked, > > > which will be called every time a tcp data packet

Re: [PATCH v2] 9p: prevent read overrun in protocol dump tracepoint

2023-12-05 Thread Christian Schoenebeck
On Monday, December 4, 2023 9:23:20 PM CET JP Kobryn wrote: > An out of bounds read can occur within the tracepoint 9p_protocol_dump. In > the fast assign, there is a memcpy that uses a constant size of 32 (macro > named P9_PROTO_DUMP_SZ). When the copy is invoked, the source buffer is not > guaran

Re: [PATCH v2] 9p: prevent read overrun in protocol dump tracepoint

2023-12-05 Thread asmadeus
JP Kobryn wrote on Mon, Dec 04, 2023 at 12:23:20PM -0800: > An out of bounds read can occur within the tracepoint 9p_protocol_dump. In > the fast assign, there is a memcpy that uses a constant size of 32 (macro > named P9_PROTO_DUMP_SZ). When the copy is invoked, the source buffer is not > guarante