Re: [PATCH bpf-next] rethook: Remove warning messages printed for finding return address of a frame.

2024-04-08 Thread Kui-Feng Lee
On 4/7/24 18:13, Masami Hiramatsu (Google) wrote: On Wed, 3 Apr 2024 16:36:25 +0200 Daniel Borkmann wrote: On 4/2/24 6:58 PM, Andrii Nakryiko wrote: On Mon, Apr 1, 2024 at 12:16 PM Kui-Feng Lee wrote: rethook_find_ret_addr() prints a warning message and returns 0 when the target task

Re: [PATCH bpf-next] rethook: Remove warning messages printed for finding return address of a frame.

2024-04-07 Thread Google
On Wed, 3 Apr 2024 16:36:25 +0200 Daniel Borkmann wrote: > On 4/2/24 6:58 PM, Andrii Nakryiko wrote: > > On Mon, Apr 1, 2024 at 12:16 PM Kui-Feng Lee wrote: > >> > >> rethook_find_ret_addr() prints a warning message and returns 0 when the > >> target task is running and not the "current" task

RE: [PATCH bpf-next] rethook: Remove warning messages printed for finding return address of a frame.

2024-04-03 Thread John Fastabend
Kui-Feng Lee wrote: > rethook_find_ret_addr() prints a warning message and returns 0 when the > target task is running and not the "current" task to prevent returning an > incorrect return address. However, this check is incomplete as the target > task can still transition to the running state

Re: [PATCH bpf-next] rethook: Remove warning messages printed for finding return address of a frame.

2024-04-03 Thread Daniel Borkmann
On 4/2/24 6:58 PM, Andrii Nakryiko wrote: On Mon, Apr 1, 2024 at 12:16 PM Kui-Feng Lee wrote: rethook_find_ret_addr() prints a warning message and returns 0 when the target task is running and not the "current" task to prevent returning an incorrect return address. However, this check is

Re: [PATCH bpf-next] rethook: Remove warning messages printed for finding return address of a frame.

2024-04-02 Thread Andrii Nakryiko
On Mon, Apr 1, 2024 at 12:16 PM Kui-Feng Lee wrote: > > rethook_find_ret_addr() prints a warning message and returns 0 when the > target task is running and not the "current" task to prevent returning an > incorrect return address. However, this check is incomplete as the target > task can still

[PATCH bpf-next] rethook: Remove warning messages printed for finding return address of a frame.

2024-04-01 Thread Kui-Feng Lee
rethook_find_ret_addr() prints a warning message and returns 0 when the target task is running and not the "current" task to prevent returning an incorrect return address. However, this check is incomplete as the target task can still transition to the running state when finding the return