Re: [PATCH v2] tools/rtla: Consolidate common parameters into shared structure

2025-08-05 Thread Crystal Wood
On Tue, 2025-08-05 at 10:03 +0300, Costa Shulyupin wrote: > On Mon, 4 Aug 2025 at 21:18, Crystal Wood wrote: > > If you want, I could rebase that on this and use container_of() to for tool- > > specific params... but then that adds complexity with the top and hist- > > specific params, most of whi

Re: [PATCH v2] tools/rtla: Consolidate common parameters into shared structure

2025-08-05 Thread Costa Shulyupin
On Mon, 4 Aug 2025 at 21:18, Crystal Wood wrote: > If you want, I could rebase that on this and use container_of() to for tool- > specific params... but then that adds complexity with the top and hist- > specific params, most of which are common between timerlat and osnoise > (and not merged by th

Re: [PATCH v2] tools/rtla: Consolidate common parameters into shared structure

2025-08-04 Thread Crystal Wood
On Sat, 2025-07-26 at 10:24 +0300, Costa Shulyupin wrote: > timerlat_params and osnoise_params structures contain 15 identical > fields. > > Introduce a common_params structure and move those fields into it to > eliminate the code duplication and improve maintainability. > > Signed-off-by: Costa

Re: [PATCH v2] tools/rtla: Consolidate common parameters into shared structure

2025-07-30 Thread Tomas Glozar
so 26. 7. 2025 v 9:25 odesílatel Costa Shulyupin napsal: > --- > Changes since v1: > - Rebase on top of recent changes > - Address Tomas's comments > - Don't change already not common members: trace_output, runtime > Just a clarification: runtime was never a common parameter, it was just mistaken

[PATCH v2] tools/rtla: Consolidate common parameters into shared structure

2025-07-26 Thread Costa Shulyupin
timerlat_params and osnoise_params structures contain 15 identical fields. Introduce a common_params structure and move those fields into it to eliminate the code duplication and improve maintainability. Signed-off-by: Costa Shulyupin --- Changes since v1: - Rebase on top of recent changes - Ad