[PATCH] x86/mce: Clean up TP_printk() output line of the mce_record tracepoint

2024-03-29 Thread Naik, Avadhut
On 3/29/2024 11:50, Luck, Tony wrote: >>> - While at it, don't forget to: >>> >>>s/ADDR/MISC/SYND >>> /addr/misc/synd >>> >> These are actually acronyms for Address, Miscellaneous and Syndrome >> registers. > > They look like abbreviations, not acronyms to me. > > -Tony Yes, they

RE: [PATCH] x86/mce: Clean up TP_printk() output line of the mce_record tracepoint

2024-03-29 Thread Luck, Tony
>> - While at it, don't forget to: >> >>s/ADDR/MISC/SYND >> /addr/misc/synd >> > These are actually acronyms for Address, Miscellaneous and Syndrome registers. They look like abbreviations, not acronyms to me. -Tony

Re: [PATCH] ftrace: make extra rcu_is_watching() validation check optional

2024-03-29 Thread Andrii Nakryiko
On Tue, Mar 26, 2024 at 11:58 AM Steven Rostedt wrote: > > On Tue, 26 Mar 2024 09:16:33 -0700 > Andrii Nakryiko wrote: > > > > It's no different than lockdep. Test boxes should have it enabled, but > > > there's no reason to have this enabled in a production system. > > > > > > > I tend to agree

[PATCH] x86/mce: Clean up TP_printk() output line of the mce_record tracepoint

2024-03-29 Thread Naik, Avadhut
On 3/29/2024 02:11, Ingo Molnar wrote: > > Please split out the other (capitalization) changes to the output into > a separate patch. > Okay. Will put the capitalization changes into a separate patch. > - While at it, don't forget to: > >s/ADDR/MISC/SYND > /addr/misc/synd > These

[PATCH] perf-ftrace: sync funcgraph options with perf-ftrace interface

2024-03-29 Thread piecuch
From: Krzysztof Piecuch Adding overrun, retval, retval-hex and tail options to set off-by-default funcgraph features. Add nocpu, nooverhead, noduration options to turn off funcgraph features which are on by default. Signed-off-by: Krzysztof Piecuch --- Documentation/trace/ftrace.rst

Re: [PATCH net-next v3 2/3] trace: tcp: fully support trace_tcp_send_reset

2024-03-29 Thread Eric Dumazet
On Fri, Mar 29, 2024 at 11:23 AM Jason Xing wrote: > > On Fri, Mar 29, 2024 at 5:07 PM Eric Dumazet wrote: > > > > On Fri, Mar 29, 2024 at 4:43 AM Jason Xing > > wrote: > > > > > > From: Jason Xing > > > > > > Prior to this patch, what we can see by enabling trace_tcp_send is > > > only

Re: [PATCH net-next v3 3/3] tcp: add location into reset trace process

2024-03-29 Thread Jason Xing
On Fri, Mar 29, 2024 at 5:13 PM Eric Dumazet wrote: > > On Fri, Mar 29, 2024 at 4:43 AM Jason Xing wrote: > > > > From: Jason Xing > > > > In addition to knowing the 4-tuple of the flow which generates RST, > > the reason why it does so is very important because we have some > > cases where the

Re: [PATCH net-next v3 2/3] trace: tcp: fully support trace_tcp_send_reset

2024-03-29 Thread Jason Xing
On Fri, Mar 29, 2024 at 5:07 PM Eric Dumazet wrote: > > On Fri, Mar 29, 2024 at 4:43 AM Jason Xing wrote: > > > > From: Jason Xing > > > > Prior to this patch, what we can see by enabling trace_tcp_send is > > only happening under two circumstances: > > 1) active rst mode > > 2) non-active rst

Re: [PATCH net-next v3 3/3] tcp: add location into reset trace process

2024-03-29 Thread Eric Dumazet
On Fri, Mar 29, 2024 at 4:43 AM Jason Xing wrote: > > From: Jason Xing > > In addition to knowing the 4-tuple of the flow which generates RST, > the reason why it does so is very important because we have some > cases where the RST should be sent and have no clue which one > exactly. > > Adding

Re: [PATCH net-next v3 2/3] trace: tcp: fully support trace_tcp_send_reset

2024-03-29 Thread Eric Dumazet
On Fri, Mar 29, 2024 at 4:43 AM Jason Xing wrote: > > From: Jason Xing > > Prior to this patch, what we can see by enabling trace_tcp_send is > only happening under two circumstances: > 1) active rst mode > 2) non-active rst mode and based on the full socket > > That means the inconsistency

Re: [PATCH net-next v3 1/3] trace: adjust TP_STORE_ADDR_PORTS_SKB() parameters

2024-03-29 Thread Eric Dumazet
On Fri, Mar 29, 2024 at 4:43 AM Jason Xing wrote: > > From: Jason Xing > > Introducing entry_saddr and entry_daddr parameters in this macro > for later use can help us record the reverse 4-tuple by analyzing > the 4-tuple of the incoming skb when receiving. > > Signed-off-by: Jason Xing

[PATCH] x86/mce: Clean up TP_printk() output line of the mce_record tracepoint

2024-03-29 Thread Ingo Molnar
* Avadhut Naik wrote: > > +/* > + * MCE Event Record. > + * > + * Only very relevant and transient information which cannot be > + * gathered from a system by any other means or which can only be > + * acquired arduously should be added to this record. > + */ > + > TRACE_EVENT(mce_record, >