Re: [PATCHv2 bpf-next 0/6] x86/fgraph,bpf: Fix ORC stack unwind from kprobe_multi
Hello: This series was applied to bpf/bpf-next.git (master) by Andrii Nakryiko : On Mon, 26 Jan 2026 22:18:31 +0100 you wrote: > hi, > Mahe reported missing function from stack trace on top of kprobe multi > program. It turned out the latest fix [1] needs some more fixing. > > v2 changes: > - keep the unwind same as for kprobes, attached function > is part of entry probe stacktrace, not kretprobe [Steven] > - several change in trigger bench [Andrii] > - added selftests for standard kprobes and fentry/fexit probes [Andrii] > > [...] Here is the summary with links: - [PATCHv2,bpf-next,1/6] x86/fgraph: Fix return_to_handler regs.rsp value https://git.kernel.org/bpf/bpf-next/c/8bc11700e0d2 - [PATCHv2,bpf-next,2/6] x86/fgraph,bpf: Switch kprobe_multi program stack unwind to hw_regs path https://git.kernel.org/bpf/bpf-next/c/aea25178 - [PATCHv2,bpf-next,3/6] selftests/bpf: Fix kprobe multi stacktrace_ips test https://git.kernel.org/bpf/bpf-next/c/0207f94971e7 - [PATCHv2,bpf-next,4/6] selftests/bpf: Add stacktrace ips test for kprobe/kretprobe https://git.kernel.org/bpf/bpf-next/c/7373f97e868a - [PATCHv2,bpf-next,5/6] selftests/bpf: Add stacktrace ips test for fentry/fexit https://git.kernel.org/bpf/bpf-next/c/e5d532be4a3b - [PATCHv2,bpf-next,6/6] selftests/bpf: Allow to benchmark trigger with stacktrace https://git.kernel.org/bpf/bpf-next/c/4173b494d93a You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
[PATCHv2 bpf-next 0/6] x86/fgraph,bpf: Fix ORC stack unwind from kprobe_multi
hi, Mahe reported missing function from stack trace on top of kprobe multi program. It turned out the latest fix [1] needs some more fixing. v2 changes: - keep the unwind same as for kprobes, attached function is part of entry probe stacktrace, not kretprobe [Steven] - several change in trigger bench [Andrii] - added selftests for standard kprobes and fentry/fexit probes [Andrii] Note I'll try to add similar stacktrace adjustment for fentry/fexit in separate patchset to not complicate this change. thanks, jirka [1] https://lore.kernel.org/bpf/[email protected]/ --- Jiri Olsa (6): x86/fgraph: Fix return_to_handler regs.rsp value x86/fgraph,bpf: Switch kprobe_multi program stack unwind to hw_regs path selftests/bpf: Fix kprobe multi stacktrace_ips test selftests/bpf: Add stacktrace ips test for kprobe/kretprobe selftests/bpf: Add stacktrace ips test for fentry/fexit selftests/bpf: Allow to benchmark trigger with stacktrace arch/x86/include/asm/ftrace.h | 2 +- arch/x86/kernel/ftrace_64.S | 5 +++- tools/testing/selftests/bpf/bench.c | 4 tools/testing/selftests/bpf/bench.h | 1 + tools/testing/selftests/bpf/benchs/bench_trigger.c | 1 + tools/testing/selftests/bpf/prog_tests/stacktrace_ips.c | 120 +++ tools/testing/selftests/bpf/progs/stacktrace_ips.c | 27 ++ tools/testing/selftests/bpf/progs/trigger_bench.c | 46 + 8 files changed, 190 insertions(+), 16 deletions(-)
