Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters

2024-02-20 Thread Xuan Zhuo
On Tue, 20 Feb 2024 15:18:15 +0100, Halil Pasic wrote: > On Thu, 1 Feb 2024 11:00:42 +0800 > Xuan Zhuo wrote: > > > > > And squish the parameters from transport to a structure. > > > > > > The patch did more than what is described here, it also switch to use > > > a structure for vring_create_vir

Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters

2024-02-20 Thread Halil Pasic
On Thu, 1 Feb 2024 11:00:42 +0800 Xuan Zhuo wrote: > > > And squish the parameters from transport to a structure. > > > > The patch did more than what is described here, it also switch to use > > a structure for vring_create_virtqueue() etc. > > > > Is it better to split? > > Sure. I unde

Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters

2024-02-02 Thread kernel test robot
Hi Xuan, kernel test robot noticed the following build errors: [auto build test ERROR on v6.7] [also build test ERROR on next-20240202] [cannot apply to remoteproc/rproc-next uml/next s390/features linus/master uml/fixes v6.8-rc2 v6.8-rc1] [If your patch is applied to the wrong git tree, kindly

Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters

2024-01-31 Thread Xuan Zhuo
On Wed, 31 Jan 2024 17:12:34 +0800, Jason Wang wrote: > On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote: > > > > Now, we pass multi parameters to find_vqs. These parameters > > may work for transport or work for vring. > > > > And find_vqs has multi implements in many places: > > > > But every ti

Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters

2024-01-31 Thread Jason Wang
On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote: > > Now, we pass multi parameters to find_vqs. These parameters > may work for transport or work for vring. > > And find_vqs has multi implements in many places: > > But every time, > arch/um/drivers/virtio_uml.c > drivers/platform/mellanox/mlxbf-