Re: [PATCH -next v2] usb: gadget: tcm_usb_gadge: fix to return error or 0 in tcm_usbg_drop_nexus()

2012-11-14 Thread Sebastian Andrzej Siewior
On 11/14/2012 06:45 AM, Felipe Balbi wrote: Hi, Hi Felipe, On Wed, Nov 14, 2012 at 01:47:23PM +0800, Wei Yongjun wrote: From: Wei Yongjunyongjun_...@trendmicro.com.cn In the error handling case of tcm_usbg_drop_nexus(), the error code is assigned to 'ret', but it is ignored. We'd better

Re: [RFC PATCH v2 3/6] usb: add runtime pm support for usb port device

2012-11-14 Thread Rafael J. Wysocki
On Wednesday, November 14, 2012 02:34:37 PM Lan Tianyu wrote: On 2012年11月14日 08:08, Rafael J. Wysocki wrote: On Tuesday, November 13, 2012 04:00:02 PM Lan Tianyu wrote: This patch is to add runtime pm callback for usb port device. Set/clear PORT_POWER feature in the resume/suspend callbak.

[PATCH v8 0/2] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2012-11-14 Thread Praveen Paneri
Changes from v7: Rebased to the latest usb-next branch. Separating arch patches from these driver patches. Changes from v6: Modified register definitions according to the existing ones. Changed default PHY clk selection for SoCs. Improved binding text and rebased to the latest usb-next. Changes

[PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-11-14 Thread Praveen Paneri
This driver uses usb_phy interface to interact with s3c-hsotg. Supports phy_init and phy_shutdown functions to enable/disable usb phy. Support will be extended to host controllers and more Samsung SoCs. Signed-off-by: Praveen Paneri p.pan...@samsung.com Acked-by: Heiko Stuebner he...@sntech.de

[PATCH v8 2/2] usb: s3c-hsotg: Adding phy driver support

2012-11-14 Thread Praveen Paneri
Adding the transceiver to hsotg driver. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Praveen Paneri p.pan...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/s3c-hsotg.c | 37

[PATCH 2/6] usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx

2012-11-14 Thread Michael Grzeschik
This driver will be used for every Freescale SoC which has this misc memory layout to control the basic usb handling. So better name this driver, function and struct names in a more generic way. Reported-by: Fabio Estevam feste...@gmail.com Signed-off-by: Michael Grzeschik

[PATCH 5/6] usb: chipidea: usbmisc: add mx53 support

2012-11-14 Thread Michael Grzeschik
This adds mx53 as the next user of the usbmisc driver and makes it possible to disable the overcurrent-detection of the internal phy. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/usb/chipidea/usbmisc_imx.c | 28

[PATCH 3/6] usb: chipidea: usbmisc: prepare driver to handle more than one soc

2012-11-14 Thread Michael Grzeschik
From: Marc Kleine-Budde m...@pengutronix.de This attaches the usbmisc_ops to the of_device_id data and makes it possible to define special functions per soc. Signed-off-by: Marc Kleine-Budde m...@pengutronix.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de ---

[PATCH 0/6] support other fsl SoCs with usbmisc + small fixes

2012-11-14 Thread Michael Grzeschik
Nearly every SoC from Freescale has this non-core usb registers. This series adds support for more users of this driver. Marc Kleine-Budde (3): usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove usb: chipidea: usbmisc: prepare driver to handle more than one soc usb:

[PATCH 1/6] usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove

2012-11-14 Thread Michael Grzeschik
From: Marc Kleine-Budde m...@pengutronix.de While there fix a potential race condition, first set usbmisc, then call usbmisc_set_ops(). Signed-off-by: Marc Kleine-Budde m...@pengutronix.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/usb/chipidea/usbmisc_imx6q.c |

[PATCH 6/6] usb: chipidea: usbmisc: add post handling and errata fix for mx25

2012-11-14 Thread Michael Grzeschik
This adds a post handling routine which is called after ci13xxx_add_device was called. The first user is the mx25, which has to disable the external-vbus-divider after the ude has started. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde

Re: [PATCH 2/6] usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx

2012-11-14 Thread Fabio Estevam
Hi Michael, On Wed, Nov 14, 2012 at 9:55 AM, Michael Grzeschik m.grzesc...@pengutronix.de wrote: This driver will be used for every Freescale SoC which has this misc memory layout to control the basic usb handling. So better name this driver, function and struct names in a more generic way.

Re: [RFC PATCH v2 3/6] usb: add runtime pm support for usb port device

2012-11-14 Thread Lan Tianyu
于 2012/11/14 17:49, Rafael J. Wysocki 写道: On Wednesday, November 14, 2012 02:34:37 PM Lan Tianyu wrote: On 2012年11月14日 08:08, Rafael J. Wysocki wrote: On Tuesday, November 13, 2012 04:00:02 PM Lan Tianyu wrote: This patch is to add runtime pm callback for usb port device. Set/clear PORT_POWER

Re: [PATCH 1/6] usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove

2012-11-14 Thread Alexander Shishkin
Michael Grzeschik m.grzesc...@pengutronix.de writes: From: Marc Kleine-Budde m...@pengutronix.de While there fix a potential race condition, first set usbmisc, then call usbmisc_set_ops(). This should be really two separate patches, both of which could use more elaborate commit messages.

Re: [PATCH 2/6] usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx

2012-11-14 Thread Michael Grzeschik
On Wed, Nov 14, 2012 at 03:25:30PM +0200, Alexander Shishkin wrote: Michael Grzeschik m.grzesc...@pengutronix.de writes: This driver will be used for every Freescale SoC which has this misc memory layout to control the basic usb handling. So better name this driver, function and struct

Re: [PATCH 2/6] usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx

2012-11-14 Thread Alexander Shishkin
Michael Grzeschik m...@pengutronix.de writes: On Wed, Nov 14, 2012 at 03:25:30PM +0200, Alexander Shishkin wrote: Michael Grzeschik m.grzesc...@pengutronix.de writes: This driver will be used for every Freescale SoC which has this misc memory layout to control the basic usb handling. So

Re: [PATCH 4/6] usb: chipidea: usbmisc: add support for ahb, ipg and per clock

2012-11-14 Thread Alexander Shishkin
Michael Grzeschik m.grzesc...@pengutronix.de writes: From: Marc Kleine-Budde m...@pengutronix.de This patch adds support for ahb, ipg and per clock, which is needed to support imx53. I would also suggest using a more elaborate wording here, some people might also be interested what are the

Re: [RFC PATCH v2 3/6] usb: add runtime pm support for usb port device

2012-11-14 Thread Lan Tianyu
于 2012/11/14 20:45, Lan Tianyu 写道: 于 2012/11/14 17:49, Rafael J. Wysocki 写道: On Wednesday, November 14, 2012 02:34:37 PM Lan Tianyu wrote: On 2012年11月14日 08:08, Rafael J. Wysocki wrote: On Tuesday, November 13, 2012 04:00:02 PM Lan Tianyu wrote: This patch is to add runtime pm callback for

[PATCH] usb: gadget: fix switch off blocked in u_serial

2012-11-14 Thread Linus Walleij
From: Haipeng YU haipeng...@stericsson.com When a device is switched off by software, gserial_cleanup will be called, and switch off will be blocked in this function because wake_up_interruptible() in gs_close() can not wake_up the wait_event() in gserial_cleanup(), it should be changed to

Re: usb phy and usb otg

2012-11-14 Thread Felipe Balbi
Hi, (please Cc myself for PHY-related questions ;-) On Wed, Nov 14, 2012 at 10:35:42AM +0800, Chao Xie wrote: The USB controller in our SOC can support otg/ehci/udc, and there is a PHY around the controller. It means that when we want to enable otg or ehci or udc, we have to enable the PHY.

Re: [PATCH] musb_core: print new line in the driver banner again

2012-11-14 Thread Greg KH
On Wed, Nov 14, 2012 at 06:49:50PM +0300, Sergei Shtylyov wrote: Commit 5c8a86e10a7c164f44537fabdc169fd8b4e7a440 (usb: musb: drop unneeded musb_debug trickery) erroneously removed '\n' from the driver's banner. Concatenate all the banner substrings while adding it back... Signed-off-by:

Re: [PATCH] musb_core: print new line in the driver banner again

2012-11-14 Thread Sergei Shtylyov
Hello. On 11/14/2012 06:02 PM, Greg KH wrote: Commit 5c8a86e10a7c164f44537fabdc169fd8b4e7a440 (usb: musb: drop unneeded musb_debug trickery) erroneously removed '\n' from the driver's banner. Concatenate all the banner substrings while adding it back... Signed-off-by: Sergei Shtylyov

Re: [RFC PATCH v2 3/6] usb: add runtime pm support for usb port device

2012-11-14 Thread Lan Tianyu
于 2012/11/14 20:45, Lan Tianyu 写道: 于 2012/11/14 17:49, Rafael J. Wysocki 写道: On Wednesday, November 14, 2012 02:34:37 PM Lan Tianyu wrote: On 2012年11月14日 08:08, Rafael J. Wysocki wrote: On Tuesday, November 13, 2012 04:00:02 PM Lan Tianyu wrote: This patch is to add runtime pm callback for

Re: [PATCH 4/6] usb: chipidea: usbmisc: add support for ahb, ipg and per clock

2012-11-14 Thread Michael Grzeschik
On Wed, Nov 14, 2012 at 03:39:11PM +0200, Alexander Shishkin wrote: Michael Grzeschik m.grzesc...@pengutronix.de writes: From: Marc Kleine-Budde m...@pengutronix.de This patch adds support for ahb, ipg and per clock, which is needed to support imx53. I would also suggest using a

Re: [PATCH 2/6] usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx

2012-11-14 Thread Michael Grzeschik
On Wed, Nov 14, 2012 at 09:57:50AM -0200, Fabio Estevam wrote: Hi Michael, On Wed, Nov 14, 2012 at 9:55 AM, Michael Grzeschik m.grzesc...@pengutronix.de wrote: This driver will be used for every Freescale SoC which has this misc memory layout to control the basic usb handling. So better

[PATCH] Try #3: Use SCSI read/write(16) with 32-bit LBA drives

2012-11-14 Thread Jason J. Herne
From: Jason J. Herne hern...@gmail.com Force large capacity ( 0x blocks) drives to use READ/WRITE(16) instead of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10) commands when a large capacity drive is installed. Signed-off-by: Jason J. Herne hern...@gmail.com ---

Re: problem with Roseweil eusb3 enclosure

2012-11-14 Thread Alan Stern
On Tue, 13 Nov 2012, Sarah Sharp wrote: Hi Alan, I've been working on the warm reset fix patch, and I've run into a couple questions. A draft patch is attached, but it's not in any way done. :) This is indeed a difficult problem to get one's mind around. In hub_events, we check whether

[PATCH 5/9] usb: add phy connection by phy-mode

2012-11-14 Thread Michael Grzeschik
This patch makes it possible to set the connection of the usbphy to the soc. It is derived from the oftree bindings for the ethernetphy and adds similar helperfunctions. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de ---

[PATCH 0/9] chipidea fixes and features

2012-11-14 Thread Michael Grzeschik
Marc Kleine-Budde (2): usb: chipidea: pci: mark platformdata as static and __devinitdata usb: chipidea: ci13xxx-imx: add dr_mode property to device tree bindings Michael Grzeschik (7): usb: chipidea: ci13xxx_imx: add 2nd and 3rd clock to support imx5x and newer usb: chipidea: ci13xxx-imx:

[PATCH 7/9] usb: chipidea: udc: add force-full-speed option

2012-11-14 Thread Michael Grzeschik
This patch makes it possible to set the chipidea udc into full-speed only mode. It can be set by the oftree property force-full-speed. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/usb/chipidea/bits.h |1 +

[PATCH 9/9] usb: chipidea: udc: configure iso endpoints

2012-11-14 Thread Michael Grzeschik
The implementation is derived from the fsl_udc_core code in fsl_ep_enable and makes basic iso handling possible. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/usb/chipidea/udc.c | 12 ++-- 1 file changed, 10

[PATCH 8/9] usb: chipidea: udc: remove unlocked ep_queue which can lead to an race

2012-11-14 Thread Michael Grzeschik
Its not nessecary to call ep_queue unlocked while in the own driver. So we move the function to an unlocked version and call it conditionaly. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/usb/chipidea/udc.c | 115

[PATCH 1/9] usb: chipidea: pci: mark platformdata as static and __devinitdata

2012-11-14 Thread Michael Grzeschik
From: Marc Kleine-Budde m...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/usb/chipidea/ci13xxx_pci.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 3/9] usb: chipidea: ci13xxx-imx: create dynamic platformdata

2012-11-14 Thread Michael Grzeschik
This patch removes the limitation of having only one instance of the ci13xxx-imx platformdata and makes different configurations possible. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- drivers/usb/chipidea/ci13xxx_imx.c |

[PATCH 2/9] usb: chipidea: ci13xxx_imx: add 2nd and 3rd clock to support imx5x and newer

2012-11-14 Thread Michael Grzeschik
This patch adds support for a second and third clock to the chipidea driver. On modern freescale ARM cores like the imx51, imx53 and imx6q three clocks (ahb, ipg and per) must be enabled in order to access the USB core. In the original driver, the clock was requested without specifying the

[PATCH 6/9] usb: chipidea: add PTW and PTS handling

2012-11-14 Thread Michael Grzeschik
This patch makes it possible to configure the PTW and PTS bits inside the portsc register for host and device mode before the driver starts and the phy can be addressed as hardware implementation is designed. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc

[PATCH 4/9] usb: chipidea: ci13xxx-imx: add dr_mode property to device tree bindings

2012-11-14 Thread Michael Grzeschik
From: Marc Kleine-Budde m...@pengutronix.de Its necessary to limit a hostonly soc to its single role, since debugging has shown that reading on the CAP_DCCPARAMS register inside a host-only port, what ci_hdrc_gadget_init does, can lead to an instable behaviour of the IC. This patch allows the

Re: Programatic disconnect and reconnect of USB device

2012-11-14 Thread Graham
Hello Alan, I have a similar issue and not sure if bind/unbind is the solution. I have multiple devices plugged into a hub (gprs modem, webcam,rfid reader) which connects to an SBC running linux 2.6.32.11. Each two of the devices work together and function correctly. However when all three are

Re: patch Revert USB/host: Cleanup unneccessary irq disable code added to usb tree

2012-11-14 Thread Alan Stern
On Tue, 13 Nov 2012 gre...@linuxfoundation.org wrote: From e592c5d0b7db94b485b4a2342db041a1882b7f75 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman gre...@linuxfoundation.org Date: Tue, 13 Nov 2012 10:52:52 -0800 Subject: Revert USB/host: Cleanup unneccessary irq disable code This

Re: [PATCH 9/9] usb: chipidea: udc: configure iso endpoints

2012-11-14 Thread Sergei Shtylyov
Hello. On 11/14/2012 07:19 PM, Michael Grzeschik wrote: The implementation is derived from the fsl_udc_core code in fsl_ep_enable and makes basic iso handling possible. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de ---

Re: [RFC PATCH v2 3/6] usb: add runtime pm support for usb port device

2012-11-14 Thread Alan Stern
On Wed, 14 Nov 2012, Lan Tianyu wrote: Hi Rafael and Alan: This patch has a collaboration problem with pm qos. Since pm core would pm_runtime_get_sync/put(port_dev) if pm qos flags was changed and port's suspend call_back() clear PORT_POWER feature without any check. This will

Re: kmemleak report on isp1763 and sierra MC8705

2012-11-14 Thread Richard Retanubun
On 10/11/12 09:30 AM, Johan Hovold wrote: Hi Johan, There was a reference-count fix for the probe error path that went in to v3.5. Haven't read all the details on how you trigger your leak, but at the face of it, it could be related. Have a look at 0658a3366db7e27fa (usb: use usb_serial_put in

gadget: provide function registration interface, v3

2012-11-14 Thread Sebastian Andrzej Siewior
this is v3 of the gadget interface. v1. first version v2. converted all ACM users v3. removed the generic configuration. This will be added once we have configfs. Comments are greatly appreciated. Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of

[PATCH 01/16] usb/gadget: composite: don't call driver's unbind() if bind() failed

2012-11-14 Thread Sebastian Andrzej Siewior
Lets assume nokia_bind() starts with return -EINVAL. After loading the gadget we end up with: |udc dummy_udc.0: registering UDC driver [g_nokia] |BUG: unable to handle kernel NULL pointer dereference at 0040 |IP: [c11f9555] __list_add+0x25/0xf0 |Call Trace: | [c12d4e21]

[PATCH 05/16] usb/gadget: add some infracture to register/unregister functions

2012-11-14 Thread Sebastian Andrzej Siewior
This patch provides an infrastructure to register unregister a USB function. This allows to turn a function into a module and avoid the '#include f_.*.c' magic and we get a clear API / cut between the bare gadget and its functions. The concept is simple: Each function defines the

[PATCH 08/16] usb/gadget: split the three possible function in g_serial into three bind functions

2012-11-14 Thread Sebastian Andrzej Siewior
This patch factors out the three possible functions into three possible bind functions which are passed as an argument to usb_add_config(). This will ease the step by step converting of the individual functions to the new function registration method. Signed-off-by: Sebastian Andrzej Siewior

[PATCH 09/16] usb/gadget: convert u_serial into a module

2012-11-14 Thread Sebastian Andrzej Siewior
Every user of u_serial has now to select the U_SERIAL symbol instead of including the file. There is one limition with this: ports and and gs_tty_driver are global variables in u_serial. Since all users share them, there can be only one user loaded at a time i.e. either g_serial or g_nokia.

[PATCH 06/16] usb/gadget: convert source sink and loopback to new function interface

2012-11-14 Thread Sebastian Andrzej Siewior
This patch converts the f_sourcesink and f_loopback file to the USB-function module. Both functions shares a few common utility functions which are currently implemented in g_zero.c itself. This patch moves the common code into the sourcesink file and creates one module out of the the two

[PATCH 07/16] usb/gadget: remove empty function in f_acm

2012-11-14 Thread Sebastian Andrzej Siewior
The significant part of this function was removed in 90f7976 (USB: Remove unsupported usb gadget drivers). I would move this to function bind time but I don't see the point in moving an empty function. Therefore bye bye. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de ---

[PATCH 04/16] usb/gadget: move loopback's config descriptor out of f_loopback

2012-11-14 Thread Sebastian Andrzej Siewior
f_loopback should only include the bare function but it also includes the config descriptor. This patch moves the config descriptor into zero.c, the only user of this function. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/gadget/f_loopback.c | 44

[PATCH 03/16] usb/gadget: move source sink's config descriptor out of f_sourcesink

2012-11-14 Thread Sebastian Andrzej Siewior
f_sourcesink should only include the bare function but it also includes the config descriptor. This patch moves the config descriptor into zero.c, the only user of this function. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/gadget/f_sourcesink.c | 48

[PATCH 02/16] usb/gadget: provide a wrapper around SourceSink's setup function

2012-11-14 Thread Sebastian Andrzej Siewior
The setup request can be sent to an interface/endpoint or to the device itself. If it is sent to an interface / endpoint then we forward it to the function that is mapped to that interface / endpoint. If the device is the target of the setup request then we forward it to the -setup() callback of

[PATCH 16/16] usb: gadget: move the global the_dev variable to their users

2012-11-14 Thread Sebastian Andrzej Siewior
the u_ether.c file has a global variable named the_dev which keeps a pointer to the network device after it has been created via gether_setup_name(). It is only used internally by u_ether. This patches moves the variable to its users and passes it via the port.ioport where it is saved later

[PATCH 15/16] usb/gadget: nokia: use function framework for ACM

2012-11-14 Thread Sebastian Andrzej Siewior
This patch converts the acm_ms gadget to make use of the function framework to request the ACM function. With nokia beeing the last user of the include interface, it is gone now. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/gadget/Kconfig|1 +

[PATCH 11/16] usb/gadget: convert f_acm to new function interface with backwards compatibility

2012-11-14 Thread Sebastian Andrzej Siewior
This patch converts f_acm into a module which uses the new function interface. It also converts one of its users that is g_serial to make use of it. The other users of it (g_nokia for instance) are still using the old include file system and should not notice the change at all. So they can be

[PATCH 10/16] usb/gadget: add usb_remove_function()

2012-11-14 Thread Sebastian Andrzej Siewior
This will be used to remove a single function from a given config. Right now ignore that an error at -bind() time and cleanup later during composite_unbind() / remove_config(). Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/gadget/composite.c | 12

[PATCH 14/16] usb/gadget: multi: use function framework for ACM

2012-11-14 Thread Sebastian Andrzej Siewior
This patch converts the acm_ms gadget to make use of the function framework to request the ACM function. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/multi.c | 47 ++-- 2 files

[PATCH 13/16] usb/gadget: cdc2: use function framework for ACM

2012-11-14 Thread Sebastian Andrzej Siewior
This patch converts the acm_ms gadget to make use of the function framework to request the ACM function. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/cdc2.c | 17 - 2 files changed, 13 insertions(+),

[PATCH 12/16] usb/gadget: acm_ms: use function framework for ACM

2012-11-14 Thread Sebastian Andrzej Siewior
This patch converts the acm_ms gadget to make use of the function framework to request the ACM function. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/acm_ms.c | 21 ++--- 2 files changed, 15

Re: Programatic disconnect and reconnect of USB device

2012-11-14 Thread Alan Stern
On Wed, 14 Nov 2012, Graham wrote: Hello Alan, I have a similar issue and not sure if bind/unbind is the solution. I have multiple devices plugged into a hub (gprs modem, webcam,rfid reader) which connects to an SBC running linux 2.6.32.11. Each two of the devices work together and

Re: USB issue with kernel 3.6

2012-11-14 Thread Piergiorgio Sartor
Hi all again, I would like just to re-state the issue and try to rationalize a possible debugging strategy. So my questions would be: 1) Is there any possibility, with a Fedora kernel, to activate some run-time debugging/verbosity option for the USB/ehci/usb-storage subsystem in order to try to

DaVinci MUSB module hang [Was: Re: [PATCH] musb_core: print new line in the driver banner again]

2012-11-14 Thread Sergei Shtylyov
Hello. On 11/14/2012 06:49 PM, Sergei Shtylyov wrote: MUSB driver has been spoiling kernel output since 3.0 and nobody noticed -- I wonder how good it's actually tested (especially given the face that loading DaVinci glue as module just hangs DM6446 EVM board). Felipe, luckily, in-kernel

Re: USB issue with kernel 3.6

2012-11-14 Thread Alan Stern
On Wed, 14 Nov 2012, Piergiorgio Sartor wrote: Hi all again, I would like just to re-state the issue and try to rationalize a possible debugging strategy. So my questions would be: 1) Is there any possibility, with a Fedora kernel, to activate some run-time debugging/verbosity option

Re: [PATCH 4/6] usb: gadget: storage_common: Drop #ifdefs used for the sake of FSG.

2012-11-14 Thread Sebastian Andrzej Siewior
On Wed, Oct 31, 2012 at 09:32:37PM +0100, Michal Nazarewicz wrote: diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c index 3433e43..5d027b3 100644 --- a/drivers/usb/gadget/f_mass_storage.c +++ b/drivers/usb/gadget/f_mass_storage.c @@ -228,10 +228,6 @@

Re: [PATCH 4/6] usb: gadget: storage_common: Drop #ifdefs used for the sake of FSG.

2012-11-14 Thread Sebastian Andrzej Siewior
On Wed, Oct 31, 2012 at 09:32:37PM +0100, Michal Nazarewicz wrote: diff --git a/drivers/usb/gadget/storage_common.c b/drivers/usb/gadget/storage_common.c index b381e0c..1b5bc69 100644 --- a/drivers/usb/gadget/storage_common.c +++ b/drivers/usb/gadget/storage_common.c static __maybe_unused

Re: problem with Roseweil eusb3 enclosure

2012-11-14 Thread Sarah Sharp
On Wed, Nov 14, 2012 at 10:57:44AM -0500, Alan Stern wrote: On Tue, 13 Nov 2012, Sarah Sharp wrote: Hi Alan, I've been working on the warm reset fix patch, and I've run into a couple questions. A draft patch is attached, but it's not in any way done. :) This is indeed a difficult

Re: [PATCH 5/6] usb: gadget: storage_common: Make fsg_lun_is_open() a function.

2012-11-14 Thread Sebastian Andrzej Siewior
On Thu, Nov 01, 2012 at 02:46:56PM +0100, Michal Nazarewicz wrote: ie. f_mass_storage.c is the 5th biggest file in drivers/usb/gadget, so if anything, I would rather split it further into pieces than merge it with storage_common.c adding another 700 lines and producing the biggest file in

Re: 3TB Hard Drive in USB Enclosure Resetting

2012-11-14 Thread Sebastian Andrzej Siewior
On Thu, Nov 08, 2012 at 01:01:43PM -0500, Alan Stern wrote: No. You shouldn't think of this as a USB problem any more; you should consider it a SCSI/ATA problem. Try asking the people on the linux-scsi and linux-ide mailing lists. But keep linux-usb in the CC: list just in case.

Re: [PATCH] Try #2: Use SCSI read/write(16) with 2TB drives

2012-11-14 Thread Sebastian Andrzej Siewior
On Wed, Nov 14, 2012 at 12:55:13AM -0500, Jason J. Herne wrote: --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -887,7 +887,7 @@ static int sd_prep_fn(struct request_queue *q, struct request *rq) SCpnt-cmnd[29] = (unsigned char) (this_count 16) 0xff;

Re: 3TB Hard Drive in USB Enclosure Resetting

2012-11-14 Thread Alan Stern
On Wed, 14 Nov 2012, Sebastian Andrzej Siewior wrote: On Thu, Nov 08, 2012 at 01:01:43PM -0500, Alan Stern wrote: No. You shouldn't think of this as a USB problem any more; you should consider it a SCSI/ATA problem. Try asking the people on the linux-scsi and linux-ide mailing lists.

Re: [Resend PATCH V4 1/4] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-14 Thread Greg KH
On Tue, Nov 13, 2012 at 04:07:17PM +0800, Lan Tianyu wrote: + for (i = 1; i = ports; i++) { + if (usb_get_hub_port_connect_type( + ehci_to_hcd(ehci)-self.root_hub, i) + == USB_PORT_CONNECT_TYPE_HARD_WIRED) +

Re: problem with Roseweil eusb3 enclosure

2012-11-14 Thread Alan Stern
On Wed, 14 Nov 2012, Sarah Sharp wrote: On a device connect, the port can go into either Compliance Mode or Inactive on various link failures. Also, the ports can change state into Inactive if the U1/U2 exit fails. So if we have Link PM enabled for a USB 3.0 device, the port can go into

Re: [RFC PATCH v2 2/6] usb: Add driver/usb/core/port.c file to fill usb port related code.

2012-11-14 Thread Alan Stern
On Tue, 13 Nov 2012, Lan Tianyu wrote: This patch is to create driver/usb/core/port.c and move usb port related code into it. @@ -1237,57 +1227,12 @@ static int hub_post_reset(struct usb_interface *intf) return 0; } -static void usb_port_device_release(struct device *dev) -{ -

[PATCH] Try #3: Use SCSI read/write(16) with 32-bit LBA drives

2012-11-14 Thread Jason J. Herne
From: Jason J. Herne hern...@gmail.com Force large capacity ( 0x blocks) drives to use READ/WRITE(16) instead of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10) commands when a large capacity drive is installed. This issue was reported and discussed here:

Re: [RFC PATCH v2 2/6] usb: Add driver/usb/core/port.c file to fill usb port related code.

2012-11-14 Thread Alan Stern
On Wed, 14 Nov 2012, Alan Stern wrote: This does not belong here; it belongs in your new port.c file. Maybe in drivers/usb/core/usb.h if necessary. Better than usb.h would be to have a drivers/usb/core/hub.h file which could contain stuff that has to be shared between hub.c and port.c but

Re: [PATCH] Try #2: Use SCSI read/write(16) with 2TB drives

2012-11-14 Thread Jason J. Herne
On Wed, Nov 14, 2012 at 2:02 PM, Sebastian Andrzej Siewior sebast...@breakpoint.cc wrote: On Wed, Nov 14, 2012 at 12:55:13AM -0500, Jason J. Herne wrote: } } + /* Use read/write(16) for 2TB disks */ + sdp-use_16_for_rw = (sdkp-capacity 0x); The comment

Re: [PATCH] Try #3: Use SCSI read/write(16) with 32-bit LBA drives

2012-11-14 Thread Sergei Shtylyov
Hello. On 15-11-2012 2:03, Jason J. Herne wrote: From: Jason J. Herne hern...@gmail.com You have already posted Try #3. And preferrably, information about patch version should be included with [PATCH] prefix like this [PATCH v4]. Force large capacity ( 0x blocks) drives to use

Re: [PATCH] Try #3: Use SCSI read/write(16) with 32-bit LBA drives

2012-11-14 Thread Jason J. Herne
On Wed, Nov 14, 2012 at 5:22 PM, Sergei Shtylyov sshtyl...@mvista.com wrote: Hello. On 15-11-2012 2:03, Jason J. Herne wrote: From: Jason J. Herne hern...@gmail.com You have already posted Try #3. And preferrably, information about patch version should be included with [PATCH] prefix

Re: [PATCH v6 1/4] Revert usb: otg: mxs-phy: Fix mx23 operation

2012-11-14 Thread Peter Chen
Hi Greg, As this serial includes both usb phy and usb core changes, can you help to take over it? Both Felipe and Alan have added their Acked-by. Thanks. On Fri, Nov 09, 2012 at 09:44:41AM +0800, Peter Chen wrote: Signed-off-by: Peter Chen peter.c...@freescale.com Acked-by: Felipe Balbi

Re: [PATCH v6 1/4] Revert usb: otg: mxs-phy: Fix mx23 operation

2012-11-14 Thread Greg KH
On Thu, Nov 15, 2012 at 11:30:22AM +0800, Peter Chen wrote: Hi Greg, As this serial includes both usb phy and usb core changes, can you help to take over it? Both Felipe and Alan have added their Acked-by. Thanks. Ok, I'll queue them up in a day or so. thanks, greg k-h -- To unsubscribe

Re: [PATCH] Try #3: Use SCSI read/write(16) with 32-bit LBA drives

2012-11-14 Thread Felipe Balbi
Hi, On Wed, Nov 14, 2012 at 08:06:20PM -0500, Jason J. Herne wrote: On Wed, Nov 14, 2012 at 5:22 PM, Sergei Shtylyov sshtyl...@mvista.com wrote: Hello. On 15-11-2012 2:03, Jason J. Herne wrote: From: Jason J. Herne hern...@gmail.com You have already posted Try #3. And

Re: [PATCH 2/4] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2012-11-14 Thread Peter Chen
On Tue, Nov 13, 2012 at 02:25:59PM +0200, Alexander Shishkin wrote: Alex, Thanks for review. At new design, when role switch occurs, the gadget just calls usb_gadget_vbus_disconnect/usb_gadget_vbus_connect as well as reset controller, it will not free any device/gadget structure ...but