RE: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-28 Thread Andrzej Pietrasiewicz
On Tuesday, November 27, 2012 5:00 PM Sebastian Andrzej Siewior wrote: On 11/27/2012 09:57 AM, Andrzej Pietrasiewicz wrote: |mkdir -p $FABRIC/naa.6001405c3214b06a/tpgt_1 |mkdir $FABRIC/naa.6001405c3214b06a/tpgt_1/lun/lun_0 |mkdir $FABRIC/naa.6001405c3214b06a/tpgt_1/lun/lun_1 So you

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-28 Thread Sebastian Andrzej Siewior
On 11/27/2012 05:23 PM, Michal Nazarewicz wrote: On Tue, Nov 27 2012, Sebastian Andrzej Siewior wrote: I don't want to push python on anyone but the removal magic is simply straight forward: unlink the disk ports, rmdir luns, tpgt,… How should a generic tool know what kind of actions are

Re: [PATCH 1/2] smsc75xx: refactor entering suspend modes

2012-11-28 Thread Steve Glendinning
Hi Alan, udev-do_remote_wakeup is set in choose_wakeup() in drivers/usb/core/driver.c. AFAICS it is always set as long as device_may_wakeup(udev-dev) is true. That's right. But is device_may_wakeup(udev-dev) true? By default it wouldn't be. The normal way to set it is for the user or a

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-28 Thread Sebastian Andrzej Siewior
On 11/28/2012 09:10 AM, Andrzej Pietrasiewicz wrote: Here I understand it. This is to some point a limitation of the gadget framework. We do know the number of interface that will be available before we bind. We simply don't know the endpoint number. There are two exceptions to what I just

Re: USB 2.0: No giveback comes for one submitted URB

2012-11-28 Thread amit nagal
On Thu, Nov 22, 2012 at 6:50 PM, naveen yadav yad.nav...@gmail.com wrote: urb_count is incremented at only one place in usb_hcd_submit_urb() and decremented in usb_hcd_giveback_urb(). (Also, in error case inside usb_hcd_submit_urb()). After taking print of urb-use_count at all Hi Alan , In

Re: [PATCH v6 2/6] PM / Runtime: introduce pm_runtime_set_memalloc_noio()

2012-11-28 Thread Rafael J. Wysocki
On Wednesday, November 28, 2012 12:34:36 PM Ming Lei wrote: On Wed, Nov 28, 2012 at 5:19 AM, Rafael J. Wysocki r...@sisk.pl wrote: Please use counters instead of walking the whole path every time. Ie. in addition to the flag add a counter to store the number of the device's children

Re: [PATCH 1/2] smsc75xx: refactor entering suspend modes

2012-11-28 Thread Bjørn Mork
Steve Glendinning st...@shawell.net writes: udev-do_remote_wakeup is set in choose_wakeup() in drivers/usb/core/driver.c. AFAICS it is always set as long as device_may_wakeup(udev-dev) is true. That's right. But is device_may_wakeup(udev-dev) true? By default it wouldn't be. The normal

Re: [PATCH v6 2/6] PM / Runtime: introduce pm_runtime_set_memalloc_noio()

2012-11-28 Thread Ming Lei
On Wed, Nov 28, 2012 at 5:29 PM, Rafael J. Wysocki r...@sisk.pl wrote: But it doesn't have to walk the children. Moreover, with counters it only Yeah, I got it, it is the advantage of counter, but with extra 'int' field introduced in 'struct device'. needs to walk the whole path if all

Re: [PATCH v6 2/6] PM / Runtime: introduce pm_runtime_set_memalloc_noio()

2012-11-28 Thread Rafael J. Wysocki
On Wednesday, November 28, 2012 11:57:19 AM Ming Lei wrote: On Wed, Nov 28, 2012 at 5:19 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday, November 24, 2012 08:59:14 PM Ming Lei wrote: The patch introduces the flag of memalloc_noio in 'struct dev_pm_info' to help PM core to teach mm

Re: [PATCH v6 2/6] PM / Runtime: introduce pm_runtime_set_memalloc_noio()

2012-11-28 Thread Rafael J. Wysocki
On Wednesday, November 28, 2012 05:47:18 PM Ming Lei wrote: On Wed, Nov 28, 2012 at 5:29 PM, Rafael J. Wysocki r...@sisk.pl wrote: But it doesn't have to walk the children. Moreover, with counters it only Yeah, I got it, it is the advantage of counter, but with extra 'int' field

Re: [PATCH 1/2] smsc75xx: refactor entering suspend modes

2012-11-28 Thread Steve Glendinning
Hi Bjorn, On 28 November 2012 09:31, Bjørn Mork bj...@mork.no wrote: Remote wakeup will not be enabled on system suspend unless the user (or a userspace program on the users behalf) has requested it. If a user types ethtool -s eth2 wol p they *are* explicitly requesting the ethernet device to

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-11-28 Thread Roger Quadros
On 11/27/2012 09:22 PM, Andy Green wrote: On 11/28/2012 02:09 AM, the mail apparently from Alan Stern included: On Wed, 28 Nov 2012, Andy Green wrote: Greg's advice was simply not to rely on pathnames in sysfs because they aren't fixed in stone. That leaves plenty of other ways to approach

Re: [PATCH 1/2] smsc75xx: refactor entering suspend modes

2012-11-28 Thread Bjørn Mork
Steve Glendinning st...@shawell.net writes: Hi Bjorn, On 28 November 2012 09:31, Bjørn Mork bj...@mork.no wrote: Remote wakeup will not be enabled on system suspend unless the user (or a userspace program on the users behalf) has requested it. If a user types ethtool -s eth2 wol p they

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-11-28 Thread Andy Green
On 11/28/2012 07:13 PM, the mail apparently from Roger Quadros included: On 11/27/2012 09:22 PM, Andy Green wrote: On 11/28/2012 02:09 AM, the mail apparently from Alan Stern included: On Wed, 28 Nov 2012, Andy Green wrote: Greg's advice was simply not to rely on pathnames in sysfs because

Re: [PATCH 1/2] smsc75xx: refactor entering suspend modes

2012-11-28 Thread Steve Glendinning
Looking at the different ethernet drivers, the normal way do do this seems to be something like this in their .set_wol implementation: device_set_wakeup_enable(adapter-pdev-dev, adapter-wol); where adapter is a netdev_priv private struct, pdev is a pci device and wol is an u32. I

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-11-28 Thread Roger Quadros
On 11/28/2012 01:47 PM, Andy Green wrote: On 11/28/2012 07:13 PM, the mail apparently from Roger Quadros included: On 11/27/2012 09:22 PM, Andy Green wrote: On 11/28/2012 02:09 AM, the mail apparently from Alan Stern included: On Wed, 28 Nov 2012, Andy Green wrote: Greg's advice was simply

Re: [PATCH 1/2] smsc75xx: refactor entering suspend modes

2012-11-28 Thread Bjørn Mork
Steve Glendinning st...@shawell.net writes: Looking at the different ethernet drivers, the normal way do do this seems to be something like this in their .set_wol implementation: device_set_wakeup_enable(adapter-pdev-dev, adapter-wol); where adapter is a netdev_priv private struct,

[try#1 PATCH 0/7] Introduce device_asset and use to control Panda HUB+ETH power and clock

2012-11-28 Thread Andy Green
The following series implements the device_asset addition to struct device that has been discussed on the usb and omap lists with Alan Stern and GKH. Several of the ideas here are from Alan Stern. First we add the new struct to linux/device.h and cause it to be used just before device probe with

[try#1 PATCH 1/7] drivers: base: introduce device assets

2012-11-28 Thread Andy Green
This patch adds support for a new struct device member assets which may point to an array of struct assets. The array is terminated by one with a NULL pre_probe callback. These assets consist of named (in .name) or anonymous object pointers (.data) operated on by specified callbacks. A void *

[try#1 PATCH 2/7] regulator: core: add default device asset handlers

2012-11-28 Thread Andy Green
This adds default device_asset handlers for struct regulator. If you want an associated regulator asset of a device to be powered before probe, and depowered after removal, these callbacks will take care of everything including get and put. By defining them here in regulator core, code

[try#1 PATCH 3/7] clk: add default device asset handlers

2012-11-28 Thread Andy Green
This adds default device_asset handlers for struct clk. If you want an associated clk asset of a device to be optionally set, and enabled before probe, and disabled after removal, these callbacks will take care of everything including get and put. By defining them here in regulator core, code

[try#1 PATCH 4/7] usb: omap ehci: remove all regulator control from ehci omap

2012-11-28 Thread Andy Green
This series migrates it to be assets of the logical ehci-omap.0 device object. Signed-off-by: Andy Green andy.gr...@linaro.org --- arch/arm/mach-omap2/usb-host.c|1 - arch/arm/plat-omap/include/plat/usb.h |7 -- drivers/usb/host/ehci-omap.c | 37

[try#1 PATCH 5/7] omap4: panda: add smsc95xx regulator and reset dependent on root hub

2012-11-28 Thread Andy Green
This adds regulators which are controlled by the OMAP4 PandaBoard (ES)'s EHCI logical root hub existing. The regulators are made a device_asset of the EHCI logical root hub by passing them through the hsusb - mfd path. Although the ehci-related platform_device is created at boot time, it is not

[try#1 PATCH 6/7] omap4 panda add smsc95xx clock dependent on root hub

2012-11-28 Thread Andy Green
This patch makes the ULPI PHY clock control also be a device_asset of the ehci-omap.0 device, along with the [HUB + ETH] smsc95xx chip power regulator. Without clock control, the PHY clock is running all the time from boot whether USB is in use or not, and during suspend distorting power

[try#1 PATCH 7/7] config omap2plus add ehci bits

2012-11-28 Thread Andy Green
omap2plus seems to have rotted a bit, this is the delta that appears if we enable modular build for ehci-hcd and smsc95xx. Signed-off-by: Andy Green andy.gr...@linaro.org --- arch/arm/configs/omap2plus_defconfig | 42 ++ 1 file changed, 17 insertions(+), 25

Re: [PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-11-28 Thread Tomasz Figa
Hi Praveen, On Friday 23 of November 2012 09:56:37 Praveen Paneri wrote: +static void samsung_usbphy_enable(struct samsung_usbphy *sphy) +{ + void __iomem *regs = sphy-regs; + u32 phypwr; + u32 phyclk; + u32 rstcon; + + /* set clock frequency for PLL */ +

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-28 Thread Michal Nazarewicz
On 11/27/2012 05:23 PM, Michal Nazarewicz wrote: How should a generic tool know what kind of actions are needed for given function to be removed? If you ask me, there should be a way to unbind gadget and unload all modules without any specific knowledge of the functions. If there is no such

Re: [PATCH v8 2/2] usb: s3c-hsotg: Adding phy driver support

2012-11-28 Thread Tomasz Figa
Hi Praveen, On Friday 23 of November 2012 09:54:51 Praveen Paneri wrote: We will anyway remove the platform data part soon. If you say I can resend it again. I think that the requirement for platform data on DT-enabled systems should be removed before this series get merged, because there are

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-28 Thread Sebastian Andrzej Siewior
On 11/28/2012 02:05 PM, Michal Nazarewicz wrote: On 11/27/2012 05:23 PM, Michal Nazarewicz wrote: How should a generic tool know what kind of actions are needed for given function to be removed? If you ask me, there should be a way to unbind gadget and unload all modules without any specific

Re: [PATCH v6 2/6] PM / Runtime: introduce pm_runtime_set_memalloc_noio()

2012-11-28 Thread Ming Lei
On Wed, Nov 28, 2012 at 6:06 PM, Rafael J. Wysocki r...@sisk.pl wrote: Well, it may be unfrequent, but does it mean it has to do things that may be avoided (ie. walking the children of every node in the path in some cases)? I agree so without introducing extra cost, :-) I don't really think

RE: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-28 Thread Andrzej Pietrasiewicz
On Wednesday, November 28, 2012 9:39 AM Sebastian Andrzej Siewior wrote: snip so that we can create the endpoint directories. And now what? What names shall the user use for the endpoint directories? Oh, that's simple: just see what the endpoint directories' names are. But wait, aren't

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-28 Thread Michal Nazarewicz
On Wed, Nov 28 2012, Sebastian Andrzej Siewior wrote: function_name-common_name /functions/acm-function/ instead of common_name /functions/function1/ +name with attribute file named name which contains the name of the function (i.e. acm). My

[PATCH v2 00/22] OMAP USB Host cleanup

2012-11-28 Thread Roger Quadros
Hi, This patchset addresses the following - Avoid addressing clocks one by one by name and use a for loop + bunch of cleanups. - Get number of channels/ports dynamically either from revision register or from platform data. Avoids getting clocks that are not present. - Add OMAP5 and HSIC mode

[PATCH v2 01/22] mfd: omap-usb-tll: Avoid creating copy of platform data

2012-11-28 Thread Roger Quadros
Just a pointer to the platform data should suffice. Signed-off-by: Roger Quadros rog...@ti.com Acked-by: Felipe Balbi ba...@ti.com --- drivers/mfd/omap-usb-tll.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/omap-usb-tll.c

[PATCH v2 02/22] mfd: omap-usb-tll: Fix channel count detection

2012-11-28 Thread Roger Quadros
Fix channel count detecion for REV2. Also, don't give up if we don't recognize the IP Revision. We assume the default number of channels (i.e. 3) for unrecognized IPs. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-tll.c | 20 +++- 1 files changed, 11

[PATCH v2 03/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path

2012-11-28 Thread Roger Quadros
Use devm_ variants of kzalloc() and ioremap(). Simplify the error path. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-tll.c | 37 +++-- 1 files changed, 11 insertions(+), 26 deletions(-) diff --git a/drivers/mfd/omap-usb-tll.c

[PATCH v2 05/22] mfd: omap-usb-tll: introduce and use mode_needs_tll()

2012-11-28 Thread Roger Quadros
This is a handy macro to check if the port requires the USB TLL module or not. Use it to Enable the TLL module and manage the clocks. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-tll.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff

[PATCH v2 06/22] mfd: omap-usb-tll: Check for missing platform data in probe

2012-11-28 Thread Roger Quadros
No need to check for missing platform data in runtime_suspend/resume as it makes more sense to do it in the probe function. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-tll.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git

[PATCH v2 09/22] mfd: omap-usb-tll: Add OMAP5 revision and HSIC support

2012-11-28 Thread Roger Quadros
The TLL module on OMAP5 has 3 channels. HSIC mode requires the TLL channel to be in Transparent UTMI mode. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-tll.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/drivers/mfd/omap-usb-tll.c

[PATCH v2 04/22] mfd: omap-usb-tll: Clean up clock handling

2012-11-28 Thread Roger Quadros
Every channel has a functional clock that is similarly named. It makes sense to use a for loop to manage these clocks as OMAPs can come with up to 3 channels. Dynamically allocate and get channel clocks depending on the number of clocks avaiable on the platform. Signed-off-by: Roger Quadros

[PATCH v2 07/22] mfd: omap-usb-tll: Fix error message

2012-11-28 Thread Roger Quadros
omap_enable/disable_tll() can fail if TLL device is not initialized. It could be due to multiple reasons and not only due to missing platform data. Also make local variables static and use 'struct device *' instead of 'struct platform_device *' for global reference. Signed-off-by: Roger Quadros

[PATCH v2 11/22] mfd: omap-usb-host: Use devm_kzalloc() and devm_request_and_ioremap()

2012-11-28 Thread Roger Quadros
Use devm_ variants of kzalloc and ioremap. Also clean up error path. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 36 +--- 1 files changed, 9 insertions(+), 27 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c

[PATCH v2 13/22] mfd: omap-usb-host: override number of ports from platform data

2012-11-28 Thread Roger Quadros
Both OMAP4 and 5 exhibit the same revision ID in the REVISION register but they have different number of ports i.e. 2 and 3 respectively. So we can't rely on REVISION register for number of ports on OMAP5 and depend on platform data (or device tree) instead. Signed-off-by: Roger Quadros

[PATCH v2 14/22] mfd: omap-usb-host: cleanup clock management code

2012-11-28 Thread Roger Quadros
All ports have similarly named port clocks so we can bunch them into a port data structure and use for loop to enable/disable the clocks. Dynamically allocate and get clocks based on number of ports available on the platform Signed-off-by: Roger Quadros rog...@ti.com ---

[PATCH v2 15/22] ARM: OMAP2+: clock data: Merge utmi_px_gfclk into usb_host_hs_utmi_px_clk

2012-11-28 Thread Roger Quadros
There is no such clock as utmi_p1_gfclk. It is only a clock selector bit to select th the parent of usb_host_hs_utmi_p1_clk. So we get rid of utmi_p1_gfclk and utmi_p2_gfclk by merging them into usb_host_hs_utmi_p1_clk and usb_host_hs_utmi_p2_clk respectively. CC: Benoit Cousson b-cous...@ti.com

[PATCH v2 16/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2012-11-28 Thread Roger Quadros
Enable the optional HSIC clocks (60MHz and 480MHz) for the ports that are configured in HSIC mode. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 77 +++--- 1 files changed, 71 insertions(+), 6 deletions(-) diff --git

[PATCH v2 18/22] mfd: omap-usb-host: get rid of cpu_is_omap..() macros

2012-11-28 Thread Roger Quadros
Instead of using cpu_is_omap..() macros in the device driver we rely on information provided in the platform data. The only information we need is whether the USB Host module has a single ULPI bypass control bit for all ports or individual bypass control bits for each port. OMAP3 REV2.1 and

[PATCH v2 17/22] mfd: omap-usb-host: Get rid of unnecessary spinlock

2012-11-28 Thread Roger Quadros
The driver does not have an interrupt handler and we don't really need a spinlock, so get rid of it. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 16 1 files changed, 0 insertions(+), 16 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c

[PATCH v2 19/22] mfd: omap-usb-host: clean up omap_usbhs_init()

2012-11-28 Thread Roger Quadros
We split initializing revision 1 and revision 2 into different functions. Initialization is now done dynamically so that only the number of ports available on the system are initialized. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 122

[PATCH v2 21/22] ARM: OMAP2+: clock data: get rid of unused USB host clock aliases

2012-11-28 Thread Roger Quadros
We don't need multiple aliases for the OMAP USB host clocks so remove them. Also use NULL dev_id for 'usb_tll_hs_usb_ch0_clk' and 'usb_tll_hs_usb_ch1_clk' Signed-off-by: Roger Quadros rog...@ti.com CC: Paul Walmsley p...@pwsan.com --- arch/arm/mach-omap2/clock3xxx_data.c | 11 --- 1

[PATCH v2 22/22] mfd: omap-usb-host: Don't spam console on clk_set_parent failure

2012-11-28 Thread Roger Quadros
clk_set_parent is expected to fail on OMAP3 platforms. We don't consider that as fatal so don't spam console. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c

[PATCH v2 20/22] USB: ehci-omap: Don't free gpios that we didn't request

2012-11-28 Thread Roger Quadros
This driver does not request any gpios so don't free them. Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd with ehci-omap in use. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/usb/host/ehci-omap.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git

[PATCH v2 12/22] mfd: omap-usb-host: know about number of ports from revision register

2012-11-28 Thread Roger Quadros
The revision register should tell us how many ports are present. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 32 +++- 1 files changed, 27 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c

[PATCH v2 10/22] mfd: omap_usb_host: Avoid creating copy of platform_data

2012-11-28 Thread Roger Quadros
We can just hold the pointer to the platform data instead of creating a copy of it. Also get rid of the unnecessary missing platform data checks in runtime_suspend/resume. We are already checking for missing platform data in probe. Signed-off-by: Roger Quadros rog...@ti.com Acked-by: Felipe

[PATCH v2 08/22] mfd: omap-usb-tll: serialize access to TLL device

2012-11-28 Thread Roger Quadros
Get rid of the unnecessary spin_lock_irqsave/restore() as there is no interrupt handler for this driver. Instead we serialize access to tll_dev using a global spinlock. Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-tll.c | 53 ++- 1

Re: [try#1 PATCH 5/7] omap4: panda: add smsc95xx regulator and reset dependent on root hub

2012-11-28 Thread Roger Quadros
On 11/28/2012 02:59 PM, Andy Green wrote: This adds regulators which are controlled by the OMAP4 PandaBoard (ES)'s EHCI logical root hub existing. The regulators are made a device_asset of the EHCI logical root hub by passing them through the hsusb - mfd path. Although the ehci-related

Re: [PATCH] net: qmi_wwan: add Huawei E173

2012-11-28 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Sun, 25 Nov 2012 17:03:59 +0100 The Huawei E173 is a QMI/wwan device which normally appear as 12d1:1436 in Linux. The descriptors displayed in that mode will be picked up by cdc_ether. But the modem has another mode with a different device ID and a

Re: USB 2.0: No giveback comes for one submitted URB

2012-11-28 Thread Alan Stern
On Wed, 28 Nov 2012, Vivek Bhagat wrote: Hi Alan, In function usb_hcd_giveback_urb() , urb completion handler is called first followed by decrement of urb-use_count . usb_hcd_giveback_urb(){ ... urb-complete (urb); atomic_dec (urb-use_count); ... } In urb completion handler , urb is

Re: [PATCH v2 13/22] mfd: omap-usb-host: override number of ports from platform data

2012-11-28 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [121128 06:52]: Both OMAP4 and 5 exhibit the same revision ID in the REVISION register but they have different number of ports i.e. 2 and 3 respectively. So we can't rely on REVISION register for number of ports on OMAP5 and depend on platform data (or device

Re: [PATCH v2 18/22] mfd: omap-usb-host: get rid of cpu_is_omap..() macros

2012-11-28 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [121128 06:51]: Instead of using cpu_is_omap..() macros in the device driver we rely on information provided in the platform data. The only information we need is whether the USB Host module has a single ULPI bypass control bit for all ports or individual bypass

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-11-28 Thread Alan Stern
On Wed, 28 Nov 2012, Roger Quadros wrote: board file: static struct regulator myreg = { .name = mydevice-regulator, }; static struct device_asset mydevice_assets[] = { { .name = mydevice-regulator, .handler =

Re: [PATCH v2 18/22] mfd: omap-usb-host: get rid of cpu_is_omap..() macros

2012-11-28 Thread Roger Quadros
On 11/28/2012 06:36 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [121128 06:51]: Instead of using cpu_is_omap..() macros in the device driver we rely on information provided in the platform data. The only information we need is whether the USB Host module has a single ULPI bypass

Re: [PATCH 1/2] smsc75xx: refactor entering suspend modes

2012-11-28 Thread Steve Glendinning
+ + ret = device_set_wakeup_enable(net-dev, pdata-wolopts); You are touching the network device here. That should have been the USB device. Try something like ret = device_set_wakeup_enable(dev-udev-dev, pdata-wolopts); Perfect, this works exactly as expected now. Patch included in

Re: [PATCH 06/10] usb: Add driver/usb/core/(port.c,hub.h) files

2012-11-28 Thread Alan Stern
On Tue, 27 Nov 2012, Sarah Sharp wrote: Hi Alan, Could you take a look at this patchset since you asked Tianyu to refactor the hub code into new files? Yes, sorry. I've been busy. Tianyu, I think you shouldn't move all the #include lines from hub.c into hub.h. At most, hub.h should have

Re: [PATCH 07/10] usb: add runtime pm support for usb port device

2012-11-28 Thread Alan Stern
On Sat, 17 Nov 2012, Lan Tianyu wrote: This patch is to add runtime pm callback for usb port device. Set/clear PORT_POWER feature in the resume/suspend callbak. Add portnum for struct usb_port to record port number. Do pm_rumtime_get_sync/put(portdev) when a device is plugged/unplugged to

Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-28 Thread Alan Stern
On Sat, 17 Nov 2012, Lan Tianyu wrote: ACPI provide _PLD and _UPC aml methods to describe usb port visibility and connectability. This patch is to use those information to change ehci root hub descriptors and set usb hub port's DeviceRemovable in the hub_configure(). When hub descriptor

Re: [PATCH 09/10] usb: expose usb port's pm qos flags to user space

2012-11-28 Thread Alan Stern
On Sat, 17 Nov 2012, Lan Tianyu wrote: This patch is to expose usb port's pm qos flags(pm_qos_no_power_off, pm_qos_remote_wakeup) to user space. User can set pm_qos_no_power_off flag to prohibit the port from being power off. Do we really need this? The user already can prevent the port from

Re: [PATCH 09/10] usb: expose usb port's pm qos flags to user space

2012-11-28 Thread Rafael J. Wysocki
On Wednesday, November 28, 2012 12:44:02 PM Alan Stern wrote: On Sat, 17 Nov 2012, Lan Tianyu wrote: This patch is to expose usb port's pm qos flags(pm_qos_no_power_off, pm_qos_remote_wakeup) to user space. User can set pm_qos_no_power_off flag to prohibit the port from being power off.

[PATCH] USB: mark uas driver as BROKEN

2012-11-28 Thread Greg KH
As reported https://bugzilla.kernel.org/show_bug.cgi?id=51031, the UAS driver causes problems and has been asked to be not built into any of the major distributions. To prevent users from running into problems with it, and for distros that were not notified, just mark the whole thing as broken.

Re: problem with Roseweil eusb3 enclosure

2012-11-28 Thread Sarah Sharp
On Thu, Nov 22, 2012 at 06:15:15AM -0500, cov...@ccs.covici.com wrote: Well, sorry to say that patch did not work, either. Here is the log output. Well, shoot. I'm sorry, John, but I've run out of ideas about how to fix this device. Without a bus analyzer, it would be difficult to figure out

Re: [PATCH] USB: mark uas driver as BROKEN

2012-11-28 Thread Sarah Sharp
Thanks Greg. Do you want to queue this up or should I? (Also, are you still accepting usb-next pull requests? I have a minor patch for you.) Sarah On Wed, Nov 28, 2012 at 10:19:16AM -0800, Greg KH wrote: As reported https://bugzilla.kernel.org/show_bug.cgi?id=51031, the UAS driver causes

Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-28 Thread Sarah Sharp
On Wed, Nov 28, 2012 at 12:39:14PM -0500, Alan Stern wrote: On Sat, 17 Nov 2012, Lan Tianyu wrote: --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1546,6 +1546,25 @@ static int hub_configure(struct usb_hub *hub, dev_err(hub-intfdev,

Re: [PATCH] USB: mark uas driver as BROKEN

2012-11-28 Thread Greg KH
On Wed, Nov 28, 2012 at 10:35:37AM -0800, Sarah Sharp wrote: Thanks Greg. Do you want to queue this up or should I? I will, can I get your ack for it? (Also, are you still accepting usb-next pull requests? I have a minor patch for you.) If it's minor stuff, yes, I'll gladly take it.

[RFC] usb/gadget: slow start of the configfs interface

2012-11-28 Thread Sebastian Andrzej Siewior
|# modprobe dummy_hcd num=2 |# find /sys/kernel/config/ -ls | 65470 drwxr-xr-x 5 root root0 Nov 28 19:39 /sys/kernel/config/ | 5320 drwxr-xr-x 2 root root0 Nov 28 19:39 /sys/kernel/config/dummy_udc.1 | 5310 drwxr-xr-x 2 root root

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-28 Thread Sebastian Andrzej Siewior
On 11/28/2012 03:24 PM, Michal Nazarewicz wrote: On Wed, Nov 28 2012, Sebastian Andrzej Siewior wrote: function_name-common_name /functions/acm-function/ instead of common_name /functions/function1/ +name with attribute file named name which

Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-28 Thread Alan Stern
On Wed, 28 Nov 2012, Sarah Sharp wrote: On Wed, Nov 28, 2012 at 12:39:14PM -0500, Alan Stern wrote: On Sat, 17 Nov 2012, Lan Tianyu wrote: --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1546,6 +1546,25 @@ static int hub_configure(struct usb_hub *hub,

Re: [PATCH] USB: mark uas driver as BROKEN

2012-11-28 Thread Sarah Sharp
On Wed, Nov 28, 2012 at 10:19:16AM -0800, Greg KH wrote: As reported https://bugzilla.kernel.org/show_bug.cgi?id=51031, the UAS driver causes problems and has been asked to be not built into any of the major distributions. To prevent users from running into problems with it, and for distros

Re: [PATCH 09/10] usb: expose usb port's pm qos flags to user space

2012-11-28 Thread Alan Stern
On Wed, 28 Nov 2012, Rafael J. Wysocki wrote: On Wednesday, November 28, 2012 12:44:02 PM Alan Stern wrote: On Sat, 17 Nov 2012, Lan Tianyu wrote: This patch is to expose usb port's pm qos flags(pm_qos_no_power_off, pm_qos_remote_wakeup) to user space. User can set pm_qos_no_power_off

[Pull Request] xHCI patch for 3.8

2012-11-28 Thread Sarah Sharp
The following changes since commit ffa5c41c81503b6f48fddb5d39f18af526ded8d3: uwb: fix uwb_dev_unlock() missed at an error path in uwb_rc_cmd_async() (2012-11-26 15:58:43 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git

[PATCH 1/1] xhci: Add Lynx Point LP to list of Intel switchable hosts

2012-11-28 Thread Sarah Sharp
From: Russell Webb russell.w...@linux.intel.com Like Lynx Point, Lynx Point LP is also switchable. See 1c12443ab8eba71a658fae4572147e56d1f84f66 for more details. This patch should be backported to stable kernels as old as 3.0, that contain commit 69e848c2090aebba5698a1620604c7dccb448684 Intel

Re: problem with Roseweil eusb3 enclosure

2012-11-28 Thread covici
Suppose, I send you a log where I don't plug in the device till the system is up -- would that give you a hint? Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Thu, Nov 22, 2012 at 06:15:15AM -0500, cov...@ccs.covici.com wrote: Well, sorry to say that patch did not work, either. Here is

Re: [PATCH 08/10] usb: add usb port auto power off mechanism

2012-11-28 Thread Alan Stern
On Sat, 17 Nov 2012, Lan Tianyu wrote: This patch is to add usb port auto power off mechanism. When usb device is suspending, usb core will suspend usb port and usb port runtime pm callback will clear PORT_POWER feature to power off port if all conditions were met. These conditions are

Re: [PATCH 10/10] usb: add usb port's pm qos flags request to change NO_POWER_OFF flag

2012-11-28 Thread Alan Stern
On Sat, 17 Nov 2012, Lan Tianyu wrote: Some usb devices can't be resumed correctly after power off. This patch is to add pm qos flags request to change NO_POWER_OFF and provide usb_device_allow_power_off() for device drivers to allow or prohibit usb core to power off the device. What happens

Re: [PATCH 06/10] usb: Add driver/usb/core/(port.c,hub.h) files

2012-11-28 Thread Alan Stern
On Sat, 17 Nov 2012, Lan Tianyu wrote: This patch is to create driver/usb/core/(port.c,hub.h) files and move usb port related code into port.c. One more thing -- this patch should be 1/10, not 6/10. The way you've organized it now, the patches in between add code to hub.c which then has to be

Re: [RFC] usb/gadget: slow start of the configfs interface

2012-11-28 Thread Michal Nazarewicz
Looks nice. :] On Wed, Nov 28 2012, Sebastian Andrzej Siewior wrote: |# modprobe dummy_hcd num=2 |# find /sys/kernel/config/ -ls | 65470 drwxr-xr-x 5 root root0 Nov 28 19:39 /sys/kernel/config/ | 5320 drwxr-xr-x 2 root root0 Nov 28 19:39

Re: problem with Roseweil eusb3 enclosure

2012-11-28 Thread Sarah Sharp
On Wed, Nov 28, 2012 at 02:30:07PM -0500, cov...@ccs.covici.com wrote: Suppose, I send you a log where I don't plug in the device till the system is up -- would that give you a hint? I think you already did? ISTR that the device does not go into compliance mode if it's plugged in after the

Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-28 Thread Sarah Sharp
On Wed, Nov 28, 2012 at 01:56:46PM -0500, Alan Stern wrote: On Wed, 28 Nov 2012, Sarah Sharp wrote: On Wed, Nov 28, 2012 at 12:39:14PM -0500, Alan Stern wrote: Instead, how about sticking the new code into a separate function: void hub_adjust_DeviceRemovable(struct usb_device

Re: Unreliable USB3 with NEC uPD720200 and Delock Cardreader

2012-11-28 Thread Sarah Sharp
On Mon, Nov 26, 2012 at 10:48:03PM +0100, Bjørn Mork wrote: Sarah Sharp sarah.a.sh...@linux.intel.com writes: It looks like both Ulrich and Andrew have the same issue. I also have a Lenovo x220, and I confirmed that when I turn on PCI runtime suspend, the NEC host controller does not

Re: [PATCH 01/10] USB: Set usb port's DeviceRemovable according acpi information in EHCI

2012-11-28 Thread Alan Stern
On Wed, 28 Nov 2012, Sarah Sharp wrote: The shared code to overwrite the bits should probably print a warning if the host and ACPI bits differ. I'm not so sure about that. For one thing, who wants warnings to be logged every time they run lsusb -v? Yeah, that's probably not a

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-11-28 Thread Ming Lei
On Thu, Nov 29, 2012 at 12:43 AM, Alan Stern st...@rowland.harvard.edu wrote: On Wed, 28 Nov 2012, Roger Quadros wrote: board file: static struct regulator myreg = { .name = mydevice-regulator, }; static struct device_asset mydevice_assets[] = { {

Re: [PATCH 06/10] usb: Add driver/usb/core/(port.c,hub.h) files

2012-11-28 Thread Lan Tianyu
On 2012年11月29日 01:27, Alan Stern wrote: On Tue, 27 Nov 2012, Sarah Sharp wrote: Hi Alan, Could you take a look at this patchset since you asked Tianyu to refactor the hub code into new files? Yes, sorry. I've been busy. Oh. Never mind. Great thanks for your review.:) Tianyu, I think

Re: USB 2.0: No giveback comes for one submitted URB

2012-11-28 Thread amit nagal
On Wed, Nov 28, 2012 at 9:58 PM, Alan Stern st...@rowland.harvard.edu wrote: Vivek and Amit, are you two copies of the same person? No . Actually vivek's post to linux-usb forum failed . so i ended up posting for him. sorry for inconvinience . As urb processing is complete by the time

Re: [try#1 PATCH 5/7] omap4: panda: add smsc95xx regulator and reset dependent on root hub

2012-11-28 Thread Andy Green
On 11/28/2012 11:06 PM, the mail apparently from Roger Quadros included: Hi Roger - On 11/28/2012 02:59 PM, Andy Green wrote: This adds regulators which are controlled by the OMAP4 PandaBoard (ES)'s EHCI logical root hub existing. The regulators are made a device_asset of the EHCI logical