Re: 3.7.3, ttyUSB0 serial problem - devices stop working and only reboot helps (Inappropriate ioctl for device)

2013-01-20 Thread Arkadiusz Miskiewicz
On Sunday 20 of January 2013, Woody Suwalski wrote: Arkadiusz Miskiewicz wrote: On Saturday 19 of January 2013, Arkadiusz Miskiewicz wrote: On Saturday 19 of January 2013, Greg Kroah-Hartman wrote: On Fri, Jan 18, 2013 at 11:28:43PM +0100, Arkadiusz Miskiewicz wrote: Hi. Using 3.7.3

Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

2013-01-20 Thread Felipe Balbi
On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote: Signed-off-by: Pali Rohár pali.ro...@gmail.com NAK for two reasons: a) the original Nokia kernel used a separate g_file_storage gadget to use Mass Storage mode, use that b) there is no commit log -- balbi signature.asc

Re: USB: storage: optimize the matching rules and support new switch command for Huawei USB storage devices

2013-01-20 Thread Felipe Balbi
Hi, On Fri, Jan 18, 2013 at 03:43:59PM -0800, Greg KH wrote: On Mon, Jan 14, 2013 at 10:55:48AM +0800, fangxiaozhi 00110321 wrote: From: fangxiaozhi huana...@huawei.com 1. Optimize the matching rules with new macro for Huawei USB storage devices, to avoid to load USB storage

Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

2013-01-20 Thread Pali Rohár
On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote: On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote: Signed-off-by: Pali Rohár pali.ro...@gmail.com NAK for two reasons: a) the original Nokia kernel used a separate g_file_storage gadget to use Mass Storage mode, use that

Re: Unable to reinsert the am35x MUSB module

2013-01-20 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/18/13 20:58, Felipe Balbi wrote: Hi, On Sun, Dec 02, 2012 at 05:33:36PM +0200, Dmitry Lifshitz wrote: Hi, We are running kernel v3.5.7 on am3517 based hardware (CM-T3517 module). Recently we faced with the following issue: am35x MUSB

Re: 3.7.3, ttyUSB0 serial problem - devices stop working and only reboot helps (Inappropriate ioctl for device)

2013-01-20 Thread Arkadiusz Miskiewicz
On Sunday 20 of January 2013, Arkadiusz Miskiewicz wrote: On Sunday 20 of January 2013, Woody Suwalski wrote: Arkadiusz Miskiewicz wrote: On Saturday 19 of January 2013, Arkadiusz Miskiewicz wrote: On Saturday 19 of January 2013, Greg Kroah-Hartman wrote: On Fri, Jan 18, 2013 at

Re: [PATCH v2] USB: prevent overlapping access by usb-storage and usbfs

2013-01-20 Thread Sergei Shtylyov
Hello. On 19-01-2013 21:54, Alan Stern wrote: Furthermore, the locking in usbfs doesn't look right. A process should be able to submit as many URBs as it wants, of whatever type, at any time. You mean USBDEVFS_SUBMITURB ioctl()? That's indeed an issue with 2.4 patch (and mine, of

[patch] usb: gadget: precedence bug in show_requests()

2013-01-20 Thread Dan Carpenter
The mod operation has higher precedence than the divide but the intent was to divide first. It's supposed to count through one time for RX and a second time for TX but instead of doing 0 1 2 0 1 2 it does 0 0 1 1 2 2. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Static checker

Re: [PATCH v2] USB: prevent overlapping access by usb-storage and usbfs

2013-01-20 Thread Sergei Shtylyov
On 20-01-2013 18:40, Sergei Shtylyov wrote: Also, why add a lock to usb_dump_desc in devices.c? None of the routines in that file try to communicate with the device. That was a part of the original patch. I haven't gone into detail about what these functions are doing. In 2.4

Re: [patch] usb: gadget: precedence bug in show_requests()

2013-01-20 Thread Sergei Shtylyov
Hello. On 20-01-2013 18:50, Dan Carpenter wrote: The mod operation has higher precedence than the divide They are of the same priority AFAIR, but that doesn't matter since these operations are executed left to right. but the intent was to divide first. It's supposed to count through

Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

2013-01-20 Thread Sergei Shtylyov
Hello. On 20-01-2013 10:12, Wei Shuai wrote: Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. we can define a new common structure wwan_noarp_info. Wrap your lines at 76-80 columns maximum please. Then more similiar NO ARP devices can be handled easily Signed-off-by:

Re: [patch] usb: gadget: precedence bug in show_requests()

2013-01-20 Thread Dan Carpenter
On Sun, Jan 20, 2013 at 09:10:24PM +0400, Sergei Shtylyov wrote: Hello. On 20-01-2013 18:50, Dan Carpenter wrote: The mod operation has higher precedence than the divide They are of the same priority AFAIR, but that doesn't matter since these operations are executed left to right.

[patch v2] usb: gadget: precedence bug in show_requests()

2013-01-20 Thread Dan Carpenter
The intent here was to have parenthesis around the (ci-hw_ep_max / 2) so that it counts like 0 1 2 0 1 2. In the current code, the mod operation happens first so it counts like 0 0 1 1 2 2. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: fixed the changelog. mod and divide have

Re: xHCI immediately wakes up Asus P8Z68-V LX in S5

2013-01-20 Thread Ben Hutchings
I finally got enough email out of the way to get back to this: On Wed, 2012-12-19 at 16:23 -0800, Sarah Sharp wrote: On Wed, Dec 19, 2012 at 03:15:09AM +, Ben Hutchings wrote: [...] I set sysctl kernel.printk=8 and recorded the screen during shutdown, from which I transcribe the

Re: [PATCH v5 02/10] USB: Set usb port's DeviceRemovable according acpi information

2013-01-20 Thread Greg KH
On Sun, Jan 20, 2013 at 01:53:31AM +0800, Lan Tianyu wrote: ACPI provide _PLD and _UPC aml methods to describe usb port visibility and connectability. This patch is to add usb_hub_adjust_DeviceRemovable() to adjust usb hub port's DeviceRemovable according ACPI information and invoke it in

Re: [PATCH v5 01/10] PM/Qos: Expose dev_pm_qos_flags symbol

2013-01-20 Thread Greg KH
On Sun, Jan 20, 2013 at 01:53:30AM +0800, Lan Tianyu wrote: The dev_pm_qos_flags() will be used in the usb core which could be compiled as a module. This patch is to export it. Acked-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Lan Tianyu tianyu@intel.com ---

Re: [PATCH V5 0/10] usb: usb port power off mechanism and expose usb port connect type

2013-01-20 Thread Greg KH
On Sun, Jan 20, 2013 at 01:53:29AM +0800, Lan Tianyu wrote: Change since v5: use EXPORT_SYMBOL_GPL to export dev_pm_qos_flags(). correct some unnecessary link breaks. Add CONFIG_USB_SUSPEND check around usb_port_runtime_resume() and usb_port_runtime_suspend() I've

Re: [PATCH v2] drivers/usb/host/uhci-* : check buffer length to avoid memory overflow

2013-01-20 Thread Chen Gang
Hello Alan Stern When you have time, could you help checking this patch ? welcome any reasonable rejections, too. thanks. gchen. 于 2013年01月19日 07:37, Greg KH 写道: On Sat, Jan 12, 2013 at 11:18:03PM +0800, Chen Gang wrote: for function uhci_sprint_schedule: the buffer len is

RE: [balbi-usb:gadget 19/61] drivers/usb/gadget/mv_udc_core.c:1124:16: error: 'struct mv_usb_platform_data' has no member named 'phy_init'

2013-01-20 Thread Chao Xie
-Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, January 18, 2013 8:05 PM To: kbuild test robot Cc: Chao Xie; linux-usb@vger.kernel.org; Felipe Balbi Subject: Re: [balbi-usb:gadget 19/61] drivers/usb/gadget/mv_udc_core.c:1124:16: error: 'struct

[RESEND PATCH v5 0/7] Add fully tested id switch and vbus connect detect support for Chipidea

2013-01-20 Thread Peter Chen
Only one typo suggestion from Marek Vasut (change d to D) is added. At this v5 version. Anyone who have tested this patchset, please give a tested-by, thanks. This patchset adds fully tested otg id switch function and vbus connect/disconnect detection for chipidea driver. The mainly design of

[RESEND PATCH v5 1/7] Revert USB: chipidea: add vbus detect for udc

2013-01-20 Thread Peter Chen
vbus register is at otgsc, and vbus detect does not belong to device function. Revert this patch, and will move vbus detect function to drivers/usb/chipidea/udc.c This reverts commit 8c4fc031954b4eb72daf13d3c907a985a3eee208. Signed-off-by: Peter Chen peter.c...@freescale.com ---

[RESEND PATCH v5 2/7] usb: chipidea: add otg file

2013-01-20 Thread Peter Chen
Implement struct usb_otg, In that way, calling otg_set_peripheral will not be failed at udc.c. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/Makefile |2 +- drivers/usb/chipidea/ci.h |2 + drivers/usb/chipidea/otg.c| 60

[RESEND PATCH v5 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2013-01-20 Thread Peter Chen
The main design flow is the same with msm otg driver, that is the id and vbus interrupt are handled at core driver, others are handled by individual drivers. - At former design, when switch usb role from device-host, it will call udc_stop, it will remove the gadget driver, so when switch role

[RESEND PATCH v5 6/7] usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS

2013-01-20 Thread Peter Chen
(change CI13XXX to CI13 to avoid junk email check) Now, we have handled vbus session in core driver when the vbus interrupt occurs, so our pullup operations are all according to vbus. Of cource, the software can still call .pullup when device connects to host if it wants to connect/disconnect with

Re: [PATCH V5 0/10] usb: usb port power off mechanism and expose usb port connect type

2013-01-20 Thread Lan Tianyu
2013/1/21 Greg KH gre...@linuxfoundation.org On Sun, Jan 20, 2013 at 01:53:29AM +0800, Lan Tianyu wrote: Change since v5: use EXPORT_SYMBOL_GPL to export dev_pm_qos_flags(). correct some unnecessary link breaks. Add CONFIG_USB_SUSPEND check around

[PATCH v2 1/1] usb: chipidea: imx: Add system suspend/resume API

2013-01-20 Thread Peter Chen
During the system suspend/resume procedure, the USB also needs to go suspend/resume procedure, this patch adds related APIs. It is tested at i.mx6q sabrelite. Meanwhile, it fixes the bug that the USB will out of work after system suspend/resume. Signed-off-by: Peter Chen peter.c...@freescale.com

Re: [RESEND PATCH v5 0/7] Add fully tested id switch and vbus connect detect support for Chipidea

2013-01-20 Thread Peter Chen
gre...@linuxfoundation.org, ba...@ti.com, st...@rowland.harvard.edu Cc: linux-usb@vger.kernel.org, linux-arm-ker...@lists.infradead.org, feste...@gmail.com, ma...@denx.de, m...@genesi-usa.com, shawn@linaro.org, ker...@pengutronix.de, m...@pengutronix.de,

RE: USB: storage: optimize the matching rules and support new switch command for Huawei USB storage devices

2013-01-20 Thread Fangxiaozhi (Franko)
Dear Greg: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Saturday, January 19, 2013 7:42 AM To: Fangxiaozhi (Franko) Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Xueguiying (Zihan); Linlei (Lei Lin); Yili (Neil); Wangyuhua (Roger,

Not enough resource for old configuration after USB bus reset

2013-01-20 Thread Soar Hung
Hi everybody, We ported the Linux and related drivers to our embedded system(a customized board), and using TUSB7340 as our host controller. We also write a usb interface driver for the tested device, the enumeration and bulk in/out transfers work fine. But we encounter problem when we keep

Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

2013-01-20 Thread David Miller
From: Wei Shuai cpuw...@gmail.com Date: Mon, 21 Jan 2013 10:20:22 +0800 The main problem is that these devices don't support ethernet. He's saying your comment is referring to the wrong thing, rather than saying anything against what your change is doing. Read his feedback carefully: +/*

Re: [PATCH] usbnet: pegasus: set wakeup enable in set_wol

2013-01-20 Thread David Miller
From: Ming Lei ming@canonical.com Date: Sat, 19 Jan 2013 19:32:01 +0800 This patch calls device_set_wakeup_enable() inside set_wol callback, so that turning on WOL from user mode utility can make the 'wakeup' of pegasus device to be enabled, then remote wakeup may be enabled before

Re: Not enough resource for old configuration after USB bus reset

2013-01-20 Thread Peter Stuge
Soar Hung wrote: We ported the Linux and related drivers to our embedded system(a customized board), and using TUSB7340 as our host controller. We also write a usb interface driver for the tested device, the enumeration and bulk in/out transfers work fine. But we encounter problem ..

Re: [PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-01-20 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 14, 2013 at 6:29 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Changes from v2: - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating usb 2.0 phy controller's driver for Samsung's SoCs. - Moving the register definitions and strcuture definitions