Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

2013-01-21 Thread Felipe Balbi
Hi, On Sun, Jan 20, 2013 at 11:17:31AM +0100, Pali Rohár wrote: On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote: On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote: Signed-off-by: Pali Rohár pali.ro...@gmail.com NAK for two reasons: a) the original Nokia kernel used

Re: Linux USB file storage gadget with new UDC

2013-01-21 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 01:32:09PM +0800, victor yeo wrote: This log looks oddly incomplete. A lot of debugging messages are missing. g_file_storage gadget: ep0-setup, length 8: : 80 06 00 01 00 00 40 00 g_file_storage gadget: get device descriptor For

USB subsystem stops working

2013-01-21 Thread Norbert Preining
Hi everyone, (please Cc) I am currently running 3.8.0-rc4 and see the following behaviour: When I plug/eject my kindle a few times, suddenly the kernel does not see any USB activity any more. Nothing. PLugging in the kindle - no reaction, plugging in a usb kbd - no reaction, plugging in a usb

Re: Linux USB file storage gadget with new UDC

2013-01-21 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 04:15:32PM +0800, victor yeo wrote: Hi, g_file_storage gadget: ep0-setup, length 8: : 80 06 00 01 00 00 40 00 g_file_storage gadget: get device descriptor For example, right here we should see the device descriptor data that was sent

Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

2013-01-21 Thread Wei Shuai
Thank you David. yes in the core driver, FLAG_NOARP will be translated to IFF_NOARP 2013/1/21, David Miller da...@davemloft.net: From: Wei Shuai cpuw...@gmail.com Date: Mon, 21 Jan 2013 10:20:22 +0800 The main problem is that these devices don't support ethernet. He's saying your comment is

Re: USB subsystem stops working

2013-01-21 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 04:51:28PM +0900, Norbert Preining wrote: Hi everyone, (please Cc) I am currently running 3.8.0-rc4 and see the following behaviour: When I plug/eject my kindle a few times, suddenly the kernel does not see any USB activity any more. Nothing. PLugging in the

Re: [PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-01-21 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 12:15:10PM +0530, Vivek Gautam wrote: Hi Felipe, On Mon, Jan 14, 2013 at 6:29 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Changes from v2: - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating usb 2.0 phy controller's driver for

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-21 Thread Bjørn Mork
Alexey Orishko alexey.oris...@gmail.com writes: On Fri, Jan 18, 2013 at 10:17 PM, Bjørn Mork bj...@mork.no wrote: Some Sierra Wireless firmwares support CDC MBIM but have no CDC Union funtional descriptor. This violates the MBIM specification, I don't believe Sierra Wireless violates MBIM

Re: [balbi-usb:gadget 19/61] drivers/usb/gadget/mv_udc_core.c:1124:16: error: 'struct mv_usb_platform_data' has no member named 'phy_init'

2013-01-21 Thread Fengguang Wu
On Mon, Jan 21, 2013 at 10:13:43AM +0200, Felipe Balbi wrote: On Sun, Jan 20, 2013 at 05:24:05PM -0800, Chao Xie wrote: [snip] I am formatting and re-test the patches. I will send out today. Thanks. great, please make sure to compile test on x86 and ARM with allyesconfig, allnoconfig

Re: Linux USB file storage gadget with new UDC

2013-01-21 Thread victor yeo
Hi, ep0_complete() should be called by your UDC driver. Seriously dude, read the documentation and read other drivers to figure out how things should be called. A quick look in the storage drivers would have shown you that ep0_complete() is passed in as req-complete() through the

Re: [balbi-usb:gadget 19/61] drivers/usb/gadget/mv_udc_core.c:1124:16: error: 'struct mv_usb_platform_data' has no member named 'phy_init'

2013-01-21 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 04:38:32PM +0800, Fengguang Wu wrote: On Mon, Jan 21, 2013 at 10:13:43AM +0200, Felipe Balbi wrote: On Sun, Jan 20, 2013 at 05:24:05PM -0800, Chao Xie wrote: [snip] I am formatting and re-test the patches. I will send out today. Thanks. great, please

Re: Linux USB file storage gadget with new UDC

2013-01-21 Thread Felipe Balbi
On Mon, Jan 21, 2013 at 04:45:03PM +0800, victor yeo wrote: Hi, ep0_complete() should be called by your UDC driver. Seriously dude, read the documentation and read other drivers to figure out how things should be called. A quick look in the storage drivers would have shown you that

[PATCH] usb: musb: fix context save over suspend.

2013-01-21 Thread NeilBrown
The standard suspend sequence involves runtime_resuming devices before suspending the system. So just saving context in runtime_suspend and restoring it in runtime resume isn't enough. We must also save in suspend and restore in resume. Without this patch, and OMAP3 system with off_mode

Re: [PATCH v8 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies

2013-01-21 Thread Roger Quadros
On 01/18/2013 10:27 PM, Paul Walmsley wrote: Hi Roger, On Fri, 18 Jan 2013, Roger Quadros wrote: We don't need multiple aliases for the OMAP USB host clocks and neither the dummy clocks so remove them. CC: Paul Walmsley p...@pwsan.com CC: Rajendra Nayak rna...@ti.com CC: Benoit Cousson

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-21 Thread Vivek Gautam
Hi Kukjin, On Fri, Jan 18, 2013 at 8:37 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Jan 18, 2013 at 07:59:52PM +0530, Vivek Gautam wrote: HI Balbi, On Fri, Jan 18, 2013 at 7:52 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote: Hi Felipe,

[V4 PATCH 00/26] mv-usb fix and enhancement patches

2013-01-21 Thread Chao Xie
The patches are divied into 4 parts 1. bug fixes usb: gadget: mv_udc: use udc_start and udc_stop functions usb: gadget: mv_udc: use devm_xxx for probe usb: gadget: mv_udc: fix the warning of mv_udc_remove usb: otg: mv_otg: use devm_xxx for probe usb: host: ehci-mv: remove unused variable

[V4 PATCH 01/26] usb: gadget: mv_udc: use udc_start and udc_stop functions

2013-01-21 Thread Chao Xie
This patches converts the driver into the new style start/stop interface. As a result the driver no longer uses the static global the_conroller variable. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/mv_udc_core.c | 79 +- 1 files

[V4 PATCH 02/26] usb: gadget: mv_udc: use devm_xxx for probe

2013-01-21 Thread Chao Xie
use devm_xxx for udc driver probe. So we do need care about the resources release in driver remove or failure handling in driver probe. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/mv_udc_core.c | 156 ++ 1 files changed, 56

[V4 PATCH 05/26] usb: host: ehci-mv: remove unused variable

2013-01-21 Thread Chao Xie
Signed-off-by: Chao Xie chao@marvell.com Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-mv.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index 6c56297..3065809 100644 ---

[V4 PATCH 06/26] usb: gadget: mv_udc: fix the value of tranceiver

2013-01-21 Thread Chao Xie
usally we will use udc-tranceiver == NULL or udc-tranceiver != NULL. So when failed to get the udc-tranceiver by usb_get_phy(), we directly set udc-tranceiver to be NULL. Then the source code will not need macro IS_ERR_OR_NULL() for udc-tranceiver judgement. It can reduce the line size and make

[V4 PATCH 03/26] usb: gadget: mv_udc: fix the warning of mv_udc_remove

2013-01-21 Thread Chao Xie
The __exit_p() will be NULL if MODULE is no defined. It will cause the warning. Removing __exit_p to remove the warning. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/mv_udc_core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[V4 PATCH 07/26] usb: gadget: mv_udc: make mv_udc depends on ARCH_MMP or ARCH_PXA

2013-01-21 Thread Chao Xie
Only ARCH_PXA and ARCH_MMP will use mv_udc. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 14625fd..53943f7 100644 ---

[V4 PATCH 09/26] usb: gadget: mv_udc: use PHY driver for udc

2013-01-21 Thread Chao Xie
Originaly, udc driver will call the callbacks in platform data for PHY initialization and shut down. With PHY driver, it will call the APIs provided by PHY driver for PHY initialization and shut down. It removes the callbacks in platform data, and at same time it removes one block in the way of

[V4 PATCH 08/26] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-01-21 Thread Chao Xie
The PHY is seperated from usb controller. The usb controller used in marvell pxa168/pxa910/mmp2 are same, but PHY initialization may be different. the usb controller can support udc/otg/ehci, and for each of the mode, it need PHY to initialized before use the controller. Direclty writing the phy

[V4 PATCH 04/26] usb: otg: mv_otg: use devm_xxx for probe

2013-01-21 Thread Chao Xie
use devm_xxx for otg driver probe. So we do need care about the resources release in driver remove or failure handling in driver probe. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/otg/mv_otg.c | 82 - 1 files changed, 22

[V4 PATCH 10/26] usb: ehci: ehci-mv: use PHY driver for ehci

2013-01-21 Thread Chao Xie
Originaly, ehci driver will call the callbacks in platform data for PHY initialization and shut down. With PHY driver, it will call the APIs provided by PHY driver for PHY initialization and shut down. It removes the callbacks in platform data, and at same time it removes one block in the way of

[V4 PATCH 11/26] usb: otg: mv_otg: use PHY driver for otg

2013-01-21 Thread Chao Xie
Originaly, otg driver will call the callbacks in platform data for PHY initialization and shut down. With PHY driver, it will call the APIs provided by PHY driver for PHY initialization and shut down. It removes the callbacks in platform data, and at same time it removes one block in the way of

[V4 PATCH 14/26] arm: brownstone: add usb support for the board

2013-01-21 Thread Chao Xie
for brownstone board, add the udc/otg/ehci support Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/brownstone.c | 47 1 files changed, 47 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c

[V4 PATCH 16/26] arm: mmp: remove the usb phy setting

2013-01-21 Thread Chao Xie
phy setting are formatted into a phy driver at drivers/usb/phy, we do not need do the setting in SOC files. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/devices.c | 278 - arch/arm/mach-mmp/include/mach/regs-usb.h | 253

[V4 PATCH 17/26] arm: mmp: remove usb devices from pxa168

2013-01-21 Thread Chao Xie
Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/pxa168.c | 42 -- 1 files changed, 0 insertions(+), 42 deletions(-) diff --git a/arch/arm/mach-mmp/pxa168.c b/arch/arm/mach-mmp/pxa168.c index b7f074f..dd3a68b 100644 ---

[V4 PATCH 18/26] usb: phy: mv_usb2_phy: add externel chip support

2013-01-21 Thread Chao Xie
For the vbus and idpin detection. It may be completed by some external chip, for example the pmic chip 88pm860x in driver/mfd can do it. Although the usb controller can detect the vbus and id pin, but it need clock on and PHY enabled to detect the vbus/idpin. It will increase the power. Using the

[V4 PATCH 20/26] usb: ehci: ehci-mv: add extern chip support

2013-01-21 Thread Chao Xie
It does the similar things as what we do for udc driver. Signed-off-by: Chao Xie chao@marvell.com Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-mv.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c

[V4 PATCH 21/26] usb: otg: mv_otg: add extern chip support

2013-01-21 Thread Chao Xie
It does the similar things as what we do for udc driver. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/otg/mv_otg.c | 63 - drivers/usb/otg/mv_otg.h |3 ++ 2 files changed, 31 insertions(+), 35 deletions(-) diff --git

[V4 PATCH 22/26] arm: mmp: add extern chip support for brownstone

2013-01-21 Thread Chao Xie
Change the board support for usb as extern chip is supported in marvell usb PHY driver Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/brownstone.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c

[V4 PATCH 23/26] arm: mmp: add extern chip support for ttc_dkb

2013-01-21 Thread Chao Xie
Change the board support for usb as extern chip is supported in marvell usb PHY driver. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/ttc_dkb.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c

[V4 PATCH 25/26] usb: otg: mv_otg: add device tree support

2013-01-21 Thread Chao Xie
All blocks are removed. Add the device tree support for otg. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/otg/mv_otg.c | 128 + drivers/usb/otg/mv_otg.h |6 +- 2 files changed, 108 insertions(+), 26 deletions(-) diff --git

[V4 PATCH 24/26] usb: gadget: mv_udc: add device tree support

2013-01-21 Thread Chao Xie
In original driver, we have callbacks in platform data, and some dynamically allocations variables in platform data. Now, these blocks are removed, the device tree support is easier now. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/gadget/mv_udc.h |5 +-

[V4 PATCH 26/26] usb: ehci: ehci-mv: add device tree support

2013-01-21 Thread Chao Xie
All blocks are removed. Add the device tree support for ehci. Signed-off-by: Chao Xie chao@marvell.com Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-mv.c | 105 +-- 1 files changed, 80 insertions(+), 25 deletions(-) diff

[V4 PATCH 15/26] arm: ttc_dkb: add usb support

2013-01-21 Thread Chao Xie
for ttc_dkb board, add udc/otg/ehci support Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/ttc_dkb.c | 30 +++--- 1 files changed, 19 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c index

[PATCH 29/33] usb: Convert to devm_ioremap_resource()

2013-01-21 Thread Thierry Reding
Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error messages can be removed from the failure code paths. Signed-off-by: Thierry

[PATCH v9 05/22] mfd: omap-usb-tll: Clean up clock handling

2013-01-21 Thread Roger Quadros
Every channel has a functional clock that is similarly named. It makes sense to use a for loop to manage these clocks as OMAPs can come with up to 3 channels. Dynamically allocate and get channel clocks depending on the number of clocks avaiable on the platform. Signed-off-by: Roger Quadros

[PATCH v9 06/22] mfd: omap-usb-tll: introduce and use mode_needs_tll()

2013-01-21 Thread Roger Quadros
This is a handy macro to check if the port requires the USB TLL module or not. Use it to Enable the TLL module and manage the clocks. Signed-off-by: Roger Quadros rog...@ti.com Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/mfd/omap-usb-tll.c | 20 1 files changed, 12

[PATCH v9 15/22] mfd: omap-usb-host: cleanup clock management code

2013-01-21 Thread Roger Quadros
All ports have similarly named port clocks so we can bunch them into a port data structure and use for loop to enable/disable the clocks. Dynamically allocate and get clocks based on number of ports available on the platform Signed-off-by: Roger Quadros rog...@ti.com Reviewed-by: Felipe Balbi

[PATCH v9 16/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2013-01-21 Thread Roger Quadros
Enable the optional HSIC clocks (60MHz and 480MHz) for the ports that are configured in HSIC mode. Signed-off-by: Roger Quadros rog...@ti.com Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/mfd/omap-usb-host.c | 97 -- 1 files changed, 83

Re: Linux USB file storage gadget with new UDC

2013-01-21 Thread victor yeo
Hi, Yes, ep0_complete() is called in UDC driver queue function, i just added it in and ep0_complete() is called now. The dmesg output is below. not in queue function, you should call it when completing. Is there any mistake in my understanding of ep0 setup data processing? 1. usb

Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

2013-01-21 Thread Sergei Shtylyov
Hello. On 21-01-2013 6:20, Wei Shuai wrote: The main problem is that these devices don't support ethernet. They support IP (v4 and _maybe_ v6) with an ethernet header. Many of them will do ARP (and IPv6 ND) as well to complete the picture, but some of them don't and that's what these drivers

[PATCH] drivers/usb/gadget: using strlcpy instead of strncpy

2013-01-21 Thread Chen Gang
for NUL terminated string, better notice '\0' in the end. Signed-off-by: Chen Gang gang.c...@asianux.com --- drivers/usb/gadget/uvc_v4l2.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/uvc_v4l2.c b/drivers/usb/gadget/uvc_v4l2.c index

Re: Linux USB file storage gadget with new UDC

2013-01-21 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 07:13:03PM +0800, victor yeo wrote: Yes, ep0_complete() is called in UDC driver queue function, i just added it in and ep0_complete() is called now. The dmesg output is below. not in queue function, you should call it when completing. Is there any

[PATCH 2/15] drivers/usb/chipidea/core.c: adjust duplicate test

2013-01-21 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Delete successive tests to the same location. In this case res has already been tested for being NULL, and calling devm_request_and_ioremap will not make it NULL. On the other hand, devm_request_and_ioremap can return NULL on failure. A simplified

Re: [PATCH 13/15] drivers/usb/musb/omap2430.c: adjust duplicate test

2013-01-21 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 02:02:57PM +0100, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Delete successive tests to the same location. Data is the just previously allocated and tested value. Test the result of the allocation made here instead. A simplified version of

Re: [PATCH V3 0/5] UVC webcam gadget related changes

2013-01-21 Thread Laurent Pinchart
Hi Felipe, On Friday 18 January 2013 20:46:59 Felipe Balbi wrote: On Thu, Jan 17, 2013 at 04:23:48PM +0530, Bhupesh Sharma wrote: This patchset tries to enhance the UVC webcam gadget driver and is based on Laurent's git tree available here (head uvc-gadget):

Re: [RFC PATCH 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-21 Thread Roger Quadros
On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote: The OMAP glue has been modified to get PHY by phandle for dt boot. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/musb/omap2430.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [RFC PATCH 5/6] usb: otg: add device tree support to otg library

2013-01-21 Thread Roger Quadros
On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote: Added an API devm_usb_get_phy_by_phandle(), to get usb phy by passing a device node phandle value. This function will return a pointer to the phy on success, -EPROBE_DEFER if there is a device_node for the phandle, but the phy has not been

Re: [RFC PATCH 5/6] usb: otg: add device tree support to otg library

2013-01-21 Thread kishon
On Monday 21 January 2013 06:51 PM, Roger Quadros wrote: On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote: Added an API devm_usb_get_phy_by_phandle(), to get usb phy by passing a device node phandle value. This function will return a pointer to the phy on success, -EPROBE_DEFER if there is

USB gadget lockup on MX53 udc

2013-01-21 Thread Michael McTernan
Hi, I think I've found a debug in fsl_udc_core.c and hope for some review of the fix. It's pretty complex so apologies in advance if my explanation misses anything. The background is that I started with the 3.0.59 stable branch (which shows the problem), then merged down the specific changes

Re: [RFC PATCH 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-21 Thread kishon
Hi, On Monday 21 January 2013 06:48 PM, Roger Quadros wrote: On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote: The OMAP glue has been modified to get PHY by phandle for dt boot. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/musb/omap2430.c |7 ++- 1 file

[PATCH] usb: phy: samsung: Remove __devinit, __devexit_p and __exit annotations

2013-01-21 Thread Vivek Gautam
Dropping __devinit, __devexit_p, __exit annotations since they are nop and no longer supported. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/usb/phy/samsung-usbphy.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/samsung-usbphy.c

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-21 Thread Bjørn Mork
Hello Alexey, I have another issue with the Sierra firmware which I hope you can help me with: The MC7710 device requires at ZLP even if we send dwNtbOutMaxSize sized NTBs. This is a problem because the current code explicitly prevents this. The following code in the v3.8 cdc-ncm was written to

[PATCH v2 3/4] ARM: OMAP2: MUSB: Specify omap4 has mailbox

2013-01-21 Thread Kishon Vijay Abraham I
Added has_mailbox to the musb platform data to specify that omap uses an external mailbox (in control module) to communicate with the musb core during device connect and disconnect. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- arch/arm/mach-omap2/usb-musb.c |3 +++

[PATCH v2 2/4] ARM: OMAP: devices: create device for usb part of control module

2013-01-21 Thread Kishon Vijay Abraham I
A seperate driver has been added to handle the usb part of control module. A device for the above driver is created here, using the register address information to be used by the driver for powering on the PHY and for writing to the mailbox. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com ---

[PATCH v2 4/4] drivers: usb: start using the control module driver

2013-01-21 Thread Kishon Vijay Abraham I
Start using the control module driver for powering on the PHY and for writing to the mailbox instead of writing to the control module registers on their own. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- Documentation/devicetree/bindings/usb/omap-usb.txt |4 ++

[PATCH v2 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-21 Thread Kishon Vijay Abraham I
Added a new driver for the usb part of control module. This has an API to power on the USB2 phy and an API to write to the mailbox depending on whether MUSB has to act in host mode or in device mode. Writing to control module registers for doing the above task which was previously done in omap

[PATCH V6 0/8] usb: usb port power off mechanism and expose usb port connect type

2013-01-21 Thread Lan Tianyu
Change since v1: optimize the export connect type patch and adjust the DeviceRemovalbe flag in the rh_call_control() after GetHubDescriptor request being processed. move all debounce operation to usb port's runtime resume callback(). Add did_runtime_put in the struct usb_port to

[PATCH v6 1/8] USB: Set usb port's DeviceRemovable according acpi information

2013-01-21 Thread Lan Tianyu
ACPI provide _PLD and _UPC aml methods to describe usb port visibility and connectability. This patch is to add usb_hub_adjust_DeviceRemovable() to adjust usb hub port's DeviceRemovable according ACPI information and invoke it in the rh_call_control(). When hub descriptor request is issued at

[PATCH v6 2/8] usb: Register usb port's acpi power resources

2013-01-21 Thread Lan Tianyu
This patch is to register usb port's acpi power resources. Create link between usb port device and its acpi power resource. Acked-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Lan Tianyu tianyu@intel.com --- drivers/usb/core/port.c |3 +++ drivers/usb/core/usb-acpi.c | 20

[PATCH v6 3/8] PM/Qos: Expose dev_pm_qos_flags symbol

2013-01-21 Thread Lan Tianyu
The dev_pm_qos_flags() will be used in the usb core which could be compiled as a module. This patch is to export it. Acked-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Lan Tianyu tianyu@intel.com --- drivers/base/power/qos.c |1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v6 4/8] usb: add runtime pm support for usb port device

2013-01-21 Thread Lan Tianyu
This patch is to add runtime pm callback for usb port device. Set/clear PORT_POWER feature in the resume/suspend callbak. Add portnum for struct usb_port to record port number. Do pm_rumtime_get_sync/put(portdev) when a device is plugged/unplugged to prevent it from being powered off when it is

[PATCH v6 6/8] usb: expose usb port's pm qos flags to user space

2013-01-21 Thread Lan Tianyu
This patch is to expose usb port's pm qos flags(pm_qos_no_power_off, pm_qos_remote_wakeup) to user space. User can set pm_qos_no_power_off flag to prohibit the port from being powered off. Acked-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Lan Tianyu tianyu@intel.com ---

[PATCH v6 8/8] usb: enable usb port device's async suspend.

2013-01-21 Thread Lan Tianyu
Signed-off-by: Lan Tianyu tianyu@intel.com --- drivers/usb/core/port.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c index 0334d91..50b646e 100644 --- a/drivers/usb/core/port.c +++ b/drivers/usb/core/port.c @@ -215,7

Re: [RESEND PATCH v9 0/2] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2013-01-21 Thread Tomasz Figa
On Friday 18 of January 2013 14:30:21 Praveen Paneri wrote: Changes from v8: Resending this patch series after rebasing to the latest usb-next branch. Rewording inline comments for better readability. Removed IS_ENABLED(CONFIG_OF) as pdev-dev.of_node is enough to check for dt support. Using

Re: [RFC PATCH 5/6] usb: otg: add device tree support to otg library

2013-01-21 Thread Roger Quadros
On 01/21/2013 03:34 PM, kishon wrote: On Monday 21 January 2013 06:51 PM, Roger Quadros wrote: On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote: Added an API devm_usb_get_phy_by_phandle(), to get usb phy by passing a device node phandle value. This function will return a pointer to the

Re: [RFC PATCH 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-21 Thread Roger Quadros
On 01/21/2013 03:41 PM, kishon wrote: Hi, On Monday 21 January 2013 06:48 PM, Roger Quadros wrote: On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote: The OMAP glue has been modified to get PHY by phandle for dt boot. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com ---

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-21 Thread Bjørn Mork
Bjørn Mork bj...@mork.no writes: I have another issue with the Sierra firmware which I hope you can help me with: The MC7710 device requires at ZLP even if we send dwNtbOutMaxSize sized NTBs. This is a problem because the current code explicitly prevents this. If anyone found this more than

[PATCH] usb: musb: core: Add missing newline character

2013-01-21 Thread Kishon Vijay Abraham I
No functional change. Just added a missing newline character. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/musb/musb_core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-21 Thread Oliver Neukum
On Monday 21 January 2013 15:47:13 Bjørn Mork wrote: But I wonder if this isn't really a generic problem in usbnet. The FLAG_MULTI_PACKET test here seems completely bogus: if (length % dev-maxpacket == 0) { if (!(info-flags FLAG_SEND_ZLP)) {

Re: [PATCH v8 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies

2013-01-21 Thread Paul Walmsley
Hi On Mon, 21 Jan 2013, Roger Quadros wrote: On 01/18/2013 10:27 PM, Paul Walmsley wrote: On Fri, 18 Jan 2013, Roger Quadros wrote: We don't need multiple aliases for the OMAP USB host clocks and neither the dummy clocks so remove them. CC: Paul Walmsley p...@pwsan.com CC:

Re: Linux USB file storage gadget with new UDC

2013-01-21 Thread victor yeo
Hi, Yes, ep0_complete() is called in UDC driver queue function, i just added it in and ep0_complete() is called now. The dmesg output is below. not in queue function, you should call it when completing. Is there any mistake in my understanding of ep0 setup data processing?

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-21 Thread Bjørn Mork
Oliver Neukum oneu...@suse.de writes: On Monday 21 January 2013 15:47:13 Bjørn Mork wrote: But I wonder if this isn't really a generic problem in usbnet. The FLAG_MULTI_PACKET test here seems completely bogus: if (length % dev-maxpacket == 0) { if (!(info-flags

Re: Linux USB file storage gadget with new UDC

2013-01-21 Thread Felipe Balbi
On Mon, Jan 21, 2013 at 11:14:19PM +0800, victor yeo wrote: Hi, Yes, ep0_complete() is called in UDC driver queue function, i just added it in and ep0_complete() is called now. The dmesg output is below. not in queue function, you should call it when completing. Is

[PATCH net 1/3] net: cdc_ncm: workaround for missing CDC Union

2013-01-21 Thread Bjørn Mork
Adding support for the MBIM mode in some Sierra Wireless devices. Some Sierra Wireless firmwares support CDC MBIM but have no CDC Union funtional descriptor. This violates the MBIM specification, but we can easily work around the bug by looking at the Interface Association Descriptor instead.

[PATCH net 0/3] cdc_ncm and cdc_mbim fixes for 3.8

2013-01-21 Thread Bjørn Mork
The 2 first patches in this series are required to make the Sierra Wireless MC7710 card work in MBIM mode. They may also be required for other Qualcomm firmware based MBIM devices. Patch #1 was previously posted as a standalone patch. This version is a replacement, removing a theoretical NULL

[PATCH net 3/3] net: cdc_ncm: fix error path for single interface probing

2013-01-21 Thread Bjørn Mork
commit bbc8d92 (net: cdc_ncm: add Huawei devices) implemented support for devices with a single combined control and data interface. Fix up the error path so that we do not double release such interfaces in case of probing failures. Signed-off-by: Bjørn Mork bj...@mork.no ---

[PATCH net 2/3] net: cdc_mbim: send ZLP after max sized NTBs

2013-01-21 Thread Bjørn Mork
We normally avoid sending ZLPs by padding NTBs with a zero byte if the NTB is shorter than dwNtbOutMaxSize, resulting in a short USB packet instead of a ZLP. But in the case where the NTB length is exactly dwNtbOutMaxSize and this is an exact multiplum of wMaxPacketSize, then we must send a ZLP.

Re: [V4 PATCH 18/26] usb: phy: mv_usb2_phy: add externel chip support

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 05:07:36AM -0500, Chao Xie wrote: + mv_phy-extern_chip.head = devm_kzalloc(pdev-dev, + sizeof(*mv_phy-extern_chip.head), + GFP_KERNEL); + if (mv_phy-extern_chip.head == NULL) +

[PATCH 1/2] usbnet: add new flag FLAG_NOARP for usb net devices

2013-01-21 Thread Wei Shuai
We do have some USB net devices, which cannot do ARP. so we can introduce a new flag FLAG_NOARP, then client drivers can easily handle this kind of devices Signed-off-by: Wei Shuai cpuw...@gmail.com --- drivers/net/usb/usbnet.c |4 include/linux/usb/usbnet.h |1 + 2 files

Re: [PATCH v9 05/22] mfd: omap-usb-tll: Clean up clock handling

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 01:04:46PM +0200, Roger Quadros wrote: Every channel has a functional clock that is similarly named. It makes sense to use a for loop to manage these clocks as OMAPs can come with up to 3 channels. Dynamically allocate and get channel clocks depending on the number

[PATCH 2/2] cdc_ncm: add support FLAG_NOARP for Infineon modem platform

2013-01-21 Thread Wei Shuai
Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. we can define a new common structure wwan_noarp_info. Then more similiar NO ARP devices can be handled easily Signed-off-by: Wei Shuai cpuw...@gmail.com --- drivers/net/usb/cdc_ncm.c | 21 + 1 files changed,

Re: [PATCH v2] drivers/usb/host/uhci-* : check buffer length to avoid memory overflow

2013-01-21 Thread Alan Stern
On Fri, 18 Jan 2013, Greg KH wrote: On Sat, Jan 12, 2013 at 11:18:03PM +0800, Chen Gang wrote: for function uhci_sprint_schedule: the buffer len is MAX_OUTPUT: 64 * 1024, which may not be enough: may loop UHCI_NUMFRAMES times (UHCI_NUMFRAMES is 1024) each time of

Re: [PATCH] usb: musb: core: Add missing newline character

2013-01-21 Thread Sergei Shtylyov
Hello. On 01/21/2013 05:52 PM, Kishon Vijay Abraham I wrote: No functional change. Just added a missing newline character. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/musb/musb_core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

RE: [PATCH net 2/3] net: cdc_mbim: send ZLP after max sized NTBs

2013-01-21 Thread Alexey ORISHKO
-Original Message- From: Bjørn Mork [mailto:bj...@mork.no] We normally avoid sending ZLPs by padding NTBs with a zero byte if the NTB is shorter than dwNtbOutMaxSize, resulting in a short USB packet instead of a ZLP. But in the case where the NTB length is exactly dwNtbOutMaxSize

Re: [PATCH net 2/3] net: cdc_mbim: send ZLP after max sized NTBs

2013-01-21 Thread Yauheni Kaliuta
Hi, Bjørn! BM == Bjørn Mork writes: We normally avoid sending ZLPs by padding NTBs with a zero byte if the NTB is shorter than dwNtbOutMaxSize, resulting in a short USB packet instead of a ZLP. But in the case where the NTB length is exactly dwNtbOutMaxSize and this is an exact

Re: USB: storage: optimize the matching rules and support new switch command for Huawei USB storage devices

2013-01-21 Thread Greg KH
On Mon, Jan 21, 2013 at 03:37:15AM +, Fangxiaozhi (Franko) wrote: Dear Greg: I get the following errors: drivers/usb/storage/unusual_devs.h:1530:1: error: implicit declaration of function ‘UNUSUAL_VENDOR_INTF’ [-Werror=implicit-function-declaration]

Re: Linux USB file storage gadget with new UDC

2013-01-21 Thread Alan Stern
On Mon, 21 Jan 2013, Felipe Balbi wrote: On Mon, Jan 21, 2013 at 11:14:19PM +0800, victor yeo wrote: Hi, Yes, ep0_complete() is called in UDC driver queue function, i just added it in and ep0_complete() is called now. The dmesg output is below. not in queue

Re: USB: storage: optimize the matching rules and support new switch command for Huawei USB storage devices

2013-01-21 Thread Greg KH
On Mon, Jan 21, 2013 at 03:41:20AM +, Fangxiaozhi (Franko) wrote: Dear Greg: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Saturday, January 19, 2013 7:42 AM To: Fangxiaozhi (Franko) Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;

Re: [PATCH 29/33] usb: Convert to devm_ioremap_resource()

2013-01-21 Thread Alan Stern
On Mon, 21 Jan 2013, Thierry Reding wrote: Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error messages can be removed from

[PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Arnd Bergmann
In linux-3.8-rc1 it became possible to build the imx and mvebu platforms together in a single kernel, which clashes in the ehci driver. Manjunath Goudar is already working on a patch to convert both the imx and the mvebu glue drivers (along with all the other ARM specific ones) to the new probing

[PATCH 00/15] ARM build regressions in v3.8

2013-01-21 Thread Arnd Bergmann
I know this comes late, but we have a number of broken configurations in ARM in v3.8 that were still building in v3.7, and I'd like to get them all fixed in the final 3.8 release. It would be nice if the respective maintainers could have a look at these patches and apply them directly when they

RE: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-21 Thread Alexey ORISHKO
-Original Message- From: Oliver Neukum [mailto:oneu...@suse.de] On Monday 21 January 2013 15:47:13 Bjørn Mork wrote: But I wonder if this isn't really a generic problem in usbnet. The FLAG_MULTI_PACKET test here seems completely bogus: if (length % dev-maxpacket == 0) {

Re: xHCI immediately wakes up Asus P8Z68-V LX in S5

2013-01-21 Thread Ben Hutchings
On Mon, Jan 21, 2013 at 09:33:15AM -0800, Sarah Sharp wrote: On Mon, Jan 21, 2013 at 12:00:14AM +, Ben Hutchings wrote: I finally got enough email out of the way to get back to this: On Wed, 2012-12-19 at 16:23 -0800, Sarah Sharp wrote: On Wed, Dec 19, 2012 at 03:15:09AM +, Ben

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Felipe Balbi
On Mon, Jan 21, 2013 at 05:16:06PM +, Arnd Bergmann wrote: In linux-3.8-rc1 it became possible to build the imx and mvebu platforms together in a single kernel, which clashes in the ehci driver. Manjunath Goudar is already working on a patch to convert both the imx and the mvebu glue

  1   2   >