Re: [PATCH v4 2/5] HCD files for the DWC2 driver

2013-02-22 Thread Felipe Balbi
Hi, On Thu, Feb 21, 2013 at 07:52:27PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, February 21, 2013 1:16 AM On Tue, Feb 19, 2013 at 06:50:05PM -0800, Paul Zimmerman wrote: +#ifdef DWC2_TRACK_MISSED_SOFS +#warning Compiling code to track

[PATCH] usb: chipidea: don't redefine __ffs()

2013-02-22 Thread Felipe Balbi
chipidea's ffs_nr() is pretty much what __ffs() does. Use that one instead. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/chipidea/ci.h| 15 +-- drivers/usb/chipidea/core.c | 8 drivers/usb/chipidea/debug.c | 4 ++-- drivers/usb/chipidea/udc.c | 12

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Lan Tianyu
On 2013/2/22 16:59, Dave Jones wrote: On Thu, Feb 21, 2013 at 10:40:10AM -0800, Greg KH wrote: USB patches for 3.9-rc1 Here's the big USB merge for 3.9-rc1 Nothing major, lots of gadget fixes, and of course, xhci stuff. I get no USB devices recognised when I insert them any

[ANNOUNCE] tree maintenance change

2013-02-22 Thread Felipe Balbi
Hi folks, I will be changing way I manage my tree. Instead of having separate fixes, dwc3, musb, xceiv and gadget branches, I will maintain only two branches (fixes and next). There will also be a 'testing' branch but nobody should be looking at that. fixes and next will always be immutable,

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Dave Jones
On Thu, Feb 21, 2013 at 10:40:10AM -0800, Greg KH wrote: USB patches for 3.9-rc1 Here's the big USB merge for 3.9-rc1 Nothing major, lots of gadget fixes, and of course, xhci stuff. I get no USB devices recognised when I insert them any more, which I think is pretty major. I suspect

USB: serial: port lifetimes (was: Re: USB Ooops PL2303 when unplug while use (linux v3.7.3))

2013-02-22 Thread Johan Hovold
On Thu, Feb 14, 2013 at 06:43:36PM +0100, Johan Hovold wrote: On Wed, Feb 13, 2013 at 01:40:08PM -0500, Peter Hurley wrote: [...] Looks to me like a bug the usb serial mini-port interface design. A usb bus disconnect has the pl2303 (and every other) mini-port freeing the private data

[PATCH 07/10] staging: usbip: userspace: libsrc: added missing space

2013-02-22 Thread Kurt Kanzenbach
This patch fixes the following checkpatch warning: -WARNING: missing space after enum definition Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de --- drivers/staging/usbip/userspace/libsrc/usbip_common.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 08/10] staging: usbip: remove unnecessary braces

2013-02-22 Thread Kurt Kanzenbach
From: Stefan Reif ke42c...@cip.cs.fau.de This patch fixes the following checkpatch warning: -WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Stefan Reif ke42c...@cip.cs.fau.de Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de ---

[PATCH 06/10] staging: usbip: userspace: libsrc: removed assignments in if conditions

2013-02-22 Thread Kurt Kanzenbach
This patch fixes the following checkpatch error: -ERROR: do not use assignment in if condition Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de --- drivers/staging/usbip/userspace/libsrc/names.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[PATCH 09/10] staging: usbip: userspace: fix whitespace errors

2013-02-22 Thread Kurt Kanzenbach
From: Stefan Reif ke42c...@cip.cs.fau.de This patch fixes the following checkpatch errors: -ERROR: space required after that ',' -ERROR: spaces required around that '=' -ERROR: space prohibited before that close parenthesis -WARNING: please, no space before tabs Signed-off-by: Stefan Reif

[PATCH 10/10] staging: usbip: removed lines over 80 characters

2013-02-22 Thread Kurt Kanzenbach
This patch fixes the following checkpatch warning: -WARNING: line over 80 characters Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de --- drivers/staging/usbip/stub_dev.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/stub_dev.c

[PATCH 03/10] staging: usbip: userspace: libsrc: spaces required around that '='

2013-02-22 Thread Kurt Kanzenbach
This patch fixes the following checkpatch error: -ERROR: spaces required around that '=' Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de --- drivers/staging/usbip/userspace/libsrc/names.c|2 +- drivers/staging/usbip/userspace/libsrc/usbip_common.c |6 +++--- 2 files

[PATCH 02/10] staging: usbip: userspace: libsrc: do not init static/globals to 0

2013-02-22 Thread Kurt Kanzenbach
This patch fixes the following checkpatch errors: -ERROR: do not initialise statics to 0 or NULL -ERROR: do not initialise globals to 0 or NULL Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de --- drivers/staging/usbip/userspace/libsrc/names.c|2 +-

[PATCH 00/10] staging: usbip: Coding style issues

2013-02-22 Thread Kurt Kanzenbach
Stefan and I fixed some coding style issues as reported by checkpatch.pl Kurt Kanzenbach (8): staging: usbip: userspace: libsrc: fix indention staging: usbip: userspace: libsrc: do not init static/globals to 0 staging: usbip: userspace: libsrc: spaces required around that '=' staging:

[PATCH 01/10] staging: usbip: userspace: libsrc: fix indention

2013-02-22 Thread Kurt Kanzenbach
This patch fixes the following checkpatch warning: -ERROR: code indent should use tabs where possible -WARNING: suspect code indent for conditional statements Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de --- drivers/staging/usbip/userspace/libsrc/names.c | 380 ++--

[PATCH 04/10] staging: usbip: userspace: libsrc: (foo*) should be (foo *)

2013-02-22 Thread Kurt Kanzenbach
This patch fixes the following checkpatch error: -ERROR: (foo*) should be (foo *) Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de --- drivers/staging/usbip/userspace/libsrc/vhci_driver.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 05/10] staging: usbip: userspace: libsrc: replaced lines over 80 characters

2013-02-22 Thread Kurt Kanzenbach
This patch fixes some of the following checkpatch warnings: -WARNING: line over 80 characters We did not split format strings for readability. Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de --- drivers/staging/usbip/userspace/libsrc/names.c | 215 +---

[PATCH 0/3] usbnet: smsc95xx: fix smsc95xx_suspend

2013-02-22 Thread Ming Lei
Hi, The 1st two patches fix smsc95xx_suspend, and the 1st one should be backported to 3.8. The last one is to rename the misleading FEATURE_AUTOSUSPEND. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

[PATCH 1/3] usbnet: smsc95xx: fix suspend failure

2013-02-22 Thread Ming Lei
The three below functions: smsc95xx_enter_suspend0() smsc95xx_enter_suspend1() smsc95xx_enter_suspend2() return 0 in case of success, so they will cause smsc95xx_suspend() to return 0 and cause suspend failure. The bug is introduced in commit 3b9f7d(smsc95xx: fix error

[PATCH 2/3] usbnet: smsc95xx: fix broken runtime suspend

2013-02-22 Thread Ming Lei
Commit b2d4b150(smsc95xx: enable dynamic autosuspend) implements autosuspend, but breaks current runtime suspend, such as: when the interface becomes down, the usb device can't be put into runtime suspend any more. This patch fixes the broken runtime suspend. Cc: Steve Glendinning

[PATCH 3/3] usbnet: smsc95xx: rename FEATURE_AUTOSUSPEND

2013-02-22 Thread Ming Lei
The name of FEATURE_AUTOSUSPEND is very misleading and the actual meaning is remote wakeup, but a device incapable of remote wakeup still can support USB autosuspend under some situations, so rename it to avoid misunderstanding. Cc: Steve Glendinning steve.glendinn...@shawell.net Signed-off-by:

Re: Issue with mini-SaS to eSATA to USB 3.0 setup

2013-02-22 Thread Fabio David
resent On Thu, Feb 21, 2013 at 4:26 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: Cc-ing the SCSI and USB storage list. Folks, does the attached picture look like a sane setup? I've never used mini-SaS to eSATA adapter before, let alone with four eSATA to USB 3.0 adapters. I know

Re: Issue with mini-SaS to eSATA to USB 3.0 setup

2013-02-22 Thread Fabio David
RESENT -- Forwarded message -- From: Fabio David fabioda...@gmail.com Date: Thu, Feb 21, 2013 at 5:42 PM Subject: Re: [usb-storage] Issue with mini-SaS to eSATA to USB 3.0 setup Thanks for your reply, Matt. But it works! Only sometimes the OS doesnt see hot-insertion /

Re: BUG: remove ASS/PSS polling timeout

2013-02-22 Thread Alan Stern
On Fri, 22 Feb 2013, Ronald wrote: Let me know how this works. I'm receiving the same result as Paul Hartman. Device works without a hitch after three reboots. If you consider it appriopate/helpful, you could add: Tested-by: Ronald Uitermark ronald...@gmail.com Okay, thanks to both of

Re: USB: serial: port lifetimes (was: Re: USB Ooops PL2303 when unplug while use (linux v3.7.3))

2013-02-22 Thread Alan Stern
On Fri, 22 Feb 2013, Johan Hovold wrote: We keep the usb-serial-port structure around until the last tty reference is dropped, but the port private data is freed as part of unregistering from the bus in disconnect. [ The subdrivers aren't supposed to access the ports after port_remove is

Re: [ANNOUNCE] tree maintenance change

2013-02-22 Thread Greg KH
On Fri, Feb 22, 2013 at 11:46:10AM +0200, Felipe Balbi wrote: Hi folks, I will be changing way I manage my tree. Instead of having separate fixes, dwc3, musb, xceiv and gadget branches, I will maintain only two branches (fixes and next). There will also be a 'testing' branch but nobody

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Dave Jones
On Fri, Feb 22, 2013 at 05:51:10PM +0800, Lan Tianyu wrote: Nothing major, lots of gadget fixes, and of course, xhci stuff. I get no USB devices recognised when I insert them any more, which I think is pretty major. I suspect it has something to do with this ? Lan Tianyu

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Lan Tianyu
On 2013/2/23 0:43, Dave Jones wrote: On Fri, Feb 22, 2013 at 05:51:10PM +0800, Lan Tianyu wrote: Nothing major, lots of gadget fixes, and of course, xhci stuff. I get no USB devices recognised when I insert them any more, which I think is pretty major. I suspect it has

Re: USB: serial: port lifetimes (was: Re: USB Ooops PL2303 when unplug while use (linux v3.7.3))

2013-02-22 Thread Johan Hovold
On Fri, Feb 22, 2013 at 10:17:51AM -0500, Alan Stern wrote: On Fri, 22 Feb 2013, Johan Hovold wrote: We keep the usb-serial-port structure around until the last tty reference is dropped, but the port private data is freed as part of unregistering from the bus in disconnect. [ The

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Dave Jones
On Sat, Feb 23, 2013 at 01:02:11AM +0800, Lan Tianyu wrote: What can I do to debug this ? Can you attach the output of dmesg with CONFIG_USB_DEBUG? http://paste.fedoraproject.org/3620 How aboutsudo lsusb -s 1:1 -v or 2:1? (12:13:51:davej@t430s:~)$ sudo lsusb -s 1:1

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Lan Tianyu
On 2013/2/23 1:14, Dave Jones wrote: On Sat, Feb 23, 2013 at 01:02:11AM +0800, Lan Tianyu wrote: What can I do to debug this ? Can you attach the output of dmesg with CONFIG_USB_DEBUG? http://paste.fedoraproject.org/3620 How aboutsudo lsusb -s 1:1 -v or 2:1?

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Dave Jones
On Sat, Feb 23, 2013 at 01:17:42AM +0800, Lan Tianyu wrote: On 2013/2/23 1:14, Dave Jones wrote: On Sat, Feb 23, 2013 at 01:02:11AM +0800, Lan Tianyu wrote: What can I do to debug this ? Can you attach the output of dmesg with CONFIG_USB_DEBUG?

Re: USB: serial: port lifetimes (was: Re: USB Ooops PL2303 when unplug while use (linux v3.7.3))

2013-02-22 Thread Alan Stern
On Fri, 22 Feb 2013, Johan Hovold wrote: So we end up with an unregistered device still possibly referenced by tty instead, and I suspect we can't do much else than deal with any post-disconnect callbacks. [ These should be few, especially with my latest TTY-patches applied. ]

Re: USB: serial: port lifetimes (was: Re: USB Ooops PL2303 when unplug while use (linux v3.7.3))

2013-02-22 Thread Greg KH
On Fri, Feb 22, 2013 at 12:35:32PM -0500, Alan Stern wrote: On Fri, 22 Feb 2013, Johan Hovold wrote: So we end up with an unregistered device still possibly referenced by tty instead, and I suspect we can't do much else than deal with any post-disconnect callbacks. [ These should be

Re: USB: serial: port lifetimes (was: Re: USB Ooops PL2303 when unplug while use (linux v3.7.3))

2013-02-22 Thread Peter Hurley
On Fri, 2013-02-22 at 12:35 -0500, Alan Stern wrote: On Fri, 22 Feb 2013, Johan Hovold wrote: So we end up with an unregistered device still possibly referenced by tty instead, and I suspect we can't do much else than deal with any post-disconnect callbacks. [ These should be few,

Re: USB: serial: port lifetimes (was: Re: USB Ooops PL2303 when unplug while use (linux v3.7.3))

2013-02-22 Thread Alan Stern
On Fri, 22 Feb 2013, Peter Hurley wrote: ISTM the usb_serial_port private data should not be freed until port_release(). I don't think that's right. In general, a driver doesn't know what's going to happen to a device after the two are unbound from each other. Another driver may get bound

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Fabio Baltieri
On Fri, Feb 22, 2013 at 03:59:54AM -0500, Dave Jones wrote: On Thu, Feb 21, 2013 at 10:40:10AM -0800, Greg KH wrote: USB patches for 3.9-rc1 Here's the big USB merge for 3.9-rc1 Nothing major, lots of gadget fixes, and of course, xhci stuff. I get no USB devices recognised

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Dave Jones
On Fri, Feb 22, 2013 at 10:51:58PM +0100, Fabio Baltieri wrote: On Fri, Feb 22, 2013 at 03:59:54AM -0500, Dave Jones wrote: On Thu, Feb 21, 2013 at 10:40:10AM -0800, Greg KH wrote: It looks like every port on my laptop is powered down, as I can't even charge devices with it. I

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Fabio Baltieri
On Fri, Feb 22, 2013 at 05:23:04PM -0500, Dave Jones wrote: On Fri, Feb 22, 2013 at 10:51:58PM +0100, Fabio Baltieri wrote: On Fri, Feb 22, 2013 at 03:59:54AM -0500, Dave Jones wrote: On Thu, Feb 21, 2013 at 10:40:10AM -0800, Greg KH wrote: It looks like every port on my laptop is

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Rafael J. Wysocki
On Friday, February 22, 2013 10:51:58 PM Fabio Baltieri wrote: On Fri, Feb 22, 2013 at 03:59:54AM -0500, Dave Jones wrote: On Thu, Feb 21, 2013 at 10:40:10AM -0800, Greg KH wrote: USB patches for 3.9-rc1 Here's the big USB merge for 3.9-rc1 Nothing major, lots of gadget

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Rafael J. Wysocki
On Friday, February 22, 2013 05:23:04 PM Dave Jones wrote: On Fri, Feb 22, 2013 at 10:51:58PM +0100, Fabio Baltieri wrote: On Fri, Feb 22, 2013 at 03:59:54AM -0500, Dave Jones wrote: On Thu, Feb 21, 2013 at 10:40:10AM -0800, Greg KH wrote: It looks like every port on my laptop is

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Rafael J. Wysocki
On Saturday, February 23, 2013 01:10:55 AM Fabio Baltieri wrote: On Fri, Feb 22, 2013 at 05:23:04PM -0500, Dave Jones wrote: On Fri, Feb 22, 2013 at 10:51:58PM +0100, Fabio Baltieri wrote: On Fri, Feb 22, 2013 at 03:59:54AM -0500, Dave Jones wrote: On Thu, Feb 21, 2013 at 10:40:10AM

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Linus Torvalds
On Fri, Feb 22, 2013 at 4:19 PM, Rafael J. Wysocki r...@sisk.pl wrote: It won't revert, there's more stuff on top of it. And it is a fix, so reverting it is not really a good idea anyway. Rafael, please don't *ever* write that crap again. We revert stuff whether it fixed something else or

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Rafael J. Wysocki
On Friday, February 22, 2013 04:30:25 PM Linus Torvalds wrote: On Fri, Feb 22, 2013 at 4:19 PM, Rafael J. Wysocki r...@sisk.pl wrote: It won't revert, there's more stuff on top of it. And it is a fix, so reverting it is not really a good idea anyway. Rafael, please don't *ever* write

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Rafael J. Wysocki
On Friday, February 22, 2013 10:51:58 PM Fabio Baltieri wrote: On Fri, Feb 22, 2013 at 03:59:54AM -0500, Dave Jones wrote: On Thu, Feb 21, 2013 at 10:40:10AM -0800, Greg KH wrote: USB patches for 3.9-rc1 Here's the big USB merge for 3.9-rc1 Nothing major, lots of gadget

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Linus Torvalds
On Fri, Feb 22, 2013 at 4:48 PM, Rafael J. Wysocki r...@sisk.pl wrote: The problem is, though, that even if bisection turns up something, it doesn't automatically mean that this particular commit is the one that caused the problem to happen in the first place. No, I agree. I just react *very*

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Fabio Baltieri
On Sat, Feb 23, 2013 at 01:35:26AM +0100, Rafael J. Wysocki wrote: On Saturday, February 23, 2013 01:10:55 AM Fabio Baltieri wrote: Well, this did the trick in my case: --- 8 --- diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c index b820528..54175a0 100644 ---

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Rafael J. Wysocki
On Friday, February 22, 2013 05:10:43 PM Linus Torvalds wrote: On Fri, Feb 22, 2013 at 4:48 PM, Rafael J. Wysocki r...@sisk.pl wrote: The problem is, though, that even if bisection turns up something, it doesn't automatically mean that this particular commit is the one that caused the

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-22 Thread Rafael J. Wysocki
On Saturday, February 23, 2013 02:44:27 AM Fabio Baltieri wrote: On Sat, Feb 23, 2013 at 01:35:26AM +0100, Rafael J. Wysocki wrote: On Saturday, February 23, 2013 01:10:55 AM Fabio Baltieri wrote: Well, this did the trick in my case: --- 8 --- diff --git a/drivers/acpi/power.c

Re: [PATCH 04/10] staging: usbip: userspace: libsrc: (foo*) should be (foo *)

2013-02-22 Thread Dan Carpenter
On Fri, Feb 22, 2013 at 12:13:28PM +0100, Kurt Kanzenbach wrote: This patch fixes the following checkpatch error: -ERROR: (foo*) should be (foo *) Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de --- drivers/staging/usbip/userspace/libsrc/vhci_driver.c |2 +- 1 file changed, 1

Re: [PATCH 06/10] staging: usbip: userspace: libsrc: removed assignments in if conditions

2013-02-22 Thread Dan Carpenter
On Fri, Feb 22, 2013 at 12:13:30PM +0100, Kurt Kanzenbach wrote: This patch fixes the following checkpatch error: -ERROR: do not use assignment in if condition Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de --- drivers/staging/usbip/userspace/libsrc/names.c | 11 +++ 1