Re: [PATCH v2 2/5] usb: chipidea: udc: configure iso endpoints

2013-03-07 Thread Michael Grzeschik
On Mon, Mar 04, 2013 at 11:26:07AM +0800, Peter Chen wrote: On Fri, Mar 01, 2013 at 03:42:24PM +0100, Michael Grzeschik wrote: The implementation is derived from the fsl_udc_core code in fsl_ep_enable and makes basic iso handling possible. Signed-off-by: Michael Grzeschik

Re: v3.9-rc1: swapper/0 [ INFO: possible circular locking dependency detected ]

2013-03-07 Thread Peter Chen
On Wed, Mar 06, 2013 at 11:33:02AM +0100, Maxime Ripard wrote: Hi, Just noticed this in 3.9-rc1 on an iMX28 (ARM) board with a config based on mxs_defconfig. I'm using the patchset Add tested id switch and vbus connect detect support for Chipidea from Peter Chen in its 10th version [1],

Re: [PATCH 4/5] usb: chipidea: udc: manage dynamic amount of tds with an linked list

2013-03-07 Thread Michael Grzeschik
On Tue, Mar 05, 2013 at 04:40:12PM +0800, Peter Chen wrote: On Fri, Mar 01, 2013 at 03:42:26PM +0100, Michael Grzeschik wrote: Instead of having a limited number of usable tds in the udc we use a linked list to support dynamic amount of needed tds for all special gadget types. This improves

Re: [PATCH v2 2/5] usb: chipidea: udc: configure iso endpoints

2013-03-07 Thread Peter Chen
I will add defines und use them. + max = 0x7ff; /* bit 0~10 */ Useless line? Not intended. I will have to change the capability setting of the qh to use max instead of mEp-ep.maxpacket. mult = (unsigned char)(1 + ((max 11) 0x03));

Re: [PATCH 5/5] usb: chipidea: udc: add multiple td support to hardware_{en,de}queue

2013-03-07 Thread Michael Grzeschik
On Tue, Mar 05, 2013 at 05:13:54PM +0800, Peter Chen wrote: On Fri, Mar 01, 2013 at 03:42:27PM +0100, Michael Grzeschik wrote: This patch removes the limitation of having a limited amount of only four active tds on one endpoint. We use the linked list implementation to manage all tds which

[PATCH 3/5] usb: musb: ux500: add otg notifier support

2013-03-07 Thread Fabio Baltieri
Add transceiver notifier event handling to the ux500 driver to set vbus on specific transceiver events. Acked-by: Linus Walleij linus.wall...@linaro.org Signed-off-by: Fabio Baltieri fabio.balti...@linaro.org --- drivers/usb/musb/ux500.c | 42 ++ 1 file

fsl_udc_core: set address request aren't handled like expected. usb30cv test suite fails.

2013-03-07 Thread Peter Bestler
Hi, We try to get our device (based on p2020rdb) usb 2.0 compliant. We ran the usb30cv test suite (version 1.0.1.2, chapter 9 tests for usb 2.0 devices) on win7 with g_zero and g_serial. We access the device via an usb 3.0 hcd from intel. Our device runs the 3.2.35-rt52 kernel. I spotted the

Re: [PATCH 4/5] usb: chipidea: udc: manage dynamic amount of tds with an linked list

2013-03-07 Thread Peter Chen
On Thu, Mar 07, 2013 at 09:16:12AM +0100, Michael Grzeschik wrote: On Tue, Mar 05, 2013 at 04:40:12PM +0800, Peter Chen wrote: On Fri, Mar 01, 2013 at 03:42:26PM +0100, Michael Grzeschik wrote: Instead of having a limited number of usable tds in the udc we use a linked list to support

Re: [PATCH 3/5] usb: musb: ux500: add otg notifier support

2013-03-07 Thread Fabio Baltieri
On Thu, Mar 07, 2013 at 04:57:40PM +0800, Fabio Baltieri wrote: Add transceiver notifier event handling to the ux500 driver to set vbus on specific transceiver events. Acked-by: Linus Walleij linus.wall...@linaro.org Signed-off-by: Fabio Baltieri fabio.balti...@linaro.org --- Sorry, I

Re: [PATCH 4/5] usb: chipidea: udc: manage dynamic amount of tds with an linked list

2013-03-07 Thread Peter Chen
On Fri, Mar 01, 2013 at 03:42:26PM +0100, Michael Grzeschik wrote: Instead of having a limited number of usable tds in the udc we use a linked list to support dynamic amount of needed tds for all special gadget types. This improves throughput. Is it better just allocate td at ep_queue? For

Re: [PATCH 5/5] usb: chipidea: udc: add multiple td support to hardware_{en,de}queue

2013-03-07 Thread Peter Chen
- mReq-req.actual = node_first-ptr-token TD_TOTAL_BYTES; - mReq-req.actual = ffs_nr(TD_TOTAL_BYTES); - mReq-req.actual = mReq-req.length - mReq-req.actual; + mReq-req.actual = actual; If the mReq-req.actual will be changed at below line, any reasons to do it? Correct,

[PATCH 06/10] usb: power: pda_power: check against CONFIG_USB_PHY

2013-03-07 Thread Felipe Balbi
CONFIG_USB_OTG_UTILS will be removed very soon, so we should check CONFIG_USB_PHY instead. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/power/pda_power.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/power/pda_power.c

[PATCH 05/10] usb: phy: make it a menuconfig

2013-03-07 Thread Felipe Balbi
We already have a considerable amount of USB PHY drivers, making it a menuconfig just prevents us from adding too much churn to USB's menuconfig. While at that, also select USB_OTG_UTILS from this new menuconfig just to keep backwards compatibility until we manage to remove that symbol.

[PATCH 02/10] usb: otg: move usb_otg_state_string to usb-common.c

2013-03-07 Thread Felipe Balbi
otg.c only had a single function definition which might make more sense to be placed in usb-common.c. While doing that, we also delete otg.c since it's now empty. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/otg/Makefile | 3 --- drivers/usb/otg/otg.c| 47

[PATCH 09/10] usb: ehci: tegra: check against CONFIG_USB_PHY

2013-03-07 Thread Felipe Balbi
CONFIG_USB_OTG_UTILS will be removed very soon, so we should check CONFIG_USB_PHY instead. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/host/ehci-tegra.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c

[PATCH 10/10] usb: phy: remove CONFIG_USB_OTG_UTILS

2013-03-07 Thread Felipe Balbi
there are no more users of CONFIG_USB_OTG_UTILS left in tree, we can remove it just fine. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/phy/Kconfig | 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index

[PATCH 04/10] usb: phy: move all PHY drivers to drivers/usb/phy/

2013-03-07 Thread Felipe Balbi
that's a much more reasonable location for those drivers. It helps us saving drivers/usb/otg/ for when we actually start adding generic OTG code. Also completely delete drivers/usb/otg/ as there's nothing left there. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/Kconfig

[PATCH 07/10] usb: gadget: mv_udc_core: check against CONFIG_USB_PHY

2013-03-07 Thread Felipe Balbi
CONFIG_USB_OTG_UTILS will be removed very soon, so we should check CONFIG_USB_PHY instead. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/mv_udc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/mv_udc_core.c

[PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-07 Thread Felipe Balbi
Hi folks, inspired by Paul's DWC2 patchset which added usb_otg_state_string() (a copy of otg_state_string()) I have now renamed otg_state_string() to usb_otg_state_string(), moved it to usb-common, then moved all phy drivers to drivers/usb/phy/ and completely deleted the otg directory. We're

[PATCH 03/10] usb: phy: convert EXPORT_SYMBOL to EXPORT_SYMBOL_GPL

2013-03-07 Thread Felipe Balbi
we only want GPL users for our generic functions, so let's switch over to EXPORT_SYMBOL_GPL. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/phy/phy.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c

[PATCH 01/10] usb: otg: prefix otg_state_string with usb_

2013-03-07 Thread Felipe Balbi
all other functions under drivers/usb/ start with usb_, let's do the same thing. This patch is in preparation for moving otg_state_string to usb-common.c and deleting otg.c completely. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/musb/am35x.c| 8

[PATCH 08/10] usb: ehci: marvel: check against CONFIG_USB_PHY

2013-03-07 Thread Felipe Balbi
CONFIG_USB_OTG_UTILS will be removed very soon, so we should check CONFIG_USB_PHY instead. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/host/ehci-mv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index

Re: [Fwd: [PATCH v2 0/4] TTY: port hangup and close fixes]

2013-03-07 Thread Johan Hovold
On Wed, Mar 06, 2013 at 02:14:56PM -0500, Peter Hurley wrote: On Wed, 2013-03-06 at 17:52 +0100, Johan Hovold wrote: @@ -225,15 +232,13 @@ void tty_port_hangup(struct tty_port *port) spin_lock_irqsave(port-lock, flags); port-count = 0; port-flags =

Re: [PATCH v6 1/7] usb: common: add a routine to print the OTG state

2013-03-07 Thread Felipe Balbi
On Thu, Mar 07, 2013 at 09:42:58AM +0200, Felipe Balbi wrote: Hi, On Thu, Mar 07, 2013 at 12:58:04AM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, March 05, 2013 11:42 PM On Mon, Mar 04, 2013 at 12:21:44PM -0800, Paul Zimmerman wrote:

Re: fsl_udc_core: set address request aren't handled like expected. usb30cv test suite fails.

2013-03-07 Thread Peter Chen
On Thu, Mar 07, 2013 at 09:58:52AM +0100, Peter Bestler wrote: Hi, We try to get our device (based on p2020rdb) usb 2.0 compliant. We ran the usb30cv test suite (version 1.0.1.2, chapter 9 tests for usb 2.0 devices) on win7 with g_zero and g_serial. We access the device via an usb 3.0 hcd

Re: [PATCH v11 6/9] usb: chipidea: add vbus regulator control

2013-03-07 Thread Felipe Balbi
On Thu, Mar 07, 2013 at 10:41:03AM +0800, Peter Chen wrote: On Wed, Mar 06, 2013 at 01:29:16PM +0200, Felipe Balbi wrote: Hi, On Wed, Mar 06, 2013 at 05:56:37PM +0800, Peter Chen wrote: For boards which have board level vbus control (eg, gpio), we need to operation vbus according to

Re: v3.9-rc1: swapper/0 [ INFO: possible circular locking dependency detected ]

2013-03-07 Thread Maxime Ripard
Hi Peter, Le 07/03/2013 09:08, Peter Chen a écrit : On Wed, Mar 06, 2013 at 11:33:02AM +0100, Maxime Ripard wrote: [2.149645] other info that might help us debug this: [2.149645] [2.157667] Possible unsafe locking scenario: [2.157667] [2.163598]CPU0

[PATCH] USB: cdc-acm: Remove obsolete predefined speeds array

2013-03-07 Thread Samuel Tardieu
Modern speed handling has been introduced by commit 9b80fee149a875a6292b2556ab2c64dc7ab7d6f5 in 2009 and the acm_tty_speed array has been unused since. Signed-off-by: Samuel Tardieu s...@rfc1149.net --- drivers/usb/class/cdc-acm.c | 8 1 file changed, 8 deletions(-) diff --git

Re: [PATCH] USB: cdc-acm: Remove obsolete predefined speeds array

2013-03-07 Thread Oliver Neukum
On Thursday 07 March 2013 11:39:28 Samuel Tardieu wrote: Modern speed handling has been introduced by commit 9b80fee149a875a6292b2556ab2c64dc7ab7d6f5 in 2009 and the acm_tty_speed array has been unused since. Signed-off-by: Samuel Tardieu s...@rfc1149.net Acked-by: Oliver Neukum

[PATCH v2] USB: cdc-acm: Remove obsolete predefined speeds array

2013-03-07 Thread Samuel Tardieu
Modern speed handling has been introduced in 2009 by commit 9b80fee149a875a6292b2556ab2c64dc7ab7d6f5 (cdc_acm: Fix to use modern speed interfaces) and the acm_tty_speed array has been unused since. Signed-off-by: Samuel Tardieu s...@rfc1149.net Acked-by: Oliver Neukum oli...@neukum.org ---

Re: 答复: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-07 Thread Bjørn Mork
Fangxiaozhi (Franko) fangxiao...@huawei.com writes: As far as I know, except switching in kernel, there isn't any mode switch solution on Android now. Do you have any good ideas for the mode switch on Android system? Josh, the usb_modeswitch maintainer, is also maintaining

Re: [PATCH 0/5] usb: musb: am335x support

2013-03-07 Thread Daniel Mack
On 04.03.2013 00:53, Daniel Mack wrote: Hi Peter, On 03.03.2013 23:24, Peter Korsgaard wrote: Daniel == Daniel Mack zon...@gmail.com writes: Hi, Daniel On my board, the USB is purely used as host interface, with a Daniel type B plug soldered. In the DT, I'm using the following Daniel

[PATCH v2 1/4] usb: dwc3: set dma_mask for dwc3_omap device

2013-03-07 Thread Kishon Vijay Abraham I
*dma_mask* is not set for devices created from dt data. So filled dma_mask for dwc3_omap device here. And dwc3 core will copy the dma_mask from its parent. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/dwc3/core.c |4 drivers/usb/dwc3/dwc3-omap.c |3 +++ 2

[PATCH v2 2/4] usb: dwc3: dwc3-omap: return -EPROBE_DEFER if probe has not yet executed

2013-03-07 Thread Kishon Vijay Abraham I
return -EPROBE_DEFER from dwc3_omap_mailbox in dwc3-omap.c, if the probe of dwc3-omap has not yet been executed or failed. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/dwc3/dwc3-omap.c |7 +-- include/linux/usb/dwc3-omap.h |6 +++--- 2 files changed, 8

[PATCH v2 0/4] usb: added palmas-usb driver and a few misc fixes

2013-03-07 Thread Kishon Vijay Abraham I
Added palmas-usb driver which is mainly used as comparator driver to detect vbus/id events when a USB cable is connected and passes on the event information to omap glue (dwc3-omap.c) The other fixes include setting dma_mask for dwc3 device since device tree doesn't fill dma_mask, returning

[PATCH v2 4/4] usb: musb: omap2430: replace *_* with *-* in property names

2013-03-07 Thread Kishon Vijay Abraham I
No functional change. Replace *_* with *-* in property names of otg to follow the general convention. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- Documentation/devicetree/bindings/usb/omap-usb.txt | 12 ++-- drivers/usb/musb/omap2430.c|6 +++---

[PATCH v2 3/4] USB: Palmas OTG Transceiver Driver

2013-03-07 Thread Kishon Vijay Abraham I
From: Graeme Gregory g...@slimlogic.co.uk This is the driver for the OTG transceiver built into the Palmas chip. It handles the various USB OTG events that can be generated by cable insertion/removal. Signed-off-by: Graeme Gregory g...@slimlogic.co.uk Signed-off-by: Moiz Sonasath

[PATCH v3 5/7] ARM: dts: omap5: Add ocp2scp data

2013-03-07 Thread Kishon Vijay Abraham I
Add ocp2scp data node in omap5 device tree file. The information for the node added here can be found @ Documentation/devicetree/bindings/bus/omap-ocp2scp.txt Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- arch/arm/boot/dts/omap5.dtsi |8 1 file changed, 8 insertions(+)

[PATCH v3 7/7] ARM: dts: omap5: add dwc3 omap and dwc3 core dt data

2013-03-07 Thread Kishon Vijay Abraham I
Add dwc3 omap glue data to the omap5 dt data file. The information about the dt node added here is available @ Documentation/devicetree/bindings/usb/omap-usb.txt. Also added dwc3 core dt data as a subnode to dwc3 omap glue data in omap5 dt data file. The information for the entered data node is

[PATCH v3 3/7] ARM: dts: omap: Add usb_otg and glue data

2013-03-07 Thread Kishon Vijay Abraham I
Add usb otg data node in omap4/omap3 device tree file. Also update the node with board specific setting in omapx-board.dts file. The dt data specifies among others the interface type (ULPI or UTMI), mode which is mostly OTG, power that specifies the amount of power this can supply when in host

[PATCH v3 2/7] ARM: dts: omap: Add omap-usb2 dt data

2013-03-07 Thread Kishon Vijay Abraham I
Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is connected to ocp2scp, omap-usb2 dt data is added as a child node of ocp2scp. The information about this data node is availabe @ Documentation/devicetree/bindings/usb/usb-phy.txt Acked-by: Felipe Balbi ba...@ti.com

[PATCH v3 1/7] ARM: dts: omap: Add omap control usb data

2013-03-07 Thread Kishon Vijay Abraham I
Add omap control usb data in omap4 device tree file. This will have the register address of registers to power on the PHY and to write to mailbox. The information about this data node is available @ Documentation/devicetree/bindings/usb/omap-usb.txt Signed-off-by: Kishon Vijay Abraham I

[PATCH v3 6/7] ARM: dts: omap5: Add omap-usb3 and omap-usb2 dt data

2013-03-07 Thread Kishon Vijay Abraham I
Add omap-usb3 and omap-usb2 data node in omap5 device tree file. The information for the node added here is available @ Documentation/devicetree/bindings/usb/usb-phy.txt Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 14 ++ 1 file changed, 14

[PATCH v3 4/7] ARM: dts: omap5: Add omap control usb data

2013-03-07 Thread Kishon Vijay Abraham I
Add omap control usb data in omap5 device tree file. This will have the register address of registers to power on the USB2 PHY and USB3 PHY. The information for the node added here is available in Documentation/devicetree/bindings/usb/omap-usb.txt Signed-off-by: Kishon Vijay Abraham I

[PATCH v3 0/7] ARM: dts: omap: Add dts data for USB

2013-03-07 Thread Kishon Vijay Abraham I
Hi Benoit, Here are the dt data patches to get usb device functional in OMAP platforms. All the patches deal with modifying arch/arm/boot except one which modifies Documentation/../usb/omap-usb.txt Changes from v2: * squashed the dt data for dwc3-omap with dwc3 core into a single patch.

Re: [PATCH 5/5] usb: chipidea: udc: add multiple td support to hardware_{en,de}queue

2013-03-07 Thread Michael Grzeschik
On Thu, Mar 07, 2013 at 09:25:34AM +0100, Michael Grzeschik wrote: On Tue, Mar 05, 2013 at 05:13:54PM +0800, Peter Chen wrote: On Fri, Mar 01, 2013 at 03:42:27PM +0100, Michael Grzeschik wrote: This patch removes the limitation of having a limited amount of only four active tds on one

Re: 答复: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-07 Thread Josua Dietze
Am 07.03.2013 13:19, schrieb Bjørn Mork: it looks like your app will need to be a member of the usb group to do this. I assume there is a way for an app to request such permissions in Android. Josh has obviously managed to get it. Actually, the PPP Widget app requires access to a root shell

[RFC PATCH 2/4] ARM: OMAP1: nokia770: enable Tahvo

2013-03-07 Thread Aaro Koskinen
Add platform data for Tahvo. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- arch/arm/mach-omap1/board-nokia770.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/mach-omap1/board-nokia770.c b/arch/arm/mach-omap1/board-nokia770.c index 62a15e2..91449c5 100644 ---

[RFC PATCH 4/4] USB: OMAP: Tahvo USB transceiver driver

2013-03-07 Thread Aaro Koskinen
Add Tahvo USB transceiver driver. Based on old code from linux-omap tree. The original driver was written by Juha Yrjölä, Tony Lindgren, and Timo Teräs. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/otg/Kconfig | 16 ++ drivers/usb/otg/Makefile|1 +

[RFC PATCH 3/4] USB: OMAP: move omap-otg out from isp1301_omap

2013-03-07 Thread Aaro Koskinen
omap-otg platform device will be needed also by other transceivers. It's not possible to have multiple instances of the driver, so it needs to be moved into a separate file so that other drivers can hook into it. Start this change with a very simplest implementation, much of the OMAP OTG code in

[RFC PATCH 0/4] USB: OMAP: Tahvo USB support for 770

2013-03-07 Thread Aaro Koskinen
Hi, These patches add support for Tahvo USB transceiver and allow use both host and peripheral modes on Nokia 770. Patches work with 3.9-rc1, but the following fixes must be also applied: ARM: OMAP1: fix USB host on 1710 http://marc.info/?l=linux-omapm=135906630828618w=2

[RFC PATCH 1/4] retu-mfd: support also Tahvo

2013-03-07 Thread Aaro Koskinen
Tahvo is a multi-function device on Nokia 770, implementing USB transceiver and charge/battery control. It's so close to Retu that a single driver can support both. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi Cc: Samuel Ortiz sa...@linux.intel.com --- drivers/mfd/Kconfig |6 +--

[PATCH v2] usb: phy: remove CONFIG_USB_OTG_UTILS

2013-03-07 Thread Felipe Balbi
there are no more users of CONFIG_USB_OTG_UTILS left in tree, we can remove it just fine. Signed-off-by: Felipe Balbi ba...@ti.com --- v1 - v2: . removed a few extra instances which my original (and stupid) grep didn't find drivers/power/Kconfig | 2 +-

Re: [RFC PATCH 1/4] retu-mfd: support also Tahvo

2013-03-07 Thread Felipe Balbi
Hi, On Thu, Mar 07, 2013 at 04:40:18PM +0200, Aaro Koskinen wrote: Tahvo is a multi-function device on Nokia 770, implementing USB transceiver and charge/battery control. It's so close to Retu that a single driver can support both. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi Cc:

Re: [RFC PATCH 3/4] USB: OMAP: move omap-otg out from isp1301_omap

2013-03-07 Thread Felipe Balbi
On Thu, Mar 07, 2013 at 04:40:20PM +0200, Aaro Koskinen wrote: omap-otg platform device will be needed also by other transceivers. It's not possible to have multiple instances of the driver, so it needs to be moved into a separate file so that other drivers can hook into it. Start this

Re: [RFC PATCH 4/4] USB: OMAP: Tahvo USB transceiver driver

2013-03-07 Thread Felipe Balbi
On Thu, Mar 07, 2013 at 04:40:21PM +0200, Aaro Koskinen wrote: Add Tahvo USB transceiver driver. Based on old code from linux-omap tree. The original driver was written by Juha Yrjölä, Tony Lindgren, and Timo Teräs. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi ---

[PATCH v3 2/6] TTY: wake up processes last at hangup

2013-03-07 Thread Johan Hovold
Move wake up of processes on blocked-open and modem-status wait queues to after port shutdown at hangup. This way the woken up processes can use the ASYNC_INITIALIZED flag to detect port shutdown. Note that this is the order currently used by serial-core. Signed-off-by: Johan Hovold

[PATCH v3 6/6] TTY: fix close of uninitialised ports

2013-03-07 Thread Johan Hovold
Make sure we do not make tty-driver callbacks or wait for port to drain on uninitialised ports (e.g. when open failed) in tty_port_close_start(). No callback, such as flush_buffer or wait_until_sent, needs to be made on a port that has never been opened. Neither does it make much sense to add

[PATCH v3 4/6] TTY: fix DTR not being dropped on hang up

2013-03-07 Thread Johan Hovold
Move HUPCL handling to port shutdown so that DTR is dropped also on hang up (tty_port_close is a noop for hung-up ports). Also do not try to drop DTR for uninitialised ports where it has never been raised (e.g. after a failed open). Note that this is also the current behaviour of serial-core.

[PATCH v3 1/6] TTY: clean up port shutdown

2013-03-07 Thread Johan Hovold
Untangle port-shutdown logic and make sure the initialised flag is always cleared for non-console ports. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/tty/tty_port.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_port.c

[PATCH v3 3/6] TTY: fix DTR being raised on hang up

2013-03-07 Thread Johan Hovold
Make sure to check ASYNC_INITIALISED before raising DTR when waking up from blocked open in tty_port_block_til_ready. Currently DTR could get raised at hang up as a blocked process would raise DTR unconditionally before checking for hang up and returning. Signed-off-by: Johan Hovold

[PATCH v3 5/6] TTY: clean up port drain-delay handling

2013-03-07 Thread Johan Hovold
Move port drain-delay handling to a separate function. Signed-off-by: Johan Hovold jhov...@gmail.com --- drivers/tty/tty_port.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c index cd65f7e..048cc85

RE: [PATCH v6 3/7] HCD files for the DWC2 driver

2013-03-07 Thread Alan Stern
On Wed, 6 Mar 2013, Paul Zimmerman wrote: BTW, you _do_ have a race because you don't check ep-hcpriv when -urb_enqueue() is called. This means that you could queue to an endpoint which is in the process of getting disabled. The urb would either be lost or completed before being started

[PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-07 Thread Felipe Balbi
this will make sure that we have sensible names for all phy drivers. Current situation was already quite bad with too generic names being used. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/phy/Makefile | 42 +++---

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-07 Thread Felipe Balbi
On Thu, Mar 07, 2013 at 05:45:26PM +0200, Felipe Balbi wrote: this will make sure that we have sensible names for all phy drivers. Current situation was already quite bad with too generic names being used. Signed-off-by: Felipe Balbi ba...@ti.com Hi, I compiled what I could with

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-07 Thread Alan Stern
On Thu, 7 Mar 2013, Felipe Balbi wrote: Hi folks, inspired by Paul's DWC2 patchset which added usb_otg_state_string() (a copy of otg_state_string()) I have now renamed otg_state_string() to usb_otg_state_string(), moved it to usb-common, then moved all phy drivers to drivers/usb/phy/ and

Re: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-07 Thread Alan Stern
On Thu, 7 Mar 2013, Jenya Y wrote: UPDATE correction to the name of the device Apple Cinema HD Display ( A1082) Since kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot. (their count seems to be random, but the type of the error is always the same) As soon as I

[PATCH v2 1/7] USB: adds comment on suspend callback

2013-03-07 Thread Ming Lei
This patch adds comments on interface driver suspend callback to emphasize that the failure return value is ignored by USB core in system sleep context, so do not try to recover device for this case and let resume/reset_resume callback handle the suspend failure if needed. Also kerneldoc for

[no subject]

2013-03-07 Thread Ming Lei
Hi, This patch adds comments on interface driver suspend callback to emphasize that the failure return value is ignored by USB core in system sleep context, so do not try to recover device for this case, otherwise the recovery things may confuse resume(). Also fixes the USB serial, HID and

[PATCH v2 2/7] USB: serial: handle suspend failure path correctly

2013-03-07 Thread Ming Lei
This patch kills traffic even though type-suspend returns failure inside usb_serial_suspend from system sleep context because USB core ignores the failiure and lets system sleep go ahread, so the serial URB traffic need to be killed in this case. Cc: Johan Hovold jhov...@gmail.com Signed-off-by:

[PATCH v2 0/7] USB: don't recover device if suspend fails in system sleep

2013-03-07 Thread Ming Lei
Hi, Sorry for my broken email client just now. This patch adds comments on interface driver suspend callback to emphasize that the failure return value is ignored by USB core in system sleep context, so do not try to recover device for this case, otherwise the recovery things may confuse

[PATCH v2 1/7] USB: adds comment on suspend callback

2013-03-07 Thread Ming Lei
This patch adds comments on interface driver suspend callback to emphasize that the failure return value is ignored by USB core in system sleep context, so do not try to recover device for this case and let resume/reset_resume callback handle the suspend failure if needed. Also kerneldoc for

[PATCH v2 2/7] USB: serial: handle suspend failure path correctly

2013-03-07 Thread Ming Lei
This patch kills traffic even though type-suspend returns failure inside usb_serial_suspend from system sleep context because USB core ignores the failiure and lets system sleep go ahread, so the serial URB traffic need to be killed in this case. Cc: Johan Hovold jhov...@gmail.com Signed-off-by:

[PATCH v2 4/7] usbnet: cdc_mbim: comments on suspend failure

2013-03-07 Thread Ming Lei
If suspend callback fails in system sleep context, usb core will ignore the failure and let system sleep go ahead further, so this patch comments on the case and requires that both usbnet_suspend() and subdriver-suspend() MUST return 0 in system sleep context. Cc: Bjørn Mork bj...@mork.no

[PATCH v2 6/7] usbnet: smsc95xx: don't recover device if suspend fails in system sleep

2013-03-07 Thread Ming Lei
If suspend callback fails in system sleep context, usb core will ignore the failure and let system sleep go ahead further, so this patch doesn't recover device under this situation. Also add comments on the case. Cc: Steve Glendinning steve.glendinn...@shawell.net Signed-off-by: Ming Lei

[PATCH v2 7/7] usbnet: smsc75xx: don't recover device if suspend fails in system sleep

2013-03-07 Thread Ming Lei
If suspend callback fails in system sleep context, usb core will ignore the failure and let system sleep go ahead further, so this patch doesn't recover device under this situation. Also add comments on this case. Cc: Steve Glendinning steve.glendinn...@shawell.net Signed-off-by: Ming Lei

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-07 Thread Felipe Balbi
On Thu, Mar 07, 2013 at 11:01:47AM -0500, Alan Stern wrote: On Thu, 7 Mar 2013, Felipe Balbi wrote: Hi folks, inspired by Paul's DWC2 patchset which added usb_otg_state_string() (a copy of otg_state_string()) I have now renamed otg_state_string() to usb_otg_state_string(), moved it

Re: [PATCH] usb: chipidea: don't redefine __ffs()

2013-03-07 Thread Felipe Balbi
Hi, On Fri, Feb 22, 2013 at 10:24:41AM +0200, Felipe Balbi wrote: chipidea's ffs_nr() is pretty much what __ffs() does. Use that one instead. Signed-off-by: Felipe Balbi ba...@ti.com it has been almost 2 weeks, just a gentle ping here. cheers -- balbi signature.asc Description:

Re: [PATCH] usb: chipidea: don't redefine __ffs()

2013-03-07 Thread Alexander Shishkin
On 7 March 2013 18:47, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Feb 22, 2013 at 10:24:41AM +0200, Felipe Balbi wrote: chipidea's ffs_nr() is pretty much what __ffs() does. Use that one instead. Signed-off-by: Felipe Balbi ba...@ti.com it has been almost 2 weeks, just a gentle ping

Re: [RFC PATCH 4/4] USB: OMAP: Tahvo USB transceiver driver

2013-03-07 Thread Tony Lindgren
* Aaro Koskinen aaro.koski...@iki.fi [130307 06:44]: +#include mach/usb.h We should be getting rid of the plat and mach includes for drivers for omap1 also, so let's not make it harder by adding more of it. We should have just the following: include/linux/platform_data/usb-omap.h this contains

Re: [PATCH] usb: chipidea: don't redefine __ffs()

2013-03-07 Thread Felipe Balbi
On Thu, Mar 07, 2013 at 07:03:38PM +0200, Alexander Shishkin wrote: On 7 March 2013 18:47, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Feb 22, 2013 at 10:24:41AM +0200, Felipe Balbi wrote: chipidea's ffs_nr() is pretty much what __ffs() does. Use that one instead. Signed-off-by:

Re: carl9170 A-MPDU transmit problem

2013-03-07 Thread Seth Forshee
On Tue, Feb 26, 2013 at 10:50:21AM -0600, Seth Forshee wrote: On Tue, Feb 26, 2013 at 12:30:58AM +0100, Christian Lamparter wrote: On Monday, February 25, 2013 09:19:03 PM Alan Stern wrote: On Mon, 25 Feb 2013, Seth Forshee wrote: 88012fe19500 1519981417 S Bo:3:003:1 -115 126 =

Re: [RFC PATCH 3/4] USB: OMAP: move omap-otg out from isp1301_omap

2013-03-07 Thread Aaro Koskinen
Hi, On Thu, Mar 07, 2013 at 04:51:59PM +0200, Felipe Balbi wrote: why is this otg_dev even needed ? Can you refresh my memory ? If you want to handle OTG controller interrupt you need it... Though looks like tahvo does not really need it, and it can be disabled. A. -- To unsubscribe from this

Re: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-07 Thread Alan Stern
Please use Reply-To-All, so that your message gets sent to the mailing list as well as to me. On Thu, 7 Mar 2013, Jenya Y wrote: Thank you Alan for the reply. I'd be bold enough to categorize this as a problem, since the usb hub doesn't work. It could be 'expected' if it were a RC

Re: [PATCH v2 5/7] usbnet: qmi_wwan: comments on suspend failure

2013-03-07 Thread Bjørn Mork
Ming Lei ming@canonical.com writes: If suspend callback fails in system sleep context, usb core will ignore the failure and let system sleep go ahead further, so this patch comments on the case and requires that both usbnet_suspend() and subdriver-suspend() MUST return 0 in system sleep

Re: [PATCH v2 4/7] usbnet: cdc_mbim: comments on suspend failure

2013-03-07 Thread Bjørn Mork
Ming Lei ming@canonical.com writes: If suspend callback fails in system sleep context, usb core will ignore the failure and let system sleep go ahead further, so this patch comments on the case and requires that both usbnet_suspend() and subdriver-suspend() MUST return 0 in system sleep

Fwd: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-07 Thread Jenya Y
// sorry for double-post I was advised to use 'reply to all' and wasn't sure if the prev. message was forwarded to linux-usb Thank you for the reply. I'd be bold enough to categorize this as a problem, since the usb hub doesn't work. It could be 'expected' if it were a RC version of the

RE: dwc3 PHY autosuspend feature

2013-03-07 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, March 06, 2013 11:39 PM On Wed, Mar 06, 2013 at 08:14:34PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, March 06, 2013 12:11 PM On Wed, Mar 06, 2013 at 07:22:33PM +, Paul Zimmerman

RE: [PATCH v6 3/7] HCD files for the DWC2 driver

2013-03-07 Thread Paul Zimmerman
From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Thursday, March 07, 2013 7:35 AM On Wed, 6 Mar 2013, Paul Zimmerman wrote: BTW, you _do_ have a race because you don't check ep-hcpriv when -urb_enqueue() is called. This means that you could queue to an endpoint which is in

Re: [PATCH v2 1/7] USB: adds comment on suspend callback

2013-03-07 Thread Alan Stern
On Fri, 8 Mar 2013, Ming Lei wrote: This patch adds comments on interface driver suspend callback to emphasize that the failure return value is ignored by USB core in system sleep context, so do not try to recover device for this case and let resume/reset_resume callback handle the suspend

Re: [PATCH 09/10] usb: ehci: tegra: check against CONFIG_USB_PHY

2013-03-07 Thread Stephen Warren
On 03/07/2013 02:36 AM, Felipe Balbi wrote: CONFIG_USB_OTG_UTILS will be removed very soon, so we should check CONFIG_USB_PHY instead. The Tegra EHCI driver isn't very useful without the Tegra PHY driver. Perhaps its Kconfig should simply select USB_PHY, and the ifdefs be removed rather than

RE: [PATCH v6 3/7] HCD files for the DWC2 driver

2013-03-07 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, March 06, 2013 11:52 PM On Wed, Mar 06, 2013 at 11:26:08PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, March 06, 2013 12:05 AM ... looking at that loop, is it really necessary ?

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-07 Thread Stephen Warren
On 03/07/2013 02:35 AM, Felipe Balbi wrote: Hi folks, inspired by Paul's DWC2 patchset which added usb_otg_state_string() (a copy of otg_state_string()) I have now renamed otg_state_string() to usb_otg_state_string(), moved it to usb-common, then moved all phy drivers to drivers/usb/phy/

Re: [Fwd: [PATCH v2 0/4] TTY: port hangup and close fixes]

2013-03-07 Thread Peter Hurley
On Thu, 2013-03-07 at 10:43 +0100, Johan Hovold wrote: On Wed, Mar 06, 2013 at 02:14:56PM -0500, Peter Hurley wrote: On Wed, 2013-03-06 at 17:52 +0100, Johan Hovold wrote: Yes, I did. First, the order should not matter for blocked opens as they will exit their wait loops based on

[PATCH] usb: serial: Add Rigblaster Advantage to device table

2013-03-07 Thread Steve Conklin
The Rigblaster Advantage is an amateur radio interface sold by West Mountain Radio. It contains a cp210x serial interface but the device ID is not in the driver. Signed-off-by: Steve Conklin sconk...@canonical.com --- drivers/usb/serial/cp210x.c |1 + 1 file changed, 1 insertion(+) diff

[RFC 00/10] xhci: Command cancellation fixes

2013-03-07 Thread Sarah Sharp
This patchset attempts to fix a particularly nasty bug that causes the xHCI host to be marked as 'dying' and all USB devices to be disconnected. The bug happens when some USB device (say a VIA USB 3.0 hub) refuses to answer to the Set Address command in a timely manner, while other commands are

[RFC 02/10] xhci: Don't hold spinlock while stopping the command ring.

2013-03-07 Thread Sarah Sharp
xhci_abort_cmd_ring() spins for up to five seconds while waiting for a register read to show that the command ring is stopped. It is holding the xhci-spinlock with IRQs disabled, which is not good on xHCI hosts that share legacy PCI interrupts with other PCI devices. Make the

[RFC 03/10] xhci: Handle command stalls.

2013-03-07 Thread Sarah Sharp
One Ring to rule them all, One Ring to find them, One Ring to bring them all and in the darkness bind them - J. R. R. Tolkien There is only one command ring for each xHCI host, and all commands flow through that ring. However, when a tricksy little USB device fails to respond to the Set

[RFC 05/10] xhci: Handle command ring stop between commands.

2013-03-07 Thread Sarah Sharp
The TLDR version: we need to turn command TRBs into a no-op command, even if the command dequeue pointer points to them on a command ring stop completion event. When the xHCI host controller is in the middle of a command, and software writes the command abort bit in the CRCR register, the host

[RFC 06/10] xhci: Refactor code to find the next enqueue pointer.

2013-03-07 Thread Sarah Sharp
Refactor copy-paste code to use the new function to find the next enqueue pointer. Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci.c | 18 ++ 1 files changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/usb/host/xhci.c

  1   2   >