Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Bjørn Mork
Ming Lei writes: > OK, I say it again, GFP_KERNEL is enough to cover all cases, and the > mem_flags parameter is redundant. The docs for usb_submit_urb() in drivers/usb/core/urb.c lists some possible mem_flags use cases. Among these are (where (b) and (c) are cases needing GFP_ATOMIC and not app

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Felipe Balbi
Hi, On Thu, Apr 11, 2013 at 01:51:16PM +0300, Roger Quadros wrote: > On 04/11/2013 01:04 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: > >> Hi Greg, > >> > >> The following patch gets rid of Kbuild warnings when USB_EHCI_HCD_OMAP > >> is en

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Roger Quadros
On 04/11/2013 01:04 PM, Felipe Balbi wrote: > Hi, > > On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: >> Hi Greg, >> >> The following patch gets rid of Kbuild warnings when USB_EHCI_HCD_OMAP >> is enabled. >> >> Patch is based on your usb-next branch and is needed for 3.10. >> >> Fr

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Ming Lei
On Thu, Apr 11, 2013 at 6:26 PM, Bjørn Mork wrote: > Ming Lei writes: > >> On Thu, Apr 11, 2013 at 6:04 PM, Bjørn Mork wrote: >>> Ming Lei writes: >>> >>> Again: What problem are you attempting to solve by removing the >>> mem_flags from the API? >> >> It is not about removing anything, we are

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Bjørn Mork
Ming Lei writes: > On Thu, Apr 11, 2013 at 6:04 PM, Bjørn Mork wrote: >> Ming Lei writes: >> >> Again: What problem are you attempting to solve by removing the >> mem_flags from the API? > > It is not about removing anything, we are discussing one new API > (include the parameters) to be introd

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Ming Lei
On Thu, Apr 11, 2013 at 6:04 PM, Bjørn Mork wrote: > Ming Lei writes: > > Again: What problem are you attempting to solve by removing the > mem_flags from the API? It is not about removing anything, we are discussing one new API (include the parameters) to be introduced. Thanks, -- Ming Lei --

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Ming Lei
On Thu, Apr 11, 2013 at 6:04 PM, Bjørn Mork wrote: > Ming Lei writes: > > I think you are turning this the wrong way around. Please explain why > there are no use cases where different flags are needed. You seem to be > only concerned about the resume case. This API is not limited to > resuming.

Re: [PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Felipe Balbi
Hi, On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: > Hi Greg, > > The following patch gets rid of Kbuild warnings when USB_EHCI_HCD_OMAP > is enabled. > > Patch is based on your usb-next branch and is needed for 3.10. > > From: Roger Quadros > Date: Thu, 11 Apr 2013 12:08:19 +0

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Bjørn Mork
Ming Lei writes: > On Thu, Apr 11, 2013 at 4:06 PM, Bjørn Mork wrote: >> Oliver Neukum writes: >> >> My immediate thought was that someone also might want to use this new >> API from atomic context, e.g. calling it directly from an URB callback. > > I am wondering it is a valid use case, and if

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Ming Lei
On Thu, Apr 11, 2013 at 5:53 PM, Oliver Neukum wrote: > On Thursday 11 April 2013 16:09:16 Ming Lei wrote: >> >> Could you explain why work queue need GFP_NOIO? > > Your fix for the memory allocation depends on it happening in the same > context. If you execute code on a work queue this happens in

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Oliver Neukum
On Thursday 11 April 2013 16:37:53 Ming Lei wrote: > On Thu, Apr 11, 2013 at 4:06 PM, Bjørn Mork wrote: > > Oliver Neukum writes: > > > > My immediate thought was that someone also might want to use this new > > API from atomic context, e.g. calling it directly from an URB callback. > > I am won

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Oliver Neukum
On Thursday 11 April 2013 16:09:16 Ming Lei wrote: > On Thu, Apr 11, 2013 at 2:50 PM, Oliver Neukum wrote: > > On Thursday 11 April 2013 10:31:31 Ming Lei wrote: > > > >> 'mem_flags' isn't needed any more since we can apply allocation > >> of GFP_NOIO automatically in resume path now, and you can

[PATCH] USB: ehci-omap: Select USB_PHY

2013-04-11 Thread Roger Quadros
Hi Greg, The following patch gets rid of Kbuild warnings when USB_EHCI_HCD_OMAP is enabled. Patch is based on your usb-next branch and is needed for 3.10. From: Roger Quadros Date: Thu, 11 Apr 2013 12:08:19 +0300 Subject: [PATCH] USB: ehci-omap: Select USB_PHY As we need NOP_USB_XCEIV which de

[PATCH 1/1] usb: gadget/uvc: Add support for Bulk endpoint to be used as Video Streaming ep

2013-04-11 Thread Bhupesh Sharma
This patch adds the support for Bulk endpoint to be used as video streaming endpoint, on basis of a module parameter. By default, the gadget still supports Isochronous endpoint for video streaming, but if the module parameter 'bulk_streaming_ep' is set to 1, we can support Bulk endpoint as well, w

Re: Linux USB file storage gadget with new UDC

2013-04-11 Thread victor yeo
Hi, >> I use kernel 3.4.4, the code in handle_stat1_irqs() is as below. There >> is no reset or disconnect member function in "struct >> usb_gadget_driver" in kernel 3.4.4. >> >> if (stat & (1 << SUSPEND_REQUEST_INTERRUPT)) { >> if (dev->driver->suspend) >>

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-11 Thread Grygorii Strashko
On 04/11/2013 10:48 AM, Roger Quadros wrote: On 04/10/2013 08:39 PM, Nishanth Menon wrote: On 13:55-20130410, Roger Quadros wrote: On 04/10/2013 11:06 AM, Mike Turquette wrote: Quoting Nishanth Menon (2013-04-09 13:49:00) On 10:43-20130409, Tony Lindgren wrote: * Tony Lindgren [130409 09:54

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Ming Lei
On Thu, Apr 11, 2013 at 4:06 PM, Bjørn Mork wrote: > Oliver Neukum writes: > > My immediate thought was that someone also might want to use this new > API from atomic context, e.g. calling it directly from an URB callback. I am wondering it is a valid use case, and if there is one URB submitted,

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Ming Lei
On Thu, Apr 11, 2013 at 2:50 PM, Oliver Neukum wrote: > On Thursday 11 April 2013 10:31:31 Ming Lei wrote: > >> 'mem_flags' isn't needed any more since we can apply allocation >> of GFP_NOIO automatically in resume path now, and you can always >> use GFP_KERNEL safely. Considered that it is a API,

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

2013-04-11 Thread Bjørn Mork
Oliver Neukum writes: > On Thursday 11 April 2013 10:31:31 Ming Lei wrote: > >> 'mem_flags' isn't needed any more since we can apply allocation >> of GFP_NOIO automatically in resume path now, and you can always >> use GFP_KERNEL safely. Considered that it is a API, please don't >> introduce it.

Re: [Libusbx-devel] libusbx v1.0.15-rc2 is now available for testing

2013-04-11 Thread nico
thanx! ++ nicolas Le 10/04/13 02:44, Pete Batard a écrit : On 2013.04.09 11:39, nico wrote: can someone provide a MinGW 32bits built of the last working RC, Sure. Please have a look at the -win download from: https://sourceforge.net/projects/libusbx/files/releases/1.0.15/binaries/ The Windows

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-11 Thread Roger Quadros
On 04/10/2013 08:39 PM, Nishanth Menon wrote: > On 13:55-20130410, Roger Quadros wrote: >> On 04/10/2013 11:06 AM, Mike Turquette wrote: >>> Quoting Nishanth Menon (2013-04-09 13:49:00) On 10:43-20130409, Tony Lindgren wrote: > * Tony Lindgren [130409 09:54]: >> * Roger Quadros [1304

Re: [PATCH] drivers: usb: chipidea: convert to devm_ioremap_resource()

2013-04-11 Thread Silviu Popescu
On Thu, Apr 11, 2013 at 10:12 AM, Alexander Shishkin wrote: > That's cool, but your chipidea patches have to be based off of > ci-for-greg branch of the chipidea tree [1] or at least usb-next branch > of Greg's usb.git [2]. > > [1] git://github.com/virtuoso/linux-ci.git > [2] git://git.kernel.org/

Re: [PATCH] drivers: usb: chipidea: convert to devm_ioremap_resource()

2013-04-11 Thread Alexander Shishkin
Silviu-Mihai Popescu writes: > Convert use of devm_request_and_ioremap() to the newly introduced > devm_ioremap_resource() which provides more consistent error handling. You mean, you've run coccinelle? Remember to mention it, then. > devm_ioremap_resource() provides its own error messages so

<    1   2