RE: Chipidea usb otg support for IMX/MXS (device functionality)

2013-06-28 Thread Chen Peter-B29397
- I use the port in HOST mode by plugging in a USB pendrive over the OTG- capable reduction ; this works OK - I disconnect the reduction and connect it to the computer ; here I get timeout waiting for 0800 in 11. This means the BSV bit in OTGSC register wasn't unset. Interestingly

Re: Two remain problems at chipidea driver

2013-06-28 Thread Peter Chen
On Mon, Jun 17, 2013 at 9:59 AM, Peter Chen hzpeterc...@gmail.com wrote: On Thu, Mar 21, 2013 at 11:06 AM, Peter Chen peter.c...@freescale.com wrote: On Wed, Mar 20, 2013 at 01:04:33PM +0200, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: On Fri, Mar 15, 2013 at

Re: [RFC] [PATCH] Debugfs support for EHCI testing modes

2013-06-28 Thread Tim Sander
Hi Greg snip As for the referenced driver: http://code.google.com/p/bricked/source/browse/drivers/usb/misc/ehset. c This is functionality which is not available within the kernel in a way that an external test device plugged triggers some test which in some cases even

Re: Sound Blaster USB X-Fi configuration problem

2013-06-28 Thread Clemens Ladisch
Mariusz Grecki wrote: Does anybody have any idea what can be the problem? The card is recognized as HS device by MS Windows (XP version) without any exceptions... When you say Windows, do you mean Windows itself, or a driver from Creative that you installed and that can send some

Re: [PATCH 1/4] usb: phy: tegra: Add support for device tree-based vbus regulator control

2013-06-28 Thread Peter De Schrijver
On Thu, Jun 27, 2013 at 06:15:02PM +0200, Stephen Warren wrote: On 06/27/2013 01:20 AM, Mikko Perttunen wrote: On Wed, 26 Jun 2013 20:14:35 +0300, Stephen Warren swar...@wwwdotorg.org wrote: On 06/26/2013 03:59 AM, Mikko Perttunen wrote: After this patch, usb vbus regulators for tegra

Re: Sound Blaster USB X-Fi configuration problem

2013-06-28 Thread Mariusz Grecki
W dniu 06/28/2013 09:00 AM, Clemens Ladisch pisze: Mariusz Grecki wrote: Does anybody have any idea what can be the problem? The card is recognized as HS device by MS Windows (XP version) without any exceptions... When you say Windows, do you mean Windows itself, or a driver from Creative

the mysterious

2013-06-28 Thread Enrico Mioso
Hi !! I'm writing you privately, only because I can't find out the proper list address, but if you reply including the list in CC, I'll adapt myself. I'm writing you a post regarding this forum thread: http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?f=3t=1280view=previous Being a

the Huawei K3806

2013-06-28 Thread Enrico Mioso
And - I'm sorry , I forgot something important... Even here you can observe the BAD CDC descriptor error - after the cdc_ether driver tried to attach to the device. Thank you. On Thu, 27 Jun 2013, Bj?rn Mork wrote: ==Date: Thu, 27 Jun 2013 17:44:46 +0200 ==From: Bj?rn Mork bj...@mork.no ==To:

Re: Linux USB file storage gadget with new UDC

2013-06-28 Thread victor yeo
Hi, g_file_storage gadget: ep0-setup, length 8: : 00 09 01 00 00 00 00 00 g_file_storage gadget: set configuration Yes, that is a Set-Config request with configuraiton value 1. You probably got hold of the wrong part of the log. Elsewhere there should be a Set-Config request with

Re: the mysterious

2013-06-28 Thread Bjørn Mork
Enrico Mioso mrkiko...@gmail.com writes: Hi !! I'm writing you privately, only because I can't find out the proper list address, but if you reply including the list in CC, I'll adapt myself. I'm writing you a post regarding this forum thread:

Re: the mysterious

2013-06-28 Thread Bjørn Mork
Bjørn Mork bj...@mork.no writes: I guess we can add a workaround for this to cdc_ether.c, just like we recently did for cdc_ncm.c for other types of Huawei devices with the same problem. Could you try the patch below and see if that makes the driver work with this modem? It's build tested

[PATCH v3 3/4] USB: EHCI: improve interrupt qh unlink

2013-06-28 Thread Ming Lei
ehci-hcd currently unlinks an interrupt QH when it becomes empty, that is, after its last URB completes. This works well because in almost all cases, the completion handler for an interrupt URB resubmits the URB; therefore the QH doesn't become empty and doesn't get unlinked. When we start using

[PATCH v3 1/4] USB: HCD: support giveback of URB in tasklet context

2013-06-28 Thread Ming Lei
This patch implements the mechanism of giveback of URB in tasklet context, so that hardware interrupt handling time for usb host controller can be saved much, and HCD interrupt handling can be simplified. Motivations: 1), on some arch(such as ARM), DMA mapping/unmapping is a bit time-consuming,

[PATCH v3 2/4] USB: URB documentation: claim complete() will be run with IRQs enabled

2013-06-28 Thread Ming Lei
There is no good reason to run complete() in hard interrupt disabled context. After switch to run complete() in tasklet, we will enable local IRQs when calling complete() since we can do it at that time. Even though we still disable IRQs now when calling complete() in tasklet, the URB

[PATCH v3 0/4] USB: HCD/EHCI: giveback of URB in tasklet context

2013-06-28 Thread Ming Lei
The patchset supports to run giveback of URB in tasklet context, so that DMA unmapping/mapping on transfer buffer and compelte() callback can be run with interrupt enabled, then time of HCD interrupt handler(IRQs disabled time) can be saved much. Also this approach may simplify HCD since HCD lock

[PATCH v3 4/4] USB: EHCI: support running URB giveback in tasklet context

2013-06-28 Thread Ming Lei
All 4 transfer types can work well on EHCI HCD after switching to run URB giveback in tasklet context, so mark all HCD drivers to support it. Also we don't need to release ehci-lock during URB giveback any more. From below test results on 3 machines(2 ARM and one x86), time consumed by EHCI

Re: Two remain problems at chipidea driver

2013-06-28 Thread Alexander Shishkin
Peter Chen hzpeterc...@gmail.com writes: On Thu, Mar 21, 2013 at 11:06 AM, Peter Chen peter.c...@freescale.com wrote: On Wed, Mar 20, 2013 at 01:04:33PM +0200, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin

Re: Chipidea usb otg support for IMX/MXS (device functionality)

2013-06-28 Thread Marek Vasut
Hi Peter, - I use the port in HOST mode by plugging in a USB pendrive over the OTG- capable reduction ; this works OK - I disconnect the reduction and connect it to the computer ; here I get timeout waiting for 0800 in 11. This means the BSV bit in OTGSC register wasn't unset.

Re: [PATCH 0/2] *** SUBJECT HERE ***

2013-06-28 Thread Johan Hovold
On Thu, Jun 27, 2013 at 11:50:52PM +0200, Anders Hammarquist wrote: In a message of Wed, 26 Jun 2013 12:39:24 +0200, Johan Hovold writes: On Wed, Jun 26, 2013 at 10:29:59AM +0200, Anders Hammarquist wrote: In a message of Tue, 25 Jun 2013 16:39:11 -0700, Greg KH writes: Indeed. I'd already

[PATCH] USB: ti_usb_3410_5052: fix dynamic-id matching

2013-06-28 Thread Johan Hovold
The driver failed to take the dynamic ids into account when determining the device type and therefore all devices were detected as 2-port devices when using the dynamic-id interface. Match on the usb-serial-driver field instead of doing redundant id-table searches. Reported-by: Anders

RE: Chipidea usb otg support for IMX/MXS (device functionality)

2013-06-28 Thread Chen Peter-B29397
Where can I measure this? Two possible reasons: 1. You have not gpio control for vbus toggle when role switches. This works well. 2. Your hardware has some problems that the vbus can't lower than 0.8v. How can I check that? Just measure the voltage of your otg vbus pin.

Re: [PATCH 05/24] USB: serial: remove generic vendor/product module parameters

2013-06-28 Thread Johan Hovold
On Thu, Jun 27, 2013 at 12:13:32PM -0700, Greg KH wrote: On Thu, Jun 27, 2013 at 09:11:36PM +0200, Bjørn Mork wrote: Johan Hovold jhov...@gmail.com writes: Remove the vendor and product module parameters which were added a long time ago when we did not have the dynamic sysfs interface

Re: sleeping while atomic in dwc3_gadget_start

2013-06-28 Thread Felipe Balbi
Hi, On Thu, Jun 27, 2013 at 09:57:52AM -0700, Stephen Boyd wrote: On 06/26/13 23:58, Felipe Balbi wrote: On Wed, Jun 26, 2013 at 02:52:56PM -0700, Stephen Boyd wrote: Hi, I'm getting the folllowing BUG message on bootup with 3.10-rc5 BUG: sleeping function called from invalid context

Re: the mysterious

2013-06-28 Thread Enrico Mioso
Ok, it works! And I'm sending this mail from the wwan0 interface XD !! thank you very much for this work!! Hoping this patch can be submitted - and hoping to send you soon even the option-related one. Note to everyone: to bring up the ndis interface, use the at^ndisdup=1,1,apn command ad usual;

Re: omap4 ehci sporadic resume issue

2013-06-28 Thread Michael Trimarchi
Hi Roger On Thu, Jun 27, 2013 at 11:07:11PM +0300, Ruslan Bilovol wrote: On Thu, Jun 27, 2013 at 10:24 PM, Michael Trimarchi mich...@amarulasolutions.com wrote: Hi On Thu, Jun 27, 2013 at 09:59:35PM +0300, Ruslan Bilovol wrote: Hello guys, On Thu, Jun 27, 2013 at 8:56 PM, Michael

Re: the mysterious

2013-06-28 Thread Bjørn Mork
Enrico Mioso mrkiko...@gmail.com writes: Ok, it works! And I'm sending this mail from the wwan0 interface XD !! thank you very much for this work!! Hoping this patch can be submitted - and hoping to send you soon even the option-related one. Note to everyone: to bring up the ndis

Re: omap4 ehci sporadic resume issue

2013-06-28 Thread Roger Quadros
On 06/28/2013 02:33 PM, Michael Trimarchi wrote: Hi Roger On Thu, Jun 27, 2013 at 11:07:11PM +0300, Ruslan Bilovol wrote: On Thu, Jun 27, 2013 at 10:24 PM, Michael Trimarchi mich...@amarulasolutions.com wrote: Do you have locks around this software workaround? The patch I did against 3.4

Re: Chipidea usb otg support for IMX/MXS (device functionality)

2013-06-28 Thread Marek Vasut
Dear Chen Peter-B29397, Where can I measure this? Two possible reasons: 1. You have not gpio control for vbus toggle when role switches. This works well. 2. Your hardware has some problems that the vbus can't lower than 0.8v. How can I check that? Just measure

Re: [RFC PATCH 4/6] USB: ehci-omap: Suspend the controller during bus suspend

2013-06-28 Thread Roger Quadros
On 06/27/2013 06:40 PM, Alan Stern wrote: On Wed, 26 Jun 2013, Roger Quadros wrote: That race doesn't apply to your system anyway; it matters only on systems where hcd-has_wakeup_irq isn't set. The only way to fix it involves changing ehci_suspend() somewhat (and making the equivalent

Re: the mysterious

2013-06-28 Thread Enrico Mioso
Sure you can !! Thank you for the patch! Now I'm also sending the option related one... On Fri, 28 Jun 2013, Bj?rn Mork wrote: ==Date: Fri, 28 Jun 2013 13:36:35 +0200 ==From: Bj?rn Mork bj...@mork.no ==To: Enrico Mioso mrkiko...@gmail.com ==Cc: linux-usb@vger.kernel.org ==Subject: Re: the

Re: omap4 ehci sporadic resume issue

2013-06-28 Thread Michael Trimarchi
Hi On Fri, Jun 28, 2013 at 02:46:11PM +0300, Roger Quadros wrote: On 06/28/2013 02:33 PM, Michael Trimarchi wrote: Hi Roger On Thu, Jun 27, 2013 at 11:07:11PM +0300, Ruslan Bilovol wrote: On Thu, Jun 27, 2013 at 10:24 PM, Michael Trimarchi mich...@amarulasolutions.com wrote: Do

[PATCH V2] usb: serial: option: Add support for ONYX 3G device (ALFANETWORK)

2013-06-28 Thread Enrico Mioso
This patch, adds support for the ONYX 3G device by ALFA NETWRORK, based on a MSM90 chip from Qualcomm. Signed-off-by: Enrico Mioso mrkiko...@gmail.com diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index bd4323d..663f001 100644 --- a/drivers/usb/serial/option.c +++

[PATCH v2 0/3] usb: tegra: Replace nvidia,vbus-gpio property with vbus-supply

2013-06-28 Thread Mikko Perttunen
This patchset removes the ehci-tegra device tree property nvidia,vbus-gpio and adds support for the vbus-supply property to phy-tegra-usb. Mikko Perttunen (3): usb: phy,host: tegra: Use regulators instead of GPIOs for USB PHY VBUS Documentation: devicetree: phy-tegra-usb: Add vbus-supply

[PATCH v2 3/3] ARM: dts: tegra20: Remove obsolete nvidia,vbus-gpio properties

2013-06-28 Thread Mikko Perttunen
USB VBUS regulators are now specified with the vbus-supply property instead of nvidia,vbus-gpio, so remove the obsolete properties. The equivalent vbus-supply properties were already added in patch ARM: tegra: update device trees for USB binding rework. Signed-off-by: Mikko Perttunen

[PATCH v2 2/3] Documentation: devicetree: phy-tegra-usb: Add vbus-supply property for host mode PHYs

2013-06-28 Thread Mikko Perttunen
Add vbus-supply as an optional property for host mode phy-tegra-usb PHYs. Signed-off-by: Mikko Perttunen mperttu...@nvidia.com --- Documentation/devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 1/3] usb: phy,host: tegra: Use regulators instead of GPIOs for USB PHY VBUS

2013-06-28 Thread Mikko Perttunen
The tegra ehci driver has enabled USB vbus regulators directly using GPIOs and the device tree attribute nvidia,vbus-gpio. This is ugly and causes error messages on boot when both the regulator driver and the ehci driver want access to the same GPIO. After this patch, usb vbus regulators for

Re: the mysterious device (follow up)

2013-06-28 Thread Enrico Mioso
A note - I have also an Huawei E173 device - an indesctructible and small device. I know huawei engineers asked Draisberghof to use a particular switching packet, for Linux systems. If you use the windows one, the E173 exposes a QMI interface instead of a buggy cdc_ethernet one. Buggy in the

Re: [RFC PATCH] usb: hcd: warn about URB buffers that are not DMA aligned and are about to be DMA mapped

2013-06-28 Thread Jussi Kivilinna
On 16.06.2013 13:35, Jussi Kivilinna wrote: On 16.06.2013 11:21, Oliver Neukum wrote: On Saturday 15 June 2013 16:22:30 Jussi Kivilinna wrote: Hm.. rethink this a bit. Transfer buffer might be dma aligned but shorter than cacheline and end of cacheline used as something else. Manual

Re: omap4 ehci sporadic resume issue

2013-06-28 Thread Roger Quadros
On 06/28/2013 03:26 PM, Michael Trimarchi wrote: Hi On Fri, Jun 28, 2013 at 02:46:11PM +0300, Roger Quadros wrote: On 06/28/2013 02:33 PM, Michael Trimarchi wrote: Hi Roger On Thu, Jun 27, 2013 at 11:07:11PM +0300, Ruslan Bilovol wrote: On Thu, Jun 27, 2013 at 10:24 PM, Michael Trimarchi

Re: [RFC PATCH] usb: hcd: warn about URB buffers that are not DMA aligned and are about to be DMA mapped

2013-06-28 Thread Oliver Neukum
On Friday 28 June 2013 15:39:27 Jussi Kivilinna wrote: On 16.06.2013 13:35, Jussi Kivilinna wrote: On 16.06.2013 11:21, Oliver Neukum wrote: On Saturday 15 June 2013 16:22:30 Jussi Kivilinna wrote: Hm.. rethink this a bit. Transfer buffer might be dma aligned but shorter than

RE: Chipidea usb otg support for IMX/MXS (device functionality)

2013-06-28 Thread Chen Peter-B29397
Just measure the voltage of your otg vbus pin. Ok, I see it's 2.25 volts after I disconnect the microB-A thing . I should see 0.8V constantly with nothing connected on the port? You should see the voltage of vbus pin is less than 0.8v when nothing is connected, we use

Re: Chipidea usb otg support for IMX/MXS (device functionality)

2013-06-28 Thread Fabio Estevam
On Fri, Jun 28, 2013 at 10:04 AM, Chen Peter-B29397 b29...@freescale.com wrote: Just measure the voltage of your otg vbus pin. Ok, I see it's 2.25 volts after I disconnect the microB-A thing . I should see 0.8V constantly with nothing connected on the port? You should see the voltage

Bug in usbnet-related code in qmi_wwan?

2013-06-28 Thread Enrico Mioso
Hi guys! I would like to inform you about a strange message I receive when generating lots of traffic via qmi_wwan. In particular, lots of this prints are generated: Jun 27 21:02:10 eeeadesso kernel: qmi_wwan 1-2:1.4 wwan0: kevent 2 may have been dropped Jun 27 21:02:10 eeeadesso kernel:

Re: Proposed modification to PL2303 driver

2013-06-28 Thread Frank Schäfer
Am 27.06.2013 22:13, schrieb Reinhard Max: On Thu, 27 Jun 2013 at 20:53, Frank Schäfer wrote: Am 27.06.2013 19:14, schrieb Reinhard Max: But the same datasheets also contain the statement I cited before, that the baud rate generator can be programmed to *any* baud rate between 75 and the

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread Sergei Shtylyov
Hello. On 28-06-2013 3:10, William Gulland wrote: Control transfers have both IN and OUT (or SETUP) packets, so when clearing TT buffers for a control transfer it's necessary to send two HUB_CLEAR_TT_BUFFER requests to the hub. Signed-off-by: William Gulland

Re: [RFC PATCH 4/6] USB: ehci-omap: Suspend the controller during bus suspend

2013-06-28 Thread Roger Quadros
On 06/28/2013 03:20 PM, Roger Quadros wrote: On 06/27/2013 06:40 PM, Alan Stern wrote: On Wed, 26 Jun 2013, Roger Quadros wrote: I updated the ehci-omap.c driver to call ehci_suspend/resume during runtime_suspend/resume. After that, it stopped detecting the port status change event when a

Re: [PATCH 1/1] usb,uhci: add a new tag for virtual uhci devices

2013-06-28 Thread Alan Stern
On Fri, 28 Jun 2013, Li, Zhen-Hua (USL-China) wrote: There was a problem, the warning Controller not stopped yet. And your last patch for this problem does a wrong thing: It prevents all HP uhci devices from auto-stop, which make HP uhci devices waste more power. Do they really waste more

Re: omap4 ehci sporadic resume issue

2013-06-28 Thread Michael Trimarchi
Hi On Fri, Jun 28, 2013 at 03:55:08PM +0300, Roger Quadros wrote: On 06/28/2013 03:26 PM, Michael Trimarchi wrote: Hi On Fri, Jun 28, 2013 at 02:46:11PM +0300, Roger Quadros wrote: On 06/28/2013 02:33 PM, Michael Trimarchi wrote: Hi Roger On Thu, Jun 27, 2013 at 11:07:11PM +0300,

Re: [RFC] [PATCH] Debugfs support for EHCI testing modes

2013-06-28 Thread Alan Stern
On Fri, 28 Jun 2013, Tim Sander wrote: Alan userspace driver is a good replacement for the debugfs approach (If working that is, what i am expecting at this point.). So my patch is not needed no discussion about that. This tool covers then:

Re: Linux USB file storage gadget with new UDC

2013-06-28 Thread Alan Stern
On Fri, 28 Jun 2013, victor yeo wrote: Hi, g_file_storage gadget: ep0-setup, length 8: : 00 09 01 00 00 00 00 00 g_file_storage gadget: set configuration Yes, that is a Set-Config request with configuraiton value 1. You probably got hold of the wrong part of the log.

[PATCH] usb: option: add TP-LINK MA260

2013-06-28 Thread Bjørn Mork
Cc: sta...@vger.kernel.org Signed-off-by: Bjørn Mork bj...@mork.no --- drivers/usb/serial/option.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 5dd857d..a6bf404 100644 --- a/drivers/usb/serial/option.c +++

[PATCH] net: cdc_ether: allow combined control and data interface

2013-06-28 Thread Bjørn Mork
Some Icera based Huawei modems handled by this driver are not completely CDC ECM compliant, using the same USB interface for both control and data. The CDC functional descriptors include a Union naming this interface as both master and slave, so it is supportable by relaxing the descriptor parsing

[PATCH 2/3] net: qmi_wwan: add Option GTM681W

2013-06-28 Thread Bjørn Mork
A standard Gobi 3000 reference design module. Reported-by: Richard Weinberger rich...@nod.at Signed-off-by: Bjørn Mork bj...@mork.no --- drivers/net/usb/qmi_wwan.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index

[PATCH 1/3] net: qmi_wwan: fixup Sierra Wireless MC8305 entry

2013-06-28 Thread Bjørn Mork
The MC8305 module got an additional entry added based solely on information from a Windows driver *.inf file. We now have the actual descriptor layout from one of these modules, and it consists of two alternate configurations where cfg #1 is a normal Gobi 2k layout and cfg #2 is MBIM only, using

[PATCH 3/3] net: qmi_wwan: add TP-LINK MA260

2013-06-28 Thread Bjørn Mork
Signed-off-by: Bjørn Mork bj...@mork.no --- drivers/net/usb/qmi_wwan.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index e4a0843..6de1102 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -582,6 +582,7 @@

Re: [PATCH] net: cdc_ether: allow combined control and data interface

2013-06-28 Thread Oliver Neukum
On Friday 28 June 2013 17:17:08 Bjørn Mork wrote: Some Icera based Huawei modems handled by this driver are not completely CDC ECM compliant, using the same USB interface for both control and data. The CDC functional descriptors include a Union naming this interface as both master and slave,

Re: [PATCH] net: cdc_ether: allow combined control and data interface

2013-06-28 Thread Bjørn Mork
Oliver Neukum oli...@neukum.org writes: On Friday 28 June 2013 17:17:08 Bjørn Mork wrote: Some Icera based Huawei modems handled by this driver are not completely CDC ECM compliant, using the same USB interface for both control and data. The CDC functional descriptors include a Union naming

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread Alan Stern
On Thu, 27 Jun 2013, William Gulland wrote: Control transfers have both IN and OUT (or SETUP) packets, so when clearing TT buffers for a control transfer it's necessary to send two HUB_CLEAR_TT_BUFFER requests to the hub. What makes you think this is necessary? Have you found any

Re: omap4 ehci sporadic resume issue

2013-06-28 Thread Michael Trimarchi
Hi On Fri, Jun 28, 2013 at 02:46:11PM +0300, Roger Quadros wrote: On 06/28/2013 02:33 PM, Michael Trimarchi wrote: Hi Roger On Thu, Jun 27, 2013 at 11:07:11PM +0300, Ruslan Bilovol wrote: On Thu, Jun 27, 2013 at 10:24 PM, Michael Trimarchi mich...@amarulasolutions.com wrote: Do

Re: [PATCH v3 3/4] USB: EHCI: improve interrupt qh unlink

2013-06-28 Thread Alan Stern
On Fri, 28 Jun 2013, Ming Lei wrote: ehci-hcd currently unlinks an interrupt QH when it becomes empty, that is, after its last URB completes. This works well because in almost all cases, the completion handler for an interrupt URB resubmits the URB; therefore the QH doesn't become empty and

Re: [PATCH v3 0/4] USB: HCD/EHCI: giveback of URB in tasklet context

2013-06-28 Thread Alan Stern
On Fri, 28 Jun 2013, Ming Lei wrote: The patchset supports to run giveback of URB in tasklet context, so that DMA unmapping/mapping on transfer buffer and compelte() callback can be run with interrupt enabled, then time of HCD interrupt handler(IRQs disabled time) can be saved much. Also this

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-28 Thread Felipe Balbi
Hi, On Thu, Jun 27, 2013 at 10:30:33AM +0300, Felipe Balbi wrote: Hi, On Thu, Jun 27, 2013 at 09:24:08AM +0200, Michael Grzeschik wrote: right, but in DT you will define both instances and each instance will have a seaparate snps,maximum_speed attribute :-) I'm

[PATCH 02/14] USB: usbatm: remove unneeded trace printk calls

2013-06-28 Thread Greg Kroah-Hartman
We have an in-kernel trace subsystem, so use that instead of printk for trying to figure out what functions are being called. Cc: Duncan Sands duncan.sa...@free.fr Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/atm/usbatm.c | 34 -- 1

[PATCH 11/14] USB: isp1362: remove _DBG() usage

2013-06-28 Thread Greg Kroah-Hartman
If you want a debug call, just make it, so move to using the already-there DBG() call. No need to make things more complex than they really need to be. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/host/isp1362-hcd.c | 30

[PATCH 04/14] USB: usbatm: move the atm_dbg() call to use dynamic debug

2013-06-28 Thread Greg Kroah-Hartman
Move the atm_dbg() call to use the dynamic debug subsystem, and not rely on CONFIG_USB_DEBUG for if things should be printed out or not. This also means the drivers do not have to be rebuilt to get debugging messages, important for getting information from users who can not rebuild their kernels.

[PATCH 13/14] USB: isp116x: remove dependency on CONFIG_USB_DEBUG

2013-06-28 Thread Greg Kroah-Hartman
Move all debugging messages in the driver to use the dynamic debug subsystem, and not rely on CONFIG_USB_DEBUG to turn them on or off. This lets debugging be enabled without having to rebuild the driver, an important thing for users that can not do it. It also removes the pointless IRQ_TEST()

[PATCH 08/14] USB: gadget: fix up comment

2013-06-28 Thread Greg Kroah-Hartman
This endif is for CONFIG_USB_GADGET_DEBUG_FILES, not CONFIG_USB_DEBUG, so document it properly. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/gadget/storage_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 01/14] USB: usbatm: remove unused UDSL_ASSERT macro

2013-06-28 Thread Greg Kroah-Hartman
If this code isn't triggering this assert by now, it never will, so just remove it, it's pointless. Cc: Duncan Sands duncan.sa...@free.fr Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/atm/usbatm.c | 8 drivers/usb/atm/usbatm.h | 12 2 files

[PATCH 05/14] USB: usbatm: remove CONFIG_USB_DEBUG dependancy

2013-06-28 Thread Greg Kroah-Hartman
Now that no USB atm driver is relying on the CONFIG_USB_DEBUG option (well, really the DEBUG option, thanks to some Makefile fun), remove it from the Makefile. Also remove two last vestiges of DEBUG in the usbatm.c driver, moving one to VERBOSE_DEBUG, which no one ever really cares about, and the

[PATCH 03/14] USB: usbatm: don't rely on CONFIG_USB_DEBUG

2013-06-28 Thread Greg Kroah-Hartman
Enable the USB atm drivers to use the dynamic debugging subsystem, and not rely on if CONFIG_USB_DEBUG is enabled or not for debugging messages. This also provides a saner debug message, pointing out the exact device the message is coming from. This also means the drivers do not have to be

[PATCH 07/14] USB: phy: remove CONFIG_USB_DEBUG usage

2013-06-28 Thread Greg Kroah-Hartman
Now that no USB phy driver is using CONFIG_USB_DEBUG, remove it from the Makefile. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/phy/Makefile | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/phy/Makefile

[PATCH 10/14] USB: isp1362: remove unused _WARN_ON() calls

2013-06-28 Thread Greg Kroah-Hartman
Like _BUG_ON(), _WARN_ON() wasn't ever being used, so just delete it, as obviously things are working properly now (if not, we have bigger problems...) Cc: Felipe Balbi ba...@ti.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/host/isp1362.h | 9 - 1 file

[PATCH 14/14] USB: sl811: remove CONFIG_USB_DEBUG dependency

2013-06-28 Thread Greg Kroah-Hartman
This removes the dependency of the driver on CONFIG_USB_DEBUG and moves it to us the dynamic debug subsystem instead. Bonus is the fact that we can now properly determine the exact hardware that is spitting out the messages. This lets debugging be enabled without having to rebuild the driver, an

[PATCH 12/14] USB: isp1362: remove CONFIG_USB_DEBUG dependency

2013-06-28 Thread Greg Kroah-Hartman
Now that the debugging macros are cleaned up, just rely on the dynamic debug code in the kernel to do the debug messages for the driver. This lets debugging be enabled without having to rebuild the driver, an important thing for users that can not do it. Cc: Felipe Balbi ba...@ti.com

Re: [PATCH 09/10] USB: adutux: remove direct calls to printk()

2013-06-28 Thread Greg Kroah-Hartman
On Thu, Jun 27, 2013 at 05:19:37PM +0400, Sergei Shtylyov wrote: Hello. On 27-06-2013 3:30, Greg Kroah-Hartman wrote: Use the pr_* calls instead, which are much more descriptive. Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb/misc/adutux.c | 12

Re: [RFC PATCH 4/6] USB: ehci-omap: Suspend the controller during bus suspend

2013-06-28 Thread Alan Stern
On Fri, 28 Jun 2013, Roger Quadros wrote: That's not what I meant. Never mind the pinctrl; I was asking about the EHCI controller itself. Under what circumstances does the controller assert its wakeup signal? And how do you tell it to stop asserting that signal? I believe this would

Re: [RFC PATCH 4/6] USB: ehci-omap: Suspend the controller during bus suspend

2013-06-28 Thread Alan Stern
On Fri, 28 Jun 2013, Roger Quadros wrote: Just found the problem. It seems that enabling the ehci_irq _after_ the root hub is resumed is the root cause of the problem. Doing so will miss events from the root hub. This sounds like a bug in the IRQ setup. It's the sort of thing you see when

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread Alan Stern
Please use Reply-To-All so that your response gets sent to the mailing list as well as to me. And please don't top-post. On Fri, 28 Jun 2013, William Gulland wrote: Yes, two ClearTTBuffer requests seem to be necessary with Intel's CaveCreek integrated rate-matching hub - I've got it into the

Re: omap4 ehci sporadic resume issue

2013-06-28 Thread Michael Trimarchi
Hi On 06/28/2013 01:46 PM, Roger Quadros wrote: On 06/28/2013 02:33 PM, Michael Trimarchi wrote: Hi Roger On Thu, Jun 27, 2013 at 11:07:11PM +0300, Ruslan Bilovol wrote: On Thu, Jun 27, 2013 at 10:24 PM, Michael Trimarchi mich...@amarulasolutions.com wrote: Do you have locks around this

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-28 Thread Michael Grzeschik
On Fri, Jun 28, 2013 at 09:00:00PM +0300, Felipe Balbi wrote: Hi, On Thu, Jun 27, 2013 at 10:30:33AM +0300, Felipe Balbi wrote: Hi, On Thu, Jun 27, 2013 at 09:24:08AM +0200, Michael Grzeschik wrote: right, but in DT you will define both instances and each instance will

[PATCH 0/9] Tegra USB cleanup series

2013-06-28 Thread Tuomas Tynkkynen
Hi, Here's a few cleanup patches for the Tegra USB drivers, to be applied on top of Mikko's two patch sets. It mostly deals with removing all usage of platform data and using standard helpers and enums instead of Tegra-specific ones. Tuomas Tynkkynen (9): usb: phy: tegra: Remove unnecessary

[PATCH 5/9] usb: phy: tegra: Register as an USB PHY.

2013-06-28 Thread Tuomas Tynkkynen
Register the Tegra PHY device instances with the PHY subsystem so that the Tegra EHCI driver can locate a PHY via the standard APIs. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PATCH 1/9] usb: phy: tegra: Remove unnecessary 'dev' field

2013-06-28 Thread Tuomas Tynkkynen
struct usb_phy already has a field for the device pointer, so this unnecessary field can be removed. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 27 +++ include/linux/usb/tegra_usb_phy.h | 1 - 2 files changed, 15

[PATCH 3/9] usb: tegra: host: Remove references to plat data

2013-06-28 Thread Tuomas Tynkkynen
Platform data is not used in tegra-ehci anymore, so remove all references to it. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index

[PATCH 2/9] usb: host: tegra: Remove leftover code

2013-06-28 Thread Tuomas Tynkkynen
ehci-tegra calls devm_usb_get_phy, which will never succeed since the Tegra PHY does not register itself with the PHY subsystem. It is also completely redundant since the code has already located a PHY via an internal API. Call otg_set_host unconditionally to simplify the code since it should be

[PATCH 4/9] ARM: tegra: Remove USB platform data

2013-06-28 Thread Tuomas Tynkkynen
USB-related platform data is not used anymore in the Tegra USB drivers, so remove all of it. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- arch/arm/mach-tegra/tegra.c | 38 + include/linux/platform_data/tegra_usb.h | 32

[PATCH 9/9] usb: phy: tegra: Use DT helpers for dr_mode

2013-06-28 Thread Tuomas Tynkkynen
Use the new of_usb_get_dr_mode helper function for parsing dr_mode from the device tree. Also replace the usage of the custom tegra_usb_phy_mode enum with the standard enum. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c | 20

[PATCH 6/9] usb: host: tegra: Locate a PHY via standard API

2013-06-28 Thread Tuomas Tynkkynen
Use devm_get_phy_by_phandle to get a PHY device instead of the custom Tegra functions. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- drivers/usb/host/ehci-tegra.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c

Fwd: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread William Gulland
From: William Gulland wgull...@google.com Date: Fri, Jun 28, 2013 at 3:13 PM Subject: Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer. To: Alan Stern st...@rowland.harvard.edu Cc: Sarah Sharp sarah.a.sh...@linux.intel.com, USB list linux-usb@vger.kernel.org On Fri,

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread Sarah Sharp
On Fri, Jun 28, 2013 at 03:24:49PM -0400, Alan Stern wrote: Please use Reply-To-All so that your response gets sent to the mailing list as well as to me. And please don't top-post. On Fri, 28 Jun 2013, William Gulland wrote: Yes, two ClearTTBuffer requests seem to be necessary with

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread Greg KH
On Fri, Jun 28, 2013 at 04:17:44PM -0700, Sarah Sharp wrote: On Fri, Jun 28, 2013 at 03:24:49PM -0400, Alan Stern wrote: Please use Reply-To-All so that your response gets sent to the mailing list as well as to me. And please don't top-post. On Fri, 28 Jun 2013, William Gulland wrote:

Re: [RFC] [PATCH] Debugfs support for EHCI testing modes

2013-06-28 Thread Jack Pham
Hi Alan and Tim, On Fri, Jun 28, 2013 at 10:58:56AM -0400, Alan Stern wrote: On Fri, 28 Jun 2013, Tim Sander wrote: But i am talking about this driver over here: http://code.google.com/p/bricked/source/browse/drivers/usb/misc/ehset.c There is a special usb debug device which can be

Re: [PATCH 2/2 net-next] usbnet: ax88179_178a: add .reset_resume hook

2013-06-28 Thread David Miller
From: David Chang dch...@suse.com Date: Thu, 27 Jun 2013 17:16:43 +0800 I tested with the AX88179 usb dongle, if without .reset_resume hook, after S3/S4 resume you have to enable network interface or reload the dirver module manually otherwise the network interface can not work.

Re: [PATCH 1/2 net-next] usbnet: ax88179_178a: Correct a typo in description

2013-06-28 Thread David Miller
From: David Chang dch...@suse.com Date: Thu, 27 Jun 2013 17:16:42 +0800 Correct a typo in description of driver_info, it should be Gigabit Signed-off-by: David Chang dch...@suse.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to