Re: [PATCH 1/1] usb: chipidea: fix the build error with randconfig

2013-07-10 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: Using below configs, the compile will have error: ERROR: ehci_init_driver undefined! .config: CONFIG_USB_CHIPIDEA=m CONFIG_USB_CHIPIDEA_HOST=y CONFIG_USB_CHIPIDEA_DEBUG=y The reason is chipidea host uses symbol from ehci, but ehci is not

Re: [PATCH] chipidea: bits: Cast PORTSC_PTS and DEVLC_PTS macros

2013-07-10 Thread Alexander Shishkin
Fabio Estevam fabio.este...@freescale.com writes: Fix the following build warnings on x86: drivers/usb/chipidea/core.c: In function 'hw_phymode_configure': drivers/usb/chipidea/core.c:226:3: warning: large integer implicitly truncated to unsigned type [-Woverflow]

Re: [PATCH] USB: host: Use usb_hcd_platform_shutdown() wherever possible

2013-07-10 Thread Roger Quadros
On 07/09/2013 05:16 PM, Alan Stern wrote: On Tue, 9 Jul 2013, Roger Quadros wrote: Most HCD drivers are doing the same thing in their .shutdown callback so it makes sense to use the generic usb_hcd_platform_shutdown() handler there. Signed-off-by: Roger Quadros rog...@ti.com ---

[PATCH v2] musb: omap: Fix: pass all the resources to musb core

2013-07-10 Thread Kishon Vijay Abraham I
commit 09fc7d (usb: musb: fix incorrect usage of resource pointer) assumes musb core will always have only 2 resources. But for OMAP platforms there can be 3 resources (2 irq resource and 1 iomem resource). Fixed it here. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- Changes from v1: *)

Re: [PATCH v2] musb: omap: Fix: pass all the resources to musb core

2013-07-10 Thread Felipe Balbi
On Wed, Jul 10, 2013 at 04:29:22PM +0530, Kishon Vijay Abraham I wrote: commit 09fc7d (usb: musb: fix incorrect usage of resource pointer) assumes musb core will always have only 2 resources. But for OMAP platforms there can be 3 resources (2 irq resource and 1 iomem resource). Fixed it here.

Re: [RFC v3] xhci: fix dma mask setup in xhci.c

2013-07-10 Thread Felipe Balbi
Hi, On Tue, Jul 09, 2013 at 02:43:45PM -0700, Sarah Sharp wrote: On Tue, Jul 09, 2013 at 02:59:38PM +0300, Felipe Balbi wrote: Hi, On Mon, Jul 08, 2013 at 09:55:15PM -0700, Sarah Sharp wrote: Felipe, Andy, and Seb, I have a couple questions below. On Fri, Jul 05, 2013 at

Re: [PATCH 1/2] usb: dwc3: adapt to use dr_mode device tree helper

2013-07-10 Thread Felipe Balbi
On Tue, Jul 09, 2013 at 02:16:32PM +0300, Roger Quadros wrote: Hi, On 07/06/2013 03:52 PM, Ruchika Kharwar wrote: This patch adapts the dwc3 to use the device tree helper of_usb_get_dr_mode for the mode of operation of the dwc3 instance being probed. Signed-off-by: Ruchika Kharwar

Re: [PATCH 2/2] [RFC] usb: dwc3: using the maximum_speed to determine if the usb3 phy is needed

2013-07-10 Thread Felipe Balbi
Hi, On Sat, Jul 06, 2013 at 07:53:57AM -0500, Ruchika Kharwar wrote: When the initialization of usb3 phy fails, when enabled in the system the dwc3_probe deferral is further qualified by the maximum speed. In devices such as dra7xx, there are multiple dwc3 instances where the

Re: [PATCH v2 1/1] usb/gadget: Kconfig: Fix configfs-based RNDIS function build

2013-07-10 Thread Michal Nazarewicz
On Tue, Jul 09 2013, Andrzej Pietrasiewicz wrote: USB_CONFIGFS_RNDIS depends on USB_U_RNDIS. Select it. Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Michal

Edgeport 416 USB to serial convertor

2013-07-10 Thread Brian Peters
I am looking to use an Edgeport 416 USB to serial convertor under SLES SP2. When I plug in the device all 16 serial ports are discovered but after about 2 minutes they spontaneously disconnect and reconnect. Is this a known problem? Is there a newer driver I should be using? Any and all help

Re: [PATCH 1/2] usb: dwc3: adapt to use dr_mode device tree helper

2013-07-10 Thread Roger Quadros
On 07/10/2013 02:42 PM, Felipe Balbi wrote: On Tue, Jul 09, 2013 at 02:16:32PM +0300, Roger Quadros wrote: Hi, On 07/06/2013 03:52 PM, Ruchika Kharwar wrote: This patch adapts the dwc3 to use the device tree helper of_usb_get_dr_mode for the mode of operation of the dwc3 instance being

Re: [PATCH 1/2] usb: dwc3: adapt to use dr_mode device tree helper

2013-07-10 Thread Felipe Balbi
Hi, On Wed, Jul 10, 2013 at 04:11:52PM +0300, Roger Quadros wrote: On 07/10/2013 02:42 PM, Felipe Balbi wrote: On Tue, Jul 09, 2013 at 02:16:32PM +0300, Roger Quadros wrote: Hi, On 07/06/2013 03:52 PM, Ruchika Kharwar wrote: This patch adapts the dwc3 to use the device tree helper

Re: [PATCH v2] musb: omap: Fix: pass all the resources to musb core

2013-07-10 Thread Kishon Vijay Abraham I
On Wednesday 10 July 2013 04:57 PM, Felipe Balbi wrote: On Wed, Jul 10, 2013 at 04:29:22PM +0530, Kishon Vijay Abraham I wrote: commit 09fc7d (usb: musb: fix incorrect usage of resource pointer) assumes musb core will always have only 2 resources. But for OMAP platforms there can be 3

Re: [PATCH 1/2] usb: dwc3: adapt to use dr_mode device tree helper

2013-07-10 Thread Roger Quadros
On 07/10/2013 04:35 PM, Felipe Balbi wrote: Hi, On Wed, Jul 10, 2013 at 04:11:52PM +0300, Roger Quadros wrote: On 07/10/2013 02:42 PM, Felipe Balbi wrote: On Tue, Jul 09, 2013 at 02:16:32PM +0300, Roger Quadros wrote: Hi, On 07/06/2013 03:52 PM, Ruchika Kharwar wrote: This patch adapts

Re: [PATCH 2/2] [RFC] usb: dwc3: using the maximum_speed to determine if the usb3 phy is needed

2013-07-10 Thread Ruchika Kharwar
On 07/10/2013 06:46 AM, Felipe Balbi wrote: Hi, On Sat, Jul 06, 2013 at 07:53:57AM -0500, Ruchika Kharwar wrote: When the initialization of usb3 phy fails, when enabled in the system the dwc3_probe deferral is further qualified by the maximum speed. In devices such as dra7xx,

Re: Video corruption varies by system load

2013-07-10 Thread Alan Stern
On Tue, 9 Jul 2013, Devin Heitmueller wrote: So I hooked up the video and wrote a bit of Perl to parse the ISOC stream and render the underlying video frames. I can see definitively that the video returned from the device contains the corruption. This rules out any sort of DMA or memory

Re: [PATCH] USB: host: Use usb_hcd_platform_shutdown() wherever possible

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Roger Quadros wrote: On 07/09/2013 05:16 PM, Alan Stern wrote: On Tue, 9 Jul 2013, Roger Quadros wrote: Most HCD drivers are doing the same thing in their .shutdown callback so it makes sense to use the generic usb_hcd_platform_shutdown() handler there.

Re: Video corruption varies by system load

2013-07-10 Thread Devin Heitmueller
Hi Alan, On Wed, Jul 10, 2013 at 10:48 AM, Alan Stern st...@rowland.harvard.edu wrote: Digging into the scheduling code probably won't help much. However you could try collecting a usbmon trace (see Documentation/usb/usbmon.txt). This would clearly show the timing of URB submissions and

Re: Edgeport 416 USB to serial convertor

2013-07-10 Thread Greg KH
On Wed, Jul 10, 2013 at 12:09:35PM +, Brian Peters wrote: I am looking to use an Edgeport 416 USB to serial convertor under SLES SP2. Great, then please contact SuSE for support, as you are paying for it already :) There's nothing we can do with their kernel, as it is different from the

Re: Video corruption varies by system load

2013-07-10 Thread Devin Heitmueller
On Wed, Jul 10, 2013 at 10:58 AM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: I bet the problem is related to the usage of the URB_ISO_ASAP flag. em28xx_alloc_urbs() sets URB_ISO_ASAP in urb-transfer_flags, and the value never gets cleared. In fact, that flag bit is supposed to be set

Re: Video corruption varies by system load

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Devin Heitmueller wrote: I bet the problem is related to the usage of the URB_ISO_ASAP flag. em28xx_alloc_urbs() sets URB_ISO_ASAP in urb-transfer_flags, and the value never gets cleared. In fact, that flag bit is supposed to be set only in the first URB of a stream,

Re: Video corruption varies by system load

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Devin Heitmueller wrote: On Wed, Jul 10, 2013 at 10:58 AM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: I bet the problem is related to the usage of the URB_ISO_ASAP flag. em28xx_alloc_urbs() sets URB_ISO_ASAP in urb-transfer_flags, and the value never gets

Re: Video corruption varies by system load

2013-07-10 Thread Devin Heitmueller
On Wed, Jul 10, 2013 at 11:40 AM, Alan Stern st...@rowland.harvard.edu wrote: Nope, that wasn't it. I am now only setting ISO_ASAP in the first packet, and I tried both leaving it as in on resubmit and clearing the flag prior to resubmit. usbmon is the best debugging tool at this point.

[PATCH 1/6] ARM: OMAP3: Enable Hardware Save and Restore for USB Host

2013-07-10 Thread Roger Quadros
To ensure hardware context is restored while resuming from OFF mode we need to enable the Hardware SAR bit for the USB Host power domain. Signed-off-by: Roger Quadros rog...@ti.com --- arch/arm/mach-omap2/powerdomains3xxx_data.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-)

[PATCH 0/6] USB: Implement runtime idling and remote wakeup for OMAP EHCI controller

2013-07-10 Thread Roger Quadros
Hi, This series implements suspend/resume for the OMAP EHCI host controller during runtime idle. This will cause its parent, the OMAP USB Host Module as well as the USB TLL Module to be put in suspend and hence allow the USB power domain to be put in a lower power state. Then we no longer prevent

[PATCH 2/6] ARM: dts: omap3beagle-xm: Add idle state pins for USB host

2013-07-10 Thread Roger Quadros
Add the Idle state pins for USB host and enable WAKEUP on DIR, DAT0-3, so that the PHY can wakeup the OMAP SoC from sleep on any USB activity (e.g. remote wakeup or connect/disconnect). Signed-off-by: Roger Quadros rog...@ti.com --- arch/arm/boot/dts/omap3-beagle-xm.dts | 29

[PATCH 5/6] USB: Support wakeup IRQ for suspended controllers

2013-07-10 Thread Roger Quadros
Some platforms e.g. ehci-omap can generate an interrupt (i.e. remote wakeup) even when the controller is suspended i.e. HW_ACCESSIBLE is cleared. Introduce a flag has_wakeup_irq in struct usb_hcd to indicate such cases. We tackle this case by disabling the IRQ, scheduling a hub resume and

[PATCH 3/6] mfd: omap-usb-host: move initialization to module_init()

2013-07-10 Thread Roger Quadros
We no longer need to be initialized in any particular order so move driver initialization to the standard place i.e. module_init() CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 23 +++

[PATCH 6/6] USB: ehci-omap: Implement suspend/resume

2013-07-10 Thread Roger Quadros
Call ehci_suspend/resume() during runtime suspend/resume as well as system suspend/resume. Use a flag bound to indicate that the HCD structures are valid. This is only true between usb_add_hcd() and usb_remove_hcd() calls. The flag can be used by omap_ehci_runtime_suspend/resume() handlers to

[PATCH 4/6] mfd: omap-usb-host: Put pins in IDLE state on suspend

2013-07-10 Thread Roger Quadros
In order to support wake up from suspend use the pinctrl framework to put the USB host pins in IDLE state during suspend. CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com --- drivers/mfd/omap-usb-host.c | 22 ++ 1 files changed, 22

Re: Video corruption varies by system load

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Devin Heitmueller wrote: On Wed, Jul 10, 2013 at 11:40 AM, Alan Stern st...@rowland.harvard.edu wrote: Nope, that wasn't it. I am now only setting ISO_ASAP in the first packet, and I tried both leaving it as in on resubmit and clearing the flag prior to resubmit.

Re: Video corruption varies by system load

2013-07-10 Thread Devin Heitmueller
On Wed, Jul 10, 2013 at 12:30 PM, Alan Stern st...@rowland.harvard.edu wrote: If you use the bus analyzer at the same time, you could compare microframe numbers. Ah, again, good suggestion. I'll get a usbmon trace in parallel to the Beagle. I'll have to move some stuff around though because I

[PATCH] option: add Olivetti Olicard 200

2013-07-10 Thread Dan Williams
Speaks AT on interfaces 5 (command PPP) and 3 (secondary), other interface protocols are unknown. Cc: sta...@vger.kernel.org Signed-off-by: Dan Williams d...@redhat.com --- diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 5dd857d..feda580 100644 ---

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-07-10 Thread Julius Werner
Hi Felipe, This is intended to pull down a reset signal line, not to switch power to the device. I could implement that with the regulator framework too, but I think that would just be confusing and harder to understand without providing any benefit. It's really just a plain old GPIO. -- To

Re: Video corruption varies by system load

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Devin Heitmueller wrote: I don't see any problems in the usbmon trace, but they might not show up there. In particular, the trace includes the status values only for the first 5 packets in each URB. Does the driver encounter any packets with a nonzero status? No.

Re: [PATCH 5/6] USB: Support wakeup IRQ for suspended controllers

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Roger Quadros wrote: Some platforms e.g. ehci-omap can generate an interrupt (i.e. remote wakeup) even when the controller is suspended i.e. HW_ACCESSIBLE is cleared. Introduce a flag has_wakeup_irq in struct usb_hcd to indicate such cases. We tackle this case by

Re: [PATCH 6/6] USB: ehci-omap: Implement suspend/resume

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Roger Quadros wrote: Call ehci_suspend/resume() during runtime suspend/resume as well as system suspend/resume. Use a flag bound to indicate that the HCD structures are valid. This is only true between usb_add_hcd() and usb_remove_hcd() calls. The flag can be used by

Re: Video corruption varies by system load

2013-07-10 Thread Devin Heitmueller
Hi Alan, On Wed, Jul 10, 2013 at 2:27 PM, Alan Stern st...@rowland.harvard.edu wrote: You inspired me to take a closer look at the usbmon log you made available. There _is_ an error indication after all; the line with timestamp 397263317 got an error in one of its 64 packets (but this was

Re: [PATCH 5/6] USB: Support wakeup IRQ for suspended controllers

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Roger Quadros wrote: Some platforms e.g. ehci-omap can generate an interrupt (i.e. remote wakeup) even when the controller is suspended i.e. HW_ACCESSIBLE is cleared. Introduce a flag has_wakeup_irq in struct usb_hcd to indicate such cases. We tackle this case by

Re: Video corruption varies by system load

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Devin Heitmueller wrote: Hi Alan, On Wed, Jul 10, 2013 at 2:27 PM, Alan Stern st...@rowland.harvard.edu wrote: You inspired me to take a closer look at the usbmon log you made available. There _is_ an error indication after all; the line with timestamp 397263317

Re: Video corruption varies by system load

2013-07-10 Thread Devin Heitmueller
On Wed, Jul 10, 2013 at 3:37 PM, Alan Stern st...@rowland.harvard.edu wrote: 20-30 times each second? Okay... I didn't realize the errors were that frequent. Yeah, now you see why I'm freaking out. If this were one corrupt line every 20 seconds, I wouldn't care less. But there are lines

[PATCH] usb: USB host support should depend on HAS_DMA

2013-07-10 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `usb_hcd_unmap_urb_setup_for_dma': drivers/usb/core/hcd.c:1361: undefined reference to `dma_unmap_single' drivers/built-in.o: In function `usb_hcd_unmap_urb_for_dma': drivers/usb/core/hcd.c:1393: undefined reference to `dma_unmap_sg'

Re: Video corruption varies by system load

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Devin Heitmueller wrote: It's rather disturbing that they don't show up at all in the usbmon trace. This suggests two possibilities: The ehci-hcd driver is so messed up that not only did it fail to tell the hardware to send those missing packets; it

Re: [PATCH] usb: USB host support should depend on HAS_DMA

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `usb_hcd_unmap_urb_setup_for_dma': drivers/usb/core/hcd.c:1361: undefined reference to `dma_unmap_single' ,,, Commit d9ea21a779278da06d0cbe989594bf542ed213d7 (usb: host: make USB_ARCH_HAS_?HCI

[PATCH] usb: gadget: fotg210-udc: Remove bogus __init/__exit annotations

2013-07-10 Thread Geert Uytterhoeven
When builtin (CONFIG_USB_FOTG210_UDC=y): LD drivers/usb/gadget/built-in.o WARNING: drivers/usb/gadget/built-in.o(.data+0xbf8): Section mismatch in reference from the variable fotg210_driver to the function .init.text:fotg210_udc_probe() The variable fotg210_driver references the function

Re: [PATCH] usb: gadget: fotg210-udc: Remove bogus __init/__exit annotations

2013-07-10 Thread Sergei Shtylyov
On 07/11/2013 01:45 AM, Geert Uytterhoeven wrote: When builtin (CONFIG_USB_FOTG210_UDC=y): LD drivers/usb/gadget/built-in.o WARNING: drivers/usb/gadget/built-in.o(.data+0xbf8): Section mismatch in reference from the variable fotg210_driver to the function

Re: Video corruption varies by system load

2013-07-10 Thread Devin Heitmueller
On Wed, Jul 10, 2013 at 5:21 PM, Alan Stern st...@rowland.harvard.edu wrote: Yeah, I tried that a few days ago. I did a memset() on the transfer_buffer prior to every resubmit, because at one point I thought perhaps I was getting back the buffer without it having been filled in. And you

Re: [PATCH] usb: USB host support should depend on HAS_DMA

2013-07-10 Thread Arnd Bergmann
On Wednesday 10 July 2013, Alan Stern wrote: This isn't right. There are USB host controllers that use PIO, not DMA. The HAS_DMA dependency should go with the controller driver, not the USB core. On the other hand, the USB core does call various routines like dma_unmap_single. It ought

Re: Audio I/O parameters

2013-07-10 Thread James Stone
Hi Clemens, On Mon, Jul 8, 2013 at 2:12 PM, James Stone jamesmst...@gmail.com wrote: Snip! Acquire audio card Audio0 creating alsa driver ... hw:USB,0|-|64|2|44100|0|0|nomon|swmeter|-|16bit Using ALSA driver USB-Audio running on card 0 - Focusrite Scarlett 2i4 USB at usb-:00:12.2-3, high

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-07-10 Thread Jingoo Han
On Wednesday, July 10, 2013 9:34 AM, Julius Werner wrote: This patch adds support for a new 'samsung,hsic-reset-gpio' in the device tree, which will be interpreted as an active-low reset pin during PHY initialization when it exists. Useful for intergrated HSIC devices like an SMSC 3503 hub.

Re: [PATCH] usb: USB host support should depend on HAS_DMA

2013-07-10 Thread Alan Stern
On Thu, 11 Jul 2013, Arnd Bergmann wrote: On Wednesday 10 July 2013, Alan Stern wrote: This isn't right. There are USB host controllers that use PIO, not DMA. The HAS_DMA dependency should go with the controller driver, not the USB core. On the other hand, the USB core does call

Re: [PATCH 1/2] usb: class: move checking 'actual' code block into checking 'buffer[1]' code block

2013-07-10 Thread Chen Gang
Hello Maintainers: Please help check this patch when you have time, thanks. BTW: this uninitialized variable warning may not be found by gcc compiler (which a gcc bug exists almost 10 years). Thanks. On 07/02/2013 12:06 PM, Chen Gang wrote: The variable 'actual' is only used in checking

Re: Video corruption varies by system load

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Devin Heitmueller wrote: So one might ask: why is the em28xx device sending a microframe with corrupt bytes? One thing I've noticed is immediately prior to any microframe containing corruption, there was a missing microframe - the time between the microframe containing