[PATCH 1/2] USB: chipidea: i.MX: remove unused define

2013-08-09 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 14362c0..11ed423 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++

[PATCH 2/2] USB: chipidea: i.MX: simplify usbmisc

2013-08-09 Thread Sascha Hauer
The chipidea i.MX driver is split into two drivers. The ci_hdrc_imx driver handles the chipidea cores and the usbmisc_imx driver handles the noncore registers common to all chipidea cores (but SoC specific). Current flow is: - usbmisc sets an ops pointer in the ci_hdrc_imx driver during probe -

[PATCH] USB chipidea i.MX: Fix module loading

2013-08-09 Thread Sascha Hauer
The Chipidea i.MX driver has some issues with module loading dependencies. This fixes this. It is an alternative approach to the one Peter Chen suggested that does without changing the dt binding. Sascha Sascha Hauer (2):

Re: [PULL] Moxa UPort firmware

2013-08-09 Thread Andrew Lunn
On Thu, Aug 08, 2013 at 11:00:20PM +0200, Ben Hutchings wrote: On Thu, 2013-08-08 at 12:20 +0200, Andrew Lunn wrote: Hi Ben, David Here is a pull request for firmware for Moxa USB-Serial hub devices. Thanks Andrew The following changes since commit

RE: [PATCH][bugfix] usb/gadget: configfs: keep a function if it is not successfully added

2013-08-09 Thread Andrzej Pietrasiewicz
On Thursday, August 08, 2013 6:02 PM Sebastian Andrzej Siewior wrote: On 08/08/2013 09:43 AM, Andrzej Pietrasiewicz wrote: diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c index c5d8f81..8cb5006 100644 --- a/drivers/usb/gadget/configfs.c +++

usb-audio: Fix invalid volume resolution for Logitech HD Webcam C525

2013-08-09 Thread Maksim A. Boyko
Add the volume control quirk for avoiding the kernel warning for the Logitech HD Webcam C525 as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2 for the Logitech HD Webcam C310. Reported-by: Maksim Boyko maksim.a.bo...@gmail.com Tested-by: Maksim Boyko maksim.a.bo...@gmail.com Cc:

Re: [PULL] Moxa UPort firmware

2013-08-09 Thread Ben Hutchings
On Fri, 2013-08-09 at 09:10 +0200, Andrew Lunn wrote: On Thu, Aug 08, 2013 at 11:00:20PM +0200, Ben Hutchings wrote: On Thu, 2013-08-08 at 12:20 +0200, Andrew Lunn wrote: Hi Ben, David Here is a pull request for firmware for Moxa USB-Serial hub devices. Thanks Andrew

[PATCH] usb-audio: Fix invalid volume resolution for Logitech HD Webcam C525

2013-08-09 Thread Maxim Boyko
Add the volume control quirk for avoiding the kernel warning for the Logitech HD Webcam C525 as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2 for the Logitech HD Webcam C310. Reported-by: Maksim Boyko maksim.a.bo...@gmail.com Tested-by: Maksim Boyko maksim.a.bo...@gmail.com Cc:

[RFC PATCH v2 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-09 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com ---

[RFC PATCH v2 0/3] DWC3 USB support for Qualcomm platform

2013-08-09 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Hi, These patches add basic support for USB3.0 controllers found on MSM platforms. USB3.0 core is based on Synopsys DesignWare SuperSpeed IP. Changes since first version: * Split devicetree bindings description file to separate patch * Address comments

[RFC PATCH v2 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-09 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS) and HS, SS PHY's controll and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com ---

[RFC PATCH v2 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-09 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the driver which manage Synopsys DesignWare USB3 controller stack inside Qualcomm SoC's. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com ---

Re: [PATCH] chipidea: core: Move hw_phymode_configure() into probe

2013-08-09 Thread Alexander Shishkin
Fabio Estevam fabio.este...@freescale.com writes: Currently hw_phymode_configure() is located inside hw_device_reset(), which is only called by chipidea udc driver. When operating in host mode, we also need to call hw_phymode_configure() in order to properly configure the PHY mode, so move

Re: [PATCH 1/1] usb: chipidea: imx: delete the dead code

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: Signed-off-by: Peter Chen peter.c...@freescale.com Added a commit message and applied. Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 08/11] usb: misc: usb3503: Default to hub mode

2013-08-09 Thread Mark Brown
From: Mark Brown broo...@linaro.org Since there is no runtime interface for changing modes this is probably the most sensible default. Signed-off-by: Mark Brown broo...@linaro.org --- drivers/usb/misc/usb3503.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 09/11] usb: misc: usb3503: Add USB3503A to the compatible list

2013-08-09 Thread Mark Brown
From: Mark Brown broo...@linaro.org There are no software visible differences that I am aware of but in case any are discovered allow the DTS to specify exactly which device is present. Signed-off-by: Mark Brown broo...@linaro.org --- Documentation/devicetree/bindings/usb/usb3503.txt | 2 +-

[PATCH 02/11] usb: misc: usb3503: Use gpio_set_value_cansleep()

2013-08-09 Thread Mark Brown
From: Mark Brown broo...@linaro.org The /RESET GPIO is not manipulated from atomic context so support GPIOs that can't be written from atomic context by using _cansleep(). --- drivers/usb/misc/usb3503.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 01/11] usb: misc: usb3503: Fix swapped properties in DT parsing

2013-08-09 Thread Mark Brown
From: Mark Brown broo...@linaro.org The intn and connect GPIO properties are swapped in the code which will cause failures at runtime if these are connected, fix the code. There are currently no in-tree users of this device to check or update. Signed-off-by: Mark Brown broo...@linaro.org ---

[PATCH 06/11] usb: misc: usb3503: Factor out I2C probe

2013-08-09 Thread Mark Brown
From: Mark Brown broo...@linaro.org In preparation for supporting operation without an I2C control interface factor out the I2C-specific parts of the probe routine from those that don't do any register I/O. Signed-off-by: Mark Brown broo...@linaro.org --- drivers/usb/misc/usb3503.c | 77

[PATCH 07/11] usb: misc: usb3503: Fix typos in error messages

2013-08-09 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/usb/misc/usb3503.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c index ca0f789..777102e 100644 ---

[PATCH 11/11] usb: misc: usb3503: Support operation with no I2C control

2013-08-09 Thread Mark Brown
From: Mark Brown broo...@linaro.org Refactor so that register writes for configuration are only performed if the device has a regmap provided and also register as a platform driver. This allows the driver to be used to manage GPIO based control of the device. Signed-off-by: Mark Brown

[PATCH 10/11] usb: misc: usb3503: Don't specify all DT properties as required

2013-08-09 Thread Mark Brown
From: Mark Brown broo...@linaro.org The binding document says that all properties are required but in fact almost all are optional (and should be) - update the document to reflect this. Signed-off-by: Mark Brown broo...@linaro.org Cc: devicet...@vger.kernel.org ---

[PATCH 05/11] usb: misc: usb3503: Convert to regmap

2013-08-09 Thread Mark Brown
From: Mark Brown broo...@linaro.org This will give access to the diagnostic infrastructure regmap has but the main point is to support future refactoring. Signed-off-by: Mark Brown broo...@linaro.org --- drivers/usb/misc/Kconfig | 1 + drivers/usb/misc/usb3503.c | 93

[PATCH 03/11] usb: misc: usb3503: Convert to devm_ APIs

2013-08-09 Thread Mark Brown
From: Mark Brown broo...@linaro.org Saves us a bit of code. Signed-off-by: Mark Brown broo...@linaro.org --- drivers/usb/misc/usb3503.c | 42 +++--- 1 file changed, 7 insertions(+), 35 deletions(-) diff --git a/drivers/usb/misc/usb3503.c

Re: [PATCH 3/3] usb: host: delete chipidea dependency

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: Now, chipidea host has already depended on USB_EHCI_HCD Signed-off-by: Peter Chen peter.c...@freescale.com Alan, what do you think? --- drivers/usb/host/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/2] chipidea: Remove previous MODULE_ALIAS

2013-08-09 Thread Alexander Shishkin
Fabio Estevam feste...@gmail.com writes: From: Fabio Estevam fabio.este...@freescale.com After the rename to ci_hdrc we ended up with two MODULE_ALIAS entries, so remove the old one. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Applied and pushed, thanks! -- To unsubscribe

Re: [PATCH v2 5/5] arm: dts: imx: Delete usbmisc_imx

2013-08-09 Thread Peter Chen
On Fri, Aug 09, 2013 at 08:20:45AM +0200, Sascha Hauer wrote: On Thu, Aug 08, 2013 at 06:19:43PM +0800, Peter Chen wrote: - compatible = fsl,imx25-usbmisc; - clocks = clks 9, clks 70, clks 8; -

Re: [PATCH 2/2] USB: chipidea: i.MX: simplify usbmisc

2013-08-09 Thread Peter Chen
On Fri, Aug 09, 2013 at 08:56:56AM +0200, Sascha Hauer wrote: The chipidea i.MX driver is split into two drivers. The ci_hdrc_imx driver handles the chipidea cores and the usbmisc_imx driver handles the noncore registers common to all chipidea cores (but SoC specific). Current flow is: -

Re: [PATCH 2/2] USB: chipidea: i.MX: simplify usbmisc

2013-08-09 Thread Sascha Hauer
On Fri, Aug 09, 2013 at 06:25:29PM +0800, Peter Chen wrote: -void usbmisc_unset_ops(const struct usbmisc_ops *ops) -{ - usbmisc_ops = NULL; -} -EXPORT_SYMBOL_GPL(usbmisc_unset_ops); - -int usbmisc_get_init_data(struct device *dev, struct usbmisc_usb_device *usbdev) +static

Re: [PATCH v14 06/12] usb: chipidea: add flag CI_HDRC_DUAL_ROLE_NOT_OTG

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: Since we need otgsc to know vbus's status at some chipidea controllers even it is peripheral-only mode. Besides, some SoCs (eg, AR9331 SoC) don't have otgsc register even the DCCPARAMS_DC and DCCPARAMS_HC are both 1 at CAP_DCCPARAMS. We inroduce

Re: [PATCH v14 04/12] usb: chipidea: otg: Add otg file used to access otgsc

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: This file is mainly used to access otgsc currently, it may add otg related things in the future. Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/Makefile |2 +-

Re: [PATCH v14 06/12] usb: chipidea: add flag CI_HDRC_DUAL_ROLE_NOT_OTG

2013-08-09 Thread Peter Chen
On Fri, Aug 09, 2013 at 03:55:56PM +0300, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: Since we need otgsc to know vbus's status at some chipidea controllers even it is peripheral-only mode. Besides, some SoCs (eg, AR9331 SoC) don't have otgsc register even the

Re: [PATCH v14 08/12] usb: chipidea: move otg relate things to otg file

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: A few typos: Move otg relate things to otg file. related Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c | 63 +--

Re: [PATCH v14 04/12] usb: chipidea: otg: Add otg file used to access otgsc

2013-08-09 Thread Peter Chen
On Fri, Aug 09, 2013 at 04:00:13PM +0300, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: This file is mainly used to access otgsc currently, it may add otg related things in the future. Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen

Re: Commit 09fc7d22b0 (usb: musb: fix incorrect usage of resource pointer) questions

2013-08-09 Thread Felipe Balbi
On Sun, Aug 04, 2013 at 08:45:24PM +0400, Sergei Shtylyov wrote: Hello. I have basically two questions on this change: 1) why it wasn't published before committing? look deeper 2) why you omitted am35x.c from this commit? mistake -- balbi signature.asc Description: Digital

Re: [PATCH] dwc3: Only build debugfs when DWC3_GADGET/DUAL_ROLE is enabled

2013-08-09 Thread Felipe Balbi
On Mon, Aug 05, 2013 at 03:08:43PM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Fix (randconfig) build problem with DEBUG_FS on Cc: ba...@ti.com Cc: linux-usb@vger.kernel.org Signed-off-by: Andi Kleen a...@linux.intel.com care to show me the defconfig which makes the

Re: [PATCH v14 06/12] usb: chipidea: add flag CI_HDRC_DUAL_ROLE_NOT_OTG

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Fri, Aug 09, 2013 at 03:55:56PM +0300, Alexander Shishkin wrote: + } else { + /* + * If the controller is not OTG capable, but support + * role switch, the defalt role is gadget,

Re: [PATCH v14 11/12] usb: chipidea: udc: misuse flag CI_HDRC_REGS_SHARED and CI_HDRC_PULLUP_ON_VBUS

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: CI_HDRC_REGS_SHARED stands for the controller registers is shared with other USB drivers, if all USB drivers are at chipidea/, it doesn't needed to set. We still have the msm driver that uses REGS_SHARED. CI_HDRC_PULLUP_ON_VBUS stands for pullup

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-09 Thread Felipe Balbi
Hi, On Tue, Aug 06, 2013 at 02:53:11PM +0300, Ivan T. Ivanov wrote: diff --git a/drivers/usb/dwc3/dwc3-msm.c b/drivers/usb/dwc3/dwc3-msm.c new file mode 100644 index 000..e509abc --- /dev/null +++ b/drivers/usb/dwc3/dwc3-msm.c @@ -0,0 +1,175 @@ +#undef CONFIG_REGULATOR why ??

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-09 Thread Felipe Balbi
Hi, On Tue, Aug 06, 2013 at 01:21:38PM +0100, Pawel Moll wrote: @@ -47,3 +64,25 @@ Example device nodes: vddcx-supply = supply; v1p8-supply = supply; }; + + usb@fd4ab000 { + compatible = qcom,dwc-usb3-msm; + #address-cells = 1; +

Re: [PATCH] usb: dwc3-pci: Ensure system sleep PM ops are defined only when used

2013-08-09 Thread Felipe Balbi
On Wed, Aug 07, 2013 at 06:01:00PM +0800, Andy Green wrote: On 7 August 2013 17:34, Mark Brown broo...@kernel.org wrote: On Tue, Aug 06, 2013 at 10:35:52PM -0300, Fabio Estevam wrote: On Tue, Aug 6, 2013 at 12:49 PM, Mark Brown broo...@kernel.org wrote: From: Andy Green

Re: [RFT] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-09 Thread Felipe Balbi
On Thu, Aug 08, 2013 at 10:25:36AM -0700, Sarah Sharp wrote: Hi Yu, Please test this patch, and make sure that interrupts aren't registered twice. I think this approach is better, since it creates a new quirk specifically for xhci platform devices, so we can tell them apart from PCI

Re: DWC3 role switch cause IRQ request failed

2013-08-09 Thread Felipe Balbi
On Wed, Aug 07, 2013 at 12:03:34PM +, Wang, Yu Y wrote: Hi Balbi, Because dwc3 driver request_threaded_irq with flags IRQF_ONESHOT and IRQF_SHARED. But xHCI driver will not set IRQF_ONESHOT. Then will met IRQ request failed if use same IRQ number. 4[1.019248] Call Trace: 4[

Re: DWC3 Dule Role setting cause dwc3 device driver request IRQ failed

2013-08-09 Thread Felipe Balbi
Hi, On Wed, Aug 07, 2013 at 12:12:59PM +, Wang, Yu Y wrote: Hi Balbi, Because dwc3 driver request_threaded_irq with flags IRQF_ONESHOT and IRQF_SHARED. But xHCI driver will not set IRQF_ONESHOT. Then will met IRQ request failed if use same IRQ number. can you please fix your email

Re: Linux USB power delivery

2013-08-09 Thread Felipe Balbi
On Thu, Aug 08, 2013 at 07:25:47AM -0700, Sarah Sharp wrote: I've heard there's little to do at the software level, but I haven't you've heard ? IIRC your name is in the spec :-) -- balbi signature.asc Description: Digital signature

Re: [RFC PATCH v2 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-09 Thread Felipe Balbi
On Fri, Aug 09, 2013 at 12:53:47PM +0300, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC.

Re: [PATCH v14 11/12] usb: chipidea: udc: misuse flag CI_HDRC_REGS_SHARED and CI_HDRC_PULLUP_ON_VBUS

2013-08-09 Thread Peter Chen
On Fri, Aug 09, 2013 at 04:23:11PM +0300, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: CI_HDRC_REGS_SHARED stands for the controller registers is shared with other USB drivers, if all USB drivers are at chipidea/, it doesn't needed to set. We still have the msm

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-09 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 05:33:48PM -0400, Alan Stern wrote: On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote: On Thu, 25 Jul 2013, Greg KH wrote: On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: From: Manu Gautam mgau...@codeaurora.org The USB

Re: DWC3 role switch cause IRQ request failed

2013-08-09 Thread Felipe Balbi
On Fri, Aug 09, 2013 at 01:34:09PM +, Wang, Yu Y wrote: On Wed, Aug 07, 2013 at 12:03:34PM +, Wang, Yu Y wrote: Hi Balbi, Because dwc3 driver request_threaded_irq with flags IRQF_ONESHOT and IRQF_SHARED. But xHCI driver will not set IRQF_ONESHOT. Then will met IRQ request

[GIT PULL FOR v3.12] UVC gadget fix

2013-08-09 Thread Laurent Pinchart
Hi Felipe, Here's a small fix for the UVC gadget driver, could you please take it in your tree for v3.12 ? The following changes since commit 941ea3616c747545d0278fc432fb7919b6d0d8f0: usb: dwc3: use dev_get_platdata() (2013-07-31 16:52:02 +0300) are available in the git repository at:

Re: [PATCH v14 11/12] usb: chipidea: udc: misuse flag CI_HDRC_REGS_SHARED and CI_HDRC_PULLUP_ON_VBUS

2013-08-09 Thread Peter Chen
On Fri, Aug 09, 2013 at 07:46:00PM +0800, Peter Chen wrote: On Fri, Aug 09, 2013 at 04:23:11PM +0300, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: CI_HDRC_REGS_SHARED stands for the controller registers is shared with other USB drivers, if all USB drivers are

Re: FUSB200 xhci issue

2013-08-09 Thread Alan Stern
On Fri, 9 Aug 2013, Christian Lamparter wrote: After loading firmware, a reset generally is necessary. Some devices will do it themselves; others require you to call usb_reset_device(). This makes things complicated. Because, as far as I remember, usb_reset_device() will cause the

Re: [RFC V3] usb: rh_call_control tbuf overflow fix

2013-08-09 Thread Alan Stern
On Thu, 8 Aug 2013, Sean O. Stalley wrote: rh_call_control() contains a buffer, tbuf, which it uses to hold USB descriptors. These discriptors are eventually copied into the transfer_buffer in the URB. The buffer in the URB is dynamically defined and is always large enough to hold the amount

Re: [PATCH 5/5] usb/musb dma: add cppi41 dma driver

2013-08-09 Thread Felipe Balbi
On Fri, Aug 02, 2013 at 09:24:10PM +0200, Sebastian Andrzej Siewior wrote: This driver is currently used by musb' cppi41 couter part. I may merge both dma engine user of musb at some point but not just yet. The driver seems to work in RX/TX mode in host mode, tested on mass storage. I

[PATCH] HWA RC: fix a kernel panic when unplugging the HWA dongle

2013-08-09 Thread Thomas Pugliese
This patch fixes a kernel panic that can occur when unplugging the HWA dongle while a downstream device is in the process of disconnecting. This involved 2 changes. First, call usb_lock_device_for_reset before usb_reset_device to synchronize the HWA's post_rest and disconnect routines.

Re: FUSB200 xhci issue

2013-08-09 Thread Oleksij Rempel
Am 09.08.2013 16:13, schrieb Alan Stern: On Fri, 9 Aug 2013, Christian Lamparter wrote: After loading firmware, a reset generally is necessary. Some devices will do it themselves; others require you to call usb_reset_device(). This makes things complicated. Because, as far as I remember,

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-09 Thread Alan Stern
On Fri, 9 Aug 2013, Felipe Balbi wrote: Wait a minute, didn't we discuss a while back that these test features should be built into usbcore so that we could have a usbcv clone for linux ? There's no way this can be built into the core. This test requires the behavior of the host

Re: [PATCH] usb: phy: nop: Prepare clocks as well as enabling them

2013-08-09 Thread Felipe Balbi
On Thu, Aug 08, 2013 at 12:35:04PM +0100, Mark Brown wrote: From: Mark Brown broo...@linaro.org Systems with the common clock API need clk_prepare() as well as the enable step. Signed-off-by: Mark Brown broo...@linaro.org clk_prepare() is done on probe()... -ECONFUSED -- balbi

Re: [PATCH 3/3] usb: host: delete chipidea dependency

2013-08-09 Thread Alexander Shishkin
Alan Stern st...@rowland.harvard.edu writes: On Fri, 9 Aug 2013, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: Now, chipidea host has already depended on USB_EHCI_HCD Signed-off-by: Peter Chen peter.c...@freescale.com Alan, what do you think? ---

Re: [GIT PULL FOR v3.12] UVC gadget fix

2013-08-09 Thread Felipe Balbi
On Fri, Aug 09, 2013 at 03:50:10PM +0200, Laurent Pinchart wrote: Hi Felipe, Here's a small fix for the UVC gadget driver, could you please take it in your tree for v3.12 ? The following changes since commit 941ea3616c747545d0278fc432fb7919b6d0d8f0: usb: dwc3: use

Re: FUSB200 xhci issue

2013-08-09 Thread Alan Stern
On Fri, 9 Aug 2013, Oleksij Rempel wrote: What about a get firmware version sort of thing? There really should be a way for the driver to tell whether the firmware has already been updated. I was not able to find good direct way to check firmware version. If i would add some new

Re: [PATCH 3/3] usb: host: delete chipidea dependency

2013-08-09 Thread Alan Stern
On Fri, 9 Aug 2013, Alexander Shishkin wrote: Alan Stern st...@rowland.harvard.edu writes: On Fri, 9 Aug 2013, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: Now, chipidea host has already depended on USB_EHCI_HCD Signed-off-by: Peter Chen

Re: [PATCH] usb: phy: nop: Prepare clocks as well as enabling them

2013-08-09 Thread Mark Brown
On Fri, Aug 09, 2013 at 05:38:57PM +0300, Felipe Balbi wrote: On Thu, Aug 08, 2013 at 12:35:04PM +0100, Mark Brown wrote: Systems with the common clock API need clk_prepare() as well as the enable step. clk_prepare() is done on probe()... -ECONFUSED Ah, so it is, missed that - though it

RE: DWC3 role switch cause IRQ request failed

2013-08-09 Thread Wang, Yu Y
On Fri, Aug 09, 2013 at 01:34:09PM +, Wang, Yu Y wrote: On Wed, Aug 07, 2013 at 12:03:34PM +, Wang, Yu Y wrote: Hi Balbi, Because dwc3 driver request_threaded_irq with flags IRQF_ONESHOT and IRQF_SHARED. But xHCI driver will not set IRQF_ONESHOT. Then will met IRQ

Re: [RFC PATCH v2 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-09 Thread Ivan T. Ivanov
Hi, On Fri, 2013-08-09 at 16:32 +0300, Felipe Balbi wrote: On Fri, Aug 09, 2013 at 12:53:47PM +0300, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required

[PATCH] usb: dwc3: core: clarify usb-phy array binding

2013-08-09 Thread Kumar Gala
The binding spec wasn't clear that the order of the phandles in the usb-phy array has meaning. Clarify this point in the binding that it should be USB2-HS-PHY, USB3-SS-PHY. Signed-off-by: Kumar Gala ga...@codeaurora.org --- Documentation/devicetree/bindings/usb/dwc3.txt | 4 +++- 1 file

Re: [RFC V3] usb: rh_call_control tbuf overflow fix

2013-08-09 Thread Sarah Sharp
On Thu, Aug 08, 2013 at 04:11:46PM -0700, Greg KH wrote: Note, I don't apply RFC patches, and rarely review them. Why are you claiming that is what this is, when it is in the 3rd version already? This is a new approach from the last patch (dynamic allocation vs. making the static tbuf bigger),

RE: [RFC V3] usb: rh_call_control tbuf overflow fix

2013-08-09 Thread Ismail, Abdul R
Alan, Just wondering why we don't require the HCDs to validate the length instead of blindly copying the descriptor to the buffer passed in. In the pseudo host controller we are developing we only copy the number of bytes requested to the buffer passed in. Thx! Rahman -Original

[PATCH] usb: musb: am335x: Do not remove the session bin HOST-only mode

2013-08-09 Thread Sebastian Andrzej Siewior
This is what I observe: On the first connect, the musb starts with DEVCTL.Session set. On disconnect, musb_core calls try_idle. That functions removes the Session bit signalize that the session is over (something that only in OTG is required). A new device, that is plugged, is no longer

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-09 Thread Ivan T. Ivanov
Hi, On Fri, 2013-08-09 at 16:23 +0300, Felipe Balbi wrote: Hi, On Tue, Aug 06, 2013 at 02:53:11PM +0300, Ivan T. Ivanov wrote: diff --git a/drivers/usb/dwc3/dwc3-msm.c b/drivers/usb/dwc3/dwc3-msm.c new file mode 100644 index 000..e509abc --- /dev/null +++

Re: [PATCH] usb: dwc3: core: clarify usb-phy array binding

2013-08-09 Thread Mark Rutland
On Fri, Aug 09, 2013 at 04:40:32PM +0100, Kumar Gala wrote: The binding spec wasn't clear that the order of the phandles in the usb-phy array has meaning. Clarify this point in the binding that it should be USB2-HS-PHY, USB3-SS-PHY. Signed-off-by: Kumar Gala ga...@codeaurora.org ---

RE: [RFC v2] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Yates, Alexandra
You are right that comment should read USB2.0! Will resend. Thank you. From: linux-usb-ow...@vger.kernel.org [linux-usb-ow...@vger.kernel.org] on behalf of Greg KH [gre...@linuxfoundation.org] Sent: Thursday, August 08, 2013 5:36 PM To: Alexandra Yates

Re: FUSB200 xhci issue

2013-08-09 Thread Alan Stern
On Fri, 9 Aug 2013, Oleksij Rempel wrote: Am 09.08.2013 16:52, schrieb Alan Stern: On Fri, 9 Aug 2013, Oleksij Rempel wrote: What about a get firmware version sort of thing? There really should be a way for the driver to tell whether the firmware has already been updated. I was

RE: [RFC V3] usb: rh_call_control tbuf overflow fix

2013-08-09 Thread Alan Stern
On Fri, 9 Aug 2013, Ismail, Abdul R wrote: Alan, Just wondering why we don't require the HCDs to validate the length instead of blindly copying the descriptor to the buffer passed in. In the pseudo host controller we are developing we only copy the number of bytes requested to the buffer

Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-09 Thread Fabio Estevam
On Fri, Aug 9, 2013 at 2:31 PM, Mark Brown broo...@kernel.org wrote: From: Mark Brown broo...@linaro.org Ensure that the definition of ax88172a_info matches the declaration seen by users and silence sparse warnings about symbols without declarations in the global namespace by moving the

Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-09 Thread Stephen Hemminger
On Fri, 9 Aug 2013 14:39:06 -0300 Fabio Estevam feste...@gmail.com wrote: On Fri, Aug 9, 2013 at 2:31 PM, Mark Brown broo...@kernel.org wrote: From: Mark Brown broo...@linaro.org Ensure that the definition of ax88172a_info matches the declaration seen by users and silence sparse warnings

Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-09 Thread Eric Dumazet
On Fri, 2013-08-09 at 10:40 -0700, Stephen Hemminger wrote: On Fri, 9 Aug 2013 14:39:06 -0300 Fabio Estevam feste...@gmail.com wrote: On Fri, Aug 9, 2013 at 2:31 PM, Mark Brown broo...@kernel.org wrote: From: Mark Brown broo...@linaro.org Ensure that the definition of ax88172a_info

Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-09 Thread Fabio Estevam
On Fri, Aug 9, 2013 at 2:40 PM, Stephen Hemminger step...@networkplumber.org wrote: +extern const struct driver_info ax88172a_info; You could drop the 'extern' here. All other function prototypes in this header file do not use 'extern'. That is data, not function prototype, so yes extern

Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-09 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 09 Aug 2013 10:50:36 -0700 Some compiler folk decided 'extern' were not mandatory for code, but its really adding confusion and endless discussions. I certainly stopped talking about it, you could too :-) -- To unsubscribe from this list:

Re: Can't mount external (USB) HDD with Kernel 3.10.3

2013-08-09 Thread Alberto Gonzalez
On Wednesday 31 July 2013 14:38:34 Alan Stern wrote: On Wed, 31 Jul 2013, Alberto Gonzalez wrote: There seems to be a regression in Kernel 3.10.3 (from 3.10.2) that prevents me being able to mount my external USB hard drive. See

Re: Usb devices become invisible after a few plug/unplug of webcams

2013-08-09 Thread Alan Stern
On Fri, 9 Aug 2013, Lionel Landwerlin wrote: Hi there, I'm playing with 2 small usb webcams, showing up the stream of the camera with it's plugged in and hiding it when it's unplugged. I'm basically using 2 external camera + the integrated one. I've noticed the usb port just become

Re: [RFC V3] usb: rh_call_control tbuf overflow fix

2013-08-09 Thread Greg KH
On Fri, Aug 09, 2013 at 08:51:30AM -0700, Sarah Sharp wrote: On Thu, Aug 08, 2013 at 04:11:46PM -0700, Greg KH wrote: Note, I don't apply RFC patches, and rarely review them. Why are you claiming that is what this is, when it is in the 3rd version already? This is a new approach from the

[PATCH] usb: gadget/composite : Avoid crash with bad gadget drivers

2013-08-09 Thread Philippe De Swert
Some bad gadget drivers do not check the return status of usb_add_config. Thus they get a not correctly initialized config and when this gadget gets deactivated the whole kernel crashes. Since on initialization failure cdev is set to NULL it can be used to detect this problem situation. It can be

Re: [PATCH] usb: dwc3: core: clarify usb-phy array binding

2013-08-09 Thread Kumar Gala
On Aug 9, 2013, at 11:28 AM, Mark Rutland wrote: On Fri, Aug 09, 2013 at 04:40:32PM +0100, Kumar Gala wrote: The binding spec wasn't clear that the order of the phandles in the usb-phy array has meaning. Clarify this point in the binding that it should be USB2-HS-PHY, USB3-SS-PHY.

Re: [PATCH] net/usb: rtl8150: allocate URB transfer_buffer and setup_packet separately

2013-08-09 Thread Petko Manolov
On Thu, 8 Aug 2013, Jussi Kivilinna wrote: On 08.08.2013 18:14, Petko Manolov wrote: On Wed, 7 Aug 2013, Jussi Kivilinna wrote: rtl8150 allocates URB transfer_buffer and setup_packet as part of same structure 'struct async_req'. This can cause same cacheline to be DMA-mapped twice

Re: FUSB200 xhci issue

2013-08-09 Thread Oleksij Rempel
Am 09.08.2013 19:16, schrieb Alan Stern: On Fri, 9 Aug 2013, Oleksij Rempel wrote: Am 09.08.2013 16:52, schrieb Alan Stern: On Fri, 9 Aug 2013, Oleksij Rempel wrote: What about a get firmware version sort of thing? There really should be a way for the driver to tell whether the firmware

Re: Can't mount external (USB) HDD with Kernel 3.10.3

2013-08-09 Thread Alan Stern
On Fri, 9 Aug 2013, Alberto Gonzalez wrote: On Wednesday 31 July 2013 14:38:34 Alan Stern wrote: On Wed, 31 Jul 2013, Alberto Gonzalez wrote: There seems to be a regression in Kernel 3.10.3 (from 3.10.2) that prevents me being able to mount my external USB hard drive. See

[RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Alexandra Yates
Modified the xHCI roothub descriptor to return USB2.0 extension descriptor Best Effort Service Latency (BESL) and Deep Best Effort Service Latency (DBESL) values when set on the xHCI host. On link power management the BESL and DBESL values are used to estimate L1 exit latency for USB2.0 host and

[RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Alexandra Yates
Modified the xHCI roothub descriptor to return USB2.0 extension descriptor Best Effort Service Latency (BESL) and Deep Best Effort Service Latency (DBESL) values when set on the xHCI host. On link power management the BESL and DBESL values are used to estimate L1 exit latency for USB2.0 host and

Re: FUSB200 xhci issue

2013-08-09 Thread Alan Stern
On Fri, 9 Aug 2013, Oleksij Rempel wrote: Is there any way to prevent the device from losing its firmware during a USB reset or suspend? For suspend - yes. It is possible to ignore suspend command or put the SoC in low power mode - but is it probably not so easy to bring it back. I

Re: 3.10.4: kmemleak in usb_get_bos_descriptor()?

2013-08-09 Thread Greg KH
On Thu, Aug 08, 2013 at 10:07:19PM +0200, Martin MOKREJŠ wrote: Hi, I get plenty of these in /sys/kernel/debug/kmemleak: unreferenced object 0x88019f675268 (size 32): comm usb-storage, pid 11411, jiffies 4310515592 (age 1538.100s) hex dump (first 32 bytes): 05 0f 16 00 02 07

Re: [PATCH] wusbcore: fix kernel panic when disconnecting a wireless USB-serial device

2013-08-09 Thread Thomas Pugliese
On Fri, 9 Aug 2013, Greg KH wrote: On Fri, Aug 09, 2013 at 09:52:13AM -0500, Thomas Pugliese wrote: This patch fixes a kernel panic that can occur when disconnecting a wireless USB-serial device. When the serial device disconnects, the device cleanup procedure ends up calling

Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Sarah Sharp
Hi Alex, For just one patch, you don't need to send a cover letter, especially when it contains the contents of your patch description. Also, please use PATCH instead of RFC in the future. I'll test this patch out, and try to come up with a way to get the USB core to use bcdUSB 2.10 for xHCI

Re: [PATCH] usb: musb: am335x: Do not remove the session bin HOST-only mode

2013-08-09 Thread Sergei Shtylyov
Hello. On 08/09/2013 08:03 PM, Sebastian Andrzej Siewior wrote: This is what I observe: On the first connect, the musb starts with DEVCTL.Session set. On disconnect, musb_core calls try_idle. That functions removes the Session bit signalize that the session is over (something that only in OTG

RE: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Yates, Alexandra
Will do! Thank you Sarah and Greg for the great feedback to make this patch better :) Thank you, Alexandra. -Original Message- From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Sarah Sharp Sent: Friday, August 09, 2013 1:03 PM To:

Re: Linux USB power delivery

2013-08-09 Thread Sarah Sharp
On Fri, Aug 09, 2013 at 04:31:25PM +0300, Felipe Balbi wrote: On Thu, Aug 08, 2013 at 07:25:47AM -0700, Sarah Sharp wrote: I've heard there's little to do at the software level, but I haven't you've heard ? IIRC your name is in the spec :-) /me checks. Huh, yes, you're right it is in

Re: Usb devices become invisible after a few plug/unplug of webcams

2013-08-09 Thread Lionel Landwerlin
On 09/08/13 19:08, Alan Stern wrote: On Fri, 9 Aug 2013, Lionel Landwerlin wrote: Hi there, I'm playing with 2 small usb webcams, showing up the stream of the camera with it's plugged in and hiding it when it's unplugged. I'm basically using 2 external camera + the integrated one. I've

Re: [PATCH 1/2] net/usb: catc: allocate URB setup_packet as separate buffer

2013-08-09 Thread David Miller
From: Jussi Kivilinna jussi.kivili...@iki.fi Date: Wed, 07 Aug 2013 16:26:29 +0300 URB setup packet must not be allocated as part of larger structure because DMA coherence issues. Patch changes catc to allocate ctrl_dr member as separate buffer. Patch is only compile tested. Cc:

Re: [PATCH v4 0/4] USB USBNET: loose SG check and support usbnet DMA SG

2013-08-09 Thread David Miller
From: Ming Lei ming@canonical.com Date: Thu, 8 Aug 2013 21:48:21 +0800 This patchset allows drivers to pass sg buffers which size can't be divided by max packet size of endpoint if the host controllers(such ax xHCI) support this kind of sg buffers. Previously we added check[1] on the

Re: [PATCH v4 0/4] USB USBNET: loose SG check and support usbnet DMA SG

2013-08-09 Thread Greg KH
On Fri, Aug 09, 2013 at 02:12:17PM -0700, David Miller wrote: From: Ming Lei ming@canonical.com Date: Thu, 8 Aug 2013 21:48:21 +0800 This patchset allows drivers to pass sg buffers which size can't be divided by max packet size of endpoint if the host controllers(such ax xHCI) support

  1   2   >