[PATCH] USB: host: tegra: CONFIG_USB_EHCI_TEGRA requires ULPI and ULPI viewport support

2013-10-04 Thread Paul Walmsley
Selecting CONFIG_USB_EHCI_TEGRA requires CONFIG_USB_ULPI_VIEWPORT. Otherwise the build can break with: drivers/usb/phy/phy-tegra-usb.c: In function 'ulpi_open': drivers/usb/phy/phy-tegra-usb.c:689:31: error: 'ulpi_viewport_access_ops' undeclared (first use in this function)

Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication

2013-10-04 Thread Dr. H. Nikolaus Schaller
Am 03.10.2013 um 22:00 schrieb David Miller: From: Dr. H. Nikolaus Schaller h...@goldelico.com Date: Thu, 3 Oct 2013 21:40:34 +0200 I have made the bug observation from debug log that this bit is set in a response each time the modem has a RING message. It might be specific to this modem

[PATCH] usb: remove intel_mid_otg.h

2013-10-04 Thread Heikki Krogerus
It's not used anymore. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com --- include/linux/usb/intel_mid_otg.h | 180 -- 1 file changed, 180 deletions(-) delete mode 100644 include/linux/usb/intel_mid_otg.h diff --git

Re: [PATCH v7 09/10] usb: dwc3: omap: manage usb_otg_ss_refclk960m clock

2013-10-04 Thread Roger Quadros
Greg, On 10/03/2013 06:41 PM, Greg KH wrote: On Thu, Oct 03, 2013 at 05:54:14PM +0300, Roger Quadros wrote: On 10/03/2013 03:29 PM, Felipe Balbi wrote: Hi, On Wed, Oct 02, 2013 at 04:41:53PM +0300, Roger Quadros wrote: On 10/02/2013 04:11 PM, Felipe Balbi wrote: On Mon, Sep 23, 2013 at

Re: [PATCH v7 09/10] usb: dwc3: omap: manage usb_otg_ss_refclk960m clock

2013-10-04 Thread Greg KH
On Fri, Oct 04, 2013 at 01:46:08PM +0300, Roger Quadros wrote: Greg, On 10/03/2013 06:41 PM, Greg KH wrote: On Thu, Oct 03, 2013 at 05:54:14PM +0300, Roger Quadros wrote: On 10/03/2013 03:29 PM, Felipe Balbi wrote: Hi, On Wed, Oct 02, 2013 at 04:41:53PM +0300, Roger Quadros wrote:

Re: Usb 3.0 external dd offlined, not ready after error recovery

2013-10-04 Thread Alan Stern
On Thu, 3 Oct 2013, [ISO-8859-1] Jorge Mu�oz Camadro wrote: Although the drive is USB-3 and is capable of communicating at SuperSpeed (5 Gb/s), it is running at only high speed (480 Mb/s). This suggests there may be something wrong with the cable. Are you using a high-quality USB-3

Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information

2013-10-04 Thread Felipe Balbi
On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS,

Re: [PATCH v4 07/19] usb/gadget: f_mass_storage: use fsg_common_setup in fsg_common_init

2013-10-04 Thread Felipe Balbi
Hi, On Wed, Oct 02, 2013 at 04:15:06PM +0200, Andrzej Pietrasiewicz wrote: W dniu 01.10.2013 16:53, Felipe Balbi pisze: On Thu, Sep 26, 2013 at 02:38:21PM +0200, Andrzej Pietrasiewicz wrote: fsg_common_init is a lengthy function. Now there are helper functions which cover all parts of it. Use

Re: [PATCH v2] USB: gadget: s3c-hsotg: add isochronous transfers support

2013-10-04 Thread Felipe Balbi
On Wed, Oct 02, 2013 at 12:34:21PM +0200, Robert Baldyga wrote: On 10/01/2013 04:45 PM, Felipe Balbi wrote: Hello, Hi, On Tue, Sep 24, 2013 at 11:47:16AM +0200, Robert Baldyga wrote: Hello, This is update for my proposal for isochronous transfers support in s3c-hsotg driver. I've

[PATCH] xhci: use usb_ss_max_streams in xhci_check_streams_endpoint

2013-10-04 Thread Hans de Goede
The ss_ep_comp bmAttributes filed can contain more info then just the streams, use usb_ss_max_streams to properly get max streams. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 8/9] usbfs: Add ep_to_host_endpoint helper function

2013-10-04 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/devio.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 102dbd2..107e107 100644 --- a/drivers/usb/core/devio.c +++

[PATCH 6/9] usbfs: proc_do_submiturb use a local variable for number_of_packets

2013-10-04 Thread Hans de Goede
This is a preparation patch for adding support for bulk streams. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/devio.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index

[PATCH 3/9] usb-core: Track if an endpoint has streams

2013-10-04 Thread Hans de Goede
This is a preparation patch for adding support for bulk streams to usbfs. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/hcd.c | 40 +++- include/linux/usb.h| 1 + 2 files changed, 32 insertions(+), 9 deletions(-) diff --git

[PATCH 9/9] usbfs: Add support for allocating / freeing streams

2013-10-04 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/devio.c | 113 ++ include/uapi/linux/usbdevice_fs.h | 7 +++ 2 files changed, 120 insertions(+) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index

[PATCH 7/9] usbfs: Add support for bulk stream ids

2013-10-04 Thread Hans de Goede
This patch makes it possible to specify a bulk stream id when submitting an urb using the async usbfs API. It overloads the number_of_packets usbdevfs_urb field for this. This is not pretty, but given other constraints it is the best we can do. The reasoning leading to this goes as follows: 1) We

[PATCH 1/9] usb-core: Fix usb_free_streams return value documentation

2013-10-04 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/hcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 9795a21..bd5acdd 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -2077,8

[PATCH 0/9] usbfs: Add support for usb3 bulk streams

2013-10-04 Thread Hans de Goede
Hi All, I'm very happy to present the (hopefully) final version of my patch set for adding bulk stream support to usbfs. I've tested this using an uas device redirected to a qemu vm (which uses usbfs to access the device), and with the xhci fixes I send yesterday this works well. This patch set

[PATCH 4/9] usb-core: Free bulk streams on interface release

2013-10-04 Thread Hans de Goede
Documentation/usb/bulk-streams.txt says: All stream IDs will be deallocated when the driver releases the interface, to ensure that drivers that don't support streams will be able to use the endpoint This commit actually implements this. Signed-off-by: Hans de Goede hdego...@redhat.com ---

[PATCH 2/9] usb-core: Move USB_MAXENDPOINTS definitions to usb.h

2013-10-04 Thread Hans de Goede
So that it can be used in other places too. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/core/config.c | 1 - include/linux/usb.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c index

[PATCH 5/9] usbfs: Kill urbs on interface before doing a set_interface

2013-10-04 Thread Hans de Goede
The usb_set_interface documentation says: * Also, drivers must not change altsettings while urbs are scheduled for * endpoints in that interface; all such urbs must first be completed * (perhaps forced by unlinking). For in kernel drivers we trust the drivers to get this right, but we cannot

Re: [PATCH 3/9] usb-core: Track if an endpoint has streams

2013-10-04 Thread Alan Stern
On Fri, 4 Oct 2013, Hans de Goede wrote: This is a preparation patch for adding support for bulk streams to usbfs. + for (i = 0; i num_eps; i++) + eps[i]-has_streams = 1; --- a/include/linux/usb.h +++ b/include/linux/usb.h @@ -71,6 +71,7 @@ struct usb_host_endpoint {

Re: [PATCH 4/9] usb-core: Free bulk streams on interface release

2013-10-04 Thread Alan Stern
On Fri, 4 Oct 2013, Hans de Goede wrote: Documentation/usb/bulk-streams.txt says: All stream IDs will be deallocated when the driver releases the interface, to ensure that drivers that don't support streams will be able to use the endpoint This commit actually implements this. ---

[PATCH] usb: wusbcore: add support for isoc out transfers

2013-10-04 Thread Thomas Pugliese
This patch adds support for isochronous out transfers to the HWA. The primary changes are: 1. Add a isoc_pack_desc_urb field to struct wa_seg. This urb is used to send the isochronous packet info message to the HWA which describes the isoc data segment(s) that will be sent as the payload of

Re: [PATCH 9/9] usbfs: Add support for allocating / freeing streams

2013-10-04 Thread Alan Stern
On Fri, 4 Oct 2013, Hans de Goede wrote: +static int parse_usbdevfs_streams(struct usb_device *dev, + struct usbdevfs_streams __user *streams, + unsigned int *num_streams_ret, + unsigned int

Re: [PATCH] memory mapping for usbfs (v0.4)

2013-10-04 Thread Markus Rechberger
On Mon, Sep 30, 2013 at 5:12 PM, Markus Rechberger mrechber...@gmail.com wrote: On Mon, Sep 30, 2013 at 4:59 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 30 Sep 2013, Markus Rechberger wrote: to explain why Isochronous makes such a difference, the kernel driver doesn't do the

Re: [PATCH] USB: host: tegra: CONFIG_USB_EHCI_TEGRA requires ULPI and ULPI viewport support

2013-10-04 Thread Stephen Warren
On 10/04/2013 12:02 AM, Paul Walmsley wrote: Selecting CONFIG_USB_EHCI_TEGRA requires CONFIG_USB_ULPI_VIEWPORT. Otherwise the build can break with: drivers/usb/phy/phy-tegra-usb.c: In function 'ulpi_open': drivers/usb/phy/phy-tegra-usb.c:689:31: error: 'ulpi_viewport_access_ops'

Re: [PATCH 3/9] usb-core: Track if an endpoint has streams

2013-10-04 Thread Hans de Goede
Hi, On 10/04/2013 05:35 PM, Alan Stern wrote: On Fri, 4 Oct 2013, Hans de Goede wrote: This is a preparation patch for adding support for bulk streams to usbfs. + for (i = 0; i num_eps; i++) + eps[i]-has_streams = 1; --- a/include/linux/usb.h +++

Re: [PATCH 4/9] usb-core: Free bulk streams on interface release

2013-10-04 Thread Hans de Goede
Hi, On 10/04/2013 05:37 PM, Alan Stern wrote: On Fri, 4 Oct 2013, Hans de Goede wrote: Documentation/usb/bulk-streams.txt says: All stream IDs will be deallocated when the driver releases the interface, to ensure that drivers that don't support streams will be able to use the endpoint This

Re: [PATCH 9/9] usbfs: Add support for allocating / freeing streams

2013-10-04 Thread Hans de Goede
Hi, On 10/04/2013 05:44 PM, Alan Stern wrote: On Fri, 4 Oct 2013, Hans de Goede wrote: +static int parse_usbdevfs_streams(struct usb_device *dev, + struct usbdevfs_streams __user *streams, + unsigned int *num_streams_ret, +

[PATCH] usbnet: smsc95xx: Add device tree input for MAC address

2013-10-04 Thread Dan Murphy
If the smsc95xx does not have a valid MAC address stored within the eeprom then a random number is generated. The MAC can also be set by uBoot but the smsc95xx does not have a way to read this. Create the binding for the smsc95xx so that uBoot can set the MAC and the code can retrieve the MAC

Re: [PATCH 4/9] usb-core: Free bulk streams on interface release

2013-10-04 Thread Alan Stern
On Fri, 4 Oct 2013, Hans de Goede wrote: + struct usb_host_endpoint *ep, *eps[USB_MAXENDPOINTS]; That's a big array to put on the stack: 30 entries each containing 8 bytes (on a 64-bit arch). I was wondering about this myself when I wrote this. What do you suggest as an alternative,

Re: [PATCH] memory mapping for usbfs (v0.4)

2013-10-04 Thread Alan Stern
On Sun, 29 Sep 2013, Markus Rechberger wrote: This patch adds memory mapping support to USBFS for isochronous and bulk data transfers, it allows to pre-allocate usb transfer buffers. The CPU usage decreases 1-2% on my 1.3ghz U7300 notebook The CPU usage decreases 6-8% on an Intel Atom n270

Re: [PATCH] memory mapping for usbfs (v0.4)

2013-10-04 Thread Markus Rechberger
On Fri, Oct 4, 2013 at 8:41 PM, Alan Stern st...@rowland.harvard.edu wrote: On the whole this seems reasonable. There are a few stylistic things that could be cleaned up (missing blank lines after variable declarations, for example, and other checkpatch issues), but they are minor. Why do

Re: [PATCH] USB: host: tegra: CONFIG_USB_EHCI_TEGRA requires ULPI and ULPI viewport support

2013-10-04 Thread Paul Walmsley
On 10/04/2013 09:04 AM, Stephen Warren wrote: On 10/04/2013 12:02 AM, Paul Walmsley wrote: Selecting CONFIG_USB_EHCI_TEGRA requires CONFIG_USB_ULPI_VIEWPORT. Otherwise the build can break with: drivers/usb/phy/phy-tegra-usb.c: In function 'ulpi_open': drivers/usb/phy/phy-tegra-usb.c:689:31:

Re: [PATCH] memory mapping for usbfs (v0.4)

2013-10-04 Thread Alan Stern
On Fri, 4 Oct 2013, Markus Rechberger wrote: The biggest problem is that your proc_alloc_memory() routine doesn't call usbfs_increase_memory_usage(). Without that, there's nothing to prevent a user from allocating all the available kernel memory. only root is supposed to have raw USB

[PATCH] usb: g_ffs: fix compilation warning

2013-10-04 Thread David Cohen
Due to lack of u_ether.h header file, g_ffs.c compiles with following warning: drivers/usb/gadget/g_ffs.c:81:1: warning: data definition has no type or storage class [enabled by default] drivers/usb/gadget/g_ffs.c:81:1: warning: type defaults to ‘int’ in declaration of

Re: [PATCH] usb: g_ffs: fix compilation warning

2013-10-04 Thread Greg KH
On Fri, Oct 04, 2013 at 02:48:46PM -0700, David Cohen wrote: Due to lack of u_ether.h header file, g_ffs.c compiles with following warning: It does? In what tree/branch/release is this happening? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the

Re: [PATCH] usb: g_ffs: fix compilation warning

2013-10-04 Thread David Cohen
On 10/04/2013 02:51 PM, Greg KH wrote: On Fri, Oct 04, 2013 at 02:48:46PM -0700, David Cohen wrote: Due to lack of u_ether.h header file, g_ffs.c compiles with following warning: It does? In what tree/branch/release is this happening? This is intended for Linus' 3.12-rc3. Haven't checked

Re: [PATCH] usb: g_ffs: fix compilation warning

2013-10-04 Thread David Cohen
On 10/04/2013 03:03 PM, David Cohen wrote: On 10/04/2013 02:51 PM, Greg KH wrote: On Fri, Oct 04, 2013 at 02:48:46PM -0700, David Cohen wrote: Due to lack of u_ether.h header file, g_ffs.c compiles with following warning: It does? In what tree/branch/release is this happening? This is

Re: [PATCH] memory mapping for usbfs (v0.4)

2013-10-04 Thread Markus Rechberger
On Fri, Oct 4, 2013 at 10:34 PM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 4 Oct 2013, Markus Rechberger wrote: The biggest problem is that your proc_alloc_memory() routine doesn't call usbfs_increase_memory_usage(). Without that, there's nothing to prevent a user from

[PATCH 1/2] USB/host: Use existing macros instead of hard-coded values in uhci-debug.c

2013-10-04 Thread Deng-Cheng Zhu
From: Deng-Cheng Zhu dengcheng@imgtec.com Now that UHCI IO registers have been defined in uhci-hcd.h, use them. Reviewed-by: James Hogan james.ho...@imgtec.com Signed-off-by: Deng-Cheng Zhu dengcheng@imgtec.com --- drivers/usb/host/uhci-debug.c | 16 1 files changed,

[PATCH 0/2] USB/host: Cleanups for UHCI

2013-10-04 Thread Deng-Cheng Zhu
This series contains hardcoding-to-macro changes in uhci-debug.c and removal of the redundant OK() macro in uhci-hub.c. Deng-Cheng Zhu (2): USB/host: Use existing macros instead of hard-coded values in uhci-debug.c USB/host: Cleaning up the OK macro in uhci-hub.c

[PATCH 2/2] USB/host: Cleaning up the OK macro in uhci-hub.c

2013-10-04 Thread Deng-Cheng Zhu
From: Deng-Cheng Zhu dengcheng@imgtec.com The logic len = (x) in OK(x) is dead. Clean it up. Reviewed-by: James Hogan james.ho...@imgtec.com Signed-off-by: Deng-Cheng Zhu dengcheng@imgtec.com --- drivers/usb/host/uhci-hub.c | 30 ++ 1 files changed, 14

[PATCH v2] usb: g_ffs: fix compilation warning

2013-10-04 Thread David Cohen
If USB_FUNCTIONFS is selected without USB_FUNCTIONFS_ETH and USB_FUNCTIONFS_RNIS, u_ether.h won't be included and then USB_ETHERNET_MODULE_PARAMAETERS macro won't be available causing the following warning compilation: drivers/usb/gadget/g_ffs.c:81:1: warning: data definition has no type or

Re: EHCI bus glue driver works for storage, fails for a WiFi module

2013-10-04 Thread Arokux X
Hi all, first of all thank you all for your help. I now have some news to report. Using your hint about timing I've inserted a bunch of udelays around the read/write functions that get called from _rtl92c_write_fw and got rid of the detected XactErr len 0/0 retry errors. Then I just tried to use

Re: [PATCH v2] usb: g_ffs: fix compilation warning

2013-10-04 Thread David Cohen
Hi Greg, On 10/04/2013 03:30 PM, David Cohen wrote: If USB_FUNCTIONFS is selected without USB_FUNCTIONFS_ETH and USB_FUNCTIONFS_RNIS, u_ether.h won't be included and then USB_ETHERNET_MODULE_PARAMAETERS macro won't be available causing the following warning compilation:

Re: Usb 3.0 external dd offlined, not ready after error recovery

2013-10-04 Thread Jorge Muñoz Camadro
On 4 October 2013 10:53, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 3 Oct 2013, [ISO-8859-1] Jorge Muñoz Camadro wrote: I'm using the one who comes with the drive, i've never changed it, and doesn't show any sign of been broken or something like that. It seems like a propietary