[PATCH v7 11/14] usb: phy: Add set_wakeup API

2013-12-20 Thread Peter Chen
This API is used to set wakeup enable at PHY registers, in that case, the PHY can be waken up from suspend due to external events, like vbus change, dp/dm change and id change. Signed-off-by: Peter Chen peter.c...@freescale.com --- include/linux/usb/phy.h | 16 1 files

[PATCH v7 13/14] usb: phy-mxs: Add system suspend/resume API

2013-12-20 Thread Peter Chen
We need this to keep PHY's power on or off during the system suspend mode. If we need to enable USB wakeup, then we must keep PHY's power being on during the system suspend mode. Otherwise, we need to keep PHY's power being off to save power. Signed-off-by: Peter Chen peter.c...@freescale.com ---

[PATCH v7 14/14] usb: phy-mxs: Add sync time after controller clear phcd

2013-12-20 Thread Peter Chen
After clear portsc.phcd, PHY needs 200us stable time for switch 32K clock to AHB clock. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c

[PATCH v7 00/14] Add power management support for mxs phy

2013-12-20 Thread Peter Chen
Hi Felipe Shawn, The serial adds power management support for MXS PHY, it includes: - Add one PHY API .set_wakeup, and related API implementation at mxs phy driver - misc changes and bug fixes for mxs phy to support low power mode and wakeup. It is based on Greg's usb-next, 3.13-rc1. Changes

[PATCH v7 01/14] usb: doc: phy-mxs: Add more compatible strings

2013-12-20 Thread Peter Chen
Add fsl,imx6q-usbphy for imx6dq and imx6dl, add fsl,imx6sl-usbphy for imx6sl. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[PATCH v7 07/14] usb: phy-mxs: change description of usb device speed

2013-12-20 Thread Peter Chen
Change high speed to HS Change non-high speed to FS/LS Implementation of notify_suspend and notify_resume will be different according to mxs_phy_data-flags. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c |8 1 files changed, 4 insertions(+), 4

[PATCH v7 02/14] usb: phy-mxs: Add platform judgement code

2013-12-20 Thread Peter Chen
The mxs-phy has several bugs and features at different versions, the driver code can get it through of_device_id.data. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 58 ++-- 1 files changed, 49 insertions(+), 9

[PATCH v7 10/14] usb: phy-mxs: add controller id

2013-12-20 Thread Peter Chen
It is used to access un-regulator registers according to different controllers. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c

[PATCH v7 09/14] ARM: dts: imx: add mxs phy controller id

2013-12-20 Thread Peter Chen
We need to use controller id to access different register regions for mxs phy. Signed-off-by: Peter Chen peter.c...@freescale.com --- arch/arm/boot/dts/imx23.dtsi |1 + arch/arm/boot/dts/imx28.dtsi |2 ++ arch/arm/boot/dts/imx6qdl.dtsi |2 ++ arch/arm/boot/dts/imx6sl.dtsi |2

[PATCH v7 05/14] ARM: dts: imx6: add anatop phandle for usbphy

2013-12-20 Thread Peter Chen
Add anatop phandle for usbphy Signed-off-by: Peter Chen peter.c...@freescale.com --- arch/arm/boot/dts/imx6qdl.dtsi |2 ++ arch/arm/boot/dts/imx6sl.dtsi |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi

[PATCH v7 03/14] usb: phy-mxs: Add auto clock and power setting

2013-12-20 Thread Peter Chen
The auto setting is used to open related power and clocks automatically after receiving wakeup signal. With this feature, the PHY's clock and power can be recovered correctly from low power mode, it is guaranteed by IC logic. Signed-off-by: Peter Chen peter.c...@freescale.com ---

[PATCH v7 12/14] usb: phy-mxs: Add implementation of set_wakeup

2013-12-20 Thread Peter Chen
When we need the PHY can be waken up by external signals, we can call this API. Besides, we call mxs_phy_disconnect_line at this API to close the connection between USB PHY and controller, after that, the line state from controller is SE0. Once the PHY is out of power, without calling

[PATCH v7 06/14] usb: phy-mxs: Add anatop regmap

2013-12-20 Thread Peter Chen
It is needed by imx6 SoC series, but not for imx23 and imx28. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c

[PATCH v7 08/14] usb: phy-mxs: Enable IC fixes for related SoCs

2013-12-20 Thread Peter Chen
Two PHY bugs are fixed by IC logic, but these bits are not enabled by default, so we enable them at driver. The two bugs are: MXS_PHY_ABNORMAL_IN_SUSPEND and MXS_PHY_SENDING_SOF_TOO_FAST which are described at code. Signed-off-by: Peter Chen peter.c...@freescale.com ---

[PATCH v7 04/14] usb: doc: phy-mxs: update binding for adding anatop phandle

2013-12-20 Thread Peter Chen
Add anatop phandle which is used to access anatop registers to control PHY's power and other USB operations. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

Re: [PATCH] USB: chipidea: fix error path

2013-12-20 Thread Sascha Hauer
On Thu, Dec 19, 2013 at 04:28:54PM +0800, Peter Chen wrote: On Thu, Dec 19, 2013 at 09:35:44AM +0100, Sascha Hauer wrote: devm_usb_get_phy_by_phandle() returns a PTR_ERR on failure, so we have to check for IS_ERR before calling usb_phy_shutdown(), not for NULL. Signed-off-by: Sascha

RE: [PATCH v2] xhci: Allocate the td array and urb_priv together.

2013-12-20 Thread David Laight
From: Steve Calfee On Wed, Dec 18, 2013 at 3:24 AM, David Laight david.lai...@aculab.com wrote: This saves a kzalloc() call on every transfer and some memory indirections. The only possible downside is for isochronous tranfers with 64 td when the allocate is 8+4096 bytes (on 64bit

RE: [PATCH v2] xhci: Allocate the td array and urb_priv together.

2013-12-20 Thread David Laight
From: David Cohen On Wed, Dec 18, 2013 at 11:24:47AM -, David Laight wrote: This saves a kzalloc() call on every transfer and some memory indirections. The only possible downside is for isochronous tranfers with 64 td when the allocate is 8+4096 bytes (on 64bit systems) so requires

RE: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

2013-12-20 Thread David Laight
From: Josh Triplett On Thu, Dec 19, 2013 at 05:33:09PM -, David Laight wrote: OTOH just including extra headers isn't ideal - it can considerably slow down the compilation time. There are many subsystems that don't really separate their internal headers from their external ones.

[PATCH 2/2] usb: musb: fix musb pointer acqusition in musb_host_finish_resume

2013-12-20 Thread Daniel Mack
This is a fall-out from usb: musb: finish suspend/reset work independently from musb_hub_control() that I missed because the MUSB_POWER register does not have the MUSB_POWER_SUSPENDM bit set on AM335x platforms; hence the code path was not travelled in my tests. Signed-off-by: Daniel Mack

[PATCH 1/2] usb: musb: fix prototype for musb_port_reset

2013-12-20 Thread Daniel Mack
musb_port_reset() takes a 2nd arguments. This didn't hit us yet because this function was never called externally prior to the musb_hub_control cleanup patch. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/musb/musb_host.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode

2013-12-20 Thread Manu Gautam
Allow userspace to pass SuperSpeed descriptors and handle them in the driver accordingly. This change doesn't modify existing desc_header and thereby keeps the ABI changes backward compatible i.e. existing userspace drivers compiled with old header (functionfs.h) would continue to work with the

Re: [PATCH v2 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode

2013-12-20 Thread Manu Gautam
On 11/26/2013 11:11 PM, Felipe Balbi wrote: any comments here ? nobody ? Manu, if nobody complains in another week, please send this hunk as a formal patch. I have just sent a Patch (v3). Thanks, Manu -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by

RE: [PATCH] USB: core: remove CONFIG_USB_DEBUG usage

2013-12-20 Thread David Laight
From: Greg Kroah-Hartman CONFIG_USB_DEBUG is going away, so remove the few places in the USB core that relied on them. This means that we always now do the debug checks for every urb submitted, which is a good idea, as who knows how many driver bugs we have been ignoring when people forget

[PATCH] USB: phy: Fix double lock in OTG FSM

2013-12-20 Thread Anton Tikhomirov
Mutex obtained at the beginning of the function should be released at the end to avoid double locking. Signed-off-by: Anton Tikhomirov av.tikhomi...@samsung.com --- drivers/usb/phy/phy-fsm-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-fsm-usb.c

Re: [PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown

2013-12-20 Thread Denis Turischev
Also, which kernel are you experiencing this issue on? In 3.12, I queued a separate patch to deal with spurious reboot issues on Lynx Point: commit 638298dc66ea36623dbc2757a24fc2c4ab41b016 Author: Takashi Iwai ti...@suse.de Date: Thu Sep 12 08:11:06 2013 +0200 xhci: Fix spurious

RE: [PATCH v7 07/14] usb: phy-mxs: change description of usb device speed

2013-12-20 Thread David Laight
From: Peter Chen Sent: 20 December 2013 07:52 Change high speed to HS Change non-high speed to FS/LS Implementation of notify_suspend and notify_resume will be different according to mxs_phy_data-flags. Signed-off-by: Peter Chen peter.c...@freescale.com ---

RE:

2013-12-20 Thread Unify Loan Company
Do you need business or personal loan? Reply back with details -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] kconfig/symbol.c: handle choice_values that depend on 'm' symbols

2013-12-20 Thread Sebastian Andrzej Siewior
On 11/18/2013 07:08 PM, Yann E. MORIN wrote: Dirk, All, Hi Yann, Acked-by: Yann E. MORIN yann.morin.1...@free.fr It will be in my tree soon. Thanks! I've been looking at gitorious.org:linux-kconfig/linux-kconfig.git into the yem/kconfig-for-next and kconfig-rc-fixes branch and haven't

[PATCH] usb: cdc-wdm: avoid hanging on zero length reads

2013-12-20 Thread Bjørn Mork
commit 73e06865ead1 (USB: cdc-wdm: support back-to-back USB_CDC_NOTIFY_RESPONSE_AVAILABLE notifications) implemented queued response handling. This added a new requirement: The read urb must be resubmitted every time we clear the WDM_READ flag if the response counter indicates that the device is

poweroff during boot

2013-12-20 Thread Stefano Butti
Good morning I'm writing to you for a problem. I would like use live USB on a hardware encrypted drive with onboard hardware numpad. The system power off usb during boot, so i must reinsert keycode on drive and complete boot manually. Is it possible prevent usb poweroff during boot? Thankyou

[PATCH v4 1/9] phy: core: Add an exported of_phy_get function

2013-12-20 Thread Kamil Debski
Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from another driver and thus it was impossible to get phy defined for a given node. The old function was renamed to _of_phy_get and was left for internal use. of_phy_get function was

[PATCH v4 2/9] phy: core: Add devm_of_phy_get to phy-core

2013-12-20 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |2 ++ 2 files changed, 33

[PATCH v5 0/9] phy: Add new Exynos USB 2.0 PHY driver

2013-12-20 Thread Kamil Debski
Hi, This is the fifth version of the patchset. It adds a new Exynos USB 2.0 PHY driver. The driver uses the Generic PHY Framework. I would like to thank everyone who contributed with comments and took the time to read through the patches in the previous versions of this patchset. We had a

[PATCH v5 6/9] phy: Add support for S5PV210 to the Exynos USB 2.0 PHY driver

2013-12-20 Thread Kamil Debski
From: Mateusz Krawczuk mat.krawc...@gmail.com Add support for the Samsung's S5PV210 SoC to the Exynos USB 2.0 PHY driver. Signed-off-by: Mateusz Krawczuk m.krawc...@partner.samsung.com [k.deb...@samsung.com: cleanup and commit description] [k.deb...@samsung.com: make changes accordingly to the

[PATCH RFC alternative ver 1] phy: Exynos 421x USB 2.0 PHY support

2013-12-20 Thread Kamil Debski
This the alternative version of the support for Exynos 421x USB 2.0 PHY in the Generic PHY framework. In this version the support for Exynos 4210 and 4212 was joined into one file. Signed-off-by: Kamil Debski k.deb...@samsung.com --- Hi, Me and Kishon were discussing for quite a long time the

[PATCH RFC alternative ver 2] phy: Exynos 421x USB 2.0 PHY support

2013-12-20 Thread Kamil Debski
This the alternative version of the support for Exynos 421x USB 2.0 PHY in the Generic PHY framework. In this version the support for Exynos 4210 and 4212 was joined into one file. Signed-off-by: Kamil Debski k.deb...@samsung.com --- Hi, This is the second alternative version. Please look at

[PATCH v2 9/9] dts: Add usb2phy to Exynos 5250

2013-12-20 Thread Kamil Debski
Add support to PHY of USB2 of the Exynos 5250 SoC. Signed-off-by: Kamil Debski k.deb...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 33 --- drivers/phy/phy-exynos5250-usb2.c | 64 + 2 files changed, 78 insertions(+), 19 deletions(-)

[PATCH v5 7/9] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

2013-12-20 Thread Kamil Debski
Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig

[PATCH v5 5/9] usb: s3c-hsotg: Use the new Exynos USB phy driver with the generic phy framework

2013-12-20 Thread Kamil Debski
Change the used phy driver to the new Exynos USB phy driver that uses the generic phy framework. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/usb/samsung-hsotg.txt |4

Re: [PATCH] USB: core: remove CONFIG_USB_DEBUG usage

2013-12-20 Thread Greg Kroah-Hartman
On Fri, Dec 20, 2013 at 10:04:00AM -, David Laight wrote: From: Greg Kroah-Hartman CONFIG_USB_DEBUG is going away, so remove the few places in the USB core that relied on them. This means that we always now do the debug checks for every urb submitted, which is a good idea, as who

Re: poweroff during boot

2013-12-20 Thread Greg KH
On Fri, Dec 20, 2013 at 02:13:43PM +0100, Stefano Butti wrote: Good morning I'm writing to you for a problem. I would like use live USB on a hardware encrypted drive with onboard hardware numpad. The system power off usb during boot, so i must reinsert keycode on drive and complete boot

Re: [PATCH v3 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode

2013-12-20 Thread Michal Nazarewicz
On Fri, Dec 20 2013, Manu Gautam wrote: Allow userspace to pass SuperSpeed descriptors and handle them in the driver accordingly. This change doesn't modify existing desc_header and thereby keeps the ABI changes backward compatible i.e. existing userspace drivers compiled with old header

RE: [PATCH] USB: core: remove CONFIG_USB_DEBUG usage

2013-12-20 Thread David Laight
From: Greg Kroah-Hartman ... ... /* Check that the pipe's type matches the endpoint's type */ if (usb_pipetype(urb-pipe) != pipetypes[xfertype]) It looks as though it ought to be possible to make that check: if (unlikely(xfertype != urb-pipe-valid_xfertype)) You should

Re: [PATCH] usb: musb: Remove USB_GADGET driver dependency

2013-12-20 Thread Felipe Balbi
On Thu, Dec 19, 2013 at 10:20:48PM -0300, Ezequiel Garcia wrote: This USB controller is dual-role, but can also work in host-only mode. There's no reason to condition the entire driver to USB_GADGET. Fix this by removing the dependency. Tested on a Beaglebone black (AM335x) using a regular

[PATCH] usb: wusbcore: add debug prints to reservation and channel change

2013-12-20 Thread Thomas Pugliese
This patch adds debug prints to the reservation and channel change sequence to help with debugging channel change problems. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/pal.c |1 + drivers/usb/wusbcore/reservation.c |1 + 2 files changed, 2

Re: [PATCH] usb: wusbcore: add debug prints to reservation and channel change

2013-12-20 Thread Greg KH
On Fri, Dec 20, 2013 at 10:55:34AM -0600, Thomas Pugliese wrote: This patch adds debug prints to the reservation and channel change sequence to help with debugging channel change problems. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/pal.c |

Re: [PATCH] usb: musb: Remove USB_GADGET driver dependency

2013-12-20 Thread Ezequiel Garcia
On Fri, Dec 20, 2013 at 09:49:58AM -0600, Felipe Balbi wrote: On Thu, Dec 19, 2013 at 10:20:48PM -0300, Ezequiel Garcia wrote: This USB controller is dual-role, but can also work in host-only mode. There's no reason to condition the entire driver to USB_GADGET. Fix this by removing the

[PATCH 3/3] uwb: use uwb_rsv_callback instead of calling rsv-callback directly

2013-12-20 Thread Thomas Pugliese
Use uwb_rsv_callback wrapper instead of calling rsv-callback directly. uwb_rsv_callback checks for NULL and is used by other callers of the callback routine. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/rsv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 0/3] uwb: minor cleanups

2013-12-20 Thread Thomas Pugliese
This patch set adds some debug prints, cleans up whitespace and comments and modifies one location to use the proper wrapper for calling reservation callbacks. Thomas Pugliese (3): uwb: add debug prints during channel change and beacon actions uwb: whitespace and comment cleanups uwb: use

[PATCH 1/3] uwb: add debug prints during channel change and beacon actions

2013-12-20 Thread Thomas Pugliese
Add debug prints during channel change and beacon actions. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/beacon.c |3 ++- drivers/uwb/radio.c |4 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/uwb/beacon.c b/drivers/uwb/beacon.c

[PATCH] uwb: move mutex_lock to error case in uwbd_evt_handle_rc_bp_slot_change

2013-12-20 Thread Thomas Pugliese
Only acquire rc-uwb_dev.mutex in the error case in uwbd_evt_handle_rc_bp_slot_change. This fixes a bug where establishing a reservation on a new channel will fail if we were unable to establish a reservation on the previous channel due to DRP conflict. If rc-uwb_dev.mutex is acquired in the

Re: [PATCH v2] xhci: Allocate the td array and urb_priv together.

2013-12-20 Thread David Cohen
On Fri, Dec 20, 2013 at 09:26:35AM -, David Laight wrote: From: David Cohen On Wed, Dec 18, 2013 at 11:24:47AM -, David Laight wrote: This saves a kzalloc() call on every transfer and some memory indirections. The only possible downside is for isochronous tranfers with 64

Re: [PATCH] uwb: move mutex_lock to error case in uwbd_evt_handle_rc_bp_slot_change

2013-12-20 Thread David Cohen
On Fri, Dec 20, 2013 at 11:55:53AM -0600, Thomas Pugliese wrote: Only acquire rc-uwb_dev.mutex in the error case in uwbd_evt_handle_rc_bp_slot_change. This fixes a bug where establishing a reservation on a new channel will fail if we were unable to establish a reservation on the previous

Re: [PATCH] uwb: move mutex_lock to error case in uwbd_evt_handle_rc_bp_slot_change

2013-12-20 Thread Thomas Pugliese
On Fri, 20 Dec 2013, David Cohen wrote: On Fri, Dec 20, 2013 at 11:55:53AM -0600, Thomas Pugliese wrote: Only acquire rc-uwb_dev.mutex in the error case in uwbd_evt_handle_rc_bp_slot_change. This fixes a bug where establishing a reservation on a new channel will fail if we were unable

[PATCH v2] uwb: move mutex_lock to error case in uwbd_evt_handle_rc_bp_slot_change

2013-12-20 Thread Thomas Pugliese
Only acquire rc-uwb_dev.mutex in the error case in uwbd_evt_handle_rc_bp_slot_change. This fixes a bug where establishing a reservation on a new channel will fail if we were unable to establish a reservation on the previous channel due to DRP conflict. If rc-uwb_dev.mutex is acquired in the

Re: [RFC/PATCH 1/3] pm: make PM macros more smart

2013-12-20 Thread Pavel Machek
On Sun 2013-12-15 11:25:08, David Cohen wrote: On Sun, Dec 15, 2013 at 06:51:12PM +0100, Pavel Machek wrote: On Thu 2013-12-12 21:18:23, David Cohen wrote: This patch makes SET_SYSTEM_SLEEP_PM_OPS() and SET_RUNTIME_PM_OPS() more smart. Despite those macros check for '#ifdef

Re: [PATCH v4 00/15] usb: phy: msm: Fixes, cleanups and DT support

2013-12-20 Thread David Brown
On Thu, Dec 19, 2013 at 05:26:13PM -0600, Felipe Balbi wrote: it's getting quite late for me. I still want to leave my stuff soaking in linux-next for a while. I'll try my best, though, if you ack it ASAP Thanks. Patch 1 already has my Ack in it, and I've sent an ack for number 6. David --

Re: [RFC/PATCH 1/3] pm: make PM macros more smart

2013-12-20 Thread David Cohen
On Fri, Dec 20, 2013 at 08:55:27PM +0100, Pavel Machek wrote: On Sun 2013-12-15 11:25:08, David Cohen wrote: On Sun, Dec 15, 2013 at 06:51:12PM +0100, Pavel Machek wrote: On Thu 2013-12-12 21:18:23, David Cohen wrote: This patch makes SET_SYSTEM_SLEEP_PM_OPS() and SET_RUNTIME_PM_OPS()

[PATCH] usb: Fix oops on LPM disable failure.

2013-12-20 Thread Sarah Sharp
If a control transfer to a parent hub to disable the U1/U2 timeout fails when usb_reset_and_verify_device() calls into usb_unlocked_disable_lpm(), the USB core will attempt to re-enable LPM. That will cause an oops in usb_enable_link_state: [ 1466.722795] usb 2-2.3: Failed to set U1 timeout to

[PATCH] phy: core: properly handle failure of pm_runtime_get functions

2013-12-20 Thread Felipe Balbi
In case pm_runtime_get*() fails, it still increments pm usage counter, so we *must* make sure to pm_runtime_put() even in those cases. This patch fixes that mistake the same way usbcore treats those possible failures. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/phy/phy-core.c | 16

[PATCH] usb: phy: am335x: fix randconfig errors

2013-12-20 Thread Felipe Balbi
by using SET_SYSTEM_SLEEP_PM_OPS, we will make sure that we don't use undefined functions. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/phy/phy-am335x.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/usb/phy/phy-am335x.c

Re: [PATCH] usb: phy: am335x: fix randconfig errors

2013-12-20 Thread Fabio Estevam
On Fri, Dec 20, 2013 at 7:05 PM, Felipe Balbi ba...@ti.com wrote: by using SET_SYSTEM_SLEEP_PM_OPS, we will make sure that we don't use undefined functions. Signed-off-by: Felipe Balbi ba...@ti.com You could optimize this a bit further: --- a/drivers/usb/phy/phy-am335x.c +++

Re: [PATCH] usb: phy: am335x: fix randconfig errors

2013-12-20 Thread Felipe Balbi
On Fri, Dec 20, 2013 at 07:19:31PM -0200, Fabio Estevam wrote: On Fri, Dec 20, 2013 at 7:05 PM, Felipe Balbi ba...@ti.com wrote: by using SET_SYSTEM_SLEEP_PM_OPS, we will make sure that we don't use undefined functions. Signed-off-by: Felipe Balbi ba...@ti.com You could optimize this a

[PATCH 2/4] usbtest: Fix BOS control test for USB 2.01 devices.

2013-12-20 Thread Sarah Sharp
Commit c952a8ba7136505cd1ca01735cc748ddc08c7d2f usb: usbtest: add a test case to support bos for queue control will cause USB 2.01 and USB 2.10 devices with a BOS descriptor to fail case 15 of the control test. The Link PM errata (released in 2007, updated in 2011) says: The value of the bcdUSB

[PATCH 4/4] usb: xhci: Check for XHCI_PLAT in xhci_cleanup_msix()

2013-12-20 Thread Sarah Sharp
From: Jack Pham ja...@codeaurora.org If CONFIG_PCI is enabled, make sure xhci_cleanup_msix() doesn't try to free a bogus PCI IRQ or dereference an invalid pci_dev when the xHCI device is actually a platform_device. This patch should be backported to kernels as old as 3.9, that contain the commit

[PATCH 3/4] xhci: Remove unused variable 'addr' in inc_deq() and inc_enq().

2013-12-20 Thread Sarah Sharp
From: Lin Wang bupt.wang...@gmail.com This patch remove unused variable 'addr' in inc_deq() and inc_enq(). Signed-off-by: Lin Wang lin.x.w...@intel.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 6 -- 1 file changed, 6 deletions(-) diff

[PATCH 1/4] xhci: Add quirks module option

2013-12-20 Thread Sarah Sharp
From: Takashi Iwai ti...@suse.de It makes easier for debugging some hardware specific issues. Note that this option won't override the value to be set. That is, you can turn quirks on by this option but cannot turn them off if set by the driver. Signed-off-by: Takashi Iwai ti...@suse.de

[GIT PULL] xhci: Cleanups, non-urgent fixes for 3.14.

2013-12-20 Thread Sarah Sharp
The following changes since commit 3d724fa513cd1bd06d3457ccda36941f3606d048: USB: emi62: Provide the correct bitstream firmware (2013-12-10 22:38:45 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git tags/for-usb-next-2013-12-20 for

Re: EHCI: BIOS handoff failed (BIOS bug?) 01010001 on Celeron N2805 (Bay Trail) / Gateway LT41P

2013-12-20 Thread Ken Harris
On Wed, Dec 18, 2013 at 12:00 AM, Ken Harris k...@hokulea.org wrote: On Tue, Dec 17, 2013 at 6:47 PM, Ken Harris k...@hokulea.org wrote: On Tue, Dec 17, 2013 at 5:33 PM, Ken Harris k...@hokulea.org wrote: On Tue, Dec 17, 2013 at 1:03 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On

Re: xhci_hcd and Canon Lide 110 not playing well together

2013-12-20 Thread Sarah Sharp
On Wed, Dec 18, 2013 at 09:59:33PM +0100, Matthias Bläsing wrote: Hey all, On Fr, 2013-12-13 at 17:53 +0100, Holger Hans Peter Freyther wrote: On Tue, May 28, 2013 at 07:40:57PM +0200, Holger Hans Peter Freyther wrote: Is there a timeline when you think this could be fixed? I

Re: [PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown

2013-12-20 Thread Sarah Sharp
On Fri, Dec 20, 2013 at 12:41:11PM +0200, Denis Turischev wrote: Also, which kernel are you experiencing this issue on? In 3.12, I queued a separate patch to deal with spurious reboot issues on Lynx Point: commit 638298dc66ea36623dbc2757a24fc2c4ab41b016 Sorry, I indeed tested not on

Re: [PATCH] USB: core: remove CONFIG_USB_DEBUG usage

2013-12-20 Thread Alan Stern
On Fri, 20 Dec 2013, Greg Kroah-Hartman wrote: /* Check that the pipe's type matches the endpoint's type */ if (usb_pipetype(urb-pipe) != pipetypes[xfertype]) It looks as though it ought to be possible to make that check: if (unlikely(xfertype != urb-pipe-valid_xfertype))

Re: EHCI: BIOS handoff failed (BIOS bug?) 01010001 on Celeron N2805 (Bay Trail) / Gateway LT41P

2013-12-20 Thread Alan Stern
On Thu, 19 Dec 2013, Ken Harris wrote: David: I'm having trouble getting USB working on my Gateway LT41P laptop. I get an error message EHCI: BIOS handoff failed (BIOS bug?) 01010001 and I wonder if you can suggest any fixes or workarounds. The EHCI controller works on MS Windows 8.1.

Re: [PATCH] USB: core: remove CONFIG_USB_DEBUG usage

2013-12-20 Thread Greg Kroah-Hartman
On Fri, Dec 20, 2013 at 09:47:53PM -0500, Alan Stern wrote: On Fri, 20 Dec 2013, Greg Kroah-Hartman wrote: /* Check that the pipe's type matches the endpoint's type */ if (usb_pipetype(urb-pipe) != pipetypes[xfertype]) It looks as though it ought to be possible to

[RFC PATCH 1/4] usb: introduce hub-resume_bits and HCD_FLAG_RESET_RESUME

2013-12-20 Thread Dan Williams
Preparation for making reset_resume a port event. End goal is to trigger port recovery actions like warm reset when recovering a port power session. A usb_device may not be attached to the port, so the flag for requesting reset service can not be contained within the usb_device. Signed-off-by:

[RFC PATCH 4/4] usb: port pm recovery

2013-12-20 Thread Dan Williams
Implement port power recovery via queuing warm reset requests in khubd context. There are two new cases where we want to trigger a warm reset to a port: 1/ Buggy xHCs that do not propagate warm reset to child ports when reset-resuming the root hub. [1] [hub_activate] 2/ Unconditionally when

[RFC PATCH 3/4] usb: reset resume in khubd context

2013-12-20 Thread Dan Williams
Preparation patch for synchronizing port warm reset recovery with khubd and child device resume recovery. End goal is to ensure khubd does not run while port recovery in-progress (as the port is known to appear disconnected), and also arrange for any optional warm resets to complete before

[RFC PATCH 0/4] port warm reset recovery

2013-12-20 Thread Dan Williams
Both the suspected quirky Synopsys xHC [1] and the port-pm-runtime-resume path need to issue warm resets to reliably bring ports back to an operational state. Per Alan's observation this also arranges for these warm resets to be queued asynchronously. Per my previous testing I found cases where

[RFC PATCH 2/4] usb: convert khubd to a workqueue

2013-12-20 Thread Dan Williams
Both a cleanup, as khubd open codes several facilities that are provided by workqueue, and a prepation for running port resume events in khubd context. Running port recovery in khubd context allows coalescing / ordering port recovery actions with device recovery and it guarantees that hub_events

Project

2013-12-20 Thread SA
May I request for your partnership to execute a project in Asia, revert if interested -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: cdc-wdm: avoid hanging on zero length reads

2013-12-20 Thread Oliver Neukum
On Fri, 2013-12-20 at 14:07 +0100, Bjørn Mork wrote: commit 73e06865ead1 (USB: cdc-wdm: support back-to-back USB_CDC_NOTIFY_RESPONSE_AVAILABLE notifications) implemented queued response handling. This added a new requirement: The read urb must be resubmitted every time we clear the WDM_READ