Rafał Miłecki zaj...@gmail.com writes:
Hi,
This is report from my Samsung NP700G7A-S01PL. This notebook has two
USB 2.0 ports and two 3.0 ports.
Starting with the following commit:
commit 7dd09a1af2c7150269350aaa567a11b06e831003
Author: Xenia Ragiadakou burzalod...@gmail.com
Date: Fri
From: Of Bjørn Mork
Rafal Milecki zaj...@gmail.com writes:
Hi,
This is report from my Samsung NP700G7A-S01PL. This notebook has two
USB 2.0 ports and two 3.0 ports.
Starting with the following commit:
commit 7dd09a1af2c7150269350aaa567a11b06e831003
Author: Xenia Ragiadakou
On Tue, Jan 28, 2014 at 11:32:28AM -0500, Alan Stern wrote:
On Tue, 28 Jan 2014, Peter Chen wrote:
It sounds like this is a bug in your EHCI hardware. The
wake-on-disconnect logic should never take effect until after the port
goes into full-speed idle.
Where EHCI spec said that?
Hello.
On 29-01-2014 10:22, Simon Horman wrote:
[snip]
+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = {
+{ .compatible = renesas,usb-phy-r8a7790, },
+{ .compatible = renesas,rcar-gen2-usb-phy, },
Frankly speaking, I don't understand the need for the clearly
On 29/01/2014 12:08 μμ, Rafał Miłecki wrote:
2014-01-29 David Laight david.lai...@aculab.com:
Maybe I misunderstand something, but won't that commit end up replacing
the previous pair of writel() with a single native writeq() on 64bit
platforms?
Judging by the comment in front of the
On Tue, Jan 28, 2014 at 04:28:44PM +0100, Michael Grzeschik wrote:
This patch makes it possible to set the chipidea udc into full-speed only
mode.
It is set by the oftree property maximum-speed = full-speed.
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de
Signed-off-by: Marc
From: Xenia Ragiadakou
On 29/01/2014 12:08 μμ, Rafał Miłecki wrote:
2014-01-29 David Laight david.lai...@aculab.com:
Maybe I misunderstand something, but won't that commit end up replacing
the previous pair of writel() with a single native writeq() on 64bit
platforms?
Judging by the
This patch adds two example applications showing usage of Asynchronous I/O API
of FunctionFS. First one (aio_simple) is simple example of bidirectional data
transfer. Second one (aio_multibuff) shows multi-buffer data transfer, which
may to be used in high performance applications.
Both examples
From: Robert Baldyga
This patch adds two example applications showing usage of Asynchronous I/O API
of FunctionFS. First one (aio_simple) is simple example of bidirectional data
transfer. Second one (aio_multibuff) shows multi-buffer data transfer, which
may to be used in high performance
On Wed, Jan 29, 2014 at 02:41:58PM +0400, Sergei Shtylyov wrote:
Hello.
On 29-01-2014 10:22, Simon Horman wrote:
[snip]
+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = {
+{ .compatible = renesas,usb-phy-r8a7790, },
+{ .compatible = renesas,rcar-gen2-usb-phy, },
Hello.
On 29-01-2014 16:22, Simon Horman wrote:
[snip]
+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = {
+{ .compatible = renesas,usb-phy-r8a7790, },
+{ .compatible = renesas,rcar-gen2-usb-phy, },
Frankly speaking, I don't understand the need for the clearly
On Wed, Jan 29, 2014 at 04:26:55PM +0400, Sergei Shtylyov wrote:
Hello.
On 29-01-2014 16:22, Simon Horman wrote:
[snip]
+static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = {
+{ .compatible = renesas,usb-phy-r8a7790, },
+{ .compatible = renesas,rcar-gen2-usb-phy, },
On Wed, Jan 29 2014, Robert Baldyga wrote:
+++ b/tools/usb/aio_multibuff/device_app/aio_multibuff.c
+#define BUF_LEN 8192
+#define BUFS_MAX 128
+#define AIO_MAX (BUFS_MAX*2)
+
+struct iocb *iocb1[AIO_MAX];
+struct iocb *iocb2[AIO_MAX];
+
+unsigned char
From: Michal Nazarewicz
On Wed, Jan 29 2014, Robert Baldyga wrote:
+ /* open endpoint files */
ep_path = malloc(strlen(argv[1]) + 4 /* /ep# */ + 1 /* '\0' */);
if (!ep_path) {
perror(malloc);
return 1;
}
At this point you could get away
Hi,
Le Fri, 24 Jan 2014 11:07:01 -0500,
Alan Stern st...@rowland.harvard.edu a écrit :
Matthieu:
Can you help with this problem?
You were right; that driver caused the problem.
Matthieu Castet wrote the Cypress-ATACB driver, so maybe he can help.
As shown above, this device
The xhci driver should send a zero length message if a bulk transfer
is a multiple of the message size and the URB_ZERO_PACKET flag is set.
Quite a few of the usb ethernet drivers generate requests with
URB_ZERO_PACKET set, and at least some will fail to send some specific
packet sizes (possibly
- Use a separate 'ret' variable for the result of prepare_transfer().
- No need to assign 'urb_priv' and 'td' until the last fragment.
- Add 'len_left' to count the bytes remaining, use instead of
'urb-transfer_buffer_length - running_total' and to check for the
last fragment (instead of
prepare_transfer() only needs an upper bound for the number of TRB required.
For scatter-gather requests this can be calculated cheaply.
However a request with a lot of fragments, or for a long transfer,
might then get bounced because the number of fragments exceeds the
size of a ring segment (and
The TRB type and flags are the same for all the TRB expect the first
(which needs the opposite value of TRB_CYCLE) and the last (which
needs TRB_CHAIN clear and TRB_IOC set).
So move the code that sets it up outside the loop.
Signed-off-by: David Laight david.lai...@aculab.com
---
The calculation done for the first fragment is exactly the same
as the one for subsequent fragments.
So move both versions to inside the loop at the top.
Simplify the calculation for the distance to the next 64k boundary.
Remove the never-checked 'num_sgs'.
Signed-off-by: David Laight
The check_trb_math() function and the check for sg buffers crossing 64k
boundaries are checks that the local function is correct.
Since the code is correct they can be removed.
Signed-off-by: David Laight david.lai...@aculab.com
---
drivers/usb/host/xhci-ring.c | 26 --
1
If URB_ZERO_PACKET is set then make sure that the last usb message
sent isn't a full sized one. A partial transfer is needed to terminate
variable length bulk output (eg ethernet frames).
URB_ZERO_PACKET is easily implemented by increasing td_residue
to account for the extra packet.
v1.0 hosts need the td_size set to the number of messages (including
the final short one) that need to be sent to complete the transfer
after all the full-sized ones for the current TRB have been sent.
The code in xhci_v1_0_td_remainder() carefully copies the algorithm
from the documentation, but
Modify the code in queue_bulk_sg_tx() to support non-sg transfers.
Rename it xhci_queue_bulk_tx() and delete the old xhci_queue_bulk_tx().
Signed-off-by: David Laight david.lai...@aculab.com
---
drivers/usb/host/xhci-ring.c | 159 ---
1 file changed, 15
Hi,
On 01/29/2014 01:39 PM, Michal Nazarewicz wrote:
On Wed, Jan 29 2014, Robert Baldyga wrote:
+++ b/tools/usb/aio_multibuff/device_app/aio_multibuff.c
+#define BUF_LEN 8192
+#define BUFS_MAX128
+#define AIO_MAX (BUFS_MAX*2)
+
+struct iocb *iocb1[AIO_MAX];
The number of trbs depends on the number of 64k boundaries crossed.
Using a common function saves there being any typos in the 3 places
it is used.
Signed-off-by: David Laight david.lai...@aculab.com
---
drivers/usb/host/xhci-ring.c | 18 --
1 file changed, 12 insertions(+), 6
From: Greg KH
On Mon, Jan 27, 2014 at 04:06:22PM +, David Laight wrote:
Many of the net/usb ethernet drivers (including common ones like
the smsc95xx) will fail to transmit all packet length properly
when connected to a USB3 port (ie using the xhci driver).
That's odd, as I've never
From: Sarah Sharp
On Wed, Jan 22, 2014 at 03:22:53PM -0800, walt wrote:
On 01/22/2014 12:56 PM, Sarah Sharp wrote:
Walt, can you turn on xHCI debugging and look for whether the NEC host
that worked with David's patch is a 1.0 host? You'll see a line like:
// @%p = 0x%x (CAPLENGTH
Hi,
On Tue, Jan 28, 2014 at 10:30:36AM -0600, Felipe Balbi wrote:
On Tue, Jan 28, 2014 at 05:32:30PM +0200, Heikki Krogerus wrote:
On Mon, Jan 27, 2014 at 10:05:20AM -0600, Felipe Balbi wrote:
For the controller drivers the PHYs are just a resource like any
other. The controller drivers
From: Sarah Sharp
Hi David,
I've been thinking about this some more, and I'd like to propose a much
simpler solution.
The TD fragment rules didn't go into the xHCI specification until the
1.0 revision. The code that follows those rules only seems to trigger
issues for 0.96 ASMedia
Hi,
Not sure if it's been posted already. I'm running the latest Linus tree.
[ 10.636228] INFO: trying to register non-static key.
[ 10.636782] the code is fine but needs lockdep annotation.
[ 10.637271] turning off the locking correctness validator.
[ 10.637772] CPU: 0 PID: 1216 Comm:
I've decided to forward this to the list.
If you read further down he says that my patch makes the operation
of the ax88179_178a stable - once the system has recognised it properly.
David
-Original Message-
From: renev...@internode.on.net [mailto:renev...@internode.on.net]
Hi,
can you recommend a test device for UAS?
Regards
Oliver
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 29 Jan 2014, Denis Kirjanov wrote:
Hi,
Not sure if it's been posted already. I'm running the latest Linus tree.
[ 10.636228] INFO: trying to register non-static key.
[ 10.636782] the code is fine but needs lockdep annotation.
[ 10.637271] turning off the locking correctness
On Wed, 29 Jan 2014, Oliver Neukum wrote:
Hi,
can you recommend a test device for UAS?
I have never encountered any. You can always try the UAS gadget over
dummy-hcd, but that's not the same as real hardware.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe
With a USB 2.0 webcam attached to the OTG port on an OMAP3 (applies to
overo gumstix, beagleboard, probably others) we see a high CPU load in a
kworker thread.
Between 2.6.33 and 2.6.34 musb_core.c changed.
IRQ handlers changed with the result that a worker in musb_core.c got
scheduled far
On Wed, 29 Jan 2014, Peter Chen wrote:
On Tue, Jan 28, 2014 at 11:32:28AM -0500, Alan Stern wrote:
On Tue, 28 Jan 2014, Peter Chen wrote:
It sounds like this is a bug in your EHCI hardware. The
wake-on-disconnect logic should never take effect until after the port
goes into
kernfs_deactivate() forgot to check whether KERNFS_LOCKDEP is set
before performing lockdep annotations and ends up feeding
uninitialized lockdep_map to lockdep triggering warning like the
following on USB stick hotunplug.
usb 1-2: USB disconnect, device number 2
INFO: trying to register
On Wed, Jan 29, 2014 at 3:04 PM, Tejun Heo t...@kernel.org wrote:
kernfs_deactivate() forgot to check whether KERNFS_LOCKDEP is set
before performing lockdep annotations and ends up feeding
uninitialized lockdep_map to lockdep triggering warning like the
following on USB stick hotunplug.
Previously the of_phy_get function took a struct device * and
was declared static. It was impossible to call it from
another driver and thus it was impossible to get phy defined
for a given node. The old function was renamed to _of_phy_get
and was left for internal use. of_phy_get function was
From: Mateusz Krawczuk mat.krawc...@gmail.com
Add support for the Samsung's S5PV210 SoC to the Exynos USB PHY driver.
Signed-off-by: Mateusz Krawczuk m.krawc...@partner.samsung.com
[k.deb...@samsung.com: cleanup and commit description]
[k.deb...@samsung.com: make changes accordingly to the
Add support to PHY of USB2 of the Exynos 4 SoC.
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
.../devicetree/bindings/arm/samsung/pmu.txt|2 ++
arch/arm/boot/dts/exynos4.dtsi | 31
arch/arm/boot/dts/exynos4210.dtsi |
Add support to PHY of USB2 of the Exynos 5250 SoC.
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
arch/arm/boot/dts/exynos5250.dtsi | 24
1 file changed, 24 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index
Change the phy provider used from the old one using the USB phy
framework to a new one using the Generic phy framework.
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
.../devicetree/bindings/usb/exynos-usb.txt | 13 +++
drivers/usb/host/ehci-exynos.c | 97
Adding devm_of_phy_get will allow to get phys by supplying a
pointer to the struct device_node instead of struct device.
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
drivers/phy/phy-core.c | 31 +++
include/linux/phy/phy.h |8
2 files changed,
Add a new driver for the Exynos USB PHY. The new driver uses the generic
PHY framework. The driver includes support for the Exynos 4x10 and 4x12
SoC families.
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
.../devicetree/bindings/phy/samsung-phy.txt| 55
Add support for Exynos 5250. This driver is to replace the old
USB 2.0 PHY driver.
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
.../devicetree/bindings/phy/samsung-phy.txt|1 +
drivers/phy/Kconfig| 11 +
drivers/phy/Makefile
Hi,
This is the sixth version of the patchset. It adds a new Exynos USB 2.0 PHY
driver. The driver uses the Generic PHY Framework.
Again, I would like to thank everyone who commented and read through the fifth
version of the patchset. Your input is very much appreciated. The last version
had two
On Wed, 29 Jan 2014, Kamil Debski wrote:
Change the phy provider used from the old one using the USB phy
framework to a new one using the Generic phy framework.
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
.../devicetree/bindings/usb/exynos-usb.txt | 13 +++
On Wed, Jan 29, 2014 at 9:29 AM, Kamil Debski k.deb...@samsung.com wrote:
Add support to PHY of USB2 of the Exynos 4 SoC.
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
.../devicetree/bindings/arm/samsung/pmu.txt|2 ++
arch/arm/boot/dts/exynos4.dtsi |
Hi,
On Wed, Jan 29, 2014 at 9:29 AM, Kamil Debski k.deb...@samsung.com wrote:
Change the phy provider used from the old one using the USB phy
framework to a new one using the Generic phy framework.
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
On Tue, Jan 28, 2014 at 11:30:51PM -0500, Mark Lord wrote:
On 14-01-28 03:30 PM, Sarah Sharp wrote:
..
Can you please pull this branch, which contains a 3.13 kernel with
David's patch reverted, and test whether your USB ethernet device works
or fails?
Fails. dmesg log attached.
It's
On Wed, Jan 29, 2014 at 11:38:19AM -0500, Alan Stern wrote:
On Wed, 29 Jan 2014, Oliver Neukum wrote:
Hi,
can you recommend a test device for UAS?
I have never encountered any. You can always try the UAS gadget over
dummy-hcd, but that's not the same as real hardware.
I've never
On Wed, Jan 29, 2014 at 03:19:51PM -0200, Fabio Estevam wrote:
On Wed, Jan 29, 2014 at 3:04 PM, Tejun Heo t...@kernel.org wrote:
kernfs_deactivate() forgot to check whether KERNFS_LOCKDEP is set
before performing lockdep annotations and ends up feeding
uninitialized lockdep_map to lockdep
On Wed, Jan 29, 2014 at 11:38:19AM -0500, Alan Stern wrote:
On Wed, 29 Jan 2014, Oliver Neukum wrote:
Hi,
can you recommend a test device for UAS?
I have never encountered any. You can always try the UAS gadget over
dummy-hcd, but that's not the same as real hardware.
Pluggable
On 29/01/2014 01:43 μμ, David Laight wrote:
From: Xenia Ragiadakou
On 29/01/2014 12:08 μμ, Rafał Miłecki wrote:
2014-01-29 David Laight david.lai...@aculab.com:
Maybe I misunderstand something, but won't that commit end up replacing
the previous pair of writel() with a single native writeq()
On Wed, Jan 29, 2014 at 04:21:00PM +1100, renev...@internode.on.net wrote:
Hello,
I am someone who has been struggling to get an ax88179 net adapter working
reliably.
I have an integrated Asmedia 1042 xhci controller that is reportedly version
0.96 on an ASUS M5A99FX PRO R2.0, BIOS 2201
On Wed, Jan 29, 2014 at 12:50:04PM +0200, Xenia Ragiadakou wrote:
On 29/01/2014 12:08 μμ, Rafał Miłecki wrote:
I've enabled some debugging in xhci-dbg.c, does it help?
xhci_hcd :04:00.0: xHCI capability registers at c90004e6:
xhci_hcd :04:00.0: CAPLENGTH AND HCIVERSION
The patch did prevent the whole system from crashing but I have to unplug and
plug something like 20 times to get it not to spit out those error messages.
Even once it is up, it doesn't operate at full gigabit speed and there is
something funky going on. When sending via scp it maxed out at
On Fri, Jan 17, 2014 at 08:31:53PM -0500, Alan Stern wrote:
I agree your alternative is much cleaner, and I agree we should try to
treat roothubs like external hubs. I've made a patch (to be sent
shortly) that fixes this.
However, I would like to see the original bad commit (usbcore:
On Mon, Jan 20, 2014 at 5:15 AM, Chen, Jamie jamie.c...@intel.com wrote:
Try to apply this patch to kernel 3.8.0.
Make sure the ehci can work fine and lspci show that PCI_COMMAND_INTX_DISABLE
is 0.
The patch can resolved this issue.
Thanks for testing it. Can you collect the complete
I just tried with 3.12.9 and got the errors. I'll keep going back.
It doesn't look like the nic is faulty, i'm using it right now plugged into a
usb 2.0 port.
[ 303.418028] usb 5-5: new high-speed USB device number 2 using ehci-pci
[ 303.548948] usb 5-5: New USB device found, idVendor=0b95,
Hi Sarah and David. I'm back with more ASMedia problems caused by this:
commit ec513b16c480c6cdda1e3d597e611eafca05227b
Merge: bcee634 2fc5a7d
Author: Linus Torvalds torva...@linux-foundation.org
Date: Mon Jan 20 16:13:02 2014 -0800
Merge tag 'usb-3.14-rc1' of
On Thu, Jan 30, 2014 at 11:13:53AM +1100, renev...@internode.on.net wrote:
I just tried with 3.12.9 and got the errors. I'll keep going back.
But which version of 3.12 worked? Just 3.12?
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message
On Wed, Jan 29, 2014 at 04:16:49PM -0800, walt wrote:
Hi Sarah and David. I'm back with more ASMedia problems caused by this:
commit ec513b16c480c6cdda1e3d597e611eafca05227b
Merge: bcee634 2fc5a7d
Author: Linus Torvalds torva...@linux-foundation.org
Date: Mon Jan 20 16:13:02 2014 -0800
On Wed, Jan 29, 2014 at 02:00:29PM -0800, Sarah Sharp wrote:
I think the solution should be to just revert the writeq patch, and
leave the xhci_write64 in place. We can always optimize that function
later to do a writeq if the host supports 64-bit writes, but we'll have
to analyze whether the
Yoma, can you apply this patch and see if it helps your issue?
Thanks,
Sarah Sharp
On Wed, Jan 22, 2014 at 03:38:51PM -0800, Sarah Sharp wrote:
If the control transfer to set the device-initiated timeout fails for a
particular link state (U1 or U2), disable that state. This may solve
issues
On Wed, Jan 29, 2014 at 03:48:27PM +, David Laight wrote:
I've decided to forward this to the list.
If you read further down he says that my patch makes the operation
of the ax88179_178a stable - once the system has recognised it properly.
I don't understand why your patch helped. This
[Please don't drop Cc'ed people.]
On Thu, Jan 30, 2014 at 10:29:33AM +1100, renev...@internode.on.net wrote:
The patch did prevent the whole system from crashing but I have to unplug and
plug something like 20 times to get it not to spit out those error messages.
Even once it is up, it
On Wed, Jan 22, 2014 at 08:51:31AM -0800, Jay S wrote:
Actually, the USB3 device I'm using, a Unitek Y-1072 HDD dock, works
fine with a WD 500 GB drive using XHCI, so it seems like it's
something to do with the larger drive.
I have also tried with a Rosewill RX35-AT-SU3 external enclosure
Hi Kishon,
On Mon, Jan 27, 2014 at 2:27 PM, Kishon Vijay Abraham I kis...@ti.com wrote:
Hi,
Thanks for review. Please find my answers inline below.
On Monday 20 January 2014 07:12 PM, Vivek Gautam wrote:
Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs.
The new driver uses
Hi,
On Thursday 30 January 2014 09:49 AM, Vivek Gautam wrote:
Hi Kishon,
On Mon, Jan 27, 2014 at 2:27 PM, Kishon Vijay Abraham I kis...@ti.com wrote:
Hi,
Thanks for review. Please find my answers inline below.
On Monday 20 January 2014 07:12 PM, Vivek Gautam wrote:
Add a new driver
On 01/29/2014 01:01 PM, David Laight wrote:
From: Robert Baldyga
This patch adds two example applications showing usage of Asynchronous I/O
API
of FunctionFS. First one (aio_simple) is simple example of bidirectional data
transfer. Second one (aio_multibuff) shows multi-buffer data
73 matches
Mail list logo
