Re: [PATCH v3 08/13] usb: chipidea: OTG fsm timers initialization.

2014-03-11 Thread Peter Chen
On Thu, Mar 06, 2014 at 12:30:40PM +0800, Peter Chen wrote: > On Thu, Feb 27, 2014 at 07:38:26AM +0800, Li Jun wrote: > > This patch adds OTG fsm timers initialization, which use controller's 1ms > > interrupt as timeout counter, also adds some local timers which are not > > in otg_fsm_timer list.

Re: [PATCH v3 09/13] usb: chipidea: OTG HNP and SRP fsm implementation.

2014-03-11 Thread Peter Chen
On Thu, Feb 27, 2014 at 07:38:27AM +0800, Li Jun wrote: > USB OTG interrupt handling and fsm transition according to USB OTG > and EH 2.0, update otg timer timeout handlers. > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/core.c| 10 ++- > drivers/usb/chipidea/otg.c |9 +- >

Re: [PATCH net-next] r8152: support dumping the hw counters

2014-03-11 Thread David Miller
From: Hayes Wang Date: Tue, 11 Mar 2014 16:24:19 +0800 > Add dumping the tally counter by ethtool. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH v2] usb: gadget: tcm_usb_gadget: stop format strings

2014-03-11 Thread Kees Cook
This makes sure that the name coming out of configfs cannot be used accidentally as a format string. Signed-off-by: Kees Cook Cc: sta...@vger.kernel.org --- v2: - with stable cc; Felipe Balbi. --- drivers/usb/gadget/tcm_usb_gadget.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: MAX3421E: device giving NAKs forever?

2014-03-11 Thread David Mosberger
I couldn't figure out how to force UHCI onto an EHCI chip but I did find I had some old IOGEAR USB 1.1 "extenders" (USB-over-CAT5 cable) and with those, the device does switch into full-speed mode on my computer: [ 886.371122] usb 1-1.3.1.1.4.2: USB disconnect, device number 15 [ 950.960459] usb

Re: [PATCH] usb: gadget: tcm_usb_gadget: stop format strings

2014-03-11 Thread Felipe Balbi
On Tue, Mar 11, 2014 at 01:26:16PM -0700, Kees Cook wrote: > This makes sure that the name coming out of configfs cannot be used > accidentally as a format string. > > Signed-off-by: Kees Cook > --- > drivers/usb/gadget/tcm_usb_gadget.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: musb - high CPU load in DMA mode and dropouts during audio playback

2014-03-11 Thread Michal Å mucr
Hi George, I did few more tests and have further details for you. This time i modified my build procedure and according to Felipe's hint, I used ti-linux-3.12.y branch from TI repository and also clean 3.14-rc6 kernel, where i subsequently tried additional unmerged patches. With ti-linux-3.12.y

RE: [PATCHv4 1/4] usb: dwc2: Add defines to support the s3c-hsotg driver

2014-03-11 Thread Paul Zimmerman
> From: Dinh Nguyen [mailto:dinh.li...@gmail.com] > Sent: Monday, March 10, 2014 5:52 AM > > In preparation of combining the dwc2/s3c-hsotg driver in a single DRD driver, > the defines in dwc2/hw.h needs to get updated so that the s3c-hsotg driver can > use them. > > Signed-off-by: Dinh Nguyen >

Re: [PATCH v2] phy-rcar-gen2-usb: add device tree support

2014-03-11 Thread Sergei Shtylyov
Hello. On 03/10/2014 02:00 PM, Magnus Damm wrote: Add support of the device tree probing for the Renesas R-Car generation 2 SoCs documenting the device tree binding as necessary. Signed-off-by: Sergei Shtylyov --- This patch is against the 'next' branch of Felipe Balbi's 'usb.git' repo.

Oops again

2014-03-11 Thread Nicholas Leippe
nouveau drivers kernel 3.13.5 lsusb hangs in D $ uname -a Linux hellcat 3.13.5-gentoo #1 SMP PREEMPT Fri Mar 7 13:38:21 MST 2014 x86_64 Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz GenuineIntel GNU/Linux $ lsmod Module Size Used by snd_pcm_oss37776 0 snd_mixer_oss

[PATCH] usb: gadget: tcm_usb_gadget: stop format strings

2014-03-11 Thread Kees Cook
This makes sure that the name coming out of configfs cannot be used accidentally as a format string. Signed-off-by: Kees Cook --- drivers/usb/gadget/tcm_usb_gadget.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/tcm_usb_gadget.c b/drivers/usb/gadget/t

Re: [PATCH v2][ 4/8] ARM: dts: imx25.dtsi: Fix USB support.

2014-03-11 Thread Sergei Shtylyov
Hello. On 03/11/2014 01:55 PM, Denis Carikli wrote: From: Fabio Estevam This patch was adapted from the thread named "USB Host support for mx25" on linux-usb@vger.kernel.org Signed-off-by: Denis Carikli Same comments as to the patch #6. WBR, Sergei -- To unsubscribe from this lis

Re: [PATCH v2][ 6/8] ARM: dts: i.MX35: Add USB support.

2014-03-11 Thread Sergei Shtylyov
Hello. On 03/11/2014 01:55 PM, Denis Carikli wrote: Signed-off-by: Denis Carikli --- Changelog v1->v2: - The usbphy nodes were made to look like the ones in imx53.dtsi - The patch was rebased on top of the clock fixes commits. --- arch/arm/boot/dts/imx35.dtsi | 16 1 f

Re: MAX3421E: device giving NAKs forever?

2014-03-11 Thread Alan Stern
On Tue, 11 Mar 2014, David Mosberger wrote: > > It looks like the host controller is behaving correctly, which means > > the fault is in the device. Have you tried plugging this device into a > > regular Linux PC and running the same test? > > Yup, works fine at least at least at hispeed. I sup

Re: MAX3421E: device giving NAKs forever?

2014-03-11 Thread David Mosberger
On Tue, Mar 11, 2014 at 12:43 PM, Alan Stern wrote: > On Tue, 11 Mar 2014, David Mosberger wrote: > >> So I hooked up a Seleae Logic and I still can't find anything obvious >> that's wrong. I attached the decoded USB trace for the last WRITE10 >> request that's ends up with "infinite" NAKs. >> >>

Re: MAX3421E: device giving NAKs forever?

2014-03-11 Thread Alan Stern
On Tue, 11 Mar 2014, David Mosberger wrote: > So I hooked up a Seleae Logic and I still can't find anything obvious > that's wrong. I attached the decoded USB trace for the last WRITE10 > request that's ends up with "infinite" NAKs. > > After receiving 8 contiguous NAKs, my driver prints some ke

RE: [PATCHv2] rebind: Add rebind mechanism for runtime-resume

2014-03-11 Thread Alan Stern
On Tue, 11 Mar 2014, Poulain, Loic wrote: > To test the patch, I tried it with the btusb driver, and forced manually the > resume issue > with one interface (intf 0) every five resume call. With this patch, the > interface is correctly > unbind/rebind. Then, the upper layer (here android) is ab

Re: MAX3421E: device giving NAKs forever?

2014-03-11 Thread Felipe Balbi
On Tue, Mar 11, 2014 at 10:16:55AM +, David Laight wrote: > From: Felipe Balbi > > On Mon, Mar 10, 2014 at 02:15:36PM -0600, David Mosberger wrote: > > > I was thinking of the Salea Logic ($150). > > > Are you aware of any limitations for this one that would get i

Re: usbnet: driver_info->stop required to stop USB interrupts?

2014-03-11 Thread Grant Grundler
On Tue, Mar 11, 2014 at 10:31 AM, Grant Grundler wrote: > FWIW, I've reproduced this on "Samsung Chromebook" (Exynos 5250) with FYA - I just noticed the system crashed on the 2048th iteration :) ... RELOAD 2046 20140310202523 LINK 1000_full (3 sec) IP 192.168.1.116 (1 Sec) RELOAD 2047 201403

Re: usbnet: driver_info->stop required to stop USB interrupts?

2014-03-11 Thread Grant Grundler
On Tue, Mar 11, 2014 at 10:31 AM, Grant Grundler wrote: ... > FWIW, I've reproduced this on "Samsung Chromebook" (Exynos 5250) with > AX88772 USB dongle using the instructions I posted before (ie bouncing > the USB port with reload_asix script). Sorry - with AX88178 dongle - not AX88772 (5 machin

Re: usbnet: driver_info->stop required to stop USB interrupts?

2014-03-11 Thread Grant Grundler
On Mon, Mar 10, 2014 at 7:53 PM, Julius Werner wrote: > I think usbnet_stop() raced with the dev->bh tasklet, which by itself > might not be a problem (usbnet_stop() later kills the tasklet itself, > so it should expect that it can be running before that). The issue is > that it calls usbnet_termi

Re: usbnet: driver_info->stop required to stop USB interrupts?

2014-03-11 Thread Julius Werner
I don't know enough about how runtime PM works in this driver to really review that patch, sorry. (Would this do a complete resume of the device if we call usbnet_stop() while it was suspended? Is that what we want?) I think you could have also preserved the original logic of using dev->wait as a

RE: [PATCHv2] rebind: Add rebind mechanism for runtime-resume

2014-03-11 Thread Poulain, Loic
To test the patch, I tried it with the btusb driver, and forced manually the resume issue with one interface (intf 0) every five resume call. With this patch, the interface is correctly unbind/rebind. Then, the upper layer (here android) is able to retrieve the device. However, btusb driver it

Re: [PATCH] xhci: extend quirk for Renesas cards

2014-03-11 Thread Mathias Nyman
On 03/11/2014 04:54 PM, Anatoly C.K. wrote: Igor do not have this card. [root@fedora-20 ~]# lspci -vmnnd 1912: Device: 03:00.0 Class: USB controller [0c03] Vendor: Renesas Technology Corp. [1912] Device: uPD720202 USB 3.0 Host Controller [0015] SVendor:Renesas Technology Corp. [1912] SD

Re: [PATCH v9 0/9] USB Host support for OMAP5 uEVM

2014-03-11 Thread Tony Lindgren
* Roger Quadros [140311 06:13]: > On 03/11/2014 03:07 PM, Lee Jones wrote: > > > > This patchset brings up USB Host ports and Ethernet port on > > the OMAP5 uEVM board. > > > > It also does some cleanup with respect to DT clock binding > > for the mfd/omap-usb-host driver. > >

Re: MAX3421E: device giving NAKs forever?

2014-03-11 Thread David Mosberger
Thanks for the tips! Yes, the saleae is very simple so it may not do the trick. I am also concerned about the very basic trigger capabilities, but I'm hopeful that we can simply collect a long enough trace and then find the interesting spots after the fact. The MAX3421E also has a couple of gpio

Re: [PATCHv2] rebind: Add rebind mechanism for runtime-resume

2014-03-11 Thread Alan Stern
On Tue, 11 Mar 2014, Poulain, Loic wrote: > Despite the needs_rebind flag, the interface rebind was never > done for the PM runtime resume. This patch fixes this issue > by triggering the rebind in usb runtime resume. > > The rebind procedure needs to be called with the device lock. > However, de

Re: [PATCH v9 0/9] USB Host support for OMAP5 uEVM

2014-03-11 Thread Roger Quadros
On 03/11/2014 03:07 PM, Lee Jones wrote: > > This patchset brings up USB Host ports and Ethernet port on > the OMAP5 uEVM board. > > It also does some cleanup with respect to DT clock binding > for the mfd/omap-usb-host driver. > > Please queue these for -next. > >>

Re: [PATCH v9 0/9] USB Host support for OMAP5 uEVM

2014-03-11 Thread Lee Jones
> >>> This patchset brings up USB Host ports and Ethernet port on > >>> the OMAP5 uEVM board. > >>> > >>> It also does some cleanup with respect to DT clock binding > >>> for the mfd/omap-usb-host driver. > >>> > >>> Please queue these for -next. > >>> > >>> Lee, > >>> > >>> I've folded some platf

[PATCH] usb: phy: Add ulpi IDs for SMSC USB3320 and TI TUSB1210

2014-03-11 Thread Michal Simek
Add new ulpi IDs which are available on Xilinx Zynq boards. Signed-off-by: Michal Simek --- http://www.ti.com/lit/ds/symlink/tusb1210.pdf page 29 I don't know why but value is not written in smsc manual here. http://ww1.microchip.com/downloads/en/DeviceDoc/3320.pdf page 62 --- drivers/usb/phy/

Re: [PATCH v9 0/9] USB Host support for OMAP5 uEVM

2014-03-11 Thread Roger Quadros
On 03/11/2014 02:02 PM, Lee Jones wrote: >>> Hi, >>> >>> This patchset brings up USB Host ports and Ethernet port on >>> the OMAP5 uEVM board. >>> >>> It also does some cleanup with respect to DT clock binding >>> for the mfd/omap-usb-host driver. >>> >>> Please queue these for -next. >>> >>> Lee,

Re: [PATCH v9 0/9] USB Host support for OMAP5 uEVM

2014-03-11 Thread Lee Jones
> > Hi, > > > > This patchset brings up USB Host ports and Ethernet port on > > the OMAP5 uEVM board. > > > > It also does some cleanup with respect to DT clock binding > > for the mfd/omap-usb-host driver. > > > > Please queue these for -next. > > > > Lee, > > > > I've folded some platform da

Re: [PATCH v2][ 4/8] ARM: dts: imx25.dtsi: Fix USB support.

2014-03-11 Thread Fabio Estevam
Hi Denis, On Tue, Mar 11, 2014 at 7:55 AM, Denis Carikli wrote: > From: Fabio Estevam > > This patch was adapted from the thread named > "USB Host support for mx25" on linux-usb@vger.kernel.org > > Signed-off-by: Denis Carikli > --- > Changelog v1->v2: > - The usbphy nodes were made to look lik

Re: [PATCH v2][ 8/8] ARM: imx_v4_v5_defconfig: Enable drivers for i.MX25/i.MX35 USB support.

2014-03-11 Thread Fabio Estevam
Hi Denis, On Tue, Mar 11, 2014 at 7:55 AM, Denis Carikli wrote: > CONFIG_USB_EHCI_MXC=y > +CONFIG_USB_STORAGE=y > +CONFIG_USB_CHIPIDEA=y > +CONFIG_USB_CHIPIDEA_UDC=y > +CONFIG_USB_CHIPIDEA_HOST=y > +CONFIG_NOP_USB_XCEIV=y > +CONFIG_USB_GADGET=y > +CONFIG_USB_ETH=m > +CONFIG_USB_MASS_STORAGE=m

Re: [PATCH 0/2] Fix CPPI Warnings during tear down after ISOCH transfers

2014-03-11 Thread Vinod Koul
On Thu, Feb 27, 2014 at 10:44:39AM +0530, George Cherian wrote: > Warinings are seen after ISOCH transfers, during channel tear down. > This is mainly beacause we handle ISOCH differently as compared to > other transfers. > > Patch 1: make sure we do channel tear down only if channel is busy. >

[PATCH v2][ 7/8] ARM: dts: mbimxsd35 baseboard: Add USB support.

2014-03-11 Thread Denis Carikli
Signed-off-by: Denis Carikli --- Changelog v1->v2: - With the clock fix patches, the usb gadget also work. So I've set the otg port to otg instead of host. - Before I forgott to set dr_mode to host in the usbhost port. That is now fixed. --- .../boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts

[PATCH v2][ 3/8] usb: chipidea: usbmisc: Add USB Host support for i.MX25/i.MX35 CPUs

2014-03-11 Thread Denis Carikli
Signed-off-by: Denis Carikli --- Changelog v1->v2: - converted two remaining defines to BIT() - Removed a variable declaration that was not used in usbmisc_imx25_init --- drivers/usb/chipidea/usbmisc_imx.c | 58 1 file changed, 58 insertions(+) diff --git a

[PATCH v2][ 2/8] ARM: dts: mx35: USB block requires only one clock

2014-03-11 Thread Denis Carikli
From: Fabio Estevam Like other imx SoCs only one USB clock is needed on mx35. Signed-off-by: Fabio Estevam --- arch/arm/boot/dts/imx35.dtsi |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi index e59ccb4..47

[PATCH v2][ 6/8] ARM: dts: i.MX35: Add USB support.

2014-03-11 Thread Denis Carikli
Signed-off-by: Denis Carikli --- Changelog v1->v2: - The usbphy nodes were made to look like the ones in imx53.dtsi - The patch was rebased on top of the clock fixes commits. --- arch/arm/boot/dts/imx35.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dt

[PATCH v2][ 5/8] ARM: dts: mbimxsd25 baseboard: Add USB support

2014-03-11 Thread Denis Carikli
Signed-off-by: Denis Carikli --- Changelog v1->v2: - With the clock fix patches, the usb gadget also work. So I've set the otg port to otg instead of host. --- .../boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/d

[PATCH v2][ 1/8] ARM: dts: mx25: USB block requires only one clock

2014-03-11 Thread Denis Carikli
From: Fabio Estevam Like other imx SoCs only one USB clock is needed on mx25. Signed-off-by: Fabio Estevam --- arch/arm/boot/dts/imx25.dtsi |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index 77bb743..82

[PATCH v2][ 8/8] ARM: imx_v4_v5_defconfig: Enable drivers for i.MX25/i.MX35 USB support.

2014-03-11 Thread Denis Carikli
Signed-off-by: Denis Carikli --- Changelog v1->v2: - With the clock fix patches, the usb gadget also work. So I've addeed it to this patch too. - CONFIG_USB_OTG_FSM=y was not needed, so it was removed. --- arch/arm/configs/imx_v4_v5_defconfig |9 + 1 file changed, 9 insertions(+) d

[PATCH v2][ 4/8] ARM: dts: imx25.dtsi: Fix USB support.

2014-03-11 Thread Denis Carikli
From: Fabio Estevam This patch was adapted from the thread named "USB Host support for mx25" on linux-usb@vger.kernel.org Signed-off-by: Denis Carikli --- Changelog v1->v2: - The usbphy nodes were made to look like the ones in imx53.dtsi - The patch was rebased on top of the clock fixes commits

RE: MAX3421E: device giving NAKs forever?

2014-03-11 Thread David Laight
From: Felipe Balbi > On Mon, Mar 10, 2014 at 02:15:36PM -0600, David Mosberger wrote: > > I was thinking of the Salea Logic ($150). > > Are you aware of any limitations for this one that would get in the way? > > for full-speed USB it should work, I guess. Never trie

[PATCHv2] rebind: Add rebind mechanism for runtime-resume

2014-03-11 Thread Poulain, Loic
Despite the needs_rebind flag, the interface rebind was never done for the PM runtime resume. This patch fixes this issue by triggering the rebind in usb runtime resume. The rebind procedure needs to be called with the device lock. However, depending the call path (remote wakeup, local resume), th

Re: usbnet: driver_info->stop required to stop USB interrupts?

2014-03-11 Thread Oliver Neukum
On Mon, 2014-03-10 at 19:53 -0700, Julius Werner wrote: > I think the best solution would be to just make dev->wait a directly > embedded structure inside struct usbnet instead of a pointer to > something stack-allocated. usbnet_bh() could just call wake_up() > unconditionally (if empty it will be

Re: usbnet: driver_info->stop required to stop USB interrupts?

2014-03-11 Thread Oliver Neukum
On Mon, 2014-03-10 at 19:53 -0700, Julius Werner wrote: > I think usbnet_stop() raced with the dev->bh tasklet, which by itself > might not be a problem (usbnet_stop() later kills the tasklet itself, > so it should expect that it can be running before that). The issue is > that it calls usbnet_term

Re: [PATCH] xhci: extend quirk for Renesas cards

2014-03-11 Thread Mathias Nyman
On 03/11/2014 07:56 AM, Igor Gnatenko wrote: On Mon, 2014-03-10 at 15:06 +0200, Mathias Nyman wrote: On 03/09/2014 04:20 PM, Igor Gnatenko wrote: After suspend another Renesas PCI-X USB 3.0 card doesn't work. 03:00.0 USB controller [0c03]: Renesas Technology Corp. uPD720202 USB 3.0 Host Contro

Re: [PATCH v9 0/9] USB Host support for OMAP5 uEVM

2014-03-11 Thread Roger Quadros
Hi Lee, On 02/27/2014 04:18 PM, Roger Quadros wrote: > Hi, > > This patchset brings up USB Host ports and Ethernet port on > the OMAP5 uEVM board. > > It also does some cleanup with respect to DT clock binding > for the mfd/omap-usb-host driver. > > Please queue these for -next. > > Lee, > >

[PATCH net-next] r8152: support dumping the hw counters

2014-03-11 Thread Hayes Wang
Add dumping the tally counter by ethtool. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 95 +++-- 1 file changed, 93 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index a90a7eb9..aa1d5b2 100644