From: Li Jun b47...@freescale.com
Hi Felipe,
This patchset adds otg HNP polling common part for otg fsm.
Li Jun (3):
usb: common: otg-fsm: start HNP polling timer in host state
usb: common: otg-fsm: add HNP polling request sending funciton
usb: common: otg-fsm: add host_request_flag in
From: Li Jun b47...@freescale.com
This patch adds host_request_flag in usb_gadget to store host request from
application, clear the flag when otg leaves host state.
Signed-off-by: Li Jun b47...@freescale.com
---
drivers/usb/common/usb-otg-fsm.c |4
include/linux/usb/gadget.h |
From: Li Jun b47...@freescale.com
This patch starts HNP polling timer when otg is set to be a_host
or b_host.
Signed-off-by: Li Jun b47...@freescale.com
---
drivers/usb/common/usb-otg-fsm.c |2 ++
include/linux/usb/otg-fsm.h |1 +
2 files changed, 3 insertions(+)
diff --git
From: Li Jun b47...@freescale.com
This patch adds OTG status selector request sending function, can be called
by HNP polling timer function after OTG port is in host state.
Signed-off-by: Li Jun b47...@freescale.com
---
drivers/usb/common/usb-otg-fsm.c | 47
Peripheral answers OTG status selector request from host according to
host request flag of gadget, this flag may be set by application via
kernel interface.
Signed-off-by: Li Jun b47...@freescale.com
---
drivers/usb/chipidea/udc.c | 12 ++--
1 file changed, 10 insertions(+), 2
From: Li Jun b47...@freescale.com
Hi Peter,
This patchset adds chipidea driver part of otg HNP polling support.
Li Jun (3):
usb: chipidea: udc: add OTG status request handling.
usb: chipidea: otg_fsm: add HNP polling support
usb: chipidea: set host request flag via sys input
From: Li Jun b47...@freescale.com
This patch sets host request flag in sys input when a A device
set a_bus_req or a B device set b_bus_req in peripheral role.
Signed-off-by: Li Jun b47...@freescale.com
---
drivers/usb/chipidea/otg_fsm.c | 13 -
1 file changed, 12 insertions(+), 1
From: Li Jun b47...@freescale.com
This patch adds HNP polling support for chipidea otg fsm driver, which
adds a SW timer to send HNP polling request.
Signed-off-by: Li Jun b47...@freescale.com
---
drivers/usb/chipidea/ci.h |2 ++
drivers/usb/chipidea/otg_fsm.c | 32
The upper timer_interval limit is arbitrary and much higher
than anything usable in the real world. Reducing it from 15s
to ~4s to make the timer_interval fit in an u32 does not make
much difference. The limit is still outside the practical
bounds.
This eliminates the need for a 64bit
From: Li Jun b47...@freescale.com
This patch adds HNP polling support for chipidea otg fsm driver, which
adds a SW timer to send HNP polling request.
Signed-off-by: Li Jun b47...@freescale.com
---
drivers/usb/chipidea/ci.h |2 ++
drivers/usb/chipidea/otg_fsm.c | 32
Change for v2:
- Replace gadget_is_otg() with ci_otg_is_fsm_mode() as condition when
handling OTG status selector request.
Peripheral answers OTG status selector request from host according to
host request flag of gadget, this flag may be set by application via
kernel interface.
From: Li Jun b47...@freescale.com
This patch sets host request flag in sys input when a A device
set a_bus_req or a B device set b_bus_req in peripheral role.
Signed-off-by: Li Jun b47...@freescale.com
---
drivers/usb/chipidea/otg_fsm.c | 13 -
1 file changed, 12 insertions(+), 1
Lars Melin lars...@gmail.com writes:
Your target audience is embedded systems with limited cpu power and
buffer memory, right?
If so, then you can't expect them to have ethtool included and their
developers are not likely to be happy over having to waste another
100KB in order to tune a 20KB
From: Li Jun b47...@freescale.com
Hi Peter,
This patchset adds chipidea driver part of otg HNP polling support.
Li Jun (3):
usb: chipidea: udc: add OTG status request handling.
usb: chipidea: otg_fsm: add HNP polling support
usb: chipidea: set host request flag via sys input
On Fri, 2014-05-16 at 18:40 +0100, Catalin Marinas wrote:
On Fri, May 16, 2014 at 06:08:45PM +0100, Jon Medhurst (Tixy) wrote:
On Fri, 2014-05-16 at 13:55 +0100, Catalin Marinas wrote:
[...]
It could if arm64 would restrict the DMA addresses to 32-bit, but it
doesn't
and I end up
On Friday 16 May 2014 13:55:01 Catalin Marinas wrote:
On Thu, May 15, 2014 at 05:53:53PM +0100, Liviu Dudau wrote:
On Thu, May 15, 2014 at 04:36:25PM +0100, Alan Stern wrote:
On Thu, 15 May 2014, Liviu Dudau wrote:
On Thu, May 15, 2014 at 03:11:48PM +0100, Alan Stern wrote:
On Wed,
The dwc3 wrapper driver should not be fiddling with the core interrupts.
Disabling the core interrupts in prepare stops xhci from proper operation.
So remove disable/enable of core interrupts from prepare/complete.
Signed-off-by: George Cherian george.cher...@ti.com
---
Move the extcon related code to its own function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 65 ++--
1 file changed, 39 insertions(+), 26 deletions(-)
Following crash is seen on dwc3_omap removal
Unable to handle kernel NULL pointer dereference at virtual address 0018
pgd = ec098000
[0018] *pgd=ad1f9831, *pte=, *ppte=
Internal error: Oops: 17 [#1] SMP ARM
Modules linked in: usb_f_ss_lb g_zero usb_f_acm u_serial usb_f_ecm
Move map offset to its own seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git
Move find and set the utmi mode to its own seperate function.
Improve code readability, decrease the dwc3_probe() size.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/dwc3/dwc3-omap.c | 44 +---
1 file changed, 25 insertions(+), 19
additional information:
I build a customized Kernel 3.14.4 based on Arch Stock kernel; with
only ONE change:
I deleted line 138 (NOT line 121)
xhci-quirks |= XHCI_SPURIOUS_REBOOT;
in drivers/usb/host/xhci-pci.c.
and issue disappears - everything works fine now
Remove the x_major calculation logic from the wrapper revision register
to differentiate between OMAP5 and AM437x. This was done to find the
register offsets of wrapper register. Now that We do it using dt
compatible, remove the whole logic.
Signed-off-by: George Cherian george.cher...@ti.com
---
The series does some refactoring on dwc3_probe()
Patch 1 - Now that we use driver compatible for revision check, remove the
unnecessary logic.
Patch 2-4 - reduce the size of dwc3_probe()
Patch 5 - Fix the crash on dwc3_omap removal
Patch 6 - Addresses the issue of xhci hang while resuming from
Hi Bin,
On 5/15/2014 8:49 PM, Bin Liu wrote:
George,
On Thu, May 15, 2014 at 1:28 AM, George Cherian george.cher...@ti.com wrote:
Hi Bin,
On 5/14/2014 10:13 PM, Bin Liu wrote:
George,
On Wed, May 14, 2014 at 9:34 AM, Bin Liu binml...@gmail.com wrote:
George,
On Wed, May 14, 2014 at
On Mon, May 19, 2014 at 09:32:43AM +0100, Arnd Bergmann wrote:
On Friday 16 May 2014 13:55:01 Catalin Marinas wrote:
On Thu, May 15, 2014 at 05:53:53PM +0100, Liviu Dudau wrote:
On Thu, May 15, 2014 at 04:36:25PM +0100, Alan Stern wrote:
On Thu, 15 May 2014, Liviu Dudau wrote:
On
From: Of Parag Warudkar
I see a continuous flood of below messages on plugging in/using my USB
token. (The comp code wasn't in the original message - I added it.) From
what I can tell the device continues to work as expected.
Should the warning be disabled for COMP_SHORT_TX like it is for
On Wed, 2014-05-14 at 16:54 +0300, Dan Carpenter wrote:
There are several issues here:
1) platform_get_resource() can return NULL and that wasn't handled.
2) We should request the memory before we remap it, and
devm_ioremap_resource() does that.
3) devm_ioremap() returns a NULL but we were
Vivek Gautam wrote:
This patch adds sysreg-syscon node to exynos5250 and exynos5420 device
tree, to access System Register's registers using syscon driver.
Signed-off-by: Kamil Debski k.deb...@samsung.com
[gautam.vi...@samsung.com: Split this syreg-syscon dts entry from
dts: Add usb2phy
Hi All,
I'm happy to announce the libusb-1.0.19-rc1 release.
The big feature of this release is support for bulk-streams on
Mac OS X and Linux (using the new usbfs API for this from 3.15).
Changelog:
* Add support for USB bulk streams on Linux and Mac OS X (#11)
* Windows: Add AMD and Intel
On Mon, May 19, 2014 at 12:19:10PM +0300, Ivan T. Ivanov wrote:
On Wed, 2014-05-14 at 16:54 +0300, Dan Carpenter wrote:
There are several issues here:
1) platform_get_resource() can return NULL and that wasn't handled.
2) We should request the memory before we remap it, and
On Monday 19 May 2014 10:03:40 Catalin Marinas wrote:
On Mon, May 19, 2014 at 09:32:43AM +0100, Arnd Bergmann wrote:
On Friday 16 May 2014 13:55:01 Catalin Marinas wrote:
On Thu, May 15, 2014 at 05:53:53PM +0100, Liviu Dudau wrote:
On Thu, May 15, 2014 at 04:36:25PM +0100, Alan Stern
Some platforms (such as the Renesas R-Car) need to initialize some specific
registers after xhci driver calls usb_add_hcd() and before the driver calls
xhci_run(). So, this patch adds the xhci_plat_start() function.
Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com
---
This patch set adds the USB xHCI support for the R-Car H2 and M2 SoCs.
These SoCs use an xHCI but still need specific initialization, mainly
to setup the firmware downloading and the specific registers.
This patch set depends on the following patches:
The R-Car H2 and M2 SoCs come with an xHCI controller that requires
some specific initilization related to the firmware downloading and
some specific registers. This patch adds the support for this special
configuration as an xHCI quirk executed during probe and start.
Signed-off-by: Yoshihiro
This commit extends the compatible string list of the xhci-platform
binding with the new renesas,r8a7790-xhci and renesas,r8a7791-xhci
compatible strings. It is used to describe the xHCI controller which
is available in the R-Car H2 and M2 SoCs.
Signed-off-by: Yoshihiro Shimoda
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/usb/gadget/net2280.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index b43725a..bd851de 100644
---
For bool variables
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/usb/gadget/net2280.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index 5b9368d..b43725a 100644
---
Improves readability of the code
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/usb/gadget/net2280.c | 572 +--
drivers/usb/gadget/net2280.h | 65 ++---
2 files changed, 318 insertions(+), 319 deletions(-)
diff --git
Instead of using magic numbers use #defines
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/usb/gadget/net2280.c | 68 +++-
drivers/usb/gadget/net2280.h | 1 +
2 files changed, 36 insertions(+), 33 deletions(-)
diff --git
From: Ricardo Ribalda Delgado
Improves readability of the code
Personally I don't find macros like BIT() improve the readability at all.
What next? Maybe:
#define ADD(a, b) ((a) + (b))
David
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a
Hi Shimoda-san,
Thanks for your patches, I did however find one typo below:
On Mon, May 19, 2014 at 7:08 PM, Yoshihiro Shimoda
yoshihiro.shimoda...@renesas.com wrote:
The R-Car H2 and M2 SoCs come with an xHCI controller that requires
some specific initilization related to the firmware
On 05/19/2014 08:46 AM, lin du wrote:
Add linux-usb in loop.
Hello,
When reload the xhci_hcd.ko continuously as following, we will see
many error messages, even HW hang! (almost 300 times;
if no sleep between rmmod and modprobe driver, the value should be smaller).
Hi
And thanks for
Hello David
I dont want to start a flame war here :) but In the particular case
of hardware registers I believe it does.
This patch has been posted because on a previous patch to support the
usb3380, one of the requested changes was to use this macro. In order
to have consistent code in the
Hello.
On 19-05-2014 10:18, Li Jun wrote:
From: Li Jun b47...@freescale.com
This patch sets host request flag in sys input when a A device
set a_bus_req or a B device set b_bus_req in peripheral role.
Signed-off-by: Li Jun b47...@freescale.com
---
drivers/usb/chipidea/otg_fsm.c | 13
Hello.
On 19-05-2014 12:32, George Cherian wrote:
Remove the x_major calculation logic from the wrapper revision register
to differentiate between OMAP5 and AM437x. This was done to find the
register offsets of wrapper register. Now that We do it using dt
compatible, remove the whole logic.
...@free-electrons.com
Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com
---
arch/arm/mach-mvebu/Kconfig | 1 +
1 file changed, 1 insertion(+)
Patches 10 and 11 applied to mvebu/soc
These two just hit linux-next (in next-20140519). They're pointless, as
config
Based on 'for-next' branch of Kgene's linux-samsung tree.
These patches are as per discussions on the driver side patches
which have already been acked. [1]
Changes from v2:
- Addressed kukjin's comments to update DT binding documentation for
sysreg.
- removed the version for
From: Vivek Gautam gautam.vi...@samsung.com
This patch adds sysreg-syscon node to exynos5250 and exynos5420 device
tree, to access System Register's registers using syscon driver.
Signed-off-by: Kamil Debski k.deb...@samsung.com
[gautam.vi...@samsung.com: Split this syreg-syscon dts entry from
From: Vivek Gautam gautam.vi...@samsung.com
Add required device node for usb2phy to let enable USB 2.0
support.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
---
arch/arm/boot/dts/exynos5420.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git
From: Vivek Gautam gautam.vi...@samsung.com
Add required device node for ehci and ohci controllers to
enable USB 2.0 support.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
---
arch/arm/boot/dts/exynos5420.dtsi | 30 ++
1 file changed, 30 insertions(+)
diff
From: Kamil Debski k.deb...@samsung.com
Add support to PHY of USB2 of the Exynos 5250 SoC.
Signed-off-by: Kamil Debski k.deb...@samsung.com
[gautam.vi...@samsung.com: Split the usb phy entries from
syscon entries from earlier patch: dts: Add usb2phy to Exynos 5250]
[gautam.vi...@samsung.com:
Vivek Gautam wrote:
Add required fixed-regulator for VBUS supply for USB 3.0
controller phy.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
---
arch/arm/boot/dts/exynos5250-snow.dts | 22 ++
1 file changed, 22 insertions(+)
diff --git
On Fri, May 16, 2014 at 10:47:18PM +0800, Zhuang Jin Can wrote:
Hi,
On Fri, May 16, 2014 at 07:41:06AM -0500, Felipe Balbi wrote:
On Fri, May 16, 2014 at 11:50:13PM +0800, Zhuang Jin Can wrote:
On Fri, May 16, 2014 at 05:57:57AM +0800, Zhuang Jin Can wrote:
In ISOC transfers, when
From: Oliver Neukum oneu...@suse.de
Parsing device descriptors can fail due to a failed memory
allocation. The error needs to be properly propagated to the
upper layers.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/gpu/drm/udl/udl_main.c | 3 +--
1 file changed, 1 insertion(+), 2
From: Oliver Neukum oneu...@suse.de
There's a window during which read() would return 0 instead
of a correct error for no data yet. Reorder initialization
to fix the race.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/misc/yurex.c | 3 +--
1 file changed, 1 insertion(+), 2
From: Oliver Neukum oneu...@suse.de
The workqueue handler may call appledisplay_bl_get_brightness() while
user space calls appledisplay_bl_update_status(). As they share a
buffer that must not happen. Use a mutex for mutual exclusion.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
From: Oliver Neukum oneu...@suse.de
send_request_dev_dep_msg_in() use a buffer allocated on the stack.
Fix by kmalloc()ing the buffer.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/class/usbtmc.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
From: Oliver Neukum oneu...@suse.de
Converting the header to BIT for readability. No functional
change.
Signed-off-by: Oliver Neukum oneu...@suse.de
---
drivers/usb/class/cdc-acm.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.h
Hi Shimoda-san,
On Mon, May 19, 2014 at 12:08 PM, Yoshihiro Shimoda
yoshihiro.shimoda...@renesas.com wrote:
The R-Car H2 and M2 SoCs come with an xHCI controller that requires
some specific initilization related to the firmware downloading and
some specific registers. This patch adds the
On Mon, May 19, 2014 at 12:08 PM, Yoshihiro Shimoda
yoshihiro.shimoda...@renesas.com wrote:
This commit extends the compatible string list of the xhci-platform
binding with the new renesas,r8a7790-xhci and renesas,r8a7791-xhci
compatible strings. It is used to describe the xHCI controller which
On Mon, May 19, 2014 at 12:07 PM, Yoshihiro Shimoda
yoshihiro.shimoda...@renesas.com wrote:
Some platforms (such as the Renesas R-Car) need to initialize some specific
registers after xhci driver calls usb_add_hcd() and before the driver calls
xhci_run(). So, this patch adds the
Hello.
On 19-05-2014 14:08, Yoshihiro Shimoda wrote:
The R-Car H2 and M2 SoCs come with an xHCI controller that requires
some specific initilization related to the firmware downloading and
some specific registers. This patch adds the support for this special
configuration as an xHCI quirk
On Sat, 2014-05-17 at 05:08 +0700, Alif Mubarak Ahmad wrote:
This device vendor and product id is 1c9e:9800
It is working as serial interface with generic usbserial driver.
I thought it is more suitable to use usbserial option driver, which
has better capability distinguishing between modem
Find whether we are running on newer silicon. The babble control
register reads 0x4 by default in newer silicon as opposed to 0
in old versions of AM335x. Based on this enable the sw babble
control logic.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_dsps.c | 37
For DSPS platform usb_phy_vbus(_off/_on) are NOPs.
So during musb_platform_reset() call usb_phy(_shutdown/_init)
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_dsps.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
Add sw_babble_control() logic to differentiate between transient
babble and real babble condition. Also add the SW babble control
register definitions.
Babble control register logic is implemented in the latest
revision of AM335x.
Signed-off-by: George Cherian george.cher...@ti.com
---
Subject: [PATCH v3 0/5] Add support for SW babble Control
Series add support for SW babble control logic found in
new silicon versions of AM335x. Runtime differentiation of
silicon version is done by checking the BABBLE_CTL register.
For newer silicon the register default value read is 0x4 and
During babble condition both first disconnect of devices are
initiated. Make sure MUSB controller is reset and re-initialized
after all disconnects.
To acheive this schedule a delayed work for babble rrecovery.
While at that convert udelay to usleep_range.
Refer
Currently musb_platform_reset() is only used by dsps.
In case of BABBLE interrupt for other platforms the musb_platform_reset()
is a NOP. In such situations no need to re-initialize the endpoints.
Also in the latest silicon revision of AM335x, we do have a babble recovery
mechanism without
BABBLE and RESET share the same interrupt. The interrupt
is considered to be RESET if MUSB is in peripheral mode and
as a BABBLE if MUSB is in HOST mode.
Handle babble condition iff MUSB is in HOST mode.
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/musb/musb_core.c | 2 +-
Hi George,
On Mon, May 19, 2014 at 3:40 AM, George Cherian george.cher...@ti.com wrote:
Hi Bin,
On 5/15/2014 8:49 PM, Bin Liu wrote:
George,
On Thu, May 15, 2014 at 1:28 AM, George Cherian george.cher...@ti.com
wrote:
Hi Bin,
On 5/14/2014 10:13 PM, Bin Liu wrote:
George,
On Wed,
On Mon, 19 May 2014, Arnd Bergmann wrote:
dma_alloc_coherent() on arm64 should return 32-bit addresses if the
coherent_dma_mask is set to 32-bit. Which kernel version is this?
The more important question is what happens to high buffers allocated
elsewhere
that get passed into dma_map_sg
Hi Peter,
W dniu 16.05.2014 11:00, Peter Chen pisze:
Hi Felipe Alan,
To continue with topic discussed at
http://www.spinics.net/lists/linux-usb/msg105279.html,
I implement the gadget bus to bind udc to gadget driver follow
most ideas from your two.
While the idea is interesting I think
On Mon, May 19, 2014 at 05:40:29PM +0200, Andrzej Pietrasiewicz wrote:
Hi Peter,
W dniu 16.05.2014 11:00, Peter Chen pisze:
Hi Felipe Alan,
To continue with topic discussed at
http://www.spinics.net/lists/linux-usb/msg105279.html,
I implement the gadget bus to bind udc to gadget driver
Hi,
On Mon, May 19, 2014 at 8:39 AM, George Cherian george.cher...@ti.com wrote:
BABBLE and RESET share the same interrupt. The interrupt
is considered to be RESET if MUSB is in peripheral mode and
as a BABBLE if MUSB is in HOST mode.
Handle babble condition iff MUSB is in HOST mode.
On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd Bergmann wrote:
On Monday 19 May 2014 10:03:40 Catalin Marinas wrote:
On Mon, May 19, 2014 at 09:32:43AM +0100, Arnd Bergmann wrote:
The more important question is what happens to high buffers allocated
elsewhere
that get passed into
On Mon, 19 May 2014, Felipe Balbi wrote:
On Mon, May 19, 2014 at 05:40:29PM +0200, Andrzej Pietrasiewicz wrote:
Hi Peter,
W dniu 16.05.2014 11:00, Peter Chen pisze:
Hi Felipe Alan,
To continue with topic discussed at
http://www.spinics.net/lists/linux-usb/msg105279.html,
I
Hi,
On Mon, May 19, 2014 at 8:39 AM, George Cherian george.cher...@ti.com wrote:
Currently musb_platform_reset() is only used by dsps.
In case of BABBLE interrupt for other platforms the musb_platform_reset()
is a NOP. In such situations no need to re-initialize the endpoints.
Also in the
On Monday 19 May 2014 10:16:57 Alan Stern wrote:
On Mon, 19 May 2014, Arnd Bergmann wrote:
dma_alloc_coherent() on arm64 should return 32-bit addresses if the
coherent_dma_mask is set to 32-bit. Which kernel version is this?
The more important question is what happens to high buffers
On Monday 19 May 2014 16:56:08 Catalin Marinas wrote:
On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd Bergmann wrote:
On Monday 19 May 2014 10:03:40 Catalin Marinas wrote:
On Mon, May 19, 2014 at 09:32:43AM +0100, Arnd Bergmann wrote:
The more important question is what happens to high
On Sat, May 17, 2014 at 10:43:14AM -0400, Alan Stern wrote:
On Fri, 16 May 2014, Todd E Brandt wrote:
This patch creates a separate instance of the usb_address0 mutex for each
USB
bus, and attaches it to the usb_bus device struct. This allows devices on
separate buses to be enumerated
This patch creates a separate instance of the usb_address0 mutex for each USB
bus, and attaches it to the usb_bus device struct. This allows devices on
separate buses to be enumerated in parallel; saving time.
In the current code, there is a single, global instance of the usb_address0
mutex which
Move logical continuations to end of line
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/usb/gadget/net2280.c | 145 +--
drivers/usb/gadget/net2280.h | 4 +-
2 files changed, 73 insertions(+), 76 deletions(-)
diff --git
Replace a long and ugly expresion with an already available function.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/usb/gadget/net2280.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c
Driver was using custom functions WARNING, ERROR, DEBUG, instead of
pr_err, pr_dgb...
VDEBUG has also been replaced by DEBUG because the same functionality
(or even better) can be achieved with dynamic printk.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
net2280 was developed before the CodeStyle was enforced. This set of patches
intend to improve the readability of the code.
This set of patches should be applied after:
[PATCH 5/5] usb: gadget: net2280: Use module_pci_driver macro
In order to avoid mail list spamming I have not resubmitted the
Instead of octal notation, to be consistent around the file.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/usb/gadget/net2280.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index
On Mon, 2014-05-19 at 21:11 +0200, Ricardo Ribalda Delgado wrote:
VDEBUG has also been replaced by DEBUG because the same functionality
(or even better) can be achieved with dynamic printk.
dev_vdbg exists for that purpose.
--
To unsubscribe from this list: send the line unsubscribe
On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:
Instead of octal notation, to be consistent around the file.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/usb/gadget/net2280.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Hello Joe
I think dev_vdg cannot be controlled with DYNAMIC_DEBUG, therefore I
replaced it with dev_dbg.
But if you prefer to use dev_dbg, I will modify it to use dev_dbg
Thanks!
On Mon, May 19, 2014 at 9:16 PM, Joe Perches j...@perches.com wrote:
On Mon, 2014-05-19 at 21:11 +0200, Ricardo
Hello Alan
What about using octal notation in all the file and merge the patch
with the other big patch of the series? I am trying to have some
consistency in the file :)
Thanks!
On Mon, May 19, 2014 at 9:30 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Mon, 19 May 2014, Ricardo Ribalda
On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:
Fix Code Style using checkpatch.pl criteria
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
Not really necessary, although this doesn't hurt.
It's notable that scattered in amongst all the checkpatch-related
changes are a
On Mon, 2014-05-19 at 21:33 +0200, Ricardo Ribalda Delgado wrote:
I think dev_vdg cannot be controlled with DYNAMIC_DEBUG, therefore I
replaced it with dev_dbg.
But if you prefer to use dev_dbg, I will modify it to use dev_dbg
s/VDEBUG/dev_vdbg/
dev_vdbg can be controlled by DYNAMIC_DEBUG.
On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:
Move logical continuations to end of line
This is almost totally unnecessary. Some people prefer the
operators at the end of the first line, other people prefer them at the
start of the next line. It's just a matter of taste and it doesn't
Hello Joe
OK, then I will use dev_vdbg. Thanks!
On Mon, May 19, 2014 at 9:42 PM, Joe Perches j...@perches.com wrote:
On Mon, 2014-05-19 at 21:33 +0200, Ricardo Ribalda Delgado wrote:
I think dev_vdg cannot be controlled with DYNAMIC_DEBUG, therefore I
replaced it with dev_dbg.
But if you
On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:
Driver was using custom functions WARNING, ERROR, DEBUG, instead of
pr_err, pr_dgb...
What's wrong with that, and why bother to change it?
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index e67ae96..11800bb
Hello Alan
I am trying to be consistent around the file. On a previous patch I
was asked to move the operators at the end. I did so, and now I am
modifying the file to look alike.
On Mon, May 19, 2014 at 9:43 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Mon, 19 May 2014, Ricardo
On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:
Hello Alan
I am trying to be consistent around the file. On a previous patch I
was asked to move the operators at the end. I did so, and now I am
modifying the file to look alike.
Changing other people's code to be more consistent is
Hello Alan
I really think that setting/unsetting DEBUG and VERBOSE is not a good
idea, and the generic functions are there to be used.
What do you think that makes it more difficult to read? The GETDEV macro?
Cheers
On Mon, May 19, 2014 at 9:44 PM, Alan Stern st...@rowland.harvard.edu wrote:
1 - 100 of 120 matches
Mail list logo
