Re: [PATCH 0/4] Add Gadget Bus

2014-05-20 Thread Andrzej Pietrasiewicz
Hi Peter, W dniu 20.05.2014 01:38, Peter Chen pisze: On Mon, May 19, 2014 at 05:40:29PM +0200, Andrzej Pietrasiewicz wrote: Hi Peter, W dniu 16.05.2014 11:00, Peter Chen pisze: Hi Felipe Alan, To continue with topic discussed at http://www.spinics.net/lists/linux-usb/msg105279.html, I

Re: [PATCH 0/4] Add Gadget Bus

2014-05-20 Thread Peter Chen
On Tue, May 20, 2014 at 08:25:41AM +0200, Andrzej Pietrasiewicz wrote: Hi Peter, W dniu 20.05.2014 01:38, Peter Chen pisze: On Mon, May 19, 2014 at 05:40:29PM +0200, Andrzej Pietrasiewicz wrote: Hi Peter, W dniu 16.05.2014 11:00, Peter Chen pisze: Hi Felipe Alan, To continue with

Re: [PATCH 0/4] Add Gadget Bus

2014-05-20 Thread Peter Chen
On Mon, May 19, 2014 at 05:40:29PM +0200, Andrzej Pietrasiewicz wrote: Hi Peter, W dniu 16.05.2014 11:00, Peter Chen pisze: Hi Felipe Alan, To continue with topic discussed at http://www.spinics.net/lists/linux-usb/msg105279.html, I implement the gadget bus to bind udc to gadget driver

Re: Longcheer SU9800 usb 3g modem 1c9e:9800

2014-05-20 Thread Alif Mubarak Ahmad
On Monday, May 19, 2014 02:19:52 PM you wrote: On Sat, 2014-05-17 at 05:08 +0700, Alif Mubarak Ahmad wrote: This device vendor and product id is 1c9e:9800 It is working as serial interface with generic usbserial driver. I thought it is more suitable to use usbserial option driver, which

Re: [patch] usb: phy: msm: fix bug in probe()

2014-05-20 Thread Ivan T. Ivanov
On Mon, 2014-05-19 at 23:35 +0300, Dan Carpenter wrote: My previous patch introduced a bug which prevented this driver from loading. devm_ioremap_resource() has a call to devm_request_mem_region() which will fail because the address space is shared between this PHY driver and CI device

Re: [PATCH 2/3] USB: musb: Add a work_struct to recover from babble errors

2014-05-20 Thread Yingchun Li
why not reuse the musb_irq_work? On Wed, Apr 2, 2014 at 7:58 PM, Daniel Mack zon...@gmail.com wrote: Handle BABBLE interrupt error conditions from a work struct handler. This indirection is necessary as we can't be certain that the phy functions don't sleep. Platform layer implementation may

Re: Longcheer SU9800 usb 3g modem 1c9e:9800

2014-05-20 Thread Oliver Neukum
On Tue, 2014-05-20 at 14:02 +0700, Alif Mubarak Ahmad wrote: On Monday, May 19, 2014 02:19:52 PM you wrote: I've applied the patch, but it seems rejected. I am using kernel 3.10.36 for use with OpenWrt. It was against git HEAD. Sorry. For your information, manually triggering echo 1c9e

Re: [PATCH net-next v2 00/12] cdc_ncm: add buffer tuning and stats using ethtool

2014-05-20 Thread Bjørn Mork
[adding Greg Suarez to the Cc list after noticing that he was missing from this thread. Sorry Greg, that was not my intention. This discussion is just as relevant to cdc_mbim as to cdc_ncm, defining a new common userspace API for all the cdc_ncm based drivers] Bjørn Mork bj...@mork.no

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-20 Thread Arnd Bergmann
On Monday 19 May 2014 16:42:18 Rob Herring wrote: On Mon, May 19, 2014 at 10:56 AM, Catalin Marinas catalin.mari...@arm.comwrote: On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd Bergmann wrote: On Monday 19 May 2014 10:03:40 Catalin Marinas wrote: On Mon, May 19, 2014 at 09:32:43AM

Re: [patch] usb: phy: msm: fix bug in probe()

2014-05-20 Thread Dan Carpenter
On Tue, May 20, 2014 at 10:19:12AM +0300, Ivan T. Ivanov wrote: On Mon, 2014-05-19 at 23:35 +0300, Dan Carpenter wrote: My previous patch introduced a bug which prevented this driver from loading. devm_ioremap_resource() has a call to devm_request_mem_region() which will fail because the

Re: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test

2014-05-20 Thread Ricardo Ribalda Delgado
Not for grep... But if this is an issue I have no problem going back to the original. We can spend a whole year just talking about codestyle. On Tue, May 20, 2014 at 10:52 AM, David Laight david.lai...@aculab.com wrote: From: Alan Stern ... -static struct usb_request *

RE: About gadget configfs

2014-05-20 Thread Peter Chen
On Tue, 6 May 2014, Peter Chen wrote: 3. Besides, I have tried two configurations, and each configuration with one function, I find the host PC always set configuration 1 (The first configuration), any ways to switch configuration at host side? libusb? You can switch

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-20 Thread Yoshihiro Shimoda
Hi Geert-san, (2014/05/19 20:58), Geert Uytterhoeven wrote: Hi Shimoda-san, On Mon, May 19, 2014 at 12:08 PM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: snip +config USB_XHCI_RCAR + tristate xHCI support for Renesas R-Car SoCs + select USB_XHCI_PLATFORM +

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-20 Thread Yoshihiro Shimoda
Hi Magnus-san, (2014/05/19 19:21), Magnus Damm wrote: Hi Shimoda-san, Thanks for your patches, I did however find one typo below: On Mon, May 19, 2014 at 7:08 PM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: snip static int xhci_plat_start(struct usb_hcd *hcd) { +

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-20 Thread Yoshihiro Shimoda
Hello, (2014/05/19 21:14), Sergei Shtylyov wrote: Hello. On 19-05-2014 14:08, Yoshihiro Shimoda wrote: snip static int xhci_plat_start(struct usb_hcd *hcd) { +struct device_node *of_node = hcd-self.controller-of_node; + +if (of_device_is_compatible(of_node,

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-20 Thread Mathias Nyman
On 05/20/2014 04:01 AM, Greg KH wrote: On Thu, May 08, 2014 at 07:25:55PM +0300, Mathias Nyman wrote: From: Dan Williams dan.j.willi...@intel.com Add a command line switch for disabling ehci port switchover. Useful for working around / debugging xhci incompatibilities where ehci operation

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-20 Thread Takashi Iwai
At Tue, 20 May 2014 12:47:36 +0300, Mathias Nyman wrote: On 05/20/2014 04:01 AM, Greg KH wrote: On Thu, May 08, 2014 at 07:25:55PM +0300, Mathias Nyman wrote: From: Dan Williams dan.j.willi...@intel.com Add a command line switch for disabling ehci port switchover. Useful for working

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-20 Thread Arnd Bergmann
On Monday 19 May 2014 19:08:05 Yoshihiro Shimoda wrote: #include xhci.h #include xhci-mvebu.h +#include xhci-rcar.h static void xhci_plat_quirks(struct device *dev, struct xhci_hcd *xhci) { @@ -39,6 +40,12 @@ static int xhci_plat_setup(struct usb_hcd *hcd) static int

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-20 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, May 20, 2014 at 11:35 AM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: (2014/05/19 20:58), Geert Uytterhoeven wrote: On Mon, May 19, 2014 at 12:08 PM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: snip +config USB_XHCI_RCAR + tristate

[PATCH] xhci: Switch only Intel Lynx Point-LP ports to EHCI on shutdown.

2014-05-20 Thread Denis Turischev
Patch xhci: Switch Intel Lynx Point ports to EHCI on shutdown. commit c09ec25d3684cad74d851c0f028a495999591279 is not fully correct It switches both Lynx Point and Lynx Point-LP ports to EHCI on shutdown. On some Lynx Point machines it causes spurious interrupt, which wake the system:

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-20 Thread Catalin Marinas
On Mon, May 19, 2014 at 05:55:56PM +0100, Arnd Bergmann wrote: On Monday 19 May 2014 16:56:08 Catalin Marinas wrote: On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd Bergmann wrote: On Monday 19 May 2014 10:03:40 Catalin Marinas wrote: On Mon, May 19, 2014 at 09:32:43AM +0100, Arnd

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-20 Thread Arnd Bergmann
On Tuesday 20 May 2014 12:02:46 Catalin Marinas wrote: On Mon, May 19, 2014 at 05:55:56PM +0100, Arnd Bergmann wrote: On Monday 19 May 2014 16:56:08 Catalin Marinas wrote: On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd Bergmann wrote: On Monday 19 May 2014 10:03:40 Catalin Marinas wrote:

Re: Longcheer SU9800 usb 3g modem 1c9e:9800

2014-05-20 Thread Alif Mubarak Ahmad
On Tuesday, May 20, 2014 09:35:40 AM Oliver Neukum wrote: It was against git HEAD. Sorry. Nevermind Looks good, but I'd prefer a full test. Thanks Oliver I've compiled the firmware and tested it. It works perfectly. Here is some dmesg of OpenWrt boot. The 3g dongle is

[PATCH] usb: usb5303: add support for reference clock specified in device tree

2014-05-20 Thread Marek Szyprowski
USB3503 chip supports 8 values of reference clock. The value is specified by REF_SEL[1:0] pins and INT_N line. This patch add support for getting 'refclk' clock, enabling it and setting INT_N line according to the value of the gathered clock. If no clock has been specified, driver defaults to the

Re: [PATCH] usb: usb5303: add support for reference clock specified in device tree

2014-05-20 Thread Mark Brown
On Tue, May 20, 2014 at 01:53:42PM +0200, Marek Szyprowski wrote: + hub-clk = devm_clk_get(dev, refclk); + if (!IS_ERR(hub-clk)) { This won't handle deferred probe - the driver should error out if it gets -EPROBE_DEFER since it means the clock exists and might be

[PATCH] drivers: phy: exynos4x12-phy: fix HSIC1 power on/off sequence

2014-05-20 Thread Marek Szyprowski
From experiments with real hardware, it seems that URSTCON bits for HSIC0 and HSIC1 seems to be swapped, so updated macro definitions for them. HSIC1 also requires enabling power to device phy to get properly enabled (similar hack is already implemented for HSIC0). Signed-off-by: Marek Szyprowski

Re: [PATCH] usb: usb5303: add support for reference clock specified in device tree

2014-05-20 Thread Marek Szyprowski
Hello, On 2014-05-20 13:57, Mark Brown wrote: On Tue, May 20, 2014 at 01:53:42PM +0200, Marek Szyprowski wrote: + hub-clk = devm_clk_get(dev, refclk); + if (!IS_ERR(hub-clk)) { This won't handle deferred probe - the driver should error out if it gets -EPROBE_DEFER since it

Re: [PATCH] xhci: Switch only Intel Lynx Point-LP ports to EHCI on shutdown.

2014-05-20 Thread Wulf Richartz
Hi Denis, thank you very much, works fine ! But my diff to the original xhcp-pci.c of Kernel 3.14.4 is: $ diff xhci-pci.c-original xhci-pci.c-changed 137,138d136 xhci-quirks |= XHCI_SPURIOUS_REBOOT; 139a138,141 if (pdev-vendor == PCI_VENDOR_ID_INTEL

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-20 Thread Catalin Marinas
On Tue, May 20, 2014 at 12:08:58PM +0100, Arnd Bergmann wrote: On Tuesday 20 May 2014 12:02:46 Catalin Marinas wrote: On Mon, May 19, 2014 at 05:55:56PM +0100, Arnd Bergmann wrote: On Monday 19 May 2014 16:56:08 Catalin Marinas wrote: On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd

Re: [PATCH 2/9] usb: gadget: net2280: Dont use magic numbers

2014-05-20 Thread Alan Stern
On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote: Instead of using magic numbers use #defines Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- drivers/usb/gadget/net2280.c | 68 +++- drivers/usb/gadget/net2280.h | 1 + 2

Re: ASMedia AS2105 interface on USB 3.0 corrupts data

2014-05-20 Thread Alan Stern
On Tue, 20 May 2014, Heinz Diehl wrote: Hi, the use of the ASMedia AS2105 controller on USB 3.0 leads to the syslog being spammed with a lot of entries like this: usb 9-2: reset SuperSpeed USB device number 3 using xhci_hcd [ 232.682214] usb 9-2: Parent hub missing LPM exit latency

[PATCH] option: add device ID

2014-05-20 Thread oneukum
From: Oliver Neukum oneu...@suse.de Reported by Alif Mubarak Ahmad: This device vendor and product id is 1c9e:9800 It is working as serial interface with generic usbserial driver. I thought it is more suitable to use usbserial option driver, which has better capability distinguishing between

Re: [PATCH 2/9] usb: gadget: net2280: Dont use magic numbers

2014-05-20 Thread Ricardo Ribalda Delgado
Hello Alan In this case, there are only two family of devices supported by the driver. Maybe quirks are too much. At the end: ep-dev-pdev-vendor == PCI_VENDOR_ID_PLX_LEGACY is not much bigger than ep-dev-quirk_flag PLX_NET2280_QUIRK But if you prefer the quirk I dont mind implementing it,

Re: [PATCH 2/9] usb: gadget: net2280: Dont use magic numbers

2014-05-20 Thread Alan Stern
On Tue, 20 May 2014, Ricardo Ribalda Delgado wrote: Hello Alan In this case, there are only two family of devices supported by the driver. Maybe quirks are too much. At the end: ep-dev-pdev-vendor == PCI_VENDOR_ID_PLX_LEGACY is not much bigger than ep-dev-quirk_flag

new driver Fresco Logic

2014-05-20 Thread Michael Durkin
Forgive my intrusion ... Im hoping to get a driver made for a Fresco Logic FL2000 USB to VGA adapter ... Device ID 1d5c:2000 Mike KC7NOA -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [RFC PATCH 04/10] clk: tegra: Initialize xusb clocks

2014-05-20 Thread Peter De Schrijver
On Thu, May 15, 2014 at 09:22:00PM +0200, Stephen Warren wrote: On 05/14/2014 06:33 PM, Andrew Bresticker wrote: Initialize the XUSB-related clocks with appropriate parents and rates for both Tegra114 and Tegra124. These first 4 clock driver patches look plausible to me, although I didn't

Re: ASMedia AS2105 interface on USB 3.0 corrupts data

2014-05-20 Thread Heinz Diehl
On 20.05.2014, Alan Stern wrote: I have no idea if this will help, but you can try posting a usbmon trace showing what happens when the device is plugged in and the errors occur. Connected the drive and did some dd if=/dev/zero... to it. It failed within seconds. This is what dmesg shows

Re: ASMedia AS2105 interface on USB 3.0 corrupts data

2014-05-20 Thread Heinz Diehl
On 20.05.2014, Heinz Diehl wrote: The usbmon dump of the whole process is here: http://www.fritha.org/usblog.zip And here's another one, while popping in and out. http://www.fritha.org/usblog2.zip -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

[PATCH 08/10 v2.1] usb: gadget: net2280: Code Cleanup

2014-05-20 Thread Ricardo Ribalda Delgado
- Move logical continuations to end of line - Improve spacing Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- v2: Comments by Alan Stern -Use octal notation istead of S_I drivers/usb/gadget/net2280.c | 155 +--

[PATCH 10/10] usb: gadget: net2280: Use quirks instead of pci id

2014-05-20 Thread Ricardo Ribalda Delgado
Use of quirks improve readability and will be easier to add new devices to this driver. Suggested-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- drivers/usb/gadget/net2280.c | 83 +++-

[PATCH 06/10] usb: gadget: net2280: Refactor queues_show

2014-05-20 Thread Ricardo Ribalda Delgado
Replace a long and ugly expresion with an already available function. Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- drivers/usb/gadget/net2280.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/usb/gadget/net2280.c

[PATCH 00/10] net2280: Support for PLX USB338x and cleanout code

2014-05-20 Thread Ricardo Ribalda Delgado
The USB 3380 is a PCI Express Gen 2 to USB 3.0 SuperSpeed Peripheral Controller. It shares a lot functionatily with the net228x family. This series of patches includes some resend of previous patches. Please check the changelog for every patch. This time it has been placed under the tear line

[PATCH 04/10] usb: gadget: net2280: Use true/false instead of 1/0

2014-05-20 Thread Ricardo Ribalda Delgado
For bool variables Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- drivers/usb/gadget/net2280.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c index 5b9368d..b43725a 100644 ---

[PATCH 03/10] usb: gadget: net2280: Use BIT() macro

2014-05-20 Thread Ricardo Ribalda Delgado
Improves readability of the code Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- drivers/usb/gadget/net2280.c | 572 +-- drivers/usb/gadget/net2280.h | 65 ++--- 2 files changed, 318 insertions(+), 319 deletions(-) diff --git

[PATCH 02/10] usb: gadget: net2280: Dont use magic numbers

2014-05-20 Thread Ricardo Ribalda Delgado
Instead of using magic numbers use #defines Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- drivers/usb/gadget/net2280.c | 68 +++- drivers/usb/gadget/net2280.h | 1 + 2 files changed, 36 insertions(+), 33 deletions(-) diff --git

[PATCH 05/10] usb: gadget: net2280: Use module_pci_driver macro

2014-05-20 Thread Ricardo Ribalda Delgado
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- drivers/usb/gadget/net2280.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c index b43725a..bd851de 100644 ---

[PATCH 09/10 v2.1] usb: gadget: net2280: Use pr_* function

2014-05-20 Thread Ricardo Ribalda Delgado
Driver was using custom functions WARNING, ERROR, DEBUG, instead of pr_err, pr_dgb... New ep_* macros have been created that use standard pr_* functions. Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- v2: Comment by Joe Perches and Alan Stern -Use ep_* instead of custom

About ConfigFS and FunctionFS together

2014-05-20 Thread Krzysztof Opasiak
Hello Michal, Recently I'm working with configfs and libusbg. I have been also using FFS with it as it was merged in some recent kernel versions. While using I have experienced some issue while mounting it. Let me describe my it: $ cd /sys/kernel/config/usb_gadget $ mkdir g1 $ mkdir

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-20 Thread Rob Herring
On Tue, May 20, 2014 at 3:01 AM, Arnd Bergmann a...@arndb.de wrote: On Monday 19 May 2014 16:42:18 Rob Herring wrote: On Mon, May 19, 2014 at 10:56 AM, Catalin Marinas catalin.mari...@arm.comwrote: On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd Bergmann wrote: On Monday 19 May 2014

Re: About ConfigFS and FunctionFS together

2014-05-20 Thread Michal Nazarewicz
On Tue, May 20 2014, Krzysztof Opasiak wrote: I found out that kernel returns -ENODEV error which when file system type has not been found. I look into code of ffs and found out that ffs_fs_mount() also returns this error if it was unable to acquire given device. I know that this error looks

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-20 Thread Dan Williams
On Tue, May 20, 2014 at 2:51 AM, Takashi Iwai ti...@suse.de wrote: At Tue, 20 May 2014 12:47:36 +0300, Mathias Nyman wrote: On 05/20/2014 04:01 AM, Greg KH wrote: On Thu, May 08, 2014 at 07:25:55PM +0300, Mathias Nyman wrote: From: Dan Williams dan.j.willi...@intel.com Add a command

Re: [PATCH 4/5] appledisplay: Convert /n to \n

2014-05-20 Thread Joe Perches
On Thu, 2014-04-24 at 18:51 -0700, Joe Perches wrote: Use a newline character appropriately. Signed-off-by: Joe Perches j...@perches.com --- Greg? Ping? You inadvertently added this /n use in commit 0a3fd536e685e0ceb646de1a43821bd11c0be75c Author: Greg Kroah-Hartman

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-20 Thread Arnd Bergmann
On Tuesday 20 May 2014 15:12:49 Catalin Marinas wrote: On Tue, May 20, 2014 at 12:08:58PM +0100, Arnd Bergmann wrote: On Tuesday 20 May 2014 12:02:46 Catalin Marinas wrote: On Mon, May 19, 2014 at 05:55:56PM +0100, Arnd Bergmann wrote: On Monday 19 May 2014 16:56:08 Catalin Marinas

Re: ffs-test.c Compilation failure

2014-05-20 Thread Michal Nazarewicz
Commit [ac8dde11: “usb: gadget: f_fs: Add flags to descriptors block”] which introduced a new descriptor format for FunctionFS removed the usb_functionfs_descs_head structure, which is still used by ffs-test. tool. Convert ffs-test by converting it to use the new header format. For testing

Re: ffs-test.c Compilation failure

2014-05-20 Thread Felipe Balbi
Hi, On Tue, May 20, 2014 at 10:05:09AM -1000, Michal Nazarewicz wrote: Commit [ac8dde11: “usb: gadget: f_fs: Add flags to descriptors block”] which introduced a new descriptor format for FunctionFS removed the usb_functionfs_descs_head structure, which is still used by ffs-test. tool.

[PATCH] iowarrior: Convert local dbg macro to dev_dbg

2014-05-20 Thread Joe Perches
Use a more standard logging style. Add terminating newlines to formats. Remove __func__ as that can be added via dynamic debug. Remove now unnecessary debug module parameter. Remove the dbg macro too. Signed-off-by: Joe Perches j...@perches.com --- compiled/untested, no hardware.

Re: [PATCH 4/5] appledisplay: Convert /n to \n

2014-05-20 Thread Greg Kroah-Hartman
On Tue, May 20, 2014 at 12:26:53PM -0700, Joe Perches wrote: On Thu, 2014-04-24 at 18:51 -0700, Joe Perches wrote: Use a newline character appropriately. Signed-off-by: Joe Perches j...@perches.com --- Greg? Ping? You inadvertently added this /n use in commit

Re: new driver Fresco Logic

2014-05-20 Thread Greg KH
On Tue, May 20, 2014 at 08:07:43AM -0700, Michael Durkin wrote: Forgive my intrusion ... Im hoping to get a driver made for a Fresco Logic FL2000 USB to VGA adapter ... Device ID 1d5c:2000 What type of chip is in this device? If it is a USB 3 device, odds are that Linux doesn't support

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-20 Thread Greg KH
On Tue, May 20, 2014 at 11:25:37AM -0700, Dan Williams wrote: On Tue, May 20, 2014 at 2:51 AM, Takashi Iwai ti...@suse.de wrote: At Tue, 20 May 2014 12:47:36 +0300, Mathias Nyman wrote: On 05/20/2014 04:01 AM, Greg KH wrote: On Thu, May 08, 2014 at 07:25:55PM +0300, Mathias Nyman

Re: [PATCH] usb: usb5303: add support for reference clock specified in device tree

2014-05-20 Thread Mark Brown
On Tue, May 20, 2014 at 02:18:30PM +0200, Marek Szyprowski wrote: On 2014-05-20 13:57, Mark Brown wrote: + else + dev_err(dev, + unsupported reference clock rate (%d)\n, +

Re: new driver Fresco Logic

2014-05-20 Thread Michael Durkin
It can be used on USB3 or USB2 .. depending on max resolution ... I would be happy with USB2 800X600 resolution ... I got the device off of ebay ... but i could send an email to Fresco Logic (the maker of the IC) or to Orinco (who sells retail devices) I have already sent an email to the seller

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-20 Thread Dan Williams
On Tue, May 20, 2014 at 1:34 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, May 20, 2014 at 11:25:37AM -0700, Dan Williams wrote: On Tue, May 20, 2014 at 2:51 AM, Takashi Iwai ti...@suse.de wrote: At Tue, 20 May 2014 12:47:36 +0300, Mathias Nyman wrote: On 05/20/2014 04:01 AM,

Re: new driver Fresco Logic

2014-05-20 Thread Felipe Balbi
Hi, On Wed, May 21, 2014 at 05:31:13AM +0900, Greg KH wrote: On Tue, May 20, 2014 at 08:07:43AM -0700, Michael Durkin wrote: Forgive my intrusion ... Im hoping to get a driver made for a Fresco Logic FL2000 USB to VGA adapter ... Device ID 1d5c:2000 What type of chip is in this

Re: new driver Fresco Logic

2014-05-20 Thread Greg KH
On Tue, May 20, 2014 at 06:38:01PM -0500, Felipe Balbi wrote: Hi, On Wed, May 21, 2014 at 05:31:13AM +0900, Greg KH wrote: On Tue, May 20, 2014 at 08:07:43AM -0700, Michael Durkin wrote: Forgive my intrusion ... Im hoping to get a driver made for a Fresco Logic FL2000 USB to VGA

Re: [PATCH v9 09/19] usb: make usb_port flags atomic, rename did_runtime_put to child_usage

2014-05-20 Thread Dan Williams
On Fri, May 16, 2014 at 11:32 AM, Alan Stern st...@rowland.harvard.edu wrote: On Wed, 7 May 2014, Dan Williams wrote: We want to manipulate -did_runtime_put in usb_port_runtime_resume(), but we don't want that to collide with other updates. Move usb_port flags to new port-bitmap fields in

[PATCH v10 01/19] USB: mutual exclusion for resetting a hub and power-managing a port

2014-05-20 Thread Dan Williams
From: Alan Stern st...@rowland.harvard.edu The USB core doesn't properly handle mutual exclusion between resetting a hub and changing the power states of the hub's ports. We need to avoid sending port-power requests to the hub while it is being reset, because such requests cannot succeed. This

[PATCH v10 02/19] usb: disable port power control if not supported in wHubCharacteristics

2014-05-20 Thread Dan Williams
A hub indicates whether it supports per-port power control via the wHubCharacteristics field in its descriptor. If it is not supported a hub will still emulate ClearPortPower(PORT_POWER) requests by stopping the link state machine. However, since this does not save power do not bother

[PATCH v10 05/19] usb: assign default peer ports for root hubs

2014-05-20 Thread Dan Williams
Assume that the peer of a superspeed port is the port with the same id on the shared_hcd root hub. This identification scheme is required of external hubs by the USB3 spec [1]. However, for root hubs, tier mismatch may be in effect [2]. Tier mismatch can only be enumerated via platform

[PATCH v10 03/19] usb: rename usb_port device objects

2014-05-20 Thread Dan Williams
The current port name portX is ambiguous. Before adding more port messages rename ports to hub-device-name-portX This is an ABI change, but the suspicion is that it will go unnoticed as the port power control implementation has been broken since its introduction. If however, someone was relying

[PATCH v10 09/19] usb: make usb_port flags atomic, rename did_runtime_put to child_usage

2014-05-20 Thread Dan Williams
We want to manipulate -did_runtime_put in usb_port_runtime_resume(), but we don't want that to collide with other updates. Move usb_port flags to new port-bitmap fields in usb_hub. did_runtime_put is renamed child_usage_bits to reflect that it is strictly standing in for the fact that usb_devices

[PATCH v10 08/19] usb: sysfs link peer ports

2014-05-20 Thread Dan Williams
The usb topology after this change will have symlinks between usb3 ports and their usb2 peers, for example: usb2/2-1/2-1:1.0/2-1-port1/peer = ../../../../usb3/3-1/3-1:1.0/3-1-port1 usb2/2-1/2-1:1.0/2-1-port2/peer = ../../../../usb3/3-1/3-1:1.0/3-1-port2 usb2/2-1/2-1:1.0/2-1-port3/peer =

[PATCH v10 11/19] usb: don't clear FEAT_C_ENABLE on usb_port_runtime_resume failure

2014-05-20 Thread Dan Williams
Three reasons: 1/ It's an invalid operation on usb3 ports 2/ There's no guarantee of when / if a usb2 port has entered an error state relative to PORT_POWER request 3/ The port is active / powered at this point, so khubd will clear it as a matter of course Acked-by: Alan Stern

[PATCH v10 07/19] usb: find internal hub tier mismatch via acpi

2014-05-20 Thread Dan Williams
ACPI identifies peer ports by setting their 'group_token' and 'group_position' _PLD data to the same value. If a platform has tier mismatch [1] , ACPI can override the default (USB3 defined) peer port association for internal hubs. External hubs follow the default peer association scheme.

[PATCH v10 17/19] usb: resume child device when port is powered on

2014-05-20 Thread Dan Williams
Unconditionally wake up the child device when the power session is recovered. This addresses the following scenarios: 1/ The device may need a reset on power-session loss, without this change port power-on recovery exposes khubd to scenarios that usb_port_resume() is set to handle. Prior

[PATCH v10 13/19] usb: refactor port handling in hub_events()

2014-05-20 Thread Dan Williams
In preparation for synchronizing port handling with pm_runtime transitions refactor port handling into its own subroutine. We expect that clearing some status flags will be required regardless of the port state, so handle those first and group all non-trivial actions at the bottom of the routine.

[PATCH v10 10/19] usb: block suspension of superspeed port while hispeed peer is active

2014-05-20 Thread Dan Williams
ClearPortFeature(PORT_POWER) on a usb3 port places the port in either a DSPORT.Powered-off-detect / DSPORT.Powered-off-reset loop, or the DSPORT.Powered-off state. There is no way to ensure that RX terminations will persist in this state, so it is possible a device will degrade to its usb2

[PATCH v10 16/19] usb: hub_handle_remote_wakeup() depends on CONFIG_PM_RUNTIME=y

2014-05-20 Thread Dan Williams
Per Alan: You mean from within hub_handle_remote_wakeup()? That routine will never get called if CONFIG_PM_RUNTIME isn't enabled, because khubd never sees wakeup requests if they arise during system suspend. In fact, that routine ought to go inside the #ifdef CONFIG_PM_RUNTIME portion of hub.c,

[PATCH v10 19/19] usb: documentation for usb port power off mechanisms

2014-05-20 Thread Dan Williams
From: Lan Tianyu tianyu@intel.com describe the mechanisms for controlling port power policy and discovering the port power state. Cc: Oliver Neukum oneu...@suse.de [oliver]: fixes, clarification of wakeup vs port-power-control Signed-off-by: Lan Tianyu tianyu@intel.com [sarah]:

[PATCH v10 18/19] usb: force warm reset to break link re-connect livelock

2014-05-20 Thread Dan Williams
Resuming a powered down port sometimes results in the port state being stuck in the training sequence. hub 3-0:1.0: debounce: port 1: total 2000ms stable 0ms status 0x2e0 port1: can't get reconnection after setting port power on, status -110 hub 3-0:1.0: port 1 status .02e0 after resume,

[PATCH v10 14/19] usb: synchronize port poweroff and khubd

2014-05-20 Thread Dan Williams
If a port is powered-off, or in the process of being powered-off, prevent khubd from operating on it. Otherwise, the following sequence of events leading to an unintended disconnect may occur: Events: (0) set pm_qos_no_poweroff to '0' for port1 (1) hub 2-2:1.0: hub_resume (2) hub 2-2:1.0: port

Re: new driver Fresco Logic

2014-05-20 Thread Michael Durkin
Ok ill join them and see if linux-me...@vger.kernel.org are working on it ... i had no idea where to start ... Mike KC7NOA On Tue, May 20, 2014 at 5:25 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, May 20, 2014 at 06:38:01PM -0500, Felipe Balbi wrote: Hi, On Wed, May 21, 2014 at

[PATCH v10 06/19] usb: assign usb3 external hub port peers

2014-05-20 Thread Dan Williams
Given that root hub port peers are already established, external hub peer ports can be determined by traversing the device topology: 1/ ascend to the parent hub and find the upstream port_dev 2/ walk -peer to find the peer port 3/ descend to the peer hub via -child 4/ find the port with the

[PATCH v10 04/19] usb: cleanup setting udev-removable from port_dev-connect_type

2014-05-20 Thread Dan Williams
Once usb-acpi has set the port's connect type the usb_device's -removable attribute can be set in the standard location set_usb_port_removable(). This also changes behavior in the case where the firmware says that the port connect type is unknown. In that case just use the default setting

[PATCH v10 00/19] port power control reworks

2014-05-20 Thread Dan Williams
Greg, Here is the port power control rework for your consideration now that Alan has finished acking it (see summary below). Patch 9 had one outstanding minor question from Alan that I believe I have addressed. Patch 16 has a checkpatch warning WARNING: msleep 20ms can sleep for up to 20ms, but

[PATCH v10 15/19] usb: introduce port status lock

2014-05-20 Thread Dan Williams
In general we do not want khubd to act on port status changes that are the result of in progress resets or USB runtime PM operations. Specifically port power control testing has been able to trigger an unintended disconnect in hub_port_connect_change(), paraphrasing: if ((portstatus

Re: new driver Fresco Logic

2014-05-20 Thread Sid Boyce
Hi Greg, Mike has the udlfb module, the Fresco does not work with it. Hopefully he'll get a solution via the linux-media list as suggested. Regards Sid. On 20/05/14 21:31, Greg KH wrote: On Tue, May 20, 2014 at 08:07:43AM -0700, Michael Durkin wrote: Forgive my intrusion ... Im hoping to get

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-20 Thread Greg KH
On Tue, May 20, 2014 at 03:40:16PM -0700, Dan Williams wrote: On Tue, May 20, 2014 at 1:34 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, May 20, 2014 at 11:25:37AM -0700, Dan Williams wrote: On Tue, May 20, 2014 at 2:51 AM, Takashi Iwai ti...@suse.de wrote: At Tue, 20 May 2014

Re: [PATCH net-next] net: cdc_ncm: fix 64bit division build error

2014-05-20 Thread Stephen Rothwell
Hi all, On Mon, 19 May 2014 09:21:09 +0200 Bjørn Mork bj...@mork.no wrote: The upper timer_interval limit is arbitrary and much higher than anything usable in the real world. Reducing it from 15s to ~4s to make the timer_interval fit in an u32 does not make much difference. The limit is

[PATCH 3/5] usb: gadget: m66592-udc: should not call gadget driver's .unbind

2014-05-20 Thread Peter Chen
It has already been covered by udc core Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/m66592-udc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/m66592-udc.c b/drivers/usb/gadget/m66592-udc.c index 5396b24..2dc37d1 100644

[PATCH 5/5] usb: gadget: omap_udc: should not call gadget driver's .unbind

2014-05-20 Thread Peter Chen
It has already been covered by udc core Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/omap_udc.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c index 2ae4f6d..e731373 100644

[PATCH 2/5] usb: gadget: fusb300_udc: should not call gadget driver's .unbind

2014-05-20 Thread Peter Chen
It has already been covered by udc core Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/fusb300_udc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/fusb300_udc.c b/drivers/usb/gadget/fusb300_udc.c index 90d2836..e882d41

[PATCH 1/5] usb: gadget: fsl_udc_core: should not call gadget driver's .unbind

2014-05-20 Thread Peter Chen
It has already been covered by udc core Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/fsl_udc_core.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c index dd9ff29..0ae3705

[PATCH 0/5] usb: gadget: cleanup gadget driver .unbind usage at udc driver

2014-05-20 Thread Peter Chen
Hi Felipe, This patch set cleans up unnecessary .unbind calling at udc driver, the udc core covers gadget driver's .unbind calling well. Peter Chen (5): usb: gadget: fsl_udc_core: should not call gadget driver's .unbind usb: gadget: fusb300_udc: should not call gadget driver's .unbind usb:

[PATCH 4/5] usb: gadget: net2272: do not need to judge gadget driver's .unbind

2014-05-20 Thread Peter Chen
It has already been covered by udc core, besides, we do not need unbind at .udc_start Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/net2272.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/net2272.c

Re: [PATCH net-next] net: cdc_ncm: fix 64bit division build error

2014-05-20 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Mon, 19 May 2014 09:21:09 +0200 The upper timer_interval limit is arbitrary and much higher than anything usable in the real world. Reducing it from 15s to ~4s to make the timer_interval fit in an u32 does not make much difference. The limit is still