[PATCH V4 0/2] usb: gadget: zero: Add support for interrupt EP

2014-07-21 Thread Amit Virdi
This patchset adds support for interrupt EP and the corresponding test cases to gadget zero. The code has been rebased and tested on Kernel v3.15-rc5 V3-V4 - Edited the commit message to provide more information regarding the new test cases added - Rebased the code in Kernel v3.16-rc5 - No

[PATCH V4 2/2] usbtest: Add interrupt EP testcases

2014-07-21 Thread Amit Virdi
Two simple test cases for interrupt endpoints are added to the usbtest.c file. These are simple non-queued interrupt IN and interrupt OUT transfers. Currently, only gadget zero is capable of executing the interrupt EP test cases. However, extending the same to other gadgets is extremely simple and

[PATCH V4 1/2] usb: gadget: zero: Add support for interrupt EP

2014-07-21 Thread Amit Virdi
Interrupt endpoints behave quite similar to the bulk endpoints with the difference that the endpoints expect data sending/reception request at particular intervals till the whole data has not been transmitted. The interrupt EP support is added to gadget zero. A new alternate setting (=2) has been

Re: [PATCH 0/9] usb: musb: several bugfixes for the musb driver

2014-07-21 Thread Lothar Waßmann
Hi, Felipe Balbi wrote: Hi, On Fri, Jul 18, 2014 at 01:16:36PM -0300, Ezequiel Garcia wrote: Hi Lothar, On 18 Jul 11:31 AM, Lothar Waßmann wrote: The first three patches do some source code cleanup in the files that are modified in the subsequent patches. I've applied

Re: [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown()

2014-07-21 Thread Lothar Waßmann
Hi, On Fri, Jul 18, 2014 at 11:31:29AM +0200, Lothar Waßmann wrote: This patch makes it possible to use the musb driver with HW that requires external regulators or clocks. can you provide an example of such HW ? Are you not using the internal PHYs ? The Ka-Ro electronics TX48 module

Re: [PATCH v3] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-21 Thread Wang YanQing
On Mon, Jul 21, 2014 at 07:46:46AM +0200, Andreas Mohr wrote: Hi, Did some more review, sorry ;) On Mon, Jul 21, 2014 at 10:46:24AM +0800, Wang YanQing wrote: +static struct gpio_chip template_chip = { + .label = pl2303-gpio, + .owner =

[PATCH] usb: phy: tegra: Avoid use of sizeof(void)

2014-07-21 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com The PHY configuration is stored in an opaque config field, but when allocating the structure, its proper size needs to be known. In the case of UTMI, the proper structure is tegra_utmip_config of which a local variable already exists, so we can use that to

Re: [PATCH V2] usb: core: allow zero packet flag for interrupt urbs

2014-07-21 Thread Alan Stern
On Mon, 21 Jul 2014, Amit Virdi wrote: Section 4.4.7.2 Interrupt Transfer Bandwidth Requirements of the USB3.0 spec says: A zero-length data payload is a valid transfer and may be useful for some implementations. So, extend the logic of allowing URB_ZERO_PACKET to interrupt

Re: [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform

2014-07-21 Thread Laurent Pinchart
Hi Felipe, What happened to these two patches ? On Monday 16 December 2013 17:48:29 Felipe Balbi wrote: On Mon, Dec 16, 2013 at 02:38:27PM -0800, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [131216 13:31]: On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I wrote:

Re: [PATCH 8/9] usb: phy: am335x: call usb_gen_phy_init()/usb_gen_phy_shutdown() in am335x_init()/am335x_shutdown()

2014-07-21 Thread Felipe Balbi
Hi,, On Mon, Jul 21, 2014 at 10:03:07AM +0200, Lothar Waßmann wrote: Hi, On Fri, Jul 18, 2014 at 11:31:29AM +0200, Lothar Waßmann wrote: This patch makes it possible to use the musb driver with HW that requires external regulators or clocks. can you provide an example of such HW ?

Re: [PATCH 0/9] usb: musb: several bugfixes for the musb driver

2014-07-21 Thread Felipe Balbi
On Mon, Jul 21, 2014 at 09:34:30AM +0200, Lothar Waßmann wrote: Hi, Felipe Balbi wrote: Hi, On Fri, Jul 18, 2014 at 01:16:36PM -0300, Ezequiel Garcia wrote: Hi Lothar, On 18 Jul 11:31 AM, Lothar Waßmann wrote: The first three patches do some source code cleanup in the

Re: [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform

2014-07-21 Thread Felipe Balbi
Hi, On Mon, Jul 21, 2014 at 05:04:57PM +0200, Laurent Pinchart wrote: Hi Felipe, What happened to these two patches ? looks like I lost them. On Monday 16 December 2013 17:48:29 Felipe Balbi wrote: On Mon, Dec 16, 2013 at 02:38:27PM -0800, Tony Lindgren wrote: * Felipe Balbi

Re: high cpu load on omap3 using musb

2014-07-21 Thread Laurent Pinchart
Hi Adam, On Wednesday 29 January 2014 08:44:57 Adam Wozniak wrote: With a USB 2.0 webcam attached to the OTG port on an OMAP3 (applies to overo gumstix, beagleboard, probably others) we see a high CPU load in a kworker thread. Between 2.6.33 and 2.6.34 musb_core.c changed. IRQ handlers

[GIT PULL] USB changes for v3.17

2014-07-21 Thread Felipe Balbi
Hi Greg, Here's my big set of patches containing 97 commits. While it looks big and all, most commits are just cleanups moving code around, using devm_*, etc. I tested these patches on a couple TI platforms and couldn't find any regressions on my setup. This tree has also been on linux-next

Re: high cpu load on omap3 using musb

2014-07-21 Thread Felipe Balbi
On Mon, Jul 21, 2014 at 05:28:58PM +0200, Laurent Pinchart wrote: Hi Adam, On Wednesday 29 January 2014 08:44:57 Adam Wozniak wrote: With a USB 2.0 webcam attached to the OTG port on an OMAP3 (applies to overo gumstix, beagleboard, probably others) we see a high CPU load in a kworker

Re: [PATCH 0/9] usb: musb: several bugfixes for the musb driver

2014-07-21 Thread Ezequiel Garcia
On 21 Jul 10:11 AM, Felipe Balbi wrote: On Mon, Jul 21, 2014 at 09:34:30AM +0200, Lothar Waßmann wrote: Hi, Felipe Balbi wrote: Hi, On Fri, Jul 18, 2014 at 01:16:36PM -0300, Ezequiel Garcia wrote: Hi Lothar, On 18 Jul 11:31 AM, Lothar Waßmann wrote: The first

Re: [PATCH 0/9] usb: musb: several bugfixes for the musb driver

2014-07-21 Thread Felipe Balbi
On Mon, Jul 21, 2014 at 12:53:52PM -0300, Ezequiel Garcia wrote: On 21 Jul 10:11 AM, Felipe Balbi wrote: On Mon, Jul 21, 2014 at 09:34:30AM +0200, Lothar Waßmann wrote: Hi, Felipe Balbi wrote: Hi, On Fri, Jul 18, 2014 at 01:16:36PM -0300, Ezequiel Garcia wrote: Hi

Re: non-working UVC device 058f:5608

2014-07-21 Thread Laurent Pinchart
On Monday 09 June 2014 12:27:37 Johannes Berg wrote: On Mon, 2014-06-09 at 11:59 +0200, Johannes Berg wrote: Johannes, could you enable USB debugging in the linus/master kernel and provide a kernel log ? I'll try to get some logs (wasn't there tracing added to xhci too? will check)

Re: [GIT PULL] USB changes for v3.17

2014-07-21 Thread Greg KH
On Mon, Jul 21, 2014 at 10:35:29AM -0500, Felipe Balbi wrote: Hi Greg, Here's my big set of patches containing 97 commits. While it looks big and all, most commits are just cleanups moving code around, using devm_*, etc. I tested these patches on a couple TI platforms and couldn't find any

Re: high cpu load on omap3 using musb

2014-07-21 Thread Laurent Pinchart
Hi Felipe and Adam, On Monday 21 July 2014 10:40:52 Felipe Balbi wrote: On Mon, Jul 21, 2014 at 05:28:58PM +0200, Laurent Pinchart wrote: On Wednesday 29 January 2014 08:44:57 Adam Wozniak wrote: With a USB 2.0 webcam attached to the OTG port on an OMAP3 (applies to overo gumstix,

Retro-fit USB monitor

2014-07-21 Thread Dave
I'm at a loss. I want to retrofit a USB host driver with the calls necessary to implement USB monitoring but I can't find any good reference material. Can someone point me in the right direction? The usbmon.txt file does a nice job on using the facility but doesn't say much about the driver

Re: Retro-fit USB monitor

2014-07-21 Thread Alan Stern
On Mon, 21 Jul 2014, Dave wrote: I'm at a loss. I want to retrofit a USB host driver with the calls necessary to implement USB monitoring but I can't find any good reference material. Can someone point me in the right direction? The usbmon.txt file does a nice job on using the facility but

Re: Retro-fit USB monitor

2014-07-21 Thread Greg KH
On Mon, Jul 21, 2014 at 04:52:40PM -0400, Dave wrote: I'm at a loss. I want to retrofit a USB host driver with the calls necessary to implement USB monitoring but I can't find any good reference material. Can someone point me in the right direction? The usbmon.txt file does a nice job on using

Re: [GIT PULL] USB changes for v3.17

2014-07-21 Thread Felipe Balbi
On Mon, Jul 21, 2014 at 11:34:50AM -0700, Greg KH wrote: On Mon, Jul 21, 2014 at 10:35:29AM -0500, Felipe Balbi wrote: Hi Greg, Here's my big set of patches containing 97 commits. While it looks big and all, most commits are just cleanups moving code around, using devm_*, etc. I

Re: Retro-fit USB monitor

2014-07-21 Thread Dave
It's the gadget driver for the Freescale Dual role controller. Sent from my iPhone On Jul 21, 2014, at 5:01 PM, Greg KH g...@kroah.com wrote: On Mon, Jul 21, 2014 at 04:52:40PM -0400, Dave wrote: I'm at a loss. I want to retrofit a USB host driver with the calls necessary to implement USB

Re: Retro-fit USB monitor

2014-07-21 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Mon, Jul 21, 2014 at 05:17:16PM -0400, Dave wrote: It's the gadget driver for the Freescale Dual role controller. gadget drivers do not use usbmon on the gadget side, sorry. That's a

RE: [PATCH 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-07-21 Thread Paul Zimmerman
From: dingu...@altera.com [mailto:dingu...@altera.com] Sent: Wednesday, July 16, 2014 1:33 PM Update DWC2 kconfig and makefile to support dual-role mode. The platform file will always get compiled for the case where the controller is directly connected to the CPU. So for loadable modules,

Re: Retro-fit USB monitor

2014-07-21 Thread Dave
Sorry about the poor form! Bad habit I suppose. That's a host-controller-only interface for now. That being usbmon - right? But there is no intrinsic reason I couldn't use the USB core as a model for retrofitting the Freescale DR driver is there? BTW - I haven't found any thing describing

RE: [PATCH 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-07-21 Thread Dinh Nguyen
On Mon, 2014-07-21 at 21:39 +, Paul Zimmerman wrote: From: dingu...@altera.com [mailto:dingu...@altera.com] Sent: Wednesday, July 16, 2014 1:33 PM Update DWC2 kconfig and makefile to support dual-role mode. The platform file will always get compiled for the case where the controller

Re: Retro-fit USB monitor

2014-07-21 Thread Greg KH
On Mon, Jul 21, 2014 at 06:08:05PM -0400, Dave wrote: Sorry about the poor form! Bad habit I suppose. That's a host-controller-only interface for now. That being usbmon - right? Yes. But there is no intrinsic reason I couldn't use the USB core as a model for retrofitting the

Re: [PATCH 0/4] Allow xHCI drivers to be built as separate modules

2014-07-21 Thread Andrew Bresticker
On Wed, Jul 9, 2014 at 6:05 PM, Andrew Bresticker abres...@chromium.org wrote: It was suggested in the review of the Tegra xHCI driver [1] that we allow xHCI drivers to be built as individual modules (like EHCI) instead of building them all into the single xhci-hcd module as they are today.

Re: [PATCH 0/6] vf610: Add USB support

2014-07-21 Thread Peter Chen
On Fri, Jul 18, 2014 at 07:01:36PM +0200, Stefan Agner wrote: This patchset adds USB support for Vybrid VF610 SoC. It extends the clock framework to support the USB PHY cocks, extends the device tree files and adds support for the non-core registers in the usbmisc_imx driver. This patchset

Re: [PATCH 5/6] usb: phy: mxs: Add VF610 USB PHY support

2014-07-21 Thread Peter Chen
On Fri, Jul 18, 2014 at 07:01:41PM +0200, Stefan Agner wrote: This adds support for the USB PHY in Vybrid VF610. We assume that the disconnection without VBUS is also needed for Vybrid. For all other flags, the presumption of innocence applies. Signed-off-by: Stefan Agner ste...@agner.ch

Re: [PATCH 4/6] chipidea: usbmisc_imx: Add USB support for VF610 SoCs

2014-07-21 Thread Peter Chen
On Fri, Jul 18, 2014 at 07:01:40PM +0200, Stefan Agner wrote: This adds Vybrid VF610 SoC support. The IP is very similar to i.MX6, however the non-core registers are spread in two different register areas. Hence we support multiple registers which are addressed by the index of usbmisc.

Re: [PATCH 0/4] Allow xHCI drivers to be built as separate modules

2014-07-21 Thread Greg Kroah-Hartman
On Mon, Jul 21, 2014 at 04:41:08PM -0700, Andrew Bresticker wrote: On Wed, Jul 9, 2014 at 6:05 PM, Andrew Bresticker abres...@chromium.org wrote: It was suggested in the review of the Tegra xHCI driver [1] that we allow xHCI drivers to be built as individual modules (like EHCI) instead of

[PATCH 2/3] usb: ci_hdrc_imx doc: fsl,usbphy is required

2014-07-21 Thread Peter Chen
From: Markus Pargmann m...@pengutronix.de fsl,usbphy is no optional property. This patch moves it to the list of required properties. Signed-off-by: Markus Pargmann m...@pengutronix.de Signed-off-by: Peter Chen peter.c...@freescale.com --- .../devicetree/bindings/usb/ci-hdrc-imx.txt|

[PATCH 0/3] Chipidea patchset for v3.17

2014-07-21 Thread Peter Chen
Hi Greg, Only some tiny changes for this patchset, like fix building warning and change return value, thanks. Markus Pargmann (2): usb: ci_hdrc_imx: Return -EINVAL for missing USB PHY usb: ci_hdrc_imx doc: fsl,usbphy is required Wei Yongjun (1): usb: chipidea: debug: fix sparse non static

Re: [PATCH 5/6] usb: phy: mxs: Add VF610 USB PHY support

2014-07-21 Thread Shawn Guo
On Fri, Jul 18, 2014 at 07:01:41PM +0200, Stefan Agner wrote: This adds support for the USB PHY in Vybrid VF610. We assume that the disconnection without VBUS is also needed for Vybrid. For all other flags, the presumption of innocence applies. Signed-off-by: Stefan Agner ste...@agner.ch

[PATCH 3/3] usb: chipidea: debug: fix sparse non static symbol warnings

2014-07-21 Thread Peter Chen
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fixes the following sparse warnings: drivers/usb/chipidea/debug.c:211:5: warning: symbol 'ci_otg_show' was not declared. Should it be static? drivers/usb/chipidea/debug.c:334:5: warning: symbol 'ci_registers_show' was not declared. Should it be

[PATCH 1/3] usb: ci_hdrc_imx: Return -EINVAL for missing USB PHY

2014-07-21 Thread Peter Chen
From: Markus Pargmann m...@pengutronix.de -ENODEV is interpreted by the generic driver probing function as a non-matching driver. This leads to a missing probe failure message. Also a missing USB PHY is more of an invalid configuration of the usb driver because it is necessary. This patch

Re: [PATCH 1/6] ARM: dts: vf610: add USB PHY and controller

2014-07-21 Thread Shawn Guo
On Fri, Jul 18, 2014 at 07:01:37PM +0200, Stefan Agner wrote: This adds USB PHY and USB controller nodes. Vybrid SoCs have two independent USB cores which each supports DR (dual role). However, real OTG is not supported since the OTG ID pin is not available. The PHYs are located within the

Re: [PATCH 2/6] ARM: imx: clk-vf610: add USBPHY clocks

2014-07-21 Thread Shawn Guo
On Fri, Jul 18, 2014 at 07:01:38PM +0200, Stefan Agner wrote: This commit adds PLL7 which is required for USBPHY1. It also adds the USB PHY and USB Controller clocks and the gates to enable them. Signed-off-by: Stefan Agner ste...@agner.ch Jingchang, Does the patch look good to you? Shawn

Re: [PATCH 4/6] chipidea: usbmisc_imx: Add USB support for VF610 SoCs

2014-07-21 Thread Shawn Guo
On Fri, Jul 18, 2014 at 07:01:40PM +0200, Stefan Agner wrote: @@ -283,6 +307,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] = { .compatible = fsl,imx6q-usbmisc, .data = imx6q_usbmisc_ops, }, + { + .compatible = fsl,vf610-usbmisc,

Re: [PATCH v2] usb-core: Quirk support for non-standard bInterval

2014-07-21 Thread Greg KH
On Mon, Jul 21, 2014 at 10:33:31PM -0400, James Michels wrote: From: James P Michels III james.p.mich...@gmail.com This patch adds usb quirks to improve support for devices with non standard bInterval values. Quirks are added to support devices with bInterval values expressed as microframes

Re: [PATCH] USB: core: hcd-pci: free IRQ before disabling PCI device when shutting down

2014-07-21 Thread Huang Rui
On Mon, Jul 21, 2014 at 10:17:44AM +0800, Jiang Liu wrote: The assigned IRQ should be freed before calling pci_disable_device() when shutting down system, otherwise it will cause following warning. [ 568.879482] [ cut here ] [ 568.884236] WARNING: CPU: 1 PID: 3300 at