[PATCH resend] Revert usb: gadget: u_ether: synchronize with transmit when stopping queue

2014-07-25 Thread roy . qing . li
From: Li RongQing roy.qing...@gmail.com This reverts commit a9232076374334ca2bc2a448dfde96d38a54349a. It introduced a dead lock, and did not fix anything. it made netif_tx_lock() be called in IRQ context, but in softirq context, the same lock is locked without disabling IRQ. In fact, the commit

Re: [PATCH net] r8152: fix the checking of the usb speed

2014-07-25 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Thu, 24 Jul 2014 16:37:43 +0800 When the usb speed of the RTL8152 is not high speed, the USB_DEV_STAT[2:1] should be equal to [0 1]. That is, the STAT_SPEED_FULL should be equal to 2. There is a easy way to check the usb speed by the speed field

Re: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-07-25 Thread Antoine Ténart
Hi Peter, On Fri, Jul 25, 2014 at 10:18:54AM +0800, Peter Chen wrote: On Wed, Jul 16, 2014 at 10:26:01AM +0200, Antoine Ténart wrote: Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock and DMA mask, to support USB2 ChipIdea controllers that don't need specific functions.

Re: [PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-25 Thread Antoine Ténart
Hi Peter, On Fri, Jul 25, 2014 at 12:34:39AM +, Peter Chen wrote: - if (ci-platdata-usb_phy) + if (ci-platdata-phy) + ci-phy = ci-platdata-phy; + else if (ci-platdata-usb_phy) ci-usb_phy = ci-platdata-usb_phy;

RE: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx

2014-07-25 Thread Peter Chen
On Fri, Jul 25, 2014 at 10:18:54AM +0800, Peter Chen wrote: On Wed, Jul 16, 2014 at 10:26:01AM +0200, Antoine Ténart wrote: Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock and DMA mask, to support USB2 ChipIdea controllers that don't need specific functions.

RE: [PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-25 Thread Peter Chen
Just add OTG member into ci_hdrc structure, see below patch diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h index 9563cb5..186fb3f 100644 --- a/drivers/usb/chipidea/ci.h +++ b/drivers/usb/chipidea/ci.h @@ -207,6 +207,7 @@ struct ci_hdrc { bool

Re: [PATCH v2 8/8] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-07-25 Thread Antoine Ténart
On Fri, Jul 25, 2014 at 08:33:28AM +, Peter Chen wrote: Just add OTG member into ci_hdrc structure, see below patch diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h index 9563cb5..186fb3f 100644 --- a/drivers/usb/chipidea/ci.h +++

Hello dear,

2014-07-25 Thread Mr Cole Davidson
Good Day Dear Friend, Hello dear, I wish to approach you with a request that would be of immense benefit to both of us.I came across your email and I picked interest to contact you, please can we be friends? or partnership with me in some business investment, Maybe you can assist. There is a

[PATCH v2 1/3] usb: gadget: f_fs: virtual address mapping

2014-07-25 Thread Robert Baldyga
This patch adds virtual endpoint address mapping to functionfs. So far endpoint addresses given by user through endpoint descriptors were ignored, and replaced by physical endpoint addresses. Endpoint address in wIndex field of setup requesti, addressed to endpoint, was the physical endpoint

[PATCH v2 2/3] usb: gadget: f_fs: add ioctl returning ep descriptor

2014-07-25 Thread Robert Baldyga
This patch introduces ioctl named FUNCTIONFS_ENDPOINT_DESC, which returns endpoint descriptor to userspace. It works only if function is active. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/f_fs.c | 17 + include/uapi/linux/usb/functionfs.h

[PATCH v2 0/3] usb: gadget: f_fs: userspace API fixes and improvements

2014-07-25 Thread Robert Baldyga
This patchset contains changes in FunctionFS making it easier and safer to use. It introduces virtual address mapping which allows to separate endpoint address space in function from physical endpoint addresses, and allow to refer to endpoints with address chosen by user. It also adds new ioctl

[PATCH v2 3/3] usb: gadget: f_fs: make numbers in ep file names the same as ep addresses

2014-07-25 Thread Robert Baldyga
This patch adds FUNCTIONFS_ADDR_NAMES flag to user flags set in descriptors, which makes numbers in endpoint file names the same as value of bEndpointAddress in endpoint descriptor. It simplifies endpoint handling, because now it can be refered using one unique number. Numbers are in hexadecimal

Re: OMAP3/AM3517 EHCI USB Issue

2014-07-25 Thread Alan Stern
On Thu, 24 Jul 2014, Michael Welling wrote: So I may be barking up the wrong tree on this one. Today I discovered something that may lead to the resolution of my issue. The hardware I am using incorporates a USB switch on-board to avoid the having an external switch to plug in keyboards

Re: [PATCH v2 3/3] usb: gadget: f_fs: make numbers in ep file names the same as ep addresses

2014-07-25 Thread Michal Nazarewicz
On Fri, Jul 25 2014, Robert Baldyga wrote: This patch adds FUNCTIONFS_ADDR_NAMES flag to user flags set in descriptors, which makes numbers in endpoint file names the same as value of bEndpointAddress in endpoint descriptor. It simplifies endpoint handling, because now it can be refered using

Re: [PATCH v2 2/3] usb: gadget: f_fs: add ioctl returning ep descriptor

2014-07-25 Thread Michal Nazarewicz
On Fri, Jul 25 2014, Robert Baldyga wrote: This patch introduces ioctl named FUNCTIONFS_ENDPOINT_DESC, which returns endpoint descriptor to userspace. It works only if function is active. I would argue that user space should never need to know the real descriptor. Is this ioctl needed for

Re: [PATCH v2 1/3] usb: gadget: f_fs: virtual address mapping

2014-07-25 Thread Michal Nazarewicz
On Fri, Jul 25 2014, Robert Baldyga wrote: This patch adds virtual endpoint address mapping to functionfs. So far endpoint addresses given by user through endpoint descriptors were ignored, and replaced by physical endpoint addresses. Endpoint address in wIndex field of setup requesti,

[RFT PATCH] xhci: rework cycle bit checking for new dequeue pointers

2014-07-25 Thread Mathias Nyman
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 95 +++- 1 file changed, 31 insertions(+), 64 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 749fc68..35da18c 100644

Re: Linux 3.16-rc6

2014-07-25 Thread Peter Zijlstra
On Thu, Jul 24, 2014 at 04:38:28PM -0400, Waiman Long wrote: Yes, I think I may have a solution for that. Borislav, can you apply the following patch on top of the lockdep patch to see if it can fix the problem? diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index

[PATCH] usb: dwc3: add tracepoints to aid debugging

2014-07-25 Thread Felipe Balbi
When we're debugging hard-to-reproduce and time-sensitive use cases, printk() poses too much overhead. That's when the kernel's tracing infrastructure comes into play. This patch implements a few initial tracepoints for the dwc3 driver. More traces can be added as necessary in order to ease the

Re: OMAP3/AM3517 EHCI USB Issue

2014-07-25 Thread Michael Welling
On Fri, Jul 25, 2014 at 10:02:15AM -0400, Alan Stern wrote: On Thu, 24 Jul 2014, Michael Welling wrote: So I may be barking up the wrong tree on this one. Today I discovered something that may lead to the resolution of my issue. The hardware I am using incorporates a USB switch

Re: [PATCH] usb: dwc3: add tracepoints to aid debugging

2014-07-25 Thread Felipe Balbi
Hi, changed one detail On Fri, Jul 25, 2014 at 11:19:05AM -0500, Felipe Balbi wrote: +DECLARE_EVENT_CLASS(dwc3_log_ctrl, + TP_PROTO(struct usb_ctrlrequest *ctrl), + TP_ARGS(ctrl), + TP_STRUCT__entry( + __field(struct usb_ctrlrequest *, ctrl) + ), +

Re: OMAP3/AM3517 EHCI USB Issue

2014-07-25 Thread Alan Stern
On Fri, 25 Jul 2014, Michael Welling wrote: On Fri, Jul 25, 2014 at 10:02:15AM -0400, Alan Stern wrote: On Thu, 24 Jul 2014, Michael Welling wrote: So I may be barking up the wrong tree on this one. Today I discovered something that may lead to the resolution of my issue.

Re: Linux 3.16-rc6

2014-07-25 Thread Waiman Long
On 07/24/2014 05:45 PM, Borislav Petkov wrote: On Thu, Jul 24, 2014 at 04:38:28PM -0400, Waiman Long wrote: Borislav, can you apply the following patch on top of the lockdep patch to see if it can fix the problem? It is too late here for me to test anything but the ingridients to reproduce are

[PATCH v5] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-25 Thread Wang YanQing
PL2303HX has two GPIOs, this patch add interface for it. Signed-off-by: Wang YanQing udkni...@gmail.com --- Changes v4-v5: 1: fix gpio_chip.lable been overwrited by template_chip. 2: use idr to manage minor instead of crude monotonous atomic increment. drivers/usb/serial/Kconfig | 10 +++

Re: OMAP3/AM3517 EHCI USB Issue

2014-07-25 Thread Michael Welling
On Fri, Jul 25, 2014 at 12:50 PM, Michael Welling mwell...@emacinc.com wrote: On Fri, Jul 25, 2014 at 01:19:23PM -0400, Alan Stern wrote: On Fri, 25 Jul 2014, Michael Welling wrote: On Fri, Jul 25, 2014 at 10:02:15AM -0400, Alan Stern wrote: On Thu, 24 Jul 2014, Michael Welling wrote:

Re: OMAP3/AM3517 EHCI USB Issue

2014-07-25 Thread Alan Stern
On Fri, 25 Jul 2014, Michael Welling wrote: What if you prevent the root hub from going into runtime suspend? Or prevent the external hub from going into runtime suspend? You could be facing a wakeup problem. This helps, it appears that the issue is with the external HUB. If I

Re: [RFT PATCH] xhci: rework cycle bit checking for new dequeue pointers

2014-07-25 Thread Julius Werner
On Fri, Jul 25, 2014 at 8:47 AM, Mathias Nyman mathias.ny...@linux.intel.com wrote: Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 95 +++- 1 file changed, 31 insertions(+), 64 deletions(-) diff --git

Re: Report about a please report the device ID to the Linux USB developers! message

2014-07-25 Thread Antonio
Hi! The usb_modeswitch driver loading/driver bind check could do with an additional test when driver binding has failed, a check to see if the device has disappeared from the bus during the 1 sec time when usb_modeswitch waits for the driver to bind. If it has disappeared then don't throw

Re: [PATCH v5] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-25 Thread Andreas Mohr
Hi, On Sat, Jul 26, 2014 at 01:35:23AM +0800, Wang YanQing wrote: + It support 2 GPIOs on PL2303HX currently, supports +static u8 gpio_dir_mask[GPIO_NUM] = {0x10, 0x20}; +static u8 gpio_value_mask[GPIO_NUM] = {0x40, 0x80}; Those two should better be static const, too (sorry). You're

[PATCH 00/11] Misc. xhci + uas fixes / cleanups

2014-07-25 Thread Hans de Goede
Hi All, I've just spend 3 days trying to get bulk streams / uas to work on an Etron controller, and failed. So the first patch in this set is the most important one (and has a CC stable, and should be added to 3.16 if still possible). It simply outright disables streams on the Etron model in

[PATCH 08/11] xhci: Always ring the doorbell for active eps when a Set TR deq ptr cmd completes

2014-07-25 Thread Hans de Goede
Even if the stream for which the command was intended has been freed in the mean time. This ensures that things start rolling again after an unlink / halt. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci-ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 03/11] xhci: Log extra info on ERROR Transfer event TRB DMA ptr not part of current TD

2014-07-25 Thread Hans de Goede
Lately (with the use of uas / bulk-streams) we have been seeing several cases where this error triggers (which should never happen). Add some extra logging to make debugging these errors easier. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci-mem.c | 4 +++-

[PATCH 11/11] xhci: xhci_ring_device: Ring stream ring bells for endpoints with streams

2014-07-25 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci-hub.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index aa79e87..bb54783 100644 --- a/drivers/usb/host/xhci-hub.c +++

[PATCH 02/11] xhci: Rename Asrock P67 pci product-id to EJ168

2014-07-25 Thread Hans de Goede
The 7023 product id is the generic product id for the Etron EJ168, it is not specific to the version found on the Asrock P67 motherboard. The same id is e.g. also used on Gigabyte motherboards and on no-name pci-e usb-3 addon cards. Signed-off-by: Hans de Goede hdego...@redhat.com ---

[PATCH 09/11] uas: Only complain about missing sg if all other checks succeed

2014-07-25 Thread Hans de Goede
Don't complain about controllers without sg support if there are other reasons why uas cannot be used anyways. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/storage/uas-detect.h | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git

[PATCH 04/11] xhci: Add missing checks for xhci_alloc_command failure

2014-07-25 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci-ring.c | 4 drivers/usb/host/xhci.c | 4 2 files changed, 8 insertions(+) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 213b28a..2e19986 100644 ---

[PATCH 06/11] xhci: Fold queue_set_tr_deq into xhci_queue_new_dequeue_state

2014-07-25 Thread Hans de Goede
xhci_queue_new_dequeue_state is the only caller of queue_set_tr_deq and queue_set_tr_deq checks for SET_DEQ_PENDING, where as xhci_queue_new_dequeue_state sets it which is inconsistent. Simply fold the 2 into one is a nice cleanup and fixes the inconsistency. Signed-off-by: Hans de Goede

[PATCH 05/11] xhci: Move allocating of command for new_dequeue_state to queue_set_tr_deq()

2014-07-25 Thread Hans de Goede
There are multiple reasons for this: 1) This fixes a missing check for xhci_alloc_command failing in xhci_handle_cmd_stop_ep() 2) This adds a warning when we cannot set the new dequeue state because of xhci_alloc_command failing 3) It puts the allocation of the command after the sanity

Re: Problem with D-Link USB 3.0 to Gigabit Ethernet Adapter DUB-1312

2014-07-25 Thread Dan Williams
On Wed, Jul 23, 2014 at 6:52 AM, Marek Uher xu...@seznam.cz wrote: Hi Sarah, Thank you very much for your answer. I bought three same all-in-one, low-energy and space effective computers from ASUS. There isn’t any possibility to add an additional extension PCIe card. There is only

Re: [PATCH] usb: dwc3: add tracepoints to aid debugging

2014-07-25 Thread Greg KH
On Fri, Jul 25, 2014 at 11:19:05AM -0500, Felipe Balbi wrote: When we're debugging hard-to-reproduce and time-sensitive use cases, printk() poses too much overhead. That's when the kernel's tracing infrastructure comes into play. This patch implements a few initial tracepoints for the dwc3