Re: UAS crash with Apricorn USB3 SATA bridge

2014-12-10 Thread Hans de Goede
Hi, On 09-12-14 20:31, Darrick J. Wong wrote: Hi, I have an Apricorn USB 3 disk dongle thing that claims to support UAS. However, the kernel crashes when I plug it in[1]. Yes there are some known issues with uas error handling which are fixed in 3.18, can you try with a 3.18 kernel please ?

Re: [PATCH V2 1/2] pinctrl: exynos: Add BUS1 pin controller for exynos7

2014-12-10 Thread Vivek Gautam
Hi Tomasz, On Mon, Dec 1, 2014 at 9:37 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Vivek, Please see my comments below. 2014-11-24 22:02 GMT+09:00 Vivek Gautam gautam.vi...@samsung.com: USB and Power regulator on Exynos7 require gpios available in BUS1 pin controller block. So adding

[PATCH V3 2/2] pinctrl: exynos: Add BUS1 pin controller for exynos7

2014-12-10 Thread Vivek Gautam
USB and Power regulator on Exynos7 require gpios available in BUS1 pin controller block. So adding the BUS1 pinctrl support. Signed-off-by: Naveen Krishna Ch naveenkrishna...@gmail.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Linus Walleij

[PATCH 1/2] Documentation: dt-bindings: Add aliases information for Exynos7 pin controllers

2014-12-10 Thread Vivek Gautam
Adding list of aliases for supported Exynos7 pin controller blocks. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Linus Walleij linus.wall...@linaro.org --- .../devicetree/bindings/pinctrl/samsung-pinctrl.txt | 10 ++ 1 file

Re: UAS crash with Apricorn USB3 SATA bridge

2014-12-10 Thread Darrick J. Wong
On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote: Hi, On 09-12-14 20:31, Darrick J. Wong wrote: Hi, I have an Apricorn USB 3 disk dongle thing that claims to support UAS. However, the kernel crashes when I plug it in[1]. Yes there are some known issues with uas error

[PATCH 2/2] usb: gadget: f_uac1: update Class-Specific AudioControl Interface Header Descriptor

2014-12-10 Thread Peter Chen
From: Xuebing Wang xbi...@gmail.com Update this according to USB Audio Class 1.0 spec. This fixes the Windows 7 detection issue. Cc: Rafael Brune m...@rbrune.de Signed-off-by: Xuebing Wang xbi...@gmail.com Signed-off-by: Fabio Estevam feste...@gmail.com Signed-off-by: Peter Chen

[PATCH 1/2] usb: gadget: f_uac1: configure endpoint before using it

2014-12-10 Thread Peter Chen
From: Xuebing Wang xbi...@gmail.com UAC1 forget to do it. Signed-off-by: Xuebing Wang xbi...@gmail.com Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/function/f_uac1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/function/f_uac1.c

[PATCH 1/1] usb: chipidea: udc: return immediately if re-enable non-empty endpoint

2014-12-10 Thread Peter Chen
Some gadget driver (like uac1) will try to enable endpoint again even the ep is not empty, it will cause the ep reset again and may affect the dTD list which has already queued. It returns -EBUSY immediately, and indicate the endpoint is in use. In this way, the ep's behavior will not be

Re: UAS crash with Apricorn USB3 SATA bridge

2014-12-10 Thread Darrick J. Wong
On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J. Wong wrote: On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote: Hi, On 09-12-14 20:31, Darrick J. Wong wrote: Hi, I have an Apricorn USB 3 disk dongle thing that claims to support UAS. However, the kernel crashes when

Re: [PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6

2014-12-10 Thread Philipp Zabel
Hi Peter, Am Mittwoch, den 10.12.2014, 13:09 +0800 schrieb Peter Chen: On Tue, Dec 09, 2014 at 05:13:35PM +0100, Philipp Zabel wrote: On i.MX6Q, the USBMISC registers are clocked by the IPG clock, so there is no need to enable USBOH3 for the USBMISC driver. Access the registers at usbmisc

Re: UAS crash with Apricorn USB3 SATA bridge

2014-12-10 Thread Darrick J. Wong
On Wed, Dec 10, 2014 at 02:15:14AM -0800, Darrick J. Wong wrote: On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J. Wong wrote: On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote: Hi, On 09-12-14 20:31, Darrick J. Wong wrote: Hi, I have an Apricorn USB 3 disk

[PATCH v5 0/5] Patches to add support for Rockchip usb PHYs.

2014-12-10 Thread Yunzhi Li
Patches to add support for Rockchip usb phys.Add a new Rockchip usb phy driver and modify dwc2 controller driver to make dwc2 platform devices support a generic PHY framework driver. This patch set has been tested on my rk3288-evb and power off the usb phys would reduce about 60mW power budget in

[PATCH v5 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-10 Thread Yunzhi Li
Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li l...@rock-chips.com Acked-by: Paul Zimmerman pa...@synopsys.com --- Changes in v5: None Changes in v4: None Changes in v3: - Fix coding style: both branches of the if() which only one

Re: [PATCH 2/2] usb: gadget: uvc: configfs support in uvc function

2014-12-10 Thread Andrzej Pietrasiewicz
W dniu 07.12.2014 o 21:25, Laurent Pinchart pisze: Hi Andrzej, snip + mutex_lock(opts-lock); What does the mutex protect against ? Modifications of opts- uvc_*_streaming_cls by configfs ? You only copy pointers around, what prevents the descriptors from being modified after you

[PATCHv3 0/3] Equivalent of g_webcam with configfs.

2014-12-10 Thread Andrzej Pietrasiewicz
This series aims at integrating configfs into uvc, the way it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex, phonet, mass_storage, FunctionFS, loopback, sourcesink, uac1, uac2, hid and midi. v1..v2: - sorted header fiels alphabetically - applied style corrections - factored out

[PATCHv3 1/3] usb: gadget: f_uvc: rename a macro to avoid conflicts

2014-12-10 Thread Andrzej Pietrasiewicz
When configfs is integrated, CONFIGFS_ATTR_STRUCT and CONFIGFS_ATTR_OPS macros should be used, but the latter expects that tere is a to_f_uvc_opts function accepting a config_item, whereas the macro being changed can be applied to a different type of argument. Signed-off-by: Andrzej Pietrasiewicz

[PATCHv3 2/3] usb: gadget: uvc: verify descriptors presence

2014-12-10 Thread Andrzej Pietrasiewicz
If the caller of uvc_alloc() does not provide enough descriptors, binding the function should fail, so appropriate code is returned from uvc_copy_descriptors(). uvc_function_bind() is modified accordingly to account for possible errors from uvc_copy_descriptors(). Signed-off-by: Andrzej

[PATCHv3 3/3] usb: gadget: uvc: configfs support in uvc function

2014-12-10 Thread Andrzej Pietrasiewicz
Add support for using the uvc function as a component of USB gadgets composed with configfs. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/ABI/testing/configfs-usb-gadget-uvc | 265 +++ drivers/usb/gadget/Kconfig| 11 +

[PATCHv2 00/18] USB gadget functions testing

2014-12-10 Thread Andrzej Pietrasiewicz
This series adds a documentation file whith a summary of how to do basic testing of functions provided by USB gadgets. It does not add any code. It documents what is already in the kernel tree. It is mostly a compilation of information from my cover letters sent together with all series which

[PATCHv2 02/18] Documentation: usb: ACM function testing

2014-12-10 Thread Andrzej Pietrasiewicz
The newly added file will be used to provide descriptions of how to test the functions of USB gadgets. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 34 ++ 1 file changed, 34 insertions(+) create mode 100644

[PATCHv2 01/18] Documentation: usb: gadget_serial: update generic serial setup instruction

2014-12-10 Thread Andrzej Pietrasiewicz
Using module parameters to specify accepted Vendor ID, Product ID is considered legacy now. Update the documentation to reflect it. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget_serial.txt | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

[PATCHv2 04/18] Documentation: usb: ECM subset function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test ECM subset function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 34 ++ 1 file changed, 34 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 12/18] Documentation: usb: OBEX function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test OBEX function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 29 + 1 file changed, 29 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 15/18] Documentation: usb: SERIAL function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test SERIAL function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 31 +++ 1 file changed, 31 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 07/18] Documentation: usb: HID function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test HID function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 47 1 file changed, 47 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 03/18] Documentation: usb: ECM function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test ECM function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 34 ++ 1 file changed, 34 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 10/18] Documentation: usb: MIDI function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test MIDI function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 84 1 file changed, 84 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 06/18] Documentation: usb: FFS function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test FFS (FunctionFS) function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 24 1 file changed, 24 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 17/18] Documentation: usb: UAC1 function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test UAC1 function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 27 +++ 1 file changed, 27 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 08/18] Documentation: usb: LOOPBACK function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test LOOPBACK function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 23 +++ 1 file changed, 23 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 11/18] Documentation: usb: NCM function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test NCM function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 34 ++ 1 file changed, 34 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 16/18] Documentation: usb: SOURCESINK function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test SOURCESINK function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 27 +++ 1 file changed, 27 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 05/18] Documentation: usb: EEM function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test EEM function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 34 ++ 1 file changed, 34 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 14/18] Documentation: usb: RNDIS function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test RNDIS function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 36 1 file changed, 36 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 18/18] Documentation: usb: UAC2 function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test UAC2 function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 27 +++ 1 file changed, 27 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 09/18] Documentation: usb: MASS STORAGE function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test MASS STORAGE function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 54 1 file changed, 54 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

[PATCHv2 13/18] Documentation: usb: PHONET function testing

2014-12-10 Thread Andrzej Pietrasiewicz
Summary of how to test PHONET function of USB gadget. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- Documentation/usb/gadget-testing.txt | 64 1 file changed, 64 insertions(+) diff --git a/Documentation/usb/gadget-testing.txt

Re: [PATCHv2 00/18] USB gadget functions testing

2014-12-10 Thread Andrzej Pietrasiewicz
W dniu 10.12.2014 o 14:02, Andrzej Pietrasiewicz pisze: This series adds a documentation file whith a summary of how to do basic testing of functions provided by USB gadgets. It does not add any code. It documents what is already in the kernel tree. It is mostly a compilation of information

Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-10 Thread Johan Hovold
On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote: This driver is for the NovaTech 124 4x serial expansion board for the NovaTech OrionLXm. Firmware source code can be found here: https://github.com/novatechweb/nt124 Great, and thanks for the patch! Signed-off-by: George

Re: ptp-gadget (by denx) on beaglebone black

2014-12-10 Thread Andrzej Pietrasiewicz
W dniu 09.12.2014 o 04:47, ivo welch pisze: dear usb experts---per request in the readme file, I am asking the question here. I am trying to get a ptp-gadget device-side implementation of the Picture Transfer Protocol to work on a beaglebone black (AM335x), running debian 7.7. the hosts to

RE: VFS and LSM issues

2014-12-10 Thread Krzysztof Opasiak
-Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Wednesday, December 10, 2014 5:54 AM To: Krzysztof Opasiak Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; linux- security-mod...@vger.kernel.org; ca...@schaufler-ca.com; jl...@evilplan.org;

Re: [PATCHv3 3/3] usb: gadget: uvc: configfs support in uvc function

2014-12-10 Thread Laurent Pinchart
Hi Andrzej, Thank you for the patch. On Wednesday 10 December 2014 12:34:02 Andrzej Pietrasiewicz wrote: Add support for using the uvc function as a component of USB gadgets composed with configfs. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com And now the moment you've been

Re: VFS and LSM issues

2014-12-10 Thread Stephen Smalley
On 12/08/2014 12:04 PM, Krzysztof Opasiak wrote: Dear All, I'm Krzysztof Opasiak from SRPOL (Samsung). I'm working on USB support in Tizen and mainline. In those works we use two Virtual File Systems - ConfigFS and FunctionFS. Recently I have tried to use them with SMACK and I ran into a

Re: VFS and LSM issues

2014-12-10 Thread Stephen Smalley
On 12/09/2014 11:54 PM, Greg KH wrote: On Mon, Dec 08, 2014 at 06:04:30PM +0100, Krzysztof Opasiak wrote: Dear All, I'm Krzysztof Opasiak from SRPOL (Samsung). I'm working on USB support in Tizen and mainline. In those works we use two Virtual File Systems - ConfigFS and FunctionFS. Recently

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-10 Thread Sebastian Andrzej Siewior
* 'Greg Kroah-Hartman' | 2014-12-09 11:54:15 [-0500]: You can unbind the HCD driver from the PCI-device via sysfs and this is not something not only a developer does. This unbind calls the remove function of the driver and the only difference between unbind and rmmod is that the module

[PATCH] extcon: add MAX3355 driver

2014-12-10 Thread Sergei Shtylyov
MAX3355E chip integrates a charge pump and comparators to enable a system with an integrated USB OTG dual-role transceiver to function as a USB OTG dual-role device. In addition to sensing/controlling Vbus, the chip also passes thru the ID signal from the USB OTG connector. On some Renesas

Re: [PATCH 1/2] usb: ohci-platform: add support for multiple phys per controller

2014-12-10 Thread Scott Branden
On 14-12-05 01:28 PM, arun.ramamur...@broadcom.com wrote: From: Arun Ramamurthy arunr...@broadcom.com Added support for cases where one controller is connected to multiple phys Signed-off-by: Arun Ramamurthy arunr...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott

Re: UAS crash with Apricorn USB3 SATA bridge

2014-12-10 Thread Darrick J. Wong
On Wed, Dec 10, 2014 at 02:29:29AM -0800, Darrick J. Wong wrote: On Wed, Dec 10, 2014 at 02:15:14AM -0800, Darrick J. Wong wrote: On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J. Wong wrote: On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote: Hi, On 09-12-14

Re: [PATCH] extcon: add MAX3355 driver

2014-12-10 Thread Chanwoo Choi
Hi Sergei, I reviewed this patch quickly. This driver has just two gpio without any registers for IP. I wonder whether MAX3355E is separate chip to detect external connector or just use gpio of AP. Could you send the datasheet of MAX3355E to me? Thanks, Chanwoo Choi On 12/11/2014 08:28 AM,

Learning USB Programming on Linux

2014-12-10 Thread ivo welch
dear experts---I would like to learn how to write programs that communicate over USB. both the host (desktop linux) and the client (beaglebone black) are running linux. I can program both host and gadget. ultimately, I will want to treat one USB port as a dedicated link between the two, without

Re: Learning USB Programming on Linux

2014-12-10 Thread Greg KH
On Thu, Dec 11, 2014 at 10:09:00AM +0800, ivo welch wrote: dear experts---I would like to learn how to write programs that communicate over USB. both the host (desktop linux) and the client (beaglebone black) are running linux. I can program both host and gadget. ultimately, I will want to

Re: Learning USB Programming on Linux

2014-12-10 Thread ivo welch
thank you, greg. if linux-usb is the wrong starter, can you recommend some pointers to good starter documentation and books about writing user-space USB programs? (is it really read the linux kernel source??) Ivo Welch (ivo.we...@gmail.com) http://www.ivo-welch.info/ J. Fred Weston

Re: Learning USB Programming on Linux

2014-12-10 Thread Greg KH
On Thu, Dec 11, 2014 at 10:54:13AM +0800, ivo welch wrote: thank you, greg. if linux-usb is the wrong starter, can you recommend some pointers to good starter documentation and books about writing user-space USB programs? (is it really read the linux kernel source??) I don't know of any,

RE: Learning USB Programming on Linux

2014-12-10 Thread Peter Chen
On Thu, Dec 11, 2014 at 10:54:13AM +0800, ivo welch wrote: thank you, greg. if linux-usb is the wrong starter, can you recommend some pointers to good starter documentation and books about writing user-space USB programs? (is it really read the linux kernel source??) I don't

Re: [PATCH] phy: phy-samsung-usb2: Don't use same name for driver name and global structure

2014-12-10 Thread Vivek Gautam
On Wed, Nov 12, 2014 at 3:54 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Using the same driver name for platform driver and a globally defined, structure used throughout the file, looks a bit unpleasing. So changing the driver name from samsung_usb2_phy_driver to samsung_usb2_phy