[PATCH 1/1] usb: phy: change some comments

2014-12-29 Thread Peter Chen
- Delete the OTG stuffs - .set_suspend is for controller, not for A-device or B-device. Signed-off-by: Peter Chen --- include/linux/usb/phy.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h index f499c23..bc91b5d 100644 --

Re: Strange behaviour...

2014-12-29 Thread Peter Chen
On Mon, Dec 29, 2014 at 01:37:04PM +0100, gianluca wrote: > On 12/25/2014 03:55 AM, Peter Chen wrote: > >On Wed, Dec 24, 2014 at 01:51:32PM +0100, gianluca wrote: > >>On 12/23/2014 01:12 AM, Peter Chen wrote: > >>>Ok, then just try to get the working version, and find the difference. > From my

Re: regression: Wrong device reset in port_event()

2014-12-29 Thread Zhuang Jin Can
Pasting the log to better explain the issue. <7>[ 589.157489] usb 2-5: usb auto-suspend, wakeup 1 <7>[ 589.168496] xhci_hcd :00:14.0: set port remote wake mask, actual port 0 status = 0xe0002a0 <7>[ 589.168543] xhci_hcd :00:14.0: set port remote wake mask, actual port 1 status = 0xe

Re: [PATCH 1/1] usb: chipidea: host: add .bus_suspend quirk

2014-12-29 Thread Peter Chen
On Mon, Dec 29, 2014 at 10:44:28AM -0500, Alan Stern wrote: > On Mon, 29 Dec 2014, Peter Chen wrote: > > > For chipidea, its resume sequence is not-EHCI compatible, see > > below description for FPR at portsc. So in order to send SoF in > > time for remote wakeup sequence(within 3ms), the RUN/STOP

Re: Tell ... to add your device to a proper driver.

2014-12-29 Thread Lars Melin
On 2014-12-30 04:18, anto1...@infinito.it wrote: Hi I send you this e-mail beacuse a read a warning message in kernel log files. I hope this can help... [ 485.687201] usbserial_generic 1-1.1:1.2: The "generic" usb-serial driver is only for testing and one-off prototypes. [ 485.687206] usb

Tell ... to add your device to a proper driver.

2014-12-29 Thread anto1945
Hi I send you this e-mail beacuse a read a warning message in kernel log files. I hope this can help... [ 485.687201] usbserial_generic 1-1.1:1.2: The "generic" usb-serial driver is only for testing and one-off prototypes. [ 485.687206] usbserial_generic 1-1.1:1.2: Tell linux-usb@vger.ker

Re: net2280: tracing

2014-12-29 Thread Jorge Ramirez-Ortiz
On 12/29/2014 02:58 PM, Felipe Balbi wrote: > Hi, > > On Mon, Dec 29, 2014 at 02:56:25PM -0500, Jorge Ramirez-Ortiz wrote: >> On 12/29/2014 11:37 AM, Felipe Balbi wrote: >>> Hi, >>> >>> On Sun, Dec 28, 2014 at 07:28:33PM -0500, Jorge Ramirez-Ortiz wrote: On 12/28/2014 11:39 AM, Felipe Balbi wr

Re: net2280: tracing

2014-12-29 Thread Felipe Balbi
Hi, On Mon, Dec 29, 2014 at 02:56:25PM -0500, Jorge Ramirez-Ortiz wrote: > On 12/29/2014 11:37 AM, Felipe Balbi wrote: > > Hi, > > > > On Sun, Dec 28, 2014 at 07:28:33PM -0500, Jorge Ramirez-Ortiz wrote: > >> On 12/28/2014 11:39 AM, Felipe Balbi wrote: > >>> On Sat, Dec 27, 2014 at 05:33:36PM -050

Re: net2280: tracing

2014-12-29 Thread Jorge Ramirez-Ortiz
On 12/29/2014 11:37 AM, Felipe Balbi wrote: > Hi, > > On Sun, Dec 28, 2014 at 07:28:33PM -0500, Jorge Ramirez-Ortiz wrote: >> On 12/28/2014 11:39 AM, Felipe Balbi wrote: >>> On Sat, Dec 27, 2014 at 05:33:36PM -0500, Jorge Ramirez-Ortiz wrote: Hi Ricardo/all I finally got around to ca

Re: [PATCH 2/4] usb: dwc3: gadget: Stop TRB preparation after limit is reached

2014-12-29 Thread Felipe Balbi
Hi, On Mon, Dec 29, 2014 at 12:05:57PM +0530, Amit Virdi wrote: > >> >> When SG is used, there are two loops iterating to prepare TRBs: > >> >> - Outer loop over the request_list > >> >> - Inner loop over the SG list > >> >> > >> >> The driver must stop preparing TRBs when the max TRBs have been

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-29 Thread Felipe Balbi
On Mon, Dec 29, 2014 at 08:30:04AM +0100, Robert Baldyga wrote: > Hi Felipe, > > On 12/23/2014 07:31 PM, Felipe Balbi wrote: > > On Tue, Dec 23, 2014 at 07:34:15AM +0100, Robert Baldyga wrote: > >> On 12/22/2014 05:34 PM, Felipe Balbi wrote: > >>> On Mon, Dec 15, 2014 at 11:05:22AM +0100, Robert B

Re: net2280: tracing

2014-12-29 Thread Felipe Balbi
Hi, On Sun, Dec 28, 2014 at 07:28:33PM -0500, Jorge Ramirez-Ortiz wrote: > On 12/28/2014 11:39 AM, Felipe Balbi wrote: > > On Sat, Dec 27, 2014 at 05:33:36PM -0500, Jorge Ramirez-Ortiz wrote: > >> Hi Ricardo/all > >> > >> I finally got around to capture a trace of a SS bulk transfer using the > >

Re: [PATCH v2 0/3] usb: chipidea: add one errata for revision 2.40a

2014-12-29 Thread Stefan Agner
On 2014-12-29 09:39, Peter Chen wrote: > Hi all, > > At the first two patches, I add identification registers APIs, we can get > controller's revision by using this APIs. Since I don't have enough spec, > if there are any errors, tell me. > > At the third patch, Sanchayan Maity implemented an err

Re: [PATCH 2/3] usb: dwc3: add Fujitsu Specific Glue layer

2014-12-29 Thread Felipe Balbi
Hi, On Mon, Dec 29, 2014 at 01:52:04AM +0800, Sneeker Yeh wrote: > Hi, > > 2014-12-22 23:59 GMT+08:00 Felipe Balbi : > > > Hi, > > > > On Tue, Dec 16, 2014 at 10:10:27AM +0800, Sneeker Yeh wrote: > > > This patch adds support for Synopsis DesignWare USB3 IP Core found > > > on Fujitsu Socs. > >

Re: [PATCH 3/3] usb: dwc3: add a quirk for device disconnection issue in Synopsis dwc3 core

2014-12-29 Thread Felipe Balbi
Hi, On Mon, Dec 29, 2014 at 04:07:50PM +0800, Sneeker Yeh wrote: > Hi, > > 2014-12-29 14:41 GMT+08:00 Sneeker Yeh : > > > Hi, > > > > 2014-12-22 23:37 GMT+08:00 Felipe Balbi : > > > >> On Tue, Dec 16, 2014 at 10:10:28AM +0800, Sneeker Yeh wrote: > >> > Synopsis DesignWare USB3 IP Core integrated

Re: [PATCH] usb-storage/SCSI: blacklist FUA on JMicron 152d:2566 USB-SATA controller

2014-12-29 Thread Dmitry Nezhevenko
It looks like FUA support is broken on JMicron 152d:2566 bridge: [223159.885704] sd 7:0:0:0: [sdc] Write Protect is off [223159.885706] sd 7:0:0:0: [sdc] Mode Sense: 47 00 10 08 [223159.885942] sd 7:0:0:0: [sdc] Write cache: enabled, read cache: enabled, supports DPO and FUA [223283.691677] sd 7

Re: [PATCH v2 05/22] usb: isp1760: Merge platform and OF glue codes

2014-12-29 Thread Felipe Balbi
Hi, On Mon, Dec 29, 2014 at 10:20:20AM +0200, Laurent Pinchart wrote: > > > > Both handle platform devices, merge them. > > > > > > > > Signed-off-by: Laurent Pinchart > > > > > > doesn't apply: > > > > > > checking file drivers/usb/host/isp1760-if.c > > > Hunk #1 FAILED at 12. > > > Hunk #2 s

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-29 Thread Felipe Balbi
Hi, On Mon, Dec 29, 2014 at 05:42:01PM +0800, Wu, Songjun wrote: > > > On 12/26/2014 23:27, Felipe Balbi wrote: > >Hi, > > > >On Wed, Dec 24, 2014 at 09:14:53AM +0800, Wu, Songjun wrote: > >> > >>在 12/24/2014 00:24, Felipe Balbi 写道: > >>>On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote

Re: [PATCH] usb-storage/SCSI: blacklist FUA on JMicron 152d:2566 USB-SATA controller

2014-12-29 Thread Alan Stern
On Mon, 29 Dec 2014, Dmitry Nezhevenko wrote: > It looks like FUA support is broken on JMicron 152d:2566 bridge: > > [223159.885704] sd 7:0:0:0: [sdc] Write Protect is off > [223159.885706] sd 7:0:0:0: [sdc] Mode Sense: 47 00 10 08 > [223159.885942] sd 7:0:0:0: [sdc] Write cache: enabled, read ca

Re: [PATCH 1/1] usb: chipidea: host: add .bus_suspend quirk

2014-12-29 Thread Alan Stern
On Mon, 29 Dec 2014, Peter Chen wrote: > For chipidea, its resume sequence is not-EHCI compatible, see > below description for FPR at portsc. So in order to send SoF in > time for remote wakeup sequence(within 3ms), the RUN/STOP bit must > be set before the resume signal is ended. > > Force Port

Re: [PATCH] cleanup on stack DECLARE_COMPLETIONs

2014-12-29 Thread Dimitri Sivanich
On Tue, Dec 23, 2014 at 06:34:08PM +0100, Nicholas Mc Guire wrote: > fixups for incorrect use of DECLARE_COMPLETION. see also commit > 6e9a4738 ("completions: lockdep annotate on stack completions") > The only somewhat special case being > drivers/misc/sgi-gru/grukservices.c:quicktest2 > which had

Re: Strange behaviour...

2014-12-29 Thread gianluca
On 12/25/2014 03:55 AM, Peter Chen wrote: On Wed, Dec 24, 2014 at 01:51:32PM +0100, gianluca wrote: On 12/23/2014 01:12 AM, Peter Chen wrote: Ok, then just try to get the working version, and find the difference. >From my mind, it should be PLL related. Here I am again ;-) The following log

[PATCH v1] USB: use %*ph specifier in mikrotek driver

2014-12-29 Thread Andy Shevchenko
There is a %*ph specifier that allows to dump small buffers. This patch converts the code to use the specifier. Signed-off-by: Andy Shevchenko --- drivers/usb/image/microtek.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/image/microtek.c b/drivers/usb/image/

[PATCH v1] USB: use %*ph specifier in uss720 driver

2014-12-29 Thread Andy Shevchenko
There is a %*ph specifier that allows to dump small buffers. This patch converts the code to use the specifier. Signed-off-by: Andy Shevchenko --- drivers/usb/misc/uss720.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/mi

[PATCH] usb-storage/SCSI: blacklist FUA on JMicron 152d:2566 USB-SATA controller

2014-12-29 Thread Dmitry Nezhevenko
It looks like FUA support is broken on JMicron 152d:2566 bridge: [223159.885704] sd 7:0:0:0: [sdc] Write Protect is off [223159.885706] sd 7:0:0:0: [sdc] Mode Sense: 47 00 10 08 [223159.885942] sd 7:0:0:0: [sdc] Write cache: enabled, read cache: enabled, supports DPO and FUA [223283.691677] sd 7

Re: [PATCH] hid: Add a new id 0x501a for Genius MousePen i608X

2014-12-29 Thread Jiri Kosina
On Sat, 27 Dec 2014, Giedrius Statkevičius wrote: > New Genius MousePen i608X devices have a new id 0x501a instead of the > old 0x5011 so add a new #define with "_2" appended and change required > places. > > The remaining two checkpatch warnings about line length > being over 80 characters are p

[PATCH v2 3/3] usb: chipidea: Add errata for revision 2.40a

2014-12-29 Thread Peter Chen
From: Sanchayan Maity At chipidea revision 2.40a, there is a below errata: 9000531823 B2-Medium Adding a dTD to a Primed Endpoint May Not Get Recognized Title: Adding a dTD to a Primed Endpoint May Not Get Recognized Impacted Configuration: All device mode configurations. Description: There

[PATCH v2 2/3] usb: chipidea: add chipidea revision information

2014-12-29 Thread Peter Chen
Define ci_get_revision API to know the controller revision information according to chipidea 1.1a, 2.0a and 2.5a spec. Besides, add one entry at struct ci_hdrc to indicate revision information, it can be used for adding different code for revisions, eg kinds of errata. Signed-off-by: Peter Chen -

[PATCH v2 0/3] usb: chipidea: add one errata for revision 2.40a

2014-12-29 Thread Peter Chen
Hi all, At the first two patches, I add identification registers APIs, we can get controller's revision by using this APIs. Since I don't have enough spec, if there are any errors, tell me. At the third patch, Sanchayan Maity implemented an errata (Adding a dTD to a Primed Endpoint May Not Get Re

[PATCH v2 1/3] usb: chipidea: add identification registers access APIs

2014-12-29 Thread Peter Chen
Using hw_write_id_reg and hw_read_id_reg to write and read identification registers contents, they can be used to get controller information, change some system configurations, and so on. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci.h | 39 +++ 1 file

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-29 Thread Wu, Songjun
On 12/26/2014 23:27, Felipe Balbi wrote: Hi, On Wed, Dec 24, 2014 at 09:14:53AM +0800, Wu, Songjun wrote: 在 12/24/2014 00:24, Felipe Balbi 写道: On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: When unloading the module, the urb request will be dequeued and the completion routine

[PATCH 1/1] usb: chipidea: host: add .bus_suspend quirk

2014-12-29 Thread Peter Chen
For chipidea, its resume sequence is not-EHCI compatible, see below description for FPR at portsc. So in order to send SoF in time for remote wakeup sequence(within 3ms), the RUN/STOP bit must be set before the resume signal is ended. Force Port Resume - RW. Default = 0b. 1= Resume detected/driven

Re: [PATCH v2 05/22] usb: isp1760: Merge platform and OF glue codes

2014-12-29 Thread Laurent Pinchart
Hi Felipe, On Tuesday 23 December 2014 18:40:13 Felipe Balbi wrote: > On Tue, Dec 23, 2014 at 12:47:42PM -0600, Felipe Balbi wrote: > > On Mon, Dec 01, 2014 at 09:47:06PM +0200, Laurent Pinchart wrote: > > > Both handle platform devices, merge them. > > > > > > Signed-off-by: Laurent Pinchart >