[patch 4/6] usb: gadget: uvc: memory leak in uvcg_frame_make()

2015-01-14 Thread Dan Carpenter
We need to add a kfree(h) on an error path. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/usb/gadget/function/uvc_configfs.c b/drivers/usb/gadget/function/uvc_configfs.c index 738d68f..1af2686 100644 --- a/drivers/usb/gadget/function/uvc_configfs.c +++

Re: [PATCH 08/12] usb: gadget: at91_udc: Remove non-DT handling code

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 07:35:16PM +0100, Alexandre Belloni wrote: On 14/01/2015 at 11:38:12 -0600, Felipe Balbi wrote : On Wed, Jan 14, 2015 at 05:22:00PM +0100, Alexandre Belloni wrote: From: Boris Brezillon boris.brezil...@free-electrons.com Since non-DT board support has been

[patch 5/6] usb: gadget: uvc: make a bunch of stuff static

2015-01-14 Thread Dan Carpenter
Sparse rightly complains that these things should be static since they are only used in the one .c file. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/usb/gadget/function/uvc_configfs.c b/drivers/usb/gadget/function/uvc_configfs.c index 1af2686..a0443a2 100644 ---

Re: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 07:45:31AM +0100, Robert Baldyga wrote: This patch fixes bug described here: https://lkml.org/lkml/2014/12/22/185 Signed-off-by: Robert Baldyga r.bald...@samsung.com --- Changelog: v2: - fixed comment from Paul Zimmerman v1:

Re: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Felipe Balbi
Hi, On Wed, Jan 14, 2015 at 03:06:39PM -0500, Alan Stern wrote: This patch fixes bug described here: https://lkml.org/lkml/2014/12/22/185 Signed-off-by: Robert Baldyga r.bald...@samsung.com --- Changelog: v2: - fixed comment from Paul Zimmerman v1:

Re: Looking for hire a developer to resolve en issue with xHCI and Lego robotic kit.

2015-01-14 Thread Greg KH
On Wed, Jan 14, 2015 at 03:17:28PM -0200, Gustavo Duarte wrote: Hi guys, first I apologize if the topic of this email isn't proper for this list. First a short background. I work for an Uruguayan governmental organization called Plan Ceibal, http://en.wikipedia.org/wiki/Ceibal_project.

[patch 1/6] usb: gadget: uvc: fix some error codes

2015-01-14 Thread Dan Carpenter
We're basically saying ERR_CAST(NULL) and PTR_ERR(NULL) here, which is nonsensical. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/usb/gadget/function/uvc_configfs.c b/drivers/usb/gadget/function/uvc_configfs.c index 33d92ab..d112c99 100644 ---

Re: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Alan Stern
On Wed, 14 Jan 2015, Felipe Balbi wrote: This is really, really odd. Register accesses are atomic, so the lock isn't really doing anything. Besides, you're calling dwc2_is_controller_alive() from within the IRQ handler, so IRQs are already disabled. Spinlocks sometimes do more

Re: [PATCH net-next] r8152: replace tasklet with NAPI

2015-01-14 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Mon, 12 Jan 2015 12:06:23 +0800 Replace tasklet with NAPI. Add rx_queue to queue the remaining rx packets if the number of the rx packets is more than the request from poll(). Signed-off-by: Hayes Wang hayesw...@realtek.com Applied, thanks. --

Re: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Alan Stern
On Wed, 14 Jan 2015, Felipe Balbi wrote: On Wed, Jan 14, 2015 at 07:45:31AM +0100, Robert Baldyga wrote: This patch fixes bug described here: https://lkml.org/lkml/2014/12/22/185 Signed-off-by: Robert Baldyga r.bald...@samsung.com --- Changelog: v2: - fixed comment from

[patch 2/6] usb: gadget: uvc: cleanup __uvcg_fill_strm()

2015-01-14 Thread Dan Carpenter
Static checkers complain about this API: drivers/usb/gadget/function/uvc_configfs.c:2139 uvcg_streaming_class_allow_link() warn: did you really mean to pass the address of 'data'? Indeed, the code is cleaner when we just pass the pointer instead of the pointer to

[patch 3/6] usb: gadget: uvc: remove an impossible condition

2015-01-14 Thread Dan Carpenter
num is a u32 so (num 0x) is never true. Also the range is already checked in kstrtou32(). Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/usb/gadget/function/uvc_configfs.c b/drivers/usb/gadget/function/uvc_configfs.c index 2bd0688..738d68f 100644 ---

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
From: Robert Baldyga [mailto:r.bald...@samsung.com] Sent: Tuesday, January 13, 2015 10:46 PM This patch fixes bug described here: https://lkml.org/lkml/2014/12/22/185 Signed-off-by: Robert Baldyga r.bald...@samsung.com Although I don't understand *why* this fixes Robert's issue, it's

Re: [GIT PULL] USB patches

2015-01-14 Thread Greg KH
On Wed, Jan 14, 2015 at 11:48:39AM -0600, Felipe Balbi wrote: Hi Greg, Alright, 3 more fixes for v3.19-rc and my queue is finally clean. All three fixes are rather obvious, two of them just took longer to sort out all the stable rules details and I ended up having to fix all that,

Re: [patch 5/6] usb: gadget: uvc: make a bunch of stuff static

2015-01-14 Thread Felipe Balbi
On Thu, Jan 15, 2015 at 12:03:52AM +0300, Dan Carpenter wrote: Sparse rightly complains that these things should be static since they are only used in the one .c file. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com fails to apply on top of my testing/next checking file

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 2:40 PM On Wed, Jan 14, 2015 at 10:28:54PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 1:46 PM On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan

Fatal Exception on device when Hotsyncing Palm in linux

2015-01-14 Thread Henri Manson
I own a Palm m505 and a while ago a developed programs using SuperWaba and uploaded them using pilot-xfer. Using Ubuntu 14.04 I tried Hotsyncing on the device but now the devices shows a dialog box containing 'Fatal Exception' and then hangs. I figured out using VirtualBox and old Ubuntu ISO

Re: Fatal Exception on device when Hotsyncing Palm in linux

2015-01-14 Thread Greg KH
On Thu, Jan 15, 2015 at 12:00:28AM +0100, Henri Manson wrote: I own a Palm m505 and a while ago a developed programs using SuperWaba and uploaded them using pilot-xfer. Using Ubuntu 14.04 I tried Hotsyncing on the device but now the devices shows a dialog box containing 'Fatal Exception' and

Re: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Felipe Balbi
Hi, On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan Stern wrote: This is really, really odd. Register accesses are atomic, so the lock isn't really doing anything. Besides, you're calling dwc2_is_controller_alive() from within the IRQ handler, so IRQs are already disabled.

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 1:46 PM On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan Stern wrote: This is really, really odd. Register accesses are atomic, so the lock isn't really doing anything. Besides, you're calling

Re: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 10:28:54PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 1:46 PM On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan Stern wrote: This is really, really odd. Register accesses are atomic, so the lock

Re: USB-serial fixes for v3.19-rc5

2015-01-14 Thread Greg Kroah-Hartman
On Wed, Jan 14, 2015 at 09:49:56AM +0100, Johan Hovold wrote: Hi Greg, Here's my first set of fixes for 3.19, somewhat late partially due to the holidays. Please pull. Thanks, Johan The following changes since commit b7392d2247cfe6771f95d256374f1a8e6a6f48d6: Linux 3.19-rc2

Re: Looking for hire a developer to resolve en issue with xHCI and Lego robotic kit.

2015-01-14 Thread Gustavo Duarte
Hi Greg, m, I'm sure that yes, I sent a response on Jan 7 to the list. I'll forward the e-mail stored on my sent try. Gustavo. On Wed, Jan 14, 2015 at 6:31 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jan 14, 2015 at 03:17:28PM -0200, Gustavo Duarte wrote: Hi guys, first I

Re: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 04:39:41PM -0600, Felipe Balbi wrote: On Wed, Jan 14, 2015 at 10:28:54PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 1:46 PM On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan Stern wrote: This is

Re: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Felipe Balbi
Hi, On Wed, Jan 14, 2015 at 10:45:26PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 2:40 PM On Wed, Jan 14, 2015 at 10:28:54PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 2:50 PM On Wed, Jan 14, 2015 at 10:45:26PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Wednesday, January 14, 2015 2:40 PM On Wed, Jan 14, 2015 at 10:28:54PM +, Paul

[PATCH] usb: Fix typo in `struct usb_host_interface' comment

2015-01-14 Thread Chris Rorvick
The descriptor member `bNumEndpoints' is plural. Signed-off-by: Chris Rorvick ch...@rorvick.com --- include/linux/usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/usb.h b/include/linux/usb.h index f89c24a..4add566 100644 --- a/include/linux/usb.h +++

[patch 6/6] usb: gadget: uvc: cleanup UVCG_FRAME_ATTR macro

2015-01-14 Thread Dan Carpenter
1) Change conv an vnoc to to_cpu_endian to to_little_endian. 2) No need to check the limit because that is already handled in kstrtoXX so delete that parameter along with the check. 3) By using a bits parameter, we can combine the uxx parameter and the str2u parameters. 4) The

[PATCH] usb: phy: make GPIOs optional for the generic phy

2015-01-14 Thread Paul Zimmerman
From 47bd18e210fecf701d493c27884e13c69bc449ea Mon Sep 17 00:00:00 2001 From: Paul Zimmerman pa...@synopsys.com Date: Wed, 14 Jan 2015 18:15:58 -0800 Subject: [PATCH] usb: phy: make GPIOs optional for the generic phy The use of GPIOs should be optional for the generic phy, otherwise the Altera

Re: [PATCH] uwb: Fix for coding style errors in address.c

2015-01-14 Thread Greg KH
On Thu, Jan 15, 2015 at 09:30:32AM +0530, Asheesh Ranjan wrote: Fixes for many warnings and errors as reported by checkpatch.pl what warnings and errors? If there are different types of things being fixed, then they need to be in different patches, one per thing you are doing. Please fix up

[PATCH] uwb: Fix for coding style errors in address.c

2015-01-14 Thread Asheesh Ranjan
Fixes for many warnings and errors as reported by checkpatch.pl Signed-off-by: Asheesh Ranjan asheesh@outlook.com --- drivers/uwb/address.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/uwb/address.c b/drivers/uwb/address.c index

Re: [PATCH v2 2/3] usb: phy: add lubbock phy driver

2015-01-14 Thread Dmitry Eremin-Solenikov
Hello, 2015-01-13 9:10 GMT+03:00 Kishon Vijay Abraham I kis...@ti.com: Hi, On Tuesday 13 January 2015 03:21 AM, Felipe Balbi wrote: On Sun, Jan 11, 2015 at 10:44:59PM +0400, Dmitry Eremin-Solenikov wrote: Hello, 2015-01-08 19:58 GMT+03:00 Felipe Balbi ba...@ti.com: On Sun, Nov 30, 2014 at

Re: BUG: xhci_queue_new_dequeue_state dereference a NULL pointer

2015-01-14 Thread c-aries
Thanks Mathias. I read the patch, it fixes my problem. 2015-01-14 19:19 GMT+08:00 Mathias Nyman mathias.ny...@linux.intel.com: Hi On 14.01.2015 08:04, c-aries wrote: I have an x86 PC, it oops, and I took a screenshot: http://babyaries.org/mirror/picture/2015-01-13-165845_1600x900_scrot.png

[PATCH 1/4] cdc-acm: add sanity checks

2015-01-14 Thread Oliver Neukum
Check the special CDC headers for a plausible minimum length. Another big operating systems ignores such garbage. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/class/cdc-acm.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git

RE: [PATCH] usb/musb: debugfs, fix copy_from_user argument

2015-01-14 Thread David Laight
From: Markus Pargmann The first arugment has to be a pointer to the memory. buf is a char array and already a pointer itself. The current code passes a pointer to a char array to copy_from_user() which is not correct. It doesn't matter, while the type of the argument is subtly different the

[PATCH] usb/musb: debugfs, fix copy_from_user argument

2015-01-14 Thread Markus Pargmann
The first arugment has to be a pointer to the memory. buf is a char array and already a pointer itself. The current code passes a pointer to a char array to copy_from_user() which is not correct. Signed-off-by: Markus Pargmann m...@pengutronix.de --- drivers/usb/musb/musb_debugfs.c | 2 +- 1

Re: [PATCH] Added PIDs for Actisense USB Devices

2015-01-14 Thread Peter Stuge
Mark Glover wrote: From: Mark Glover m...@actisense.com Signed-off-by: Mark Glover m...@actisense.com There's an extraneous leading whitespace on the Signed-off-by line. +#define CHETCO_SEASWITCH_PID 0xA549 /* SeaSwitch USB Apadter */ The typo remains. Apadter here

[PATCH 2/4] cdc-wdm: add sanity checks

2015-01-14 Thread Oliver Neukum
Check the CDC headers for elements with insufficient length. Other popular operating systems filter then, too. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/class/cdc-wdm.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/usb/class/cdc-wdm.c

[PATCH 3/4] cdc-acm: kill unnecessary messages

2015-01-14 Thread Oliver Neukum
Memory allocation failures are reported by a central facility. No need to repeat the job. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/class/cdc-acm.c | 33 + 1 file changed, 9 insertions(+), 24 deletions(-) diff --git

Re: [PATCH 2/4] usb: dwc3: gadget: Stop TRB preparation after limit is reached

2015-01-14 Thread Greg KH
On Wed, Jan 14, 2015 at 02:39:55PM +0530, Amit Virdi wrote: Alright, I just applied your patches to testing/fixes. I'll start testing today and should be able to send a pull request to Greg by the end of the week, hopefully. Thanks! Just a small clarification - git failed to send patches

dwc3 gadget fails on dra7-evm

2015-01-14 Thread Roger Quadros
Hi, In 3.19-rc4 on dra7-evm or dra72-evm modprobe g_zero [ 34.680683] zero gadget: Gadget Zero, version: Cinco de Mayo 2008 [ 34.687074] zero gadget: zero ready [ 34.694133] dwc3 4889.usb: failed to enable ep0out [ 34.701600] zero 4889.usb: failed to start zero: -110 ERROR: could

Re: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Felipe Balbi
Hi, On Wed, Jan 14, 2015 at 11:04:27PM +, Paul Zimmerman wrote: This is really, really odd. Register accesses are atomic, so the lock isn't really doing anything. Besides, you're calling dwc2_is_controller_alive() from within the IRQ handler, so

[PATCH 05/12] usb: gadget: at91_udc: Fix clock names

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon boris.brezil...@free-electrons.com The driver is requesting clock by their global name (those declared in the clk_lookup list), but this only works with !CCF kernels. Now that all SoCs have moved to CCF, fix the driver to use local names (hclk and pclk). Signed-off-by:

[PATCH 01/12] mfd: syscon: Add atmel-matrix registers definition

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon boris.brezil...@free-electrons.com AT91 SoCs have a memory range reserved for internal bus configuration. Expose those registers so that drivers can make use of the matrix syscon declared in at91 DTs. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com

[PATCH 04/12] mfd: syscon: Add Atmel SMC binding doc

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon boris.brezil...@free-electrons.com The SMC registers are used to configure Atmel EBI (External Bus Interface) to interface with standard memory devices (NAND, NOR, SRAM or specialized devices like FPGAs). Declare this memory region as a syscon, so that different drivers can

[PATCH 08/12] usb: gadget: at91_udc: Remove non-DT handling code

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon boris.brezil...@free-electrons.com Since non-DT board support has been removed from the at91 architecture we can safely remove non-DT handling code. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/gadget/udc/Kconfig| 1 +

[PATCH 02/12] mfd: syscon: Add Atmel Matrix bus DT binding documentation

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon boris.brezil...@free-electrons.com The Matrix registers are provided to configure internal bus behavior on at91 SoCs. Some registers might be accessed by several drivers (e.g. to configure external memory bus timings), hence we declare this register set as a syscon device.

[PATCH 06/12] usb: gadget: at91_udc: Drop uclk clock

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon boris.brezil...@free-electrons.com Now that at91 system clocks forward set_rate request to their parent we can remove the uclk clock and directly call clk_set_rate on fclk. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com ---

[PATCH 07/12] usb: gadget: at91_udc: Document DT clocks and clock-names property

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon boris.brezil...@free-electrons.com The at91_udc driver request 2 clocks, and thus need them to be defined in the device tree. Document the clocks and clock-names properties so that everybody use the correct names. Signed-off-by: Boris Brezillon

[PATCH 10/12] usb: gadget: at91_udc: Rework for multi-platform kernel support

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon boris.brezil...@free-electrons.com cpu_is_at91xxx are a set of macros defined in mach/cpu.h and are here used to detect the SoC we are booting on. Use compatible string + a caps structure to replace those cpu_is_xxx tests. Remove all mach and asm headers (which are now

[PATCH 09/12] usb: gadget: at91_udc: Simplify probe and remove functions

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon boris.brezil...@free-electrons.com Make use of devm_ functions to simplify probe and remove code. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/gadget/udc/at91_udc.c | 116 +- 1 file changed, 39

[PATCH 03/12] mfd: syscon: Add atmel-smc registers definition

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon boris.brezil...@free-electrons.com Atmel AT91 SoCs have a memory range reserved for SMC (Static Memory Controller) configuration. Expose those registers so that drivers can make use of the smc syscon declared in at91 DTs. Signed-off-by: Boris Brezillon

Re: [PATCH] usb/musb: debugfs, fix copy_from_user argument

2015-01-14 Thread 'Markus Pargmann'
Hi, On Wed, Jan 14, 2015 at 03:19:42PM +, David Laight wrote: From: Markus Pargmann The first arugment has to be a pointer to the memory. buf is a char array and already a pointer itself. The current code passes a pointer to a char array to copy_from_user() which is not correct. It

[PATCH 12/12] usb: gadget: at91_udc: Allocate udc instance

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon boris.brezil...@free-electrons.com Allocate udc structure instead of relying on the statically declared object. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/gadget/udc/at91_udc.c | 96 +++ 1 file

[PATCH 11/12] usb: gadget: at91_udc: Update DT binding documentation

2015-01-14 Thread Alexandre Belloni
From: Boris Brezillon boris.brezil...@free-electrons.com Three compatible strings have been added to the at91_udc driver. Update the documentation accordingly. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- Documentation/devicetree/bindings/usb/atmel-usb.txt | 6 +- 1

[PATCH 00/12] Atmel matrix, SMC and UDC rework

2015-01-14 Thread Alexandre Belloni
Hi Felipe, The following series replace the previous series sent by Boris named: - [PATCH v5 00/11] memory: add Atmel EBI (External Bus Interface) driver - [PATCH 00/11] usb: gadget: at91_udc: Rework for multi-platform support The patches I left out are less urgent and will be resent later,

[GIT PULL] USB patches

2015-01-14 Thread Felipe Balbi
Hi Greg, Alright, 3 more fixes for v3.19-rc and my queue is finally clean. All three fixes are rather obvious, two of them just took longer to sort out all the stable rules details and I ended up having to fix all that, otherwise we would miss the time frame. Please condiser merging to your

Re: [PATCH] usb/musb: debugfs, fix copy_from_user argument

2015-01-14 Thread 'Markus Pargmann'
Hi, On Wed, Jan 14, 2015 at 11:08:12AM -0600, Felipe Balbi wrote: On Wed, Jan 14, 2015 at 05:12:55PM +0100, 'Markus Pargmann' wrote: Hi, On Wed, Jan 14, 2015 at 03:19:42PM +, David Laight wrote: From: Markus Pargmann The first arugment has to be a pointer to the memory. buf is

Re: [PATCH] usb/musb: debugfs, fix copy_from_user argument

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 05:12:55PM +0100, 'Markus Pargmann' wrote: Hi, On Wed, Jan 14, 2015 at 03:19:42PM +, David Laight wrote: From: Markus Pargmann The first arugment has to be a pointer to the memory. buf is a char array and already a pointer itself. The current code passes a

Looking for hire a developer to resolve en issue with xHCI and Lego robotic kit.

2015-01-14 Thread Gustavo Duarte
Hi guys, first I apologize if the topic of this email isn't proper for this list. First a short background. I work for an Uruguayan governmental organization called Plan Ceibal, http://en.wikipedia.org/wiki/Ceibal_project. Since the last two years Ceibal have been adding a new Robotic area to

Re: [RESEND PATCH 1/2] usb: dwc3: gadget: Fix TRB preparation during SG

2015-01-14 Thread Sergei Shtylyov
Hello. On 01/14/2015 08:04 PM, Felipe Balbi wrote: From: Amit Virdi amit.vi...@st.com When scatter gather (SG) is used, multiple TRBs are prepared from one DWC3 request (dwc3_request). So while preparing TRBs, the 'last' flag should be set only when it is the last TRB being prepared from

Re: [PATCH 05/12] usb: gadget: at91_udc: Fix clock names

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 05:21:57PM +0100, Alexandre Belloni wrote: From: Boris Brezillon boris.brezil...@free-electrons.com The driver is requesting clock by their global name (those declared in the clk_lookup list), but this only works with !CCF kernels. Now that all SoCs have moved to

Re: [PATCH 06/12] usb: gadget: at91_udc: Drop uclk clock

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 05:21:58PM +0100, Alexandre Belloni wrote: From: Boris Brezillon boris.brezil...@free-electrons.com Now that at91 system clocks forward set_rate request to their parent we can remove the uclk clock and directly call clk_set_rate on fclk. Signed-off-by: Boris

Re: [PATCH 08/12] usb: gadget: at91_udc: Remove non-DT handling code

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 05:22:00PM +0100, Alexandre Belloni wrote: From: Boris Brezillon boris.brezil...@free-electrons.com Since non-DT board support has been removed from the at91 architecture we can safely remove non-DT handling code. Signed-off-by: Boris Brezillon

Re: dwc3 gadget fails on dra7-evm

2015-01-14 Thread Felipe Balbi
Hi, On Wed, Jan 14, 2015 at 05:44:08PM +0200, Roger Quadros wrote: In 3.19-rc4 on dra7-evm or dra72-evm modprobe g_zero [ 34.680683] zero gadget: Gadget Zero, version: Cinco de Mayo 2008 [ 34.687074] zero gadget: zero ready [ 34.694133] dwc3 4889.usb: failed to enable ep0out [

[RESEND PATCH 2/2] usb: dwc3: gadget: Stop TRB preparation after limit is reached

2015-01-14 Thread Felipe Balbi
From: Amit Virdi amit.vi...@st.com DWC3 gadget sets up a pool of 32 TRBs for each EP during initialization. This means, the max TRBs that can be submitted for an EP is fixed to 32. Since the request queue for an EP is a linked list, any number of requests can be queued to it by the gadget layer.

Re: [PATCH 3/3] usb: dwc3: add a quirk for device disconnection issue in Synopsis dwc3 core

2015-01-14 Thread Felipe Balbi
Hi, On Wed, Jan 14, 2015 at 03:08:43PM +0800, Sneeker Yeh wrote: Hi Felipe: thanks for suggestion, 2015-01-13 1:20 GMT+08:00 Felipe Balbi ba...@ti.com: Hi, On Sun, Jan 11, 2015 at 11:19:55PM +0800, Sneeker Yeh wrote: enable the quirk only for you. Isn't there a better way of

[RESEND PATCH 1/2] usb: dwc3: gadget: Fix TRB preparation during SG

2015-01-14 Thread Felipe Balbi
From: Amit Virdi amit.vi...@st.com When scatter gather (SG) is used, multiple TRBs are prepared from one DWC3 request (dwc3_request). So while preparing TRBs, the 'last' flag should be set only when it is the last TRB being prepared from the last dwc3_request entry. The current implementation

Re: [RESEND PATCH 1/2] usb: dwc3: gadget: Fix TRB preparation during SG

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 08:20:19PM +0300, Sergei Shtylyov wrote: Hello. On 01/14/2015 08:04 PM, Felipe Balbi wrote: From: Amit Virdi amit.vi...@st.com When scatter gather (SG) is used, multiple TRBs are prepared from one DWC3 request (dwc3_request). So while preparing TRBs, the 'last'

Re: [PATCH 10/12] usb: gadget: at91_udc: Rework for multi-platform kernel support

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 05:22:02PM +0100, Alexandre Belloni wrote: From: Boris Brezillon boris.brezil...@free-electrons.com cpu_is_at91xxx are a set of macros defined in mach/cpu.h and are here used to detect the SoC we are booting on. Use compatible string + a caps structure to replace

[PATCH 1/2] usb: dwc3: gadget: Fix TRB preparation during SG

2015-01-14 Thread Felipe Balbi
From: Amit Virdi amit.vi...@st.com When scatter gather (SG) is used, multiple TRBs are prepared from one DWC3 request (dwc3_request). So while preparing TRBs, the 'last' flag should be set only when it is the last TRB being prepared from the last dwc3_request entry. The current implementation

[PATCH 2/2] usb: dwc3: gadget: Stop TRB preparation after limit is reached

2015-01-14 Thread Felipe Balbi
From: Amit Virdi amit.vi...@st.com DWC3 gadget sets up a pool of 32 TRBs for each EP during initialization. This means, the max TRBs that can be submitted for an EP is fixed to 32. Since the request queue for an EP is a linked list, any number of requests can be queued to it by the gadget layer.

Re: [PATCH 12/12] usb: gadget: at91_udc: Allocate udc instance

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 05:22:04PM +0100, Alexandre Belloni wrote: From: Boris Brezillon boris.brezil...@free-electrons.com Allocate udc structure instead of relying on the statically declared object. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Felipe Balbi

Re: [PATCH 09/12] usb: gadget: at91_udc: Simplify probe and remove functions

2015-01-14 Thread Felipe Balbi
On Wed, Jan 14, 2015 at 05:22:01PM +0100, Alexandre Belloni wrote: From: Boris Brezillon boris.brezil...@free-electrons.com Make use of devm_ functions to simplify probe and remove code. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Felipe Balbi ba...@ti.com

Re: [PATCH 08/12] usb: gadget: at91_udc: Remove non-DT handling code

2015-01-14 Thread Alexandre Belloni
On 14/01/2015 at 11:38:12 -0600, Felipe Balbi wrote : On Wed, Jan 14, 2015 at 05:22:00PM +0100, Alexandre Belloni wrote: From: Boris Brezillon boris.brezil...@free-electrons.com Since non-DT board support has been removed from the at91 architecture we can safely remove non-DT handling

USB-serial fixes for v3.19-rc5

2015-01-14 Thread Johan Hovold
Hi Greg, Here's my first set of fixes for 3.19, somewhat late partially due to the holidays. Please pull. Thanks, Johan The following changes since commit b7392d2247cfe6771f95d256374f1a8e6a6f48d6: Linux 3.19-rc2 (2014-12-28 16:49:37 -0800) are available in the git repository at:

Re: [PATCH 2/4] usb: dwc3: gadget: Stop TRB preparation after limit is reached

2015-01-14 Thread Amit Virdi
Alright, I just applied your patches to testing/fixes. I'll start testing today and should be able to send a pull request to Greg by the end of the week, hopefully. Thanks! Just a small clarification - git failed to send patches to stable kernel list again (unfortunately I used the older

Re: [Bug 90941] xhci_hcd 0000:00:14.0: Setup ERROR: setup context command for slot 1.

2015-01-14 Thread Mathias Nyman
On 08.01.2015 02:02, Cristian wrote: Hello Gurus, See message of dmesg: [ 5136.529349] xhci_hcd :00:14.0: Setup ERROR: setup context command for slot 1. [ 5136.529351] usb 1-1: hub failed to enable device, error -22 [ 5136.788988] usb 1-1: reset low-speed USB device number 2 using

Re: BUG: xhci_queue_new_dequeue_state dereference a NULL pointer

2015-01-14 Thread Mathias Nyman
Hi On 14.01.2015 08:04, c-aries wrote: I have an x86 PC, it oops, and I took a screenshot: http://babyaries.org/mirror/picture/2015-01-13-165845_1600x900_scrot.png Then I browsed the xhci source code, compared with the oops machine code:

[PATCH] Added PIDs for Actisense USB Devices Signed-off-by: Mark Glover m...@actisense.com

2015-01-14 Thread Mark Glover
From: Mark Glover m...@actisense.com --- drivers/usb/serial/ftdi_sio.c | 17 + drivers/usb/serial/ftdi_sio_ids.h | 21 + 2 files changed, 38 insertions(+) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index

Re: [PATCH] Added PIDs for Actisense USB Devices Signed-off-by: Mark Glover m...@actisense.com

2015-01-14 Thread Peter Stuge
Please update your commit message to leave one blank line between the commit message summary and the rest of the message. (This avoids your signed-off-by ending up in the email subject.) Mark Glover wrote: +++ b/drivers/usb/serial/ftdi_sio_ids.h .. +#define CHETCO_SEAGAUGE_PID 0xA548

[PATCH] Added PIDs for Actisense USB Devices

2015-01-14 Thread Mark Glover
From: Mark Glover m...@actisense.com Signed-off-by: Mark Glover m...@actisense.com --- drivers/usb/serial/ftdi_sio.c | 17 + drivers/usb/serial/ftdi_sio_ids.h | 21 + 2 files changed, 38 insertions(+) diff --git a/drivers/usb/serial/ftdi_sio.c