Re: [PATCH 1/3] USB: host: ehci_atmel: Move global variables to private struct

2015-01-17 Thread Alan Stern
On Sat, 17 Jan 2015, Sylvain Rochet wrote: This patch move Atmel EHCI global variables (clocks ptr and clocked boolean) to private struct atmel_ehci, appended at the end of the parent struct usb_hcd. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com ---

Re: [PATCH 1/3] USB: host: ehci_atmel: Move global variables to private struct

2015-01-17 Thread Boris Brezillon
Hi Sylvain, On Sat, 17 Jan 2015 19:23:31 +0100 Sylvain Rochet sylvain.roc...@finsecur.com wrote: This patch move Atmel EHCI global variables (clocks ptr and clocked boolean) to private struct atmel_ehci, appended at the end of the parent struct usb_hcd. Maybe you should add a cover letter to

[PATCHv3 3/5] USB: host: ehci_atmel: Move global variables to private struct

2015-01-17 Thread Sylvain Rochet
This patch move Atmel EHCI global variables (clocks ptr and clocked boolean) to private struct atmel_ehci_priv, stored in ehci-priv. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/usb/host/ehci-atmel.c | 78 +++ 1 file changed, 49

[PATCHv3 0/5] USB: host: Atmel OHCI and EHCI drivers improvements

2015-01-17 Thread Sylvain Rochet
Sylvain Rochet (5): USB: host: ehci_atmel: Add suspend/resume support USB: host: ohci_at91: Stop/start USB PLL for all sleep modes USB: host: ehci_atmel: Move global variables to private struct USB: host: ohci_at91: Move global variables to private struct USB: host: ohci_at91:

[PATCHv3 5/5] USB: host: ohci_at91: usb_hcd_at91_probe(), remove useless stack initialisation

2015-01-17 Thread Sylvain Rochet
struct usb_hcd *hcd = NULL; ... hcd = usb_create_hcd(driver, dev, at91); This patch remove *hcd useless initialisation Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/usb/host/ohci-at91.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCHv3 4/5] USB: host: ohci_at91: Move global variables to private struct

2015-01-17 Thread Sylvain Rochet
This patch move AT91 OHCI global variables (clocks ptr and clocked boolean) to private struct ohci_at91_priv, stored in ohci-priv. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/usb/host/ohci-at91.c | 85 ++-- 1 file changed, 51

[PATCHv3 2/5] USB: host: ohci_at91: Stop/start USB PLL for all sleep modes

2015-01-17 Thread Sylvain Rochet
Disable/unprepare clocks without testing the sleep target_state, removed the at91_suspend_entering_slow_clock() call (which is only a target_state == PM_SUSPEND_MEM). Other kind of suspend now benefit from the power save induced by this PLL deactivation. The resume penalty is about 500 us, which

[PATCHv3 1/5] USB: host: ehci_atmel: Add suspend/resume support

2015-01-17 Thread Sylvain Rochet
This patch add suspend/resume support for Atmel EHCI, mostly about disabling and unpreparing clocks so USB PLL is stopped before entering sleep state. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/usb/host/ehci-atmel.c | 32 1 file

Re: XHCI, brain-dead scanner, and microframe rounding

2015-01-17 Thread Hans-Peter Jansen
Mathias Nyman mathias.nyman@... writes: On 09/15/2014 10:50 PM, Alan Stern wrote: On Mon, 15 Sep 2014, Mathias Nyman wrote: I haven't had time to dig into the usbmon traces, but I just got another report from Gunter K�ningsmann about similar scanner problem, and I just noticed that

Re: [PATCHv3 1/5] USB: host: ehci_atmel: Add suspend/resume support

2015-01-17 Thread Sergei Shtylyov
Hello. On 01/18/2015 12:25 AM, Sylvain Rochet wrote: There's little inconsistency in your patch subjects: you're using '_' but the files you're modifying are named using '-'... This patch add suspend/resume support for Atmel EHCI, mostly about disabling and unpreparing clocks so USB PLL

[PATCH 2/3] USB: host: ohci_at91: Move global variables to private struct

2015-01-17 Thread Sylvain Rochet
This patch move Atmel OHCI global variables (clocks ptr and clocked boolean) to private struct ohci_at91, appended at the end of the parent struct usb_hcd. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/usb/host/ohci-at91.c | 85 +++-

[PATCH 3/3] USB: host: ohci_at91: usb_hcd_at91_probe(), remove useless stack initialisation

2015-01-17 Thread Sylvain Rochet
struct usb_hcd *hcd = NULL; ... hcd = usb_create_hcd(driver, dev, at91); This patch remove *hcd useless initialisation to NULL; Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/usb/host/ohci-at91.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/3] USB: host: ehci_atmel: Move global variables to private struct

2015-01-17 Thread Sylvain Rochet
This patch move Atmel EHCI global variables (clocks ptr and clocked boolean) to private struct atmel_ehci, appended at the end of the parent struct usb_hcd. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/usb/host/ehci-atmel.c | 75

Re: [PATCH 1/3] USB: host: ehci_atmel: Move global variables to private struct

2015-01-17 Thread Sylvain Rochet
Hello Alan, On Sat, Jan 17, 2015 at 03:30:45PM -0500, Alan Stern wrote: This is not the right way to do it. For an example of the right way, see the ehci-platform.c file. Your private structure is stored in ehci-priv, and its size is specified by the .extra_priv_size member of an

3.18 regression: Error while assigning device slot ID, USB3 devices not detected

2015-01-17 Thread Robert Hancock
I've got an Intel Haswell-based system with a Gigabyte Z87X-D3H motherboard under Fedora 21. After updating to the 3.18.2-200 Fedora kernel, I noticed some errors in dmesg and at least some of my USB3 ports don't recognize any USB3 devices plugged into them: [0.560838] xhci_hcd

Re: 3.18 regression: Error while assigning device slot ID, USB3 devices not detected

2015-01-17 Thread Greg KH
On Sun, Jan 18, 2015 at 12:08:18AM -0600, Robert Hancock wrote: I've got an Intel Haswell-based system with a Gigabyte Z87X-D3H motherboard under Fedora 21. After updating to the 3.18.2-200 Fedora kernel, I noticed some errors in dmesg and at least some of my USB3 ports don't recognize any

Re: [PATCHv3 1/5] USB: host: ehci_atmel: Add suspend/resume support

2015-01-17 Thread Sylvain Rochet
Hi Sergei, On Sun, Jan 18, 2015 at 01:22:38AM +0300, Sergei Shtylyov wrote: There's little inconsistency in your patch subjects: you're using '_' but the files you're modifying are named using '-'... Indeed. @@ -187,6 +217,8 @@ static struct platform_driver ehci_atmel_driver = {

[PATCH] mmc: vub300: remove unreachable return value handling

2015-01-17 Thread Nicholas Mc Guire
Signed-off-by: Nicholas Mc Guire der.h...@hofr.at --- The return value of wait_for_completion_timeout is unsigned long, as it is used here for wait_for_completion_timeout only the type of commretval was changed to unsigned long. As wait_for_completion_timeout does not return negative values

Re: NETDEV WATCHDOG: internal(r8152): transmit queue 0 timed out

2015-01-17 Thread poma
On 17.01.2015 00:57, sean darcy wrote: On 01/16/2015 07:09 AM, poma wrote: On 16.01.2015 10:37, Hayes Wang wrote: poma [mailto:pomidorabelis...@gmail.com] Sent: Friday, January 16, 2015 4:25 PM [...] This looks like a USB problem. Is there a way to get usb (or NetworkManager) to

[PATCHv2 1/2] USB: host: ehci_atmel: Add suspend/resume support

2015-01-17 Thread Sylvain Rochet
This patch add suspend/resume support for Atmel EHCI, mostly about disabling and unpreparing clocks so USB PLL is stopped before entering sleep state. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/usb/host/ehci-atmel.c | 32 1 file

[PATCHv2 2/2] USB: host: ohci_at91: Stop/start USB PLL for all sleep modes

2015-01-17 Thread Sylvain Rochet
Disable/unprepare clocks without testing the sleep target_state, removed the at91_suspend_entering_slow_clock() call (which is only a target_state == PM_SUSPEND_MEM). Other kind of suspend now benefit from the power save induced by this PLL deactivation. The resume penalty is about 500 us, which

Re: [PATCHv2 1/2] USB: host: ehci_atmel: Add suspend/resume support

2015-01-17 Thread Boris Brezillon
On Sat, 17 Jan 2015 16:36:34 +0100 Sylvain Rochet sylvain.roc...@finsecur.com wrote: This patch add suspend/resume support for Atmel EHCI, mostly about disabling and unpreparing clocks so USB PLL is stopped before entering sleep state. Signed-off-by: Sylvain Rochet

Re: [PATCHv2 2/2] USB: host: ohci_at91: Stop/start USB PLL for all sleep modes

2015-01-17 Thread Boris Brezillon
On Sat, 17 Jan 2015 16:36:35 +0100 Sylvain Rochet sylvain.roc...@finsecur.com wrote: Disable/unprepare clocks without testing the sleep target_state, removed the at91_suspend_entering_slow_clock() call (which is only a target_state == PM_SUSPEND_MEM). Other kind of suspend now benefit from