RE: [PATCH net-next 1/7] r8152: adjust rx_bottom

2015-01-25 Thread Hayes Wang
David Miller [mailto:da...@davemloft.net] > Sent: Sunday, January 25, 2015 2:44 PM [...] > What keeps rtl_start_rx() from running in parallel with > r8152_submit_rx(), or any other accessor of the RX agg->list? Forgive my poor English. I would try to describe them clearly. The steps about the rx

Re: [PATCH] usb: gadget: f_fs: Fix loop variable

2015-01-25 Thread Robert Baldyga
On 01/23/2015 10:18 PM, Mario Schuknecht wrote: > Use if-loop variable 'epfile' instead of start variable 'epfiles'. Now the > correct endpoint file name is stored. > > Signed-off-by: Mario Schuknecht > --- > drivers/usb/gadget/function/f_fs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 del

Re: Control message failures kill entire XHCI stack

2015-01-25 Thread Devin Heitmueller
Hi Mathias, Here's an interesting development: as a result of a related thread on linux-media, I came across a patch they are distributing in openelec: https://github.com/OpenELEC/OpenELEC.tv/commit/b636927dec20652ff020e54ed7838a2e9be51e03 Now I'm not saying that reverting the commit in questio

Re: [PATCH 2/2] usb: musb: try a race-free wakeup

2015-01-25 Thread Bin Liu
Hi Felipe, On Wed, Jan 21, 2015 at 11:06 AM, Bin Liu wrote: > Hi Sebastian, > > On Mon, Oct 27, 2014 at 1:06 PM, Sebastian Andrzej Siewior > wrote: >> Attaching a keyboard, using it as a wakeup via >> |for f in $(find /sys/devices/ocp.3/4740.usb -name wakeup) >> |do >> | echo enabled >

Re: [PATCH 00/23] Use USB_CHAR_* in the host drivers

2015-01-25 Thread Peter Korsgaard
> "Sergei" == Sergei Shtylyov writes: Hi, >I've just discovered that I missed c67x00 in this patchset, > probably due to the value and the comments there differing... >From the code it follows that most probably both are wrong: no > power switching is supported (the value claims

Re: [PATCH 00/23] Use USB_CHAR_* in the host drivers

2015-01-25 Thread Sergei Shtylyov
Hello. On 01/19/2015 01:24 AM, Sergei Shtylyov wrote: Here's a set of 23 patches against the 'usb-next' branch of Greg KH's 'usb.git' repo plus 2 FHCI patches I posted a week ago. It's to replace the use of the hex numbers where the USB_CHAR_* #define's should have been used. [01/23] ehc

Re: Control message failures kill entire XHCI stack

2015-01-25 Thread Devin Heitmueller
Hi Mathias, I've done additional debugging and found a few things that might be noteworthy. When I originally reported the issue, I noted that it was some sort of recovery problem related to failed control messages. So while you've been focused on why stopping the endpoint failed when it came ti

Re: [PATCH 17/23] uhci-hub: use HUB_CHAR_*

2015-01-25 Thread Sergei Shtylyov
Hello. On 01/19/2015 07:41 PM, Alan Stern wrote: Fix using the bare number to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/host/uhci-hub.c |5 +++-- 1 file changed, 3 insertions(+),

[PATCH v2] uhci-hub: use HUB_CHAR_*

2015-01-25 Thread Sergei Shtylyov
Fix using the bare number to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov Acked-by: Alan Stern --- This patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo. Changes in version 2: - additionally in

Re: [PATCH 20/23] musb_virthub: use HUB_CHAR_*

2015-01-25 Thread Sergei Shtylyov
Hello. On 01/19/2015 01:57 AM, Sergei Shtylyov wrote: Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- drivers/usb/musb/musb_virthub.c |7 --- 1 file changed, 4 inse

Re: [PATCH 24/32] usb: use %*pb[l] to print bitmaps including cpumasks and nodemasks

2015-01-25 Thread Greg Kroah-Hartman
On Sat, Jan 24, 2015 at 09:03:30AM -0500, Tejun Heo wrote: > printk and friends can now formap bitmaps using '%*pb[l]'. cpumask > and nodemask also provide cpumask_pr_args() and nodemask_pr_args() > respectively which can be used to generate the two printf arguments > necessary to format the speci

Re: [PATCH 1/4] cdc-acm: add sanity checks

2015-01-25 Thread Greg KH
On Wed, Jan 14, 2015 at 04:35:10PM +0100, Oliver Neukum wrote: > Check the special CDC headers for a plausible minimum length. > Another big operating systems ignores such garbage. > > Signed-off-by: Oliver Neukum > --- > drivers/usb/class/cdc-acm.c | 18 ++ > 1 file changed, 14

[PATCH v3 0/5] Add support for Fujitsu USB host controller

2015-01-25 Thread Sneeker Yeh
These patches add support for XHCI compliant Host controller found on Fujitsu Socs, and are based on http://lwn.net/Articles/629162/ The first patch is to add Fujitsu glue layer of Synopsis DesignWare USB3 driver and last four patch is about quirk implementation of errata in Synopsis DesignWare USB

[PATCH v3 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core

2015-01-25 Thread Sneeker Yeh
This issue is defined by a three-way race at disconnect, between 1) Class driver interrupt endpoint resheduling attempts if the ISR gave an ep error event due to device detach (it would try 3 times) 2) Disconnect interrupt on PORTSC_CSC, which is cleared by hub thread asynchronously 3) The ha

[PATCH v3 2/5] xhci: Platform: Set Synopsis device disconnection quirk based on platform data

2015-01-25 Thread Sneeker Yeh
If an xhci platform has Synopsis device disconnection errata then enable XHCI_DISCONNECT_QUIRK quirk flag. Signed-off-by: Sneeker Yeh --- drivers/usb/host/xhci-plat.c |3 +++ include/linux/usb/xhci_pdriver.h |4 2 files changed, 7 insertions(+) diff --git a/drivers/usb/host/xhc

[PATCH v3 3/5] usb: dwc3: add revision number DWC3_REVISION_290A and DWC3_REVISION_300A

2015-01-25 Thread Sneeker Yeh
Add the contstant for v2.90a and v3.00a dwc3 IP detection Signed-off-by: Sneeker Yeh --- drivers/usb/dwc3/core.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 4bb9aa6..46f9f9a 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/us

[PATCH v3 4/5] usb: dwc3: Add quirk for Synopsis device disconnection errata

2015-01-25 Thread Sneeker Yeh
Synopsis Designware USB3 IP earlier than v3.00a which is configured in silicon with DWC_USB3_SUSPEND_ON_DISCONNECT_EN=1, would need a specific quirk to prevent xhci host controller from dying when device is disconnected. Since DWC_USB3_SUSPEND_ON_DISCONNECT_EN is an IP configuration whose state ca

[PATCH v3 5/5] usb: dwc3: add Fujitsu Specific Glue layer

2015-01-25 Thread Sneeker Yeh
This patch adds support for Synopsis DesignWare USB3 IP Core found on Fujitsu Socs. Signed-off-by: Sneeker Yeh --- .../devicetree/bindings/usb/fujitsu-dwc3.txt | 33 drivers/usb/dwc3/Kconfig | 11 ++ drivers/usb/dwc3/Makefile |