[PATCH 18/19] usb: musb: gadget: use common is_selfpowered

2015-01-28 Thread Peter Chen
Delete private selfpowered variable, and use common one. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/musb/musb_gadget.c | 4 +--- drivers/usb/musb/musb_gadget_ep0.c | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/musb_gadget.c

[PATCH 19/19] usb: udc-core: add is_selfpowered sys entry

2015-01-28 Thread Peter Chen
The user can read it through sys entry. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/udc-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc/udc-core.c index 86d4d19..4f1aed4 100644 ---

Re: usb_debug serial driver protocol

2015-01-28 Thread Greg KH
On Mon, Jan 26, 2015 at 04:37:25PM +0100, Michael Zimmermann wrote: Hi, I want to use the usb_debug serial driver as a UART shell on my (embedded) device, because I just want to use it as a console(without a complex protocol so I can easily use putchar and getchar functions). This seems

[PATCH 16/19] usb: gadget: pch_udc: set value for common is_selfpowered

2015-01-28 Thread Peter Chen
Set value for common is_selfpowered. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/pch_udc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c index 1c7379a..613547f 100644 ---

[PATCH 02/19] usb: chipidea: udc: add set_selfpowered gaget ops

2015-01-28 Thread Peter Chen
The gadget power property will be used at get_status request. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/udc.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index

[PATCH 08/19] usb: gadget: lpc32xx_udc: use common is_selfpowered

2015-01-28 Thread Peter Chen
Delete private selfpowered variable, and use common one. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/lpc32xx_udc.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c

Re: [PATCH v3] usb: Retry port status check on resume to work around RH bugs

2015-01-28 Thread Alan Stern
On Tue, 27 Jan 2015, Julius Werner wrote: The EHCI controller on the RK3288 SoC is violating basic parts of the USB spec and thereby unable to properly resume a suspended port. It does not start SOF generation within 3ms of finishing resume signaling, so the attached device will drop of the

[PATCH 10/19] usb: gadget: omap_udc: set value for common is_selfpowered

2015-01-28 Thread Peter Chen
Set value for common is_selfpowered. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/omap_udc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/omap_udc.c b/drivers/usb/gadget/udc/omap_udc.c index 288c087..e2fcdb8 100644 ---

RE: [PATCH v1 00/13] usb: second series of updates for dwc2 driver

2015-01-28 Thread Kaukab, Yousaf
-Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, January 27, 2015 4:31 PM To: John Youn Cc: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com; Herrero, Gregory; r.bald...@samsung.com; dingu...@opensource.altera.com; sergei.shtyl...@cogentembedded.com

Re: [PATCH 2/2] drivers: usb: dwc2: remove 'force' parameter from kill_all_requests()

2015-01-28 Thread Felipe Balbi
On Wed, Jan 28, 2015 at 08:18:30AM +0100, Robert Baldyga wrote: On 01/27/2015 04:42 PM, Felipe Balbi wrote: On Mon, Jan 05, 2015 at 10:31:35AM +0100, Robert Baldyga wrote: This patch fixes in simpler way the bug described in [1] and [2]. It looks like DWC2 is the only UDC driver that

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-28 Thread Heikki Krogerus
Hi, Can you share how tusb1210 is connected on the platform you're using as test for this patch? I don't think this driver would work reliably with this device: http://liliputing.com/2014/11/trekstor-launches-first-android-tablet-based-intels-irda-reference-design.html The only

[PATCH 17/19] usb: dwc3: gadget: use common is_selfpowered

2015-01-28 Thread Peter Chen
Delete private selfpowered variable, and use common one. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/dwc3/core.h | 2 -- drivers/usb/dwc3/ep0.c| 2 +- drivers/usb/dwc3/gadget.c | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 04/19] staging: emxx_udc: use common is_selfpowered

2015-01-28 Thread Peter Chen
Delete private selfpowered variable, and use common one. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/staging/emxx_udc/emxx_udc.c | 9 +++-- drivers/staging/emxx_udc/emxx_udc.h | 1 - 2 files changed, 3 insertions(+), 7 deletions(-) diff --git

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-28 Thread Felipe Balbi
On Wed, Jan 28, 2015 at 10:43:11AM -0200, Fabio Estevam wrote: On Wed, Jan 28, 2015 at 10:21 AM, Fabio Estevam feste...@gmail.com wrote: Hi Felipe, On Tue, Jan 27, 2015 at 7:35 PM, Felipe Balbi ba...@ti.com wrote: sounds like a bug in chipidea now. There are no errors from the PHY,

[PATCH v1] usb: host: pci_quirks: joing string literals

2015-01-28 Thread Andy Shevchenko
The patch joins the string literals for happy debugging. There is no functional change. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/usb/host/pci-quirks.c | 55 ++- 1 file changed, 28 insertions(+), 27 deletions(-) diff

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-28 Thread Robert Jarzmik
Felipe Balbi ba...@ti.com writes: nop-gpiod_reset = devm_gpiod_get_optional(dev, reset); if (gpiod_is_active_low(nop-gpiod_reset)) gpiod_direction_output(nop-gpiod_reset, GPIOD_OUT_LOW); else gpiod_direction_output(nop-gpiod_reset,

[PATCH 13/19] usb: gadget: s3c2410_udc: set value for common is_selfpowered

2015-01-28 Thread Peter Chen
Set value for common is_selfpowered. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/s3c2410_udc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c index 256a67b..b808951 100644 ---

[PATCH 05/19] usb: renesas_usbhs: gadget: set value for common is_selfpowered

2015-01-28 Thread Peter Chen
Set value for common is_selfpowered. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/renesas_usbhs/mod_gadget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index 8697e6e..e0384af 100644

[PATCH 03/19] usb: gadget: at91_udc: use common is_selfpowered

2015-01-28 Thread Peter Chen
Delete private selfpowered variable, and use common one. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/at91_udc.c | 8 drivers/usb/gadget/udc/at91_udc.h | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Robert Jarzmik
Felipe Balbi ba...@ti.com writes: At the same time, declare the interrupt as one shot so that it is masked until the end of the threaded handler. This prevents the irq core from spitting out an error : Threaded irq requested with handler=NULL and !ONESHOT for irq 63 Shouldn't this be

[PATCH 09/19] usb: gadget: fsl_udc_core: set value for common is_selfpowered

2015-01-28 Thread Peter Chen
fsl udc core assumes itself always self powered, so set is_selfpowered is 1. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/fsl_udc_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c

[PATCH 06/19] usb: gadget: bdc_udc: set value for common is_selfpowered

2015-01-28 Thread Peter Chen
Set value for common is_selfpowered. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/bdc/bdc_udc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/bdc/bdc_udc.c b/drivers/usb/gadget/udc/bdc/bdc_udc.c index 3700ce7..7f77db5 100644 ---

[PATCH 15/19] usb: gadget: atmel_usba_udc: set value for common is_selfpowered

2015-01-28 Thread Peter Chen
Set value for common is_selfpowered. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/atmel_usba_udc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 4b5b7fa..c041086 100644

Re: XHCI NULL pointer with device reset

2015-01-28 Thread Felipe Balbi
Hi, On Wed, Jan 28, 2015 at 02:48:54PM +0200, Mathias Nyman wrote: On 27.01.2015 20:27, Felipe Balbi wrote: Hi Mathias, I managed to reliably reproduce a NULL pointer deref by issues a series of Device Resets and killing off my application (using libusb) midway through the test.

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-28 Thread Felipe Balbi
On Wed, Jan 28, 2015 at 01:40:59PM -0200, Fabio Estevam wrote: On Wed, Jan 28, 2015 at 12:04 PM, Felipe Balbi ba...@ti.com wrote: I don't want to change direction all the time, some controllers might not be glitch free, but I agree that direction has to be set. It looks like we're missing

Re: [PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Sören Brinkmann
On Wed, 2015-01-28 at 09:29AM +0100, Robert Jarzmik wrote: All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by commit usb: phy: generic: migrate to gpio_desc. At the same time,

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-28 Thread Roger Quadros
Chanwoo, On 28/01/15 04:19, Chanwoo Choi wrote: Hi Roger, On 01/28/2015 12:38 AM, Roger Quadros wrote: Chanwoo, On 27/01/15 03:54, Chanwoo Choi wrote: Hi Roger, On 01/27/2015 01:27 AM, Roger Quadros wrote: Hi Chanwoo, All your comments are valid. Need some clarification on one

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-28 Thread David Cohen
On Wed, Jan 28, 2015 at 04:20:25PM +0200, Heikki Krogerus wrote: Hi, Can you share how tusb1210 is connected on the platform you're using as test for this patch? I don't think this driver would work reliably with this device:

Re: [PATCH v3 1/5] usb: serial: add register map for F81232

2015-01-28 Thread Johan Hovold
On Wed, Jan 28, 2015 at 01:57:56PM +0800, Peter Hung wrote: Add register map for F81232. and add some function to operating this device. etc. f81232_get_register()/f81232_set_register() to work with USB control point. and worker f81232_int_work_wq() to read MSR when IIR acquired.

[PATCH 14/19] usb: gadget: net2272: use common is_selfpowered

2015-01-28 Thread Peter Chen
Delete private selfpowered variable, and use common one. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/net2272.c | 7 ++- drivers/usb/gadget/udc/net2272.h | 1 - 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/gadget/udc/net2272.c

[PATCH 11/19] usb: gadget: r8a66597-udc: set value for common is_selfpowered

2015-01-28 Thread Peter Chen
Set value for common is_selfpowered. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/r8a66597-udc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c index 06870da..2495fe9 100644 ---

[PATCH 00/19] usb: gadget: add is_selfpowered

2015-01-28 Thread Peter Chen
Hi Felipe, We can use a common is_selfpowered flag at usb_gadget to indicate whether the gadget is self-powered or bus-powered, it can avoid every udc driver defining a similar flag, and the user can read it through udc core sys entry. The changes are based on your testing/test tree, and it

Re: [PATCh v4 3/3] usb: udc: add usb_udc_activation_handler

2015-01-28 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: During this API, the deactivation count will be update, and it will try to connect or disconnect gadget. It can be used to enable functions for gadget. It's up to Felipe, but I'd like to see answers to the following questions in this commit message:

RE: [PATCH] usb: gadget: composite: Provide list of registered functions

2015-01-28 Thread Krzysztof Opasiak
-Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, January 27, 2015 8:38 PM To: Krzysztof Opasiak Cc: ba...@ti.com; linux-usb@vger.kernel.org; gre...@linuxfoundation.org; bige...@breakpoint.cc; s.wa...@samsung.com; k.lewando...@samsung.com;

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-28 Thread Fabio Estevam
Hi Felipe, On Tue, Jan 27, 2015 at 7:35 PM, Felipe Balbi ba...@ti.com wrote: sounds like a bug in chipidea now. There are no errors from the PHY, which means that the PHY is code is behaving. Not sure it is a bug in the chipidea driver. The phy-generic driver is not putting the reset gpio

[PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-28 Thread Roger Quadros
This driver observes the USB ID pin connected over a GPIO and updates the USB cable extcon states accordingly. The existing GPIO extcon driver is not suitable for this purpose as it needs to be taught to understand USB cable states and it can't handle more than one cable per instance. For the

RE: [PATCH v2] chipidea: pci: register nop PHY

2015-01-28 Thread Peter Chen
On Tue, Jan 27, 2015 at 03:50:18PM +0200, Andy Shevchenko wrote: Since PHY for ChipIdea is optional (not all SoCs having PHY for ChipIdea should be programmed), we register 'nop' PHY for platforms that do not have programmable PHY. Signed-off-by: Andy Shevchenko

Re: usb_debug serial driver protocol

2015-01-28 Thread Greg KH
On Wed, Jan 28, 2015 at 10:25:16PM +0100, Peter Stuge wrote: Greg KH wrote: Is that some kind of initialization protocol I have to handle? If yes, where do I find information about it? The protocol should be part of the USB specification. USB debug class devices use no protocol,

Re: [PATCH v1] usb: host: pci_quirks: joing string literals

2015-01-28 Thread Greg KH
On Wed, Jan 28, 2015 at 07:03:17PM +0200, Andy Shevchenko wrote: The patch joins the string literals for happy debugging. There is no functional change. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/usb/host/pci-quirks.c | 55

[PATCH] cdc-acm: kill unnecessary messages

2015-01-28 Thread Oliver Neukum
Memory allocation failures are reported by a central facility. No need to repeat the job. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/class/cdc-acm.c | 33 + 1 file changed, 9 insertions(+), 24 deletions(-) diff --git

Re: [PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Fabio Estevam
On Wed, Jan 28, 2015 at 6:29 AM, Robert Jarzmik robert.jarz...@free.fr wrote: All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by commit usb: phy: generic: migrate to gpio_desc. At

[PATCH 07/19] usb: gadget: dummy_hcd: set value for common is_selfpowered

2015-01-28 Thread Peter Chen
Set value for common is_selfpowered. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/dummy_hcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c index 270c1ec..8dda484 100644 ---

[PATCH 12/19] usb: gadget: net2280: use common is_selfpowered

2015-01-28 Thread Peter Chen
Delete private selfpowered variable, and use common one. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/net2280.c | 6 +++--- drivers/usb/gadget/udc/net2280.h | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/net2280.c

Re: [PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Felipe Balbi
On Wed, Jan 28, 2015 at 10:21:11AM -0800, Sören Brinkmann wrote: On Wed, 2015-01-28 at 09:29AM +0100, Robert Jarzmik wrote: All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by

Re: [PATCH v2] ehci-pci: disable for Intel MID platforms

2015-01-28 Thread Alan Stern
On Wed, 28 Jan 2015, Andy Shevchenko wrote: On some Intel MID platforms the ChipIdea USB controller is used. The EHCI PCI is in conflict with the proper driver. The patch makes ehci-pci to be ignored in favour of ChipIdea controller. Signed-off-by: Andy Shevchenko

[PATCH v2] ehci-pci: disable for Intel MID platforms

2015-01-28 Thread Andy Shevchenko
On some Intel MID platforms the ChipIdea USB controller is used. The EHCI PCI is in conflict with the proper driver. The patch makes ehci-pci to be ignored in favour of ChipIdea controller. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/usb/host/ehci-pci.c | 23

Re: [PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Felipe Balbi
On Wed, Jan 28, 2015 at 08:04:20PM +0100, Robert Jarzmik wrote: Felipe Balbi ba...@ti.com writes: At the same time, declare the interrupt as one shot so that it is masked until the end of the threaded handler. This prevents the irq core from spitting out an error : Threaded irq

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-28 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Tue, Jan 27, 2015 at 11:21:56AM -0500, Alan Stern wrote: On Tue, 27 Jan 2015, Peter Chen wrote: Please fix this properly. I don't know the right way to fix this. Alan, has you any suggestion? It depends. How did the code

Re: XHCI NULL pointer with device reset

2015-01-28 Thread Mathias Nyman
On 27.01.2015 20:27, Felipe Balbi wrote: Hi Mathias, I managed to reliably reproduce a NULL pointer deref by issues a series of Device Resets and killing off my application (using libusb) midway through the test. Attached you can find a tarball with serial console capture. Note that I

[PATCH 01/19] usb: gadget: introduce is_selfpowered for usb_gadget

2015-01-28 Thread Peter Chen
Whether the gadget is selfpowerwed or not can be determined by composite core, so we can use a common entry to indicate if the self-powered is supported by gadget, and the related private variable at individual udc driver can be deleted. Signed-off-by: Peter Chen peter.c...@freescale.com ---

Re: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232

2015-01-28 Thread Sergei Shtylyov
Hello. On 1/28/2015 8:58 AM, Peter Hung wrote: This patch implement CMSPAR in set_termios, and fix some warnning from checkpatch.pl Please don't try to do 2 unrelated things in one patch. Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 21

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-28 Thread Fabio Estevam
On Wed, Jan 28, 2015 at 12:04 PM, Felipe Balbi ba...@ti.com wrote: I don't want to change direction all the time, some controllers might not be glitch free, but I agree that direction has to be set. It looks like we're missing a gpiod_direction_output() call from probe() so that this

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-28 Thread Alan Stern
On Wed, 28 Jan 2015, Peter Chen wrote: Hi Andy, Would you define pci_id at ci_hdrc_pci.c (instead of ehci-pci.c) at your platform code/table to fix this problem? I am not familiar with pci, but it works at other platforms, like ARM. You can't remove the definition of pci_id in

[PATCH 2/2] usb: gadget: legacy: don't use __init/__exit attributes for bind/unbind path

2015-01-28 Thread Ruslan Bilovol
Since it's possible now to do independent gadget and gadget driver registration in udc-core, some of the functions can't have __init/__exit attributes (almost bind/unbind callbacks are affected) Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/legacy/acm_ms.c |

Re: usb_debug serial driver protocol

2015-01-28 Thread Peter Stuge
Greg KH wrote: I've found that screen can leave usb serial ports in an odd state, it's not unique to this specific device, I blame the screen command :) I think that's a lame excuse to not investigate a potential bug. It would obviously be helpful if someone who experienced this

[PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-01-28 Thread Ruslan Bilovol
Change behavior during registration of gadgets and gadget drivers in udc-core. Instead of previous approach when for successful probe of usb gadget driver at least one usb gadget should be already registered use another one where gadget drivers and gadgets can be registered in udc-core

[PATCH 0/2] usb/gadget: independent registration of gadgets and gadget

2015-01-28 Thread Ruslan Bilovol
This patchset adds independent registration of gadgets and gadget drivers to udc-core. This is very useful for built-in modules into kernel case since it's possible situation that gadget driver is probing at a time when no gadgets are registered in udc-core. In this case instead of silently

Re: [PATCH] usb: gadget: composite: Provide list of registered functions

2015-01-28 Thread Sebastian Andrzej Siewior
* Krzysztof Opasiak | 2015-01-28 13:38:33 [+0100]: the first thing a user of usb-gadget has to do, is create a directory, not a file. This: $ modprobe libcomposite $ mount none -t configfs /sys/kernel/config/usb-gadget don't you mount it at config and cd to usb-gadget then? $ mkdir

Re: usb_debug serial driver protocol

2015-01-28 Thread Peter Stuge
Greg KH wrote: Is that some kind of initialization protocol I have to handle? If yes, where do I find information about it? The protocol should be part of the USB specification. USB debug class devices use no protocol, just transfers of 1-8 bytes, used in arbitrary ways by the various

Re: usb-storage URB use-after-free

2015-01-28 Thread Joe Lawrence
This one should have gone over to linux-usb. -- Joe On 01/28/2015 05:04 PM, Joe Lawrence wrote: Hello linux-usb, We've hit a USB use-after-free on Stratus HW during device removal tests. We're running fio disk I/O to a scsi disk hanging off USB when the USB controller is hotplug removed.

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-28 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [150128 04:15]: On 28/01/15 04:19, Chanwoo Choi wrote: I still fail to understand that we need to call disable_irq() in .suspend() and enable_irq() in .resume() can you point me to any other drivers doing so? You can refer the suspend function in

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-28 Thread Peter Chen
On Wed, Jan 28, 2015 at 10:42:53AM -0500, Alan Stern wrote: On Wed, 28 Jan 2015, Peter Chen wrote: Hi Andy, Would you define pci_id at ci_hdrc_pci.c (instead of ehci-pci.c) at your platform code/table to fix this problem? I am not familiar with pci, but it works at other

Re: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232

2015-01-28 Thread Peter Hung
Hello. I had using scripts/checkpatch.pl -f to scan original f81232.c. It reported with quoted string split across lines, so I merge these 2 strings into 1 in patch 1/5. But it still warning with line over 80 character, so I had shorted string with this line. I will refine my patch set again

[PATCH] usb: dwc2: fix USB core dependencies

2015-01-28 Thread Arnd Bergmann
It is currently possible to configure the dwc2 driver as built-in when host mode or dual-role is enabled, but the USB core is a loadable module. This leads to a link failure: drivers/built-in.o: In function `_dwc2_hcd_start': :(.text+0x84538): undefined reference to `usb_hcd_resume_root_hub'

[PATCH] usb: musb: add omap-control dependency

2015-01-28 Thread Arnd Bergmann
The omap musb front-end calls into the phy driver directly instead of using a generic phy interface, which causes a link error when the specific driver is not built-in: drivers/built-in.o: In function `omap2430_musb_disable': usb/musb/omap2430.c:480: undefined reference to

Re: [RFC PATCH] usb: dwc2: Use platform endianness when accessing registers

2015-01-28 Thread Antti Seppälä
On 27 January 2015 at 04:18, John Youn john.y...@synopsys.com wrote: From: Vincent Pelletier [mailto:plr.vinc...@gmail.com] Sent: Friday, January 23, 2015 12:19 AM On Fri, 23 Jan 2015 02:38:37 +, John Youn john.y...@synopsys.com wrote: Having the __raw functions everywhere is not pretty

Re: [PATCH v3 1/5] usb: serial: add register map for F81232

2015-01-28 Thread Peter Hung
Hello. 1. For retry Issue: These patches is referenced from our other usb serial product. That product maybe not ack the control ep command when It's in very heavily loading. Our workaround is to modify driver to retry more times if it timeout because it's f/w can't upgrade with usb

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-28 Thread Fabio Estevam
On Wed, Jan 28, 2015 at 10:21 AM, Fabio Estevam feste...@gmail.com wrote: Hi Felipe, On Tue, Jan 27, 2015 at 7:35 PM, Felipe Balbi ba...@ti.com wrote: sounds like a bug in chipidea now. There are no errors from the PHY, which means that the PHY is code is behaving. Not sure it is a bug in

RE: [PATCH v1 01/13] usb: dwc2: host: register hcd handle to the phy

2015-01-28 Thread John Youn
From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] Sent: Wednesday, January 21, 2015 6:37 AM From: Gregory Herrero gregory.herr...@intel.com If phy driver is present, register hcd handle to it and let it take care of calling usb_add_hcd. Otherwise, add hcd here. Moreover, save

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-28 Thread Chanwoo Choi
Hi Roger, We need to discuss one point about 'id_irqwake'. I don't recommend to use 'id_irqwake' field. And I catch build warning by using select keywork in Kconfig. It is my wrong guide of select keyword. So, I'll change it as 'depends on' keyword. Looks good to me except for 'id_irqwake'.

[PATCH] usb: phy: generic: fix the gpios to be optional

2015-01-28 Thread Robert Jarzmik
All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by commit usb: phy: generic: migrate to gpio_desc. At the same time, declare the interrupt as one shot so that it is masked until the end

Re: [PATCH 2/2] drivers: usb: dwc2: remove 'force' parameter from kill_all_requests()

2015-01-28 Thread Robert Baldyga
On 01/27/2015 04:42 PM, Felipe Balbi wrote: On Mon, Jan 05, 2015 at 10:31:35AM +0100, Robert Baldyga wrote: This patch fixes in simpler way the bug described in [1] and [2]. It looks like DWC2 is the only UDC driver that doesn't force usb requests to complete in ep_disable() function. This

[PATCH v2] usb: phy: phy-generic: Fix USB PHY gpio reset

2015-01-28 Thread Fabio Estevam
Since commit e9f2cefb0cdc2ae (usb: phy: generic: migrate to gpio_desc) a kernel hang is observed on imx51-babbage board: [1.392824] ci_hdrc ci_hdrc.1: doesn't support gadget [1.397975] ci_hdrc ci_hdrc.1: EHCI Host Controller [1.403205] ci_hdrc ci_hdrc.1: new USB bus registered,

Re: [PATCH v2] ehci-pci: disable for Intel MID platforms

2015-01-28 Thread Alexander Shishkin
Andy Shevchenko andriy.shevche...@linux.intel.com writes: On some Intel MID platforms the ChipIdea USB controller is used. The EHCI PCI is in conflict with the proper driver. The patch makes ehci-pci to be ignored in favour of ChipIdea controller. Signed-off-by: Andy Shevchenko

[PATCH] usb: renesas: fix extcon dependency

2015-01-28 Thread Arnd Bergmann
The renesas usbhs driver calls extcon_get_edev_by_phandle(), which is defined in drivers/extcon/extcon-class.c, and that can be a loadable module. If the extcon-class support is disabled, usbhs will work correctly for all devices that do not need extcon. However, if extcon-class is a loadable

[PATCH] usb: phy: phy-generic: Fix USB PHY gpio reset

2015-01-28 Thread Fabio Estevam
Since commit e9f2cefb0cdc2ae (usb: phy: generic: migrate to gpio_desc) a kernel hang is observed on imx51-babbage board: [1.392824] ci_hdrc ci_hdrc.1: doesn't support gadget [1.397975] ci_hdrc ci_hdrc.1: EHCI Host Controller [1.403205] ci_hdrc ci_hdrc.1: new USB bus registered,

[PATCH] usb: musb: add generic usb phy dependencies

2015-01-28 Thread Arnd Bergmann
Multiple musb glue drivers depend on the generic usb phy support, but fail to list it as a dependency in Kconfig. This results in build erros like: drivers/built-in.o: In function `am35x_remove': :(.text+0xadacc): undefined reference to `usb_phy_generic_unregister' drivers/built-in.o: In function

Re: [PATCh v4 3/3] usb: udc: add usb_udc_activation_handler

2015-01-28 Thread Peter Chen
On Wed, Jan 28, 2015 at 09:08:56AM +0200, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: During this API, the deactivation count will be update, and it will try to connect or disconnect gadget. It can be used to enable functions for gadget. It's up to Felipe, but

Re: [PATCH 1/8] usb: add bus type for USB ULPI

2015-01-28 Thread Felipe Balbi
Hi, On Fri, Jan 23, 2015 at 05:12:51PM +0200, Heikki Krogerus wrote: @@ -6,4 +6,5 @@ obj-$(CONFIG_USB_COMMON)+= usb-common.o usb-common-y += common.o usb-common-$(CONFIG_USB_LED_TRIG) += led.o -obj-$(CONFIG_USB_OTG_FSM) += usb-otg-fsm.o

Re: [PATCH 7/8] phy: helpers for USB ULPI PHY registering

2015-01-28 Thread Felipe Balbi
On Fri, Jan 23, 2015 at 05:12:57PM +0200, Heikki Krogerus wrote: ULPI PHYs need to be bound to their controllers with a lookup. This adds helpers that the ULPI drivers can use to do both, the registration of the PHY and the lookup, at the same time. Signed-off-by: Heikki Krogerus

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-28 Thread Felipe Balbi
On Fri, Jan 23, 2015 at 05:12:58PM +0200, Heikki Krogerus wrote: TUSB1210 ULPI PHY has vendor specific register for eye diagram tuning. On some platforms the system firmware has set optimized value to it. In order to not loose the optimized value, the driver stores it during probe and

[PATCH_V3 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-01-28 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Add the binding documentation for the JZ4740 OHCI controller. Signed-off-by: Paul Burton paul.bur...@imgtec.com Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- The jz4740 is platform only at the moment. But DT support is being

[PATCH_V3 3/3] usb: ohci: jz4740: prepare the clock before enabling it

2015-01-28 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com The clock must have been prepared before enabling it. Signed-off-by: Paul Burton paul.bur...@imgtec.com Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com Acked-by: Alan Stern st...@rowland.harvard.edu -- V2 changes. Add

[PATCH_V3 0/3] usb: ohci: jz4740: Add DT support and a fix

2015-01-28 Thread Zubair Lutfullah Kakakhel
Hi, Here are a few simple patches for the jz4740. First adds a simple DT binding. Seconds adds DT support. Third is a minor fix in clock enabling. Patches are based on 3.19-rc6. Quite disjoint and stay within jz4740 so should apply easily on other trees. If you would like to have them rebased

[PATCH_V3 2/3] usb: ohci: jz4740: add DT support

2015-01-28 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com This is a simple matter of providing a match table, the probe code needs no modification. Signed-off-by: Paul Burton paul.bur...@imgtec.com Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com Acked-by: Alan Stern st...@rowland.harvard.edu

[PATCH v5 0/3] usb: udc: Unify dp control

2015-01-28 Thread Peter Chen
Hi Felipe, This is the follow-up: http://marc.info/?l=linux-usbm=140979297227434w=2. Sorry for late. In the first patch, we introduce an internal APIs which are used to find corresponding udc according to usb_gadget, it can simplify the code structure. In the 2nd patch, it maintains flag

[PATCH v5 1/3] usb: udc: add usb_gadget_find_udc

2015-01-28 Thread Peter Chen
This is an internal API, and is used to find corresponding udc according to gadget. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/udc-core.c | 51 --- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git

[PATCH v5 3/3] usb: udc: add usb_udc_activation_handler

2015-01-28 Thread Peter Chen
Currently, connect gadget is unconditional after binding, but some function drivers may want to connect gadget on the fly. With this API, the function driver can disconnect gadget during the initialization, and connect gadget when it wants. During this API, the deactivation count will be update,

[PATCH v5 2/3] usb: udc: add usb_udc_vbus_handler

2015-01-28 Thread Peter Chen
This commit updates udc core vbus status, and try to connect or disconnect gadget. Signed-off-by: Peter Chen peter.c...@freescale.com Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/gadget/udc/udc-core.c | 34 +- include/linux/usb/gadget.h|

RE: [PATCH v1 01/13] usb: dwc2: host: register hcd handle to the phy

2015-01-28 Thread Kaukab, Yousaf
-Original Message- From: John Youn [mailto:john.y...@synopsys.com] Sent: Thursday, January 29, 2015 3:25 AM To: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com; john.y...@synopsys.com Cc: Herrero, Gregory; r.bald...@samsung.com; dingu...@opensource.altera.com;